Review Request 27522: Review request for patch for an issue - CLOUDSTACK-5583

2014-11-03 Thread Krunal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27522/
---

Review request for cloudstack, Mandar Barve and Mike Tutkowski.


Bugs: CLOUDSTACK-5583
https://issues.apache.org/jira/browse/CLOUDSTACK-5583


Repository: cloudstack-git


Description
---

Patch for Cloudstack bug - "vmopsSnapshot plug-in (XenServer) does not return 
an error when it should"


Diffs
-

  scripts/vm/hypervisor/xenserver/vmopsSnapshot 6b4693c 

Diff: https://reviews.apache.org/r/27522/diff/


Testing
---

Unit testing was done and results already shared via email.


Thanks,

Krunal



Regarding CLOUDSTACK-1986 issue - Key translation fails for the Japanese keyboard

2014-10-15 Thread Krunal Jain
Hi Sanjay,



As per my understanding, we are providing Japanese Keyboard support via
console proxy from CloudStack’s 4.2 version and onwards (CLOUDSTACK-958:
Localization -- Add Japanese language keyboard support
<https://issues.apache.org/jira/browse/CLOUDSTACK-958>). But, there are few
keys whose translation is failing and we have an issue already reported for
the same – “CLOUDSTACK-1986: Key translation fails for the Japanese
keyboard” <https://issues.apache.org/jira/browse/CLOUDSTACK-1986>.



I was trying to understand and reproduce this issue and have gone through
few wiki pages and functional specs for the same.

·
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Non-US+Keyboard+Support+for+Console+Proxy

·
https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS+for+3+foreign+language+keyboard+support



Also, I saw another JIRA – “CLOUDSTACK-2419: Localization - Some Japanese
keys are not working”
<https://issues.apache.org/jira/browse/CLOUDSTACK-2419> which seems to be
fixed by you and I see that you delivered some changes into the “
services/console-proxy/server/js/ajaxkeys.js
<https://reviews.apache.org/r/11021/diff/#0>” file.

Now when I try to find this file, I am not getting it in the same location
as mentioned above. Rather, it’s there at the location “
systemvm/js/ajaxkeys.js”. Note that, I am using CloudStack version 4.3.1.
Is this path correct to look into? And, as we still have few keys whose
translation is failing so would appreciate your help to fix the same.



Thanks in advance! J



*Regards,*

*Krunal Jain | Senior Engineer – Cloud (Product Engineering)*

Email: krunal.j...@sungard.com ▪ kruna...@gmail.com | Mobile:
+91-92713-59024 <+91%2092713%2059024>

*Sungard Availability Services, India *| www.sungardas.
<http://www.sungardas.com/>*in*
2nd Floor, Wing 4, Cluster D, MIDC, Kharadi Knowledge Park, Pune - 411 014

*[image: Logo]* <http://www.sungardas.com/>
*[image: cid:image019.png@01CF48EC.6617C7F0]*
<http://blog.sungardas.com/> *[image:
cid:image020.png@01CF48EC.6617C7F0]* <http://www.youtube.com/user/SunGardAS>
 *[image: cid:image021.png@01CF48EC.6617C7F0]*
<https://plus.google.com/u/0/102459878242108588663/posts> *[image:
cid:image022.png@01CF48EC.6617C7F0]*
<https://www.facebook.com/SunGardAS> *[image:
cid:image023.png@01CF48EC.6617C7F0]*
<http://www.linkedin.com/company/sungard-availability-services> *[image:
cid:image024.png@01CF48EC.6617C7F0]* <https://twitter.com/SunGardAS>
*CONFIDENTIALITY:*  This e-mail (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited.  If you received this e-mail in error,
please notify the sender and delete this e-mail from your system.


RE: CLOUDSTACK-5583: vmopsSnapshot plug-in (XenServer) does not return an error when it should

2014-10-31 Thread Krunal Jain
cmd2 =
'''xe vm-destroy uuid=%s ''' % vdiUuid


logging.debug("Executing command: " + cmd2)

retCode2 =
subprocess.call(cmd2, shell=True)

if retCode2
!= 0:


logging. error("Command: " + cmd2 + " failed with return code: " +
str(retCode2))

else:

logging. error("Command: "
+ cmd + " failed with return code: " + str(retCode) + " and error message:
" + stderr)

except OSError, (errno, strerror):

errMsg = "OSError while reverting vm " +
vmName + " to snapshot " + snapshotUUID + " with errno: " + str(errno) + "
and strerr: " + strerror

logging. error(errMsg)

raise xs_errors.XenError(errMsg)

return str(retCode)



Logs:

2014-10-31 16:57:37 DEBUG [root] Executing command: xe vbd-list
vm-uuid=91dcb34d-1b96-909f-71c2-9ea3ed0911ec | grep 'vdi-uuid' | grep -v
'not in database' | sed -e 's/vdi-uuid ( RO)://g'

2014-10-31 16:57:37 DEBUG [root]
['0043e816-d74d-4e2c-8078-0e92f093454c',
'aff8dc5b-8db3-4822-ba83-d2357f0c1cad']

2014-10-31 16:57:37 DEBUG [root] Executing command: xe vm-param-get
param-name=power-state uuid=91dcb34d-1b96-909f-71c2-9ea3ed0911ec

2014-10-31 16:57:37 DEBUG [root] vmPowerState: halted

2014-10-31 16:57:37 DEBUG [root] Executing command: xe vm-destroy
uuid=91dcb34d-1b96-909f-71c2-9ea3ed0911ec

2014-10-31 16:57:37 DEBUG [root] Executing command: xe snapshot-revert
snapshot-uuid=ab6ac37f-3a50-e1e7-23ce-4f19cd929c2c

2014-10-31 16:57:39 ERROR [root] Command: xe snapshot-revert
snapshot-uuid=ab6ac37f-3a50-e1e7-23ce-4f19cd929c2c  failed with *return
code: 1 and error message: Error code: SR_BACKEND_FAILURE_44*



I have changed all the calls using “os” to “subprocess”. Request you to
please have a look and suggest if any changes are required.

Thanks in advance!



*Regards,*

*Krunal Jain | Senior Engineer – Cloud (Product Engineering)*

Email: krunal.j...@sungard.com ▪ kruna...@gmail.com | Mobile:
+91-92713-59024 <+91%2092713%2059024>

*Sungard Availability Services, India *| www.sungardas.
<http://www.sungardas.com/>*in*
2nd Floor, Wing 4, Cluster D, MIDC, Kharadi Knowledge Park, Pune - 411 014

*[image: Logo]* <http://www.sungardas.com/>
*[image: cid:image019.png@01CF48EC.6617C7F0]*
<http://blog.sungardas.com/> *[image:
cid:image020.png@01CF48EC.6617C7F0]* <http://www.youtube.com/user/SunGardAS>
 *[image: cid:image021.png@01CF48EC.6617C7F0]*
<https://plus.google.com/u/0/102459878242108588663/posts> *[image:
cid:image022.png@01CF48EC.6617C7F0]*
<https://www.facebook.com/SunGardAS> *[image:
cid:image023.png@01CF48EC.6617C7F0]*
<http://www.linkedin.com/company/sungard-availability-services> *[image:
cid:image024.png@01CF48EC.6617C7F0]* <https://twitter.com/SunGardAS>
*CONFIDENTIALITY:*  This e-mail (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited.  If you received this e-mail in error,
please notify the sender and delete this e-mail from your system.





*From:* Mandar Barve [mailto:mandar.ba...@sungardas.com]
*Sent:* Monday, October 27, 2014 12:12 PM
*To:* Krunal Jain
*Subject:* Fwd: CLOUDSTACK-5583: vmopsSnapshot plug-in (XenServer) does not
return an error when it should





-- Forwarded message --
From: *Mike Tutkowski* 
Date: Sun, Jul 27, 2014 at 9:48 AM
Subject: Re: CLOUDSTACK-5583: vmopsSnapshot plug-in (XenServer) does not
return an error when it should
To: Mandar Barve 
Cc: cloudstack 

Sorry...I somehow missed this e-mail.



Yes, I think trying that approach sounds good.



Thanks!



On Mon, Jul 7, 2014 at 8:11 AM, Mandar Barve 
wrote:

I followed the steps you mentioned on the bug using a software iSCSI target
in a VM and could reproduce the problem. I do see INSUFFICIENT_SPACE
exception being thrown when "xe snapshot-revert" is called by the
vmopsSnapshot plug in. When this happens the plugin doesn't throw any
exception or return any error.



The problem looks like this xe command is called via os.system module by
the python plugin. xe is a different program and any error/exception thrown
by this won't get propagated to the caller. To fix this os.system can be
replaced by subprocess.call with a check for the return code. I tried this
and this will return a non zero error code to the management server. It may
still not return the child process's exception code.



Let me know what you think.



Thanks,

Mandar



On Fri, Mar 14, 2014 a

RE: Review Request 27522: Review request for patch for an issue - CLOUDSTACK-5583

2014-11-03 Thread Krunal Jain
   RE: Review Request 27522: Review request for patch for an issue -
CLOUDSTACK-5583

Hi,

I am not able to assign the issue CLOUDSTACK-5583 to myself or edit it.

Request you to please help me with it, thanks in advance! J

 *Regards,*

*Krunal Jain | Senior Engineer – Cloud (Product Engineering)*

Email: *krunal.j...@sungard.com*  ▪
*kruna...@gmail.com*  | Mobile: *+91-92713-59024*
<+91%2092713%2059024>

*Sungard Availability Services, India* | *www.sungardas.*
<http://www.sungardas.com/>*in*
2nd Floor, Wing 4, Cluster D, MIDC, Kharadi Knowledge Park, Pune - 411 014

 <http://www.sungardas.com/>* <<...>> *
 <http://blog.sungardas.com/>* <<...>> *
<http://www.youtube.com/user/SunGardAS>* <<...>> *
<https://plus.google.com/u/0/102459878242108588663/posts>* <<...>> *
<https://www.facebook.com/SunGardAS>* <<...>> *
<http://www.linkedin.com/company/sungard-availability-services>* <<...>> *
<https://twitter.com/SunGardAS>* <<...>> *
*CONFIDENTIALITY:*  This e-mail (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited.  If you received this e-mail in error,
please notify the sender and delete this e-mail from your system.

 -Original Message-
From: Krunal [mailto:nore...@reviews.apache.org ]
On Behalf Of Krunal
Sent: Monday, November 03, 2014 7:06 PM
To: Mandar Barve; Mike Tutkowski
Cc: Krunal; cloudstack
Subject: Review Request 27522: Review request for patch for an issue -
CLOUDSTACK-5583

---

This is an automatically generated e-mail. To reply, visit:

https://reviews.apache.org/r/27522/

---

Review request for cloudstack, Mandar Barve and Mike Tutkowski.

Bugs: CLOUDSTACK-5583

https://issues.apache.org/jira/browse/CLOUDSTACK-5583

Repository: cloudstack-git

Description

---

Patch for Cloudstack bug - "vmopsSnapshot plug-in (XenServer) does not
return an error when it should"

Diffs

-

  scripts/vm/hypervisor/xenserver/vmopsSnapshot 6b4693c

Diff: https://reviews.apache.org/r/27522/diff/

Testing

---

Unit testing was done and results already shared via email.

Thanks,

Krunal


I am not able to register or delete a new Template/ISO in CloudStack 4.5

2014-12-11 Thread Krunal Jain
Hello,



When I am trying to register a new Template/ISO in CloudStack (v4.5), it
says registered and shows up in the list but the “state.ready” remains NO.



Hence, when I try creating instance the Template/ISO is not shown for
selection and thus, am not able to provision it.

Also, I am not able to delete the Template/ISO.



Can anyone please help me with this?

Thanks in advance!

Regards,

*Krunal Jain | Senior Engineer – Cloud (Product Engineering)*

Email: *krunal.j...@sungard.com * ▪
*kruna...@gmail.com
* | Mobile: *+91-92713-59024 <+91%2092713%2059024>*

*Sungard Availability Services, India* | *www.sungardas.in
<http://www.sungardas.in>*

2nd Floor, Wing 4, Cluster D, MIDC, Kharadi Knowledge Park, Pune - 411 014

*[image: Logo]* <http://www.sungardas.com/>
*[image: cid:image019.png@01CF48EC.6617C7F0]*
<http://blog.sungardas.com/> *[image:
cid:image020.png@01CF48EC.6617C7F0]* <http://www.youtube.com/user/SunGardAS>
 *[image: cid:image021.png@01CF48EC.6617C7F0]*
<https://plus.google.com/u/0/102459878242108588663/posts> *[image:
cid:image022.png@01CF48EC.6617C7F0]*
<https://www.facebook.com/SunGardAS> *[image:
cid:image023.png@01CF48EC.6617C7F0]*
<http://www.linkedin.com/company/sungard-availability-services> *[image:
cid:image024.png@01CF48EC.6617C7F0]* <https://twitter.com/SunGardAS>

CONFIDENTIALITY:  This e-mail (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited.  If you received this e-mail in error,
please notify the sender and delete this e-mail from your system.


RE: I am not able to register or delete a new Template/ISO in CloudStack 4.5

2014-12-11 Thread Krunal Jain
Thanks, It helped!

-Original Message-
From: Nitin Mehta [mailto:nitin.me...@citrix.com]
Sent: Thursday, December 11, 2014 5:18 PM
To: dev@cloudstack.apache.org
Subject: Re: I am not able to register or delete a new Template/ISO in
CloudStack 4.5

Try using -
https://cwiki.apache.org/confluence/display/CLOUDSTACK/SSVM,+templates,+Sec
ondary+storage+troubleshooting or Google(for pinpointed answers)

Cheers,
-Nitin

On 11/12/14 3:41 PM, "Abhinandan Prateek"
 wrote:

>It takes some time for the template to be downloaded. Recently when I
>tried 4.3 I did not see any progress bar shown there, it was there in
>older versions.
>
>If the template lies in your internal network then you need to set global
>variable secstorage.allowed.internal.sites with the cidr of the internal
>network. SSVM will then go thru the internal interface to download these
>templates.
>
>-abhi
>
>
>On 11-Dec-2014, at 12:24 pm, Krunal Jain
>mailto:krunal.j...@sungardas.com>> wrote:
>
>Hello,
>
>When I am trying to register a new Template/ISO in CloudStack (v4.5), it
>says registered and shows up in the list but the “state.ready” remains NO.
>
>Hence, when I try creating instance the Template/ISO is not shown for
>selection and thus, am not able to provision it.
>Also, I am not able to delete the Template/ISO.
>
>Can anyone please help me with this?
>Thanks in advance!
>Regards,
>Krunal Jain | Senior Engineer – Cloud (Product Engineering)
>Email: krunal.j...@sungard.com<mailto:krunal.j...@sungard.com> ▪
>kruna...@gmail.com<mailto:kruna...@gmail.com> | Mobile:
>+91-92713-59024<mailto:+91%2092713%2059024>
>Sungard Availability Services, India |
>www.sungardas.in<http://www.sungardas.in/>
>2nd Floor, Wing 4, Cluster D, MIDC, Kharadi Knowledge Park, Pune - 411 014
><http://www.sungardas.com/>
><http://blog.sungardas.com/> <http://www.youtube.com/user/SunGardAS>
><https://plus.google.com/u/0/102459878242108588663/posts>
><https://www.facebook.com/SunGardAS>
><http://www.linkedin.com/company/sungard-availability-services>
><https://twitter.com/SunGardAS>
>CONFIDENTIALITY:  This e-mail (including any attachments) may contain
>confidential, proprietary and privileged information, and unauthorized
>disclosure or use is prohibited.  If you received this e-mail in error,
>please notify the sender and delete this e-mail from your system.
>
>Find out more about ShapeBlue and our range of CloudStack related services
>
>IaaS Cloud Design &
>Build<http://shapeblue.com/iaas-cloud-design-and-build//>
>CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/>
>CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/>
>CloudStack Software
>Engineering<http://shapeblue.com/cloudstack-software-engineering/>
>CloudStack Infrastructure
>Support<http://shapeblue.com/cloudstack-infrastructure-support/>
>CloudStack Bootcamp Training
>Courses<http://shapeblue.com/cloudstack-training/>
>
>This email and any attachments to it may be confidential and are intended
>solely for the use of the individual to whom it is addressed. Any views
>or opinions expressed are solely those of the author and do not
>necessarily represent those of Shape Blue Ltd or related companies. If
>you are not the intended recipient of this email, you must neither take
>any action based upon its contents, nor copy or show it to anyone. Please
>contact the sender if you believe you have received this email in error.
>Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
>Services India LLP is a company incorporated in India and is operated
>under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is
>a company incorporated in Brasil and is operated under license from Shape
>Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of
>South Africa and is traded under license from Shape Blue Ltd. ShapeBlue
>is a registered trademark.