[GitHub] cloudstack-docs pull request #19: Updating The Nuage VSP Plugin Documentatio...

2017-02-27 Thread krissterckx
GitHub user krissterckx opened a pull request:

https://github.com/apache/cloudstack-docs/pull/19

Updating The Nuage VSP Plugin Documentation for ACS 4.10 release



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/krissterckx/cloudstack-docs master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19


commit 3417a0c830eef61ab1960b0d61244f12afb7a9e7
Author: Kris Sterckx 
Date:   2017-02-24T11:09:29Z

Updating The Nuage VSP Plugin Documentation for ACS 4.10 release




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs pull request: Inclusion of Nuage-VSP plugin

2015-12-21 Thread KrisSterckx
GitHub user KrisSterckx opened a pull request:

https://github.com/apache/cloudstack-docs/pull/14

Inclusion of Nuage-VSP plugin

Documentation for the 4.7.0 Nuage-VSP plugin

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/KrisSterckx/cloudstack-docs master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14


commit e1a32fbac1e66ccc8b9d44e156a8b4435bf7ba16
Author: Kris Sterckx 
Date:   2015-12-14T13:49:23Z

Inclusion of Nuage-VSP plugin




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs pull request: Inclusion of Nuage-VSP plugin

2016-01-04 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack-docs/pull/14#issuecomment-168614046
  
Hi all, @runseb 
what should do I to get attention to this PR ? 

Happy New Year, all !
Kris 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs pull request: Inclusion of Nuage-VSP plugin

2016-01-05 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack-docs/pull/14#issuecomment-168938400
  
Thanks @nlivens and @runseb !   
Additional question i have : How does this end up now at 
http://docs.cloudstack.apache.org/en/latest/ ?

thanks! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs pull request: Inclusion of Nuage-VSP plugin

2016-01-05 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack-docs/pull/14#issuecomment-168966438
  
@terbolous OK thanks - is that something you will take up ? Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-05 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-145488778
  
I would like to bring attention to the reviewers that only a few CS core 
extensions were made - all other modifications are NuageVsp plugin internal, 
for Nuage Virtualized Services Platform Release 3.2 support.

api/src/com/cloud/network/Network.java
* Remove the unused NuageVspVpc constant

engine/schema/src/com/cloud/network/dao/IPAddressDao.java
engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java
* new DAO method added

engine/schema/src/com/cloud/network/vpc/VpcOfferingVO.java
* new constructor added

server/src/com/cloud/configuration/ConfigurationManagerImpl.java
* Exclude shared networks from DirectNetworkGuru canHandle() in case the 
offering is NuageVsp as then NuageVsp guru is handling.

server/src/com/cloud/configuration/ConfigurationManagerImpl.java
* Add extra check on isPersistent() for nuageVpc check


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-11 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-147174211
  
Hi @remibergsma , The rebase is committed. Thanks.   

(The cloudstack-pull-requests jenkins project is disabled though?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-11 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-147179219
  
@remibergsma OK done now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-14 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-148123443
  
@remibergsma @jburwell thanks for all help and detailed review. Most 
comments have been addressed. Could we set for the remaining ones to take in 
next release? The plugin update is functional and brings great value - it would 
be great to take it in and further continuously improve. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-19 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-149321626
  
@jburwell do you approve the PR ? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-22 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-150258402
  
@remibergsma  how can we continue pls ? Could you run Travis again ? Can we 
do anything ? Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-29 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-152114217
  
@jburwell thanks for intensive review. How does it look like? :) thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-11-02 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-153036347
  
Hi

@jburwell can you pls approve if the PR looks good to you now ?

@remibergsma, can you pls suggest how we can continue ? Thanks

Kris


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-11-03 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-153367941
  
@jburwell  @remibergsma  Pls note all again that the changes to core are 
very minimal and are limited to convenience extensions only. I would expect 
running the CI should be good in verifying that the plugin changes don't break 
anything in core.

Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-11-03 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-153373302
  
@jburwell we have added unit testing and Marvin tests, and we posted the 
results of Marvin in the Jira ticket, but in order to run the Marvin tests you 
need a Nuage VSP solution. I believe that was made clear and it is also 
@remibergsma 's understanding as we talked in Dublin.
Having that said I do understand your request, and we can work at 
facilitating more community testing in next releases. Also we can certainly 
have the conversation on how we can help you on the short hand, or we could 
organize a live demo of the functionality or whatever helps in building trust. 
Thanks.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-11-03 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-153518941
  
Thanks @mlsorensen .

We wanted to bring this plugin update in 4.6 still for the exact reason to 
update the community with enriched functionality with our latest released Nuage 
SDN platform. We kept changes to the core to the minimum for the sake of 
maximizing the acceptance (knowing we were pretty late in the cycle) and at the 
same time maximizing the benefits to the community, with added unit- & marvin 
test coverage. 

Myself and the entire engineering who worked at this upstream contribution 
(dev & QA team) are still hoping for Apache CloudStack to welcome the support 
for the latest released Nuage VSP SDN platform and benefit the features & bug 
fixes it brings.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-11-18 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-157825620
  
Thanks @remibergsma and all reviewers  -  This is great.  This is a great 
add to CloudStack and a great milestone for Nuage Networks.  CloudStack + SDN  
: a winning team !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-19 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220326489
  
@DaanHoogland  to your question :

We are embarking full CloudStack build automation as that gives us 
cloudstack-nuagevsp-plugin <> nuagevsp-client-jar version compatibility by 
design, and provides us higher development efficiency as it gives us java 
compile time checking.

We could publish the code at our github.com/nuagenetworks repo's if that is 
desired. I see this is not consistently applied by other vendors though.

Let me know if there are other actions to take, or feel free to shoot any 
additional question.

cheers,
Kris


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-19 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220394412
  
Hi @DaanHoogland 

The architecture is 

`cloudstack   ---cmp-->  nuage-vsp-acs-client  ---cfg-->  
Nuage VSP platform`

with 

- nuagevsp-plugin : the plugin in cloudstack
- nuage-vsp-acs-client : publicly available middleware which glues the 
plugin to the Nuage VSP platform
- Nuage VSP platform : the Nuage Networks SDN platform, commercially 
available (http://www.nuagenetworks.net)

and

- `---cmp-->` a compile-time dependency (resolved by Maven, cfr @nlivens's 
update of the pom file)
- `---cfg-->` a configuration-time dependency, resolved at cloudstack 
infrastructure provisioning time when adding the cloudstack NuageVsp device to 
its Physical Network (and part of that, provisioning the API URL and 
credentials of the Nuage VSP platform itself).

Adding the NuageVsp device in cloudstack will fail when invalid Nuage VSP 
configuration is submitted (wrong API URL and/or wrong credentials) (as at that 
time the nuage-vsp-acs-client software will attempt to logon to the specified 
Nuage VSP platform), which would happen when the user has no Nuage VSP platform 
at all. The end-result of that is that no device is added, and so the physical 
network remaining unusable until another device is added.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220576106
  
Yes, correct, and thanks @DaanHoogland.

Could you initiate for more reviews; or anything i can do?

Thx


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220667799
  
Thanks @swill. Folks, pls review :)

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Dynamically load drivers before creating ...

2016-05-23 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1553#issuecomment-221024596
  
@DaanHoogland moreover it is proven in Nuage lab to resolve the issues we 
had


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-23 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-221023752
  
Travis CI failure : Is it a known issue ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-23 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-221087524
  
@rhtyd, @koushik-das, @remibergsma, @abhinandanprateek, @rafaelweingartner 

anyone wants to further review ? We would like votes :)
Thanks!

Thanks @swill , @GabrielBrascher 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-24 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-221394563
  
Thanks all folks, that gives the needed LGTM votes!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-25 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-221666486
  
Thanks @swill and all involved !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1585: CLOUDSTACK-9399 : NPE during deletion of host when c...

2016-06-10 Thread KrisSterckx
Github user KrisSterckx commented on the issue:

https://github.com/apache/cloudstack/pull/1585
  
@swill, you prefer i close and reopen? Thx


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...

2016-09-06 Thread krissterckx
Github user krissterckx commented on the issue:

https://github.com/apache/cloudstack/pull/1578
  
LGTM

Code is good, tests are good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...

2016-04-15 Thread KrisSterckx
Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1452#issuecomment-210464551
  
Hi @DaanHoogland  is this PR still in the candidate list of 4.9.0 ?

If there is anything that I & the team can facilitate in doing, pls let me 
know.

Thanks, Kris



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...

2016-10-11 Thread krissterckx
Github user krissterckx commented on the issue:

https://github.com/apache/cloudstack/pull/1578
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...

2016-10-11 Thread krissterckx
Github user krissterckx commented on the issue:

https://github.com/apache/cloudstack/pull/1578
  
Hi @jburwell  appreciating your view based on the comments addressed.

Thanks

Kris 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...

2016-11-10 Thread krissterckx
Github user krissterckx commented on the issue:

https://github.com/apache/cloudstack/pull/1578
  
@jburwell @rhtyd 
I would appreciate your feedback.
 
This PR is pending from early June, and we have more PR's pending. 

Thanks,
Cheers

Kris Sterckx
Nuage Networks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...

2016-11-16 Thread krissterckx
Github user krissterckx commented on the issue:

https://github.com/apache/cloudstack/pull/1578
  
Thanks @karuturi 

Kris


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

2016-12-03 Thread krissterckx
Github user krissterckx commented on the issue:

https://github.com/apache/cloudstack/pull/1579
  
Hi @rhtyd 
as #1806 got merged, can a travis re-run be initiated ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

2016-12-04 Thread krissterckx
Github user krissterckx commented on the issue:

https://github.com/apache/cloudstack/pull/1579
  
Thanks @rhtyd , I resubmitted


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

2016-12-04 Thread krissterckx
Github user krissterckx commented on the issue:

https://github.com/apache/cloudstack/pull/1579
  
@rhtyd Travis is happy
findbugs fails at globodns though (not due to this PR)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---



[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

2016-12-06 Thread krissterckx
Github user krissterckx commented on the issue:

https://github.com/apache/cloudstack/pull/1579
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

2016-12-07 Thread krissterckx
Github user krissterckx commented on the issue:

https://github.com/apache/cloudstack/pull/1579
  
Volumes test (test_create_volume_under_domain) is only failure ; unrelated 
to this PR

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

2016-12-07 Thread krissterckx
Github user krissterckx commented on the issue:

https://github.com/apache/cloudstack/pull/1579
  
@rhtyd can we merge in ? Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1904: CLOUDSTACK-9729: Use latest Nuage client.

2017-01-13 Thread krissterckx
Github user krissterckx commented on the issue:

https://github.com/apache/cloudstack/pull/1904
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1912: CLOUDSTACK-9749: Disable password service on ilb sys...

2017-01-24 Thread krissterckx
Github user krissterckx commented on the issue:

https://github.com/apache/cloudstack/pull/1912
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---