[GitHub] cloudstack pull request #1910: CLOUDSTACK-9748:VPN Users search functionalit...
Github user Ashadeepa closed the pull request at: https://github.com/apache/cloudstack/pull/1910 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1957 @rafaelweingartner : This is due to the change in my remote urls. Closing the old PR https://github.com/apache/cloudstack/issues/1910. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1959: CLOUDSTACK-9786:API reference guide entry for...
GitHub user Ashadeepa opened a pull request: https://github.com/apache/cloudstack/pull/1959 CLOUDSTACK-9786:API reference guide entry for associateIpAddress needs additional information Going through the code & implementation, it seems like either of the parameters are not required while accessing the API : associateIpAddress. There are 3 cases for which this api works. 1) networkId 2) vpcId 3) zoneId. Either of these can be provided to achieve the same functionality. If neither of them is provided, there is an error text shown. E.g. [root@CCP ~]# curl -s 'http://10.66.43.37:8096/client/api?command=associateIpAddress&listall=true' | xmllint --format - -o 431 4350 Unable to figure out zone to assign ip to. Please specify either zoneId, or networkId, or vpcId in the call Modify the API reference guide entry with this detail in the "description" You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9786 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1959.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1959 commit 030d34dca89621965afa2043a78a165a21adc26e Author: Ashadeepa Debnath Date: 2017-02-21T11:29:02Z CLOUDSTACK-9786:API reference guide entry for associateIpAddress needs a fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1957 @rafaelweingartner : Regarding that force commit, will surely keep that in mind in future. About keyword documentation, I had gone through several cloudstack apis (E.g. https://cloudstack.apache.org/api/apidocs-4.9/apis/listVirtualMachines.html, https://cloudstack.apache.org/api/apidocs-4.9/apis/listNetworks.html, https://cloudstack.apache.org/api/apidocs-4.9/apis/listZones.html, etc) , similar thing are being used. I do agree what you are suggesting. However, IMO, the API name "listVpnUser" gives an idea about the response we will get, i.e. listing the vpn user using a search keyword. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1942: CLOUDSTACK-9784 : GPU detail not displayed in GPU ta...
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1942 Tested the code changes. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1910: CLOUDSTACK-9748:VPN Users search functionalit...
GitHub user Ashadeepa opened a pull request: https://github.com/apache/cloudstack/pull/1910 CLOUDSTACK-9748:VPN Users search functionality broken VPN Users search functionality broken If you try to search VPN users with itâs user name, you will not be able to search. Fixed the same. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Ashadeepa/cloudstack CLOUDSTACK-9748 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1910.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1910 commit 0752ff667db09eeb3276627baef009eb414abaf4 Author: root Date: 2017-01-17T18:09:17Z CLOUDSTACK-9748:VPN Users search functionality broken --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1910: CLOUDSTACK-9748:VPN Users search functionalit...
Github user Ashadeepa commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1910#discussion_r98381118
--- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java
---
@@ -613,6 +614,10 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
sc.setParameters("username", username);
}
+if (keyword!= null) {
+sc.setParameters("username", "%" + keyword + "%");
+}
+
Pair, Integer> result =
_vpnUsersDao.searchAndCount(sc, searchFilter);
--- End diff --
@syed : If both are set, we are giving preference to keyword as the search
will happen using keyword query param. This is in according with other existing
APIs. Keyword is the request parameter for : List by keyword functionality.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1910: CLOUDSTACK-9748:VPN Users search functionalit...
Github user Ashadeepa commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1910#discussion_r98381232
--- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java
---
@@ -596,7 +597,7 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
sb.and("id", sb.entity().getId(), SearchCriteria.Op.EQ);
-sb.and("username", sb.entity().getUsername(),
SearchCriteria.Op.EQ);
+sb.and("username", sb.entity().getUsername(),
SearchCriteria.Op.LIKE);
--- End diff --
@syed Used LIKE instead of EQ as username will be used in a WHERE clause to
search for a specified pattern in a column using the keyword.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1910: CLOUDSTACK-9748:VPN Users search functionalit...
Github user Ashadeepa commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1910#discussion_r98422211
--- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java
---
@@ -596,7 +597,7 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
sb.and("id", sb.entity().getId(), SearchCriteria.Op.EQ);
-sb.and("username", sb.entity().getUsername(),
SearchCriteria.Op.EQ);
+sb.and("username", sb.entity().getUsername(),
SearchCriteria.Op.LIKE);
--- End diff --
@ustcweizhou : Thanks but unfortunately, addOr & addAnd methods are now
deprecated, so I avoided using the same.
Also, LIKE with work only when keyword is set. When only username is set,
`sc.setParameters("username", username); `
will get executed with the exact match i.e. same as how EQ will work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1910: CLOUDSTACK-9748:VPN Users search functionalit...
Github user Ashadeepa closed the pull request at: https://github.com/apache/cloudstack/pull/1910 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1910: CLOUDSTACK-9748:VPN Users search functionality broke...
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1910   [TestResults_CLOUDSTACK-9748.txt](https://github.com/apache/cloudstack/files/779944/TestResults_CLOUDSTACK-9748.txt) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1910: CLOUDSTACK-9748:VPN Users search functionalit...
GitHub user Ashadeepa reopened a pull request: https://github.com/apache/cloudstack/pull/1910 CLOUDSTACK-9748:VPN Users search functionality broken VPN Users search functionality broken If you try to search VPN users with itâs user name, you will not be able to search. Fixed the same. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Ashadeepa/cloudstack CLOUDSTACK-9748 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1910.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1910 commit 0752ff667db09eeb3276627baef009eb414abaf4 Author: root Date: 2017-01-17T18:09:17Z CLOUDSTACK-9748:VPN Users search functionality broken --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1910: CLOUDSTACK-9748:VPN Users search functionality broke...
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1910 @ustcweizhou : Hi, I had tested the same and added my test results in the file TestResults_CLOUDSTACK-9748.txt. As per my previous comment, when both username & keyword are set, users with username like 'keyword' will be the expected result. Also, your suggested won't work as "keyword" in absent in the VPNUserVO class as there is no such column named as keyword. I tried it, got an exception. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1957: CLOUDSTACK-9748:VPN Users search functionalit...
GitHub user Ashadeepa opened a pull request: https://github.com/apache/cloudstack/pull/1957 CLOUDSTACK-9748:VPN Users search functionality broken VPN Users search functionality broken If you try to search VPN users with itâs user name, you will not be able to search. Fixed the same. Parent PR : https://github.com/apache/cloudstack/pull/1910 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9748 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1957.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1957 commit 588ececd045c9175b33647375fd702e3e37f2126 Author: root Date: 2017-01-17T18:09:17Z CLOUDSTACK-9748:VPN Users search functionality broken --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1910: CLOUDSTACK-9748:VPN Users search functionality broke...
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1910 @ustcweizhou : Thanks. I have made the changes. New PR : https://github.com/apache/cloudstack/pull/1957. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1957 @ustcweizhou : My bad. Amended the changes . Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1957: CLOUDSTACK-9748:VPN Users search functionalit...
Github user Ashadeepa commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1957#discussion_r10411
--- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java
---
@@ -621,6 +627,10 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
sc.setParameters("username", username);
}
+if (keyword!= null) {
--- End diff --
@ustcweizhou : My bad. Amended the changes . Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
