Re: [Doc] Developer Enviroment Wiki - Maven

2013-09-02 Thread Alexander Hitchins
Would there be any milage in creating template vm's set up with a 
working dev environment? Then we could download the image, run and just 
then update source via Git. This is what I was planning to do within my 
organisation. If other may find it useful then I'll try to ensure it's 
available for all.


Alex

On 9/2/2013 9:09 AM, Sebastien Goasguen wrote:

On Sep 2, 2013, at 3:12 AM, Marty Sweet  wrote:


Maybe have a link off the enviroment page which links to the Wiki.

Ok I did that, we just need to think about how to clean this up.


I found the Wiki guides helpful for setting up, maybe just a 'Development
environment in rhel' and 'Development environment in Debian' section.

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Setting+up+CloudStack+Development+Environment+on+Linux
is
messy but if you logically pick out the steps it works.

Maybe:
- Setup Debian
- Setup RHEL
- Pull Repo

Should we also be encouraging users to make a github clone and work from
there? I have seen that mentioned in one place, can't remember where now.


We have talked about moving the docs to a separate repo. I think we need to do 
that, then accept pull requests for the docs.
that would allow folks to correct/help with docs.



Marty


On Mon, Sep 2, 2013 at 8:04 AM, Sebastien Goasguen  wrote:


On Aug 30, 2013, at 12:51 PM, Marty Sweet  wrote:


After more searching I have found:


https://cwiki.apache.org/confluence/display/CLOUDSTACK/Setting+up+CloudStack+Development+Environment+on+Linux

which
seems the most comprehensive.

Would it be possible to have this guide instead of
http://cloudstack.apache.org/develop/environment.html<

http://cloudstack.apache.org/develop/environment.html#maven>

as
multiple near identical installation instructions are bound to cause
confusion.

Marty


Looking at this the webpage:
http://cloudstack.apache.org/develop/environment.html

Mixes 4.0 release instructions and 4.1+
It also mixes ubuntu/debian and rhel flavors.

I am not sure what's the best to clean this up. We can remove the 4.0
instructions and we can pick one OS

Developers should look for info on the wiki while all info for users
should be in the docs (in an ideal world).

We can't really duplicate all info on the website.

thoughts ?

-sebastien


On Fri, Aug 30, 2013 at 5:47 PM, Marty Sweet 

wrote:

Hi Sebastian,

I found the answer in the INSTALL.md file in the main repo, maven is

3.0.5.

I see Ian has created a more detailed guide in this bug
https://issues.apache.org/jira/browse/CLOUDSTACK-2877, but

unfortunately

it is not on the Wiki Environment page.

Marty


On Fri, Aug 30, 2013 at 5:37 PM, sebgoa  wrote:


On Aug 30, 2013, at 6:22 PM, Marty Sweet  wrote:


Hi guys,

On this wiki it does not cover the installation of Maven, while it

does

for

Ant, Tomcat and MySQL. Should users install 'maven' or 'maven2'?

http://cloudstack.apache.org/develop/environment.html#maven

Would it be worth filing a bug? I am unsure how to contribute to this
specific page myself?

I am pretty sure it's maven3, but it might work with maven2 as well.

If you find the answer :) you can file a bug and I will pick it up.

To edit the website you need to be a committer, the site is kept in a

svn

repo separate from the source code.

-sebastien


Thanks,
Marty






--

Alexander Hitchins
-
e: a...@alexhitchins.com
w: alexhitchins.com
m: 07788 423 969



Re: [Doc] Developer Enviroment Wiki - Maven

2013-09-02 Thread Alexander Hitchins
Excellent, when I'm at that stage I will certianly pass it on. Be great 
to be able to give something back to the community.


On 9/2/2013 9:27 AM, Daan Hoogland wrote:

H Alex,

Would sound like a good thing in taking away hurdles for starting
contributers. Make sure all the bookmarks are on the desktop:)

So go do it, the community will be greatful.

Greetings,
Daan

On Mon, Sep 2, 2013 at 10:22 AM, Alexander Hitchins
 wrote:

Would there be any milage in creating template vm's set up with a working
dev environment? Then we could download the image, run and just then update
source via Git. This is what I was planning to do within my organisation. If
other may find it useful then I'll try to ensure it's available for all.

Alex


On 9/2/2013 9:09 AM, Sebastien Goasguen wrote:

On Sep 2, 2013, at 3:12 AM, Marty Sweet  wrote:


Maybe have a link off the enviroment page which links to the Wiki.

Ok I did that, we just need to think about how to clean this up.


I found the Wiki guides helpful for setting up, maybe just a 'Development
environment in rhel' and 'Development environment in Debian' section.


https://cwiki.apache.org/confluence/display/CLOUDSTACK/Setting+up+CloudStack+Development+Environment+on+Linux
is
messy but if you logically pick out the steps it works.

Maybe:
- Setup Debian
- Setup RHEL
- Pull Repo

Should we also be encouraging users to make a github clone and work from
there? I have seen that mentioned in one place, can't remember where now.


We have talked about moving the docs to a separate repo. I think we need
to do that, then accept pull requests for the docs.
that would allow folks to correct/help with docs.



Marty


On Mon, Sep 2, 2013 at 8:04 AM, Sebastien Goasguen 
wrote:


On Aug 30, 2013, at 12:51 PM, Marty Sweet  wrote:


After more searching I have found:


https://cwiki.apache.org/confluence/display/CLOUDSTACK/Setting+up+CloudStack+Development+Environment+on+Linux

which
seems the most comprehensive.

Would it be possible to have this guide instead of
http://cloudstack.apache.org/develop/environment.html<

http://cloudstack.apache.org/develop/environment.html#maven>

as
multiple near identical installation instructions are bound to cause
confusion.

Marty


Looking at this the webpage:
http://cloudstack.apache.org/develop/environment.html

Mixes 4.0 release instructions and 4.1+
It also mixes ubuntu/debian and rhel flavors.

I am not sure what's the best to clean this up. We can remove the 4.0
instructions and we can pick one OS

Developers should look for info on the wiki while all info for users
should be in the docs (in an ideal world).

We can't really duplicate all info on the website.

thoughts ?

-sebastien


On Fri, Aug 30, 2013 at 5:47 PM, Marty Sweet 

wrote:

Hi Sebastian,

I found the answer in the INSTALL.md file in the main repo, maven is

3.0.5.

I see Ian has created a more detailed guide in this bug
https://issues.apache.org/jira/browse/CLOUDSTACK-2877, but

unfortunately

it is not on the Wiki Environment page.

Marty


On Fri, Aug 30, 2013 at 5:37 PM, sebgoa  wrote:


On Aug 30, 2013, at 6:22 PM, Marty Sweet 
wrote:


Hi guys,

On this wiki it does not cover the installation of Maven, while it

does

for

Ant, Tomcat and MySQL. Should users install 'maven' or 'maven2'?

http://cloudstack.apache.org/develop/environment.html#maven

Would it be worth filing a bug? I am unsure how to contribute to
this
specific page myself?

I am pretty sure it's maven3, but it might work with maven2 as well.

If you find the answer :) you can file a bug and I will pick it up.

To edit the website you need to be a committer, the site is kept in a

svn

repo separate from the source code.

-sebastien


Thanks,
Marty



--

Alexander Hitchins
-----
e: a...@alexhitchins.com
w: alexhitchins.com
m: 07788 423 969



--
​
Alexander Hitchins
-
e: a...@alexhitchins.com
w: alexhitchins.com
m: 07788 423 969



Re: [DOCS] feedback

2013-09-02 Thread Alexander Hitchins
Thanks Sebastien, I will read these tonight. I'm a big fan of Markdown 
and am using it for all my notes and docs.


Alex


On 9/2/2013 4:19 PM, sebgoa wrote:

Hi,

After seeing lots of frustrated people with folks I decided to try something 
out with markdown.

I used pandoc to convert some docbook files to markdown and I used a structure 
for a book based on 'The little mongodb' book.
We can generate epub and pdf using latex.

See:

https://github.com/runseb/cloudstack-books

There are two "books" aimed at being step by step recipes. Not long, not 
convoluted, single OS, etc…simple step by step.

https://github.com/runseb/cloudstack-books/blob/master/en/clients.markdown
https://github.com/runseb/cloudstack-books/blob/master/en/installation.markdown

I am still sanitizing the installation one based on 4.2 .

Comments, flames ?

-Sebastien



--

Alexander Hitchins
-
e: a...@alexhitchins.com
w: alexhitchins.com
m: 07788 423 969



Re: [DOCS] feedback

2013-09-02 Thread Alexander Hitchins
By syntax highlighting do you mean marking 'code sections'? If so then 
yes you can...


http://daringfireball.net/projects/markdown/syntax#precode

Alex Hitchins

On 9/2/2013 8:31 PM, Ian Duffy wrote:

Love the idea of using markdown! Much easier to write then docbook.

Any idea if it supports the syntax highlighting markdown features github
offer?

e.g.

```shell
#!/bin/bash
echo "hello world"
```

Had some slight issues building on OSX due to me missing the font used and
certain laTeX plugins.
I noticed when I built it some of the code didn't wrap correctly and went
outside of its codeblock, can
this be fixed or is it something we just live with?

On 2 September 2013 17:53, sebgoa  wrote:


On Sep 2, 2013, at 5:19 PM, sebgoa  wrote:


Hi,

After seeing lots of frustrated people with folks I decided to try

something out with markdown.
s/folks/docs


I used pandoc to convert some docbook files to markdown and I used a

structure for a book based on 'The little mongodb' book.

We can generate epub and pdf using latex.

See:

https://github.com/runseb/cloudstack-books

There are two "books" aimed at being step by step recipes. Not long, not

convoluted, single OS, etc…simple step by step.



https://github.com/runseb/cloudstack-books/blob/master/en/clients.markdown
https://github.com/runseb/cloudstack-books/blob/master/en/installation.markdown

I am still sanitizing the installation one based on 4.2 .

Comments, flames ?

-Sebastien





--
​
Alexander Hitchins
-
e: a...@alexhitchins.com
w: alexhitchins.com
m: 07788 423 969



DevCloud Download Issue

2013-09-16 Thread Alexander Hitchins

All,

I'm trying to download the DevCloud image from the following URL :

http://people.apache.org/~bhaisaab/cloudstack/devcloud/devcloud2.ova 
<http://people.apache.org/%7Ebhaisaab/cloudstack/devcloud/devcloud2.ova>


Everytime I attempt the download it fails. I got this location from the 
Wiki, is there a better/other location I can try?


Many thanks,

--

Alexander Hitchins
-
e: a...@alexhitchins.com
w: alexhitchins.com
m: 07788 423 969



Review Request 17188: CS-5438

2014-01-22 Thread Alexander Hitchins

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17188/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

CS-5438 - Added required dependency to the cloud.spec file.


Diffs
-

  packaging/centos63/cloud.spec 7132d4f 

Diff: https://reviews.apache.org/r/17188/diff/


Testing
---

Checked dependency was correct.


Thanks,

Alexander Hitchins



Re: Review Request 17188: CS-5438

2014-01-22 Thread Alexander Hitchins

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17188/#review32508
---

Ship it!


Ship It!

- Alexander Hitchins


On Jan. 22, 2014, 5:03 p.m., Alexander Hitchins wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17188/
> ---
> 
> (Updated Jan. 22, 2014, 5:03 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CS-5438 - Added required dependency to the cloud.spec file.
> 
> 
> Diffs
> -
> 
>   packaging/centos63/cloud.spec 7132d4f 
> 
> Diff: https://reviews.apache.org/r/17188/diff/
> 
> 
> Testing
> ---
> 
> Checked dependency was correct.
> 
> 
> Thanks,
> 
> Alexander Hitchins
> 
>



Review Request 17497: CLOUDSTACK-5977 - Incorrect String Quotations

2014-01-29 Thread Alexander Hitchins

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17497/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

CLOUDSTACK-5977 - String entered as "None" - Should be 'None' for MySQL (& 
MariaDB)


Diffs
-

  setup/db/create-schema.sql 2a53a71 

Diff: https://reviews.apache.org/r/17497/diff/


Testing
---

Ran SQL, No Issues.


Thanks,

Alexander Hitchins



Review Request 17531: CLOUDSTACK-5440 - Added new guest OS types.

2014-01-30 Thread Alexander Hitchins

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17531/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

Added new guest OS types in upgrade script.


Diffs
-

  setup/db/db/schema-421to430.sql afad06c 

Diff: https://reviews.apache.org/r/17531/diff/


Testing
---

Ran new SQL, no errors, checked table, contains correct data.


Thanks,

Alexander Hitchins



Review Request 18077: Findbugs Fixes

2014-02-13 Thread Alexander Hitchins

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18077/
---

Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Repository: cloudstack-git


Description
---

Findbugs Patches


Diffs
-

  
plugins/dedicated-resources/src/org/apache/cloudstack/dedicated/DedicatedResourceManagerImpl.java
 b82b361 
  server/src/com/cloud/network/NetworkModelImpl.java 52a08e1 
  server/src/com/cloud/network/guru/ControlNetworkGuru.java a6e2180 

Diff: https://reviews.apache.org/r/18077/diff/


Testing
---


Thanks,

Alexander Hitchins



Review Request 18078: Findbugs Fixes

2014-02-13 Thread Alexander Hitchins

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18078/
---

Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Repository: cloudstack-git


Description
---

Findbugs Changes


Diffs
-

  
plugins/dedicated-resources/src/org/apache/cloudstack/dedicated/DedicatedResourceManagerImpl.java
 b82b361 
  server/src/com/cloud/network/guru/ControlNetworkGuru.java a6e2180 

Diff: https://reviews.apache.org/r/18078/diff/


Testing
---


Thanks,

Alexander Hitchins



Review Request 18079: Findbugs Fixes

2014-02-13 Thread Alexander Hitchins

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18079/
---

Review request for cloudstack, DrinnaPopopixOJ DrinnaPopopixOJ and Hugo 
Trippaers.


Repository: cloudstack-git


Description
---

Findbugs Fixes


Diffs
-

  
plugins/dedicated-resources/src/org/apache/cloudstack/dedicated/DedicatedResourceManagerImpl.java
 b82b361 

Diff: https://reviews.apache.org/r/18079/diff/


Testing
---


Thanks,

Alexander Hitchins



Review Request 18844: Amended review request (origin: https://reviews.apache.org/r/17531/)

2014-03-06 Thread Alexander Hitchins

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18844/
---

Review request for cloudstack and Devdeep Singh.


Bugs: cloudstack-5440
https://issues.apache.org/jira/browse/cloudstack-5440


Repository: cloudstack-git


Description
---

Please see amended script to add new os types. 32 & 64 bit separated and hard 
coded to specific Id numbers.


Diffs
-

  setup/db/db/schema-430to440.sql acc7e21 

Diff: https://reviews.apache.org/r/18844/diff/


Testing
---

Ran SQL, changes applied with no errors.


Thanks,

Alexander Hitchins



Re: Review Request 17531: CLOUDSTACK-5440 - Added new guest OS types.

2014-03-20 Thread Alexander Hitchins

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17531/
---

(Updated March 20, 2014, 11:50 a.m.)


Review request for cloudstack and Devdeep Singh.


Changes
---

Devdeep, I've updated this review request with the amended diff. I will close 
the other review request.


Repository: cloudstack-git


Description
---

Added new guest OS types in upgrade script.


Diffs (updated)
-

  setup/db/db/schema-430to440.sql acc7e21 

Diff: https://reviews.apache.org/r/17531/diff/


Testing
---

Ran new SQL, no errors, checked table, contains correct data.


Thanks,

Alexander Hitchins



Review Request 19460: Check for returned null, throw exception rather than continue.

2014-03-20 Thread Alexander Hitchins

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19460/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

https://issues.apache.org/jira/browse/CLOUDSTACK-5825

I've added a check for null returned. Previously it would return even though 
there were errors. If null is returned, the takeSnapshot raised and caught an 
exception. I check for null and if received throw a new exception rather than 
continue the flow.


Diffs
-

  server/src/com/cloud/storage/VolumeApiServiceImpl.java 5ffa99b 

Diff: https://reviews.apache.org/r/19460/diff/


Testing
---

Compiled and deployed on a new test system, completed steps and snapshots 
created successfully. 

I could not re-create a snapshot error, however normal operation is as 
expected. It's better it throws an exception rather than continue to log it's 
successful when it's not.


Thanks,

Alexander Hitchins