Re: Review Request 14143: CLOUDSTACK-4637: Add 30sec sleep before router is ssh'd
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14143/#review26219 --- Commit d4dc4f7e70159609f51cf66a032073e31b23eb97 in branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d4dc4f7 ] CLOUDSTACK-4637: Add 30sec sleep before router is ssh'd Egress rules testcases access vm via router. Sleep before accessing router else the expect fails since router is not accessible. Also use router.hostid instead of vm.hostid to identify the host. Signed-off-by: venkataswamybabu budumuru (cherry picked from commit 7d06e77ed9bfacf6d3b74f396c705567d4bf8ba2) - ASF Subversion and Git Services On Sept. 14, 2013, 7:43 a.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14143/ > --- > > (Updated Sept. 14, 2013, 7:43 a.m.) > > > Review request for cloudstack and venkata swamy babu budumuru. > > > Bugs: CLOUDSTACK-4637 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-4637: Add 30sec sleep before router is ssh'd > > Egress rules testcases access vm via router. Sleep before > accessing router else the expect fails since router is not > accessible. Also use router.hostid instead of vm.hostid > to identify the host. > > > Diffs > - > > test/integration/component/test_egress_fw_rules.py ef0fc5a > > Diff: https://reviews.apache.org/r/14143/diff/ > > > Testing > --- > > > Thanks, > > Girish Shilamkar > >
Re: Review Request 14143: CLOUDSTACK-4637: Add 30sec sleep before router is ssh'd
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14143/#review26218 --- Commit 7d06e77ed9bfacf6d3b74f396c705567d4bf8ba2 in branch refs/heads/4.2-forward from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7d06e77 ] CLOUDSTACK-4637: Add 30sec sleep before router is ssh'd Egress rules testcases access vm via router. Sleep before accessing router else the expect fails since router is not accessible. Also use router.hostid instead of vm.hostid to identify the host. Signed-off-by: venkataswamybabu budumuru - ASF Subversion and Git Services On Sept. 14, 2013, 7:43 a.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14143/ > --- > > (Updated Sept. 14, 2013, 7:43 a.m.) > > > Review request for cloudstack and venkata swamy babu budumuru. > > > Bugs: CLOUDSTACK-4637 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-4637: Add 30sec sleep before router is ssh'd > > Egress rules testcases access vm via router. Sleep before > accessing router else the expect fails since router is not > accessible. Also use router.hostid instead of vm.hostid > to identify the host. > > > Diffs > - > > test/integration/component/test_egress_fw_rules.py ef0fc5a > > Diff: https://reviews.apache.org/r/14143/diff/ > > > Testing > --- > > > Thanks, > > Girish Shilamkar > >
Re: Review Request 9539: (CLOUDSTACK-1325) add password in response of RestoreVM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9539/#review26267 --- Commit 5aee73b1a59f02c7853892d13afc58ad01f40c88 in branch refs/heads/4.1 from Wei Zhou [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5aee73b ] CLOUDSTACK-1325: add password in response of RestoreVM (cherry picked from commit a5723992a0eeea9fc383c656b0d61dfc9e541ff9) Signed-off-by: Wei Zhou - ASF Subversion and Git Services On May 6, 2013, 5:12 a.m., Wei Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9539/ > --- > > (Updated May 6, 2013, 5:12 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Harikrishna Patnala. > > > Bugs: CLOUDSTACK-1325 > > > Repository: cloudstack-git > > > Description > --- > > In 4.0.1, There is no password field in the respone of RestoreVM. > Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325 > > This patch add a new password in the response. > > > Diffs > - > > api/src/com/cloud/vm/UserVmService.java 6635657 > server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8 > > Diff: https://reviews.apache.org/r/9539/diff/ > > > Testing > --- > > Testing manually ok. > > command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b > public $jobid => > string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab" > > command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab > public $password => > string(9) "mD5qkzmdk" > > > Thanks, > > Wei Zhou > >
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name and firewall rules issues after KVM upgrade to 4.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13992/#review26343 --- Commit 175549f3ab952bbd39318c16c269c16526255475 in branch refs/heads/4.2-forward from Wei Zhou [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=175549f ] CLOUDSTACK-4405: additional patch for bridge name and firewall rules issues after KVM upgrade to 4.2 There still exist two issues after Edison's commits. (1) Migration from new hosts to old hosts failed. The bridge name on old host is set to cloudVirBr* if network.bridge.name.schema is set to 3.0 in /etc/cloudstack/agent/agent.properties, but the actual bridge name is breth*-* after running cloudstack-agent-upgrade. (2) all ports of vms (Basic zone, or Advanced zone with security groups) on old hosts are open, because the iptables rules are binding to device (bridge) name which is changed by cloudstack-agent-upgrade. After this, the KVM upgrade steps : a. Install 4.2 cloudstack agent on each kvm host b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules. c. install a libvirt hook: c1. mkdir /etc/libvirt/hooks c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu c3. chmod +x /etc/libvirt/hooks/qemu c4. service libvirtd restart c5. service cloudstack-agent restart - ASF Subversion and Git Services On Sept. 9, 2013, 8:09 a.m., Wei Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13992/ > --- > > (Updated Sept. 9, 2013, 8:09 a.m.) > > > Review request for cloudstack and edison su. > > > Bugs: CLOUDSTACK-4405 > > > Repository: cloudstack-git > > > Description > --- > > There still exist two issues after Edison's commits. > (1) Migration from new hosts to old hosts failed. > The bridge name on old host is set to cloudVirBr* if > network.bridge.name.schema is set to 3.0 in > /etc/cloudstack/agent/agent.properties, but the actual bridge name is > breth*-* after running cloudstack-agent-upgrade. > > (2) all ports of vms (Basic zone, or Advanced zone with security groups) on > old hosts are open, because the iptables rules are binding to device (bridge) > name which is changed by cloudstack-agent-upgrade. > > > Diffs > - > > agent/bindir/cloudstack-agent-upgrade.in 4972d39 > debian/cloudstack-agent.postinst 499ae6a > debian/rules 5e3d58c > packaging/centos63/cloud.spec 2b814f8 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java > e3779a7 > scripts/vm/network/security_group.py 0ac8b74 > > Diff: https://reviews.apache.org/r/13992/diff/ > > > Testing > --- > > tested ok on my environment. > > After this, the KVM upgrade steps : > a. Install 4.2 cloudstack agent on each kvm host > b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing > bridge name to new bridge name, and update related firewall rules. >c. install a libvirt hook: > c1. mkdir /etc/libvirt/hooks > c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook > /etc/libvirt/hooks/qemu > c3. chmod +x /etc/libvirt/hooks/qemu > c4. service libvirtd restart > c5. service cloudstack-agent restart > > > Thanks, > > Wei Zhou > >
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name and firewall rules issues after KVM upgrade to 4.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13992/#review26344 --- Commit a0988780ad88bb56becb0a13efedcd79c1bee142 in branch refs/heads/4.2-forward from Wei Zhou [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a098878 ] CLOUDSTACK-4405: change rpm and debian packaging to support automatic update (KVM upgrade) Including following steps: b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules. c. install a libvirt hook: c1. mkdir /etc/libvirt/hooks c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu c3. chmod +x /etc/libvirt/hooks/qemu c4. service libvirtd restart - ASF Subversion and Git Services On Sept. 9, 2013, 8:09 a.m., Wei Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13992/ > --- > > (Updated Sept. 9, 2013, 8:09 a.m.) > > > Review request for cloudstack and edison su. > > > Bugs: CLOUDSTACK-4405 > > > Repository: cloudstack-git > > > Description > --- > > There still exist two issues after Edison's commits. > (1) Migration from new hosts to old hosts failed. > The bridge name on old host is set to cloudVirBr* if > network.bridge.name.schema is set to 3.0 in > /etc/cloudstack/agent/agent.properties, but the actual bridge name is > breth*-* after running cloudstack-agent-upgrade. > > (2) all ports of vms (Basic zone, or Advanced zone with security groups) on > old hosts are open, because the iptables rules are binding to device (bridge) > name which is changed by cloudstack-agent-upgrade. > > > Diffs > - > > agent/bindir/cloudstack-agent-upgrade.in 4972d39 > debian/cloudstack-agent.postinst 499ae6a > debian/rules 5e3d58c > packaging/centos63/cloud.spec 2b814f8 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java > e3779a7 > scripts/vm/network/security_group.py 0ac8b74 > > Diff: https://reviews.apache.org/r/13992/diff/ > > > Testing > --- > > tested ok on my environment. > > After this, the KVM upgrade steps : > a. Install 4.2 cloudstack agent on each kvm host > b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing > bridge name to new bridge name, and update related firewall rules. >c. install a libvirt hook: > c1. mkdir /etc/libvirt/hooks > c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook > /etc/libvirt/hooks/qemu > c3. chmod +x /etc/libvirt/hooks/qemu > c4. service libvirtd restart > c5. service cloudstack-agent restart > > > Thanks, > > Wei Zhou > >
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name and firewall rules issues after KVM upgrade to 4.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13992/#review26346 --- Commit 258118efa67b426611dc87c66b4891924641772b in branch refs/heads/master from Wei Zhou [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=258118e ] CLOUDSTACK-4405: additional patch for bridge name and firewall rules issues after KVM upgrade to 4.2 There still exist two issues after Edison's commits. (1) Migration from new hosts to old hosts failed. The bridge name on old host is set to cloudVirBr* if network.bridge.name.schema is set to 3.0 in /etc/cloudstack/agent/agent.properties, but the actual bridge name is breth*-* after running cloudstack-agent-upgrade. (2) all ports of vms (Basic zone, or Advanced zone with security groups) on old hosts are open, because the iptables rules are binding to device (bridge) name which is changed by cloudstack-agent-upgrade. After this, the KVM upgrade steps : a. Install 4.2 cloudstack agent on each kvm host b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules. c. install a libvirt hook: c1. mkdir /etc/libvirt/hooks c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu c3. chmod +x /etc/libvirt/hooks/qemu c4. service libvirtd restart c5. service cloudstack-agent restart Signed-off-by: Wei Zhou - ASF Subversion and Git Services On Sept. 9, 2013, 8:09 a.m., Wei Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13992/ > --- > > (Updated Sept. 9, 2013, 8:09 a.m.) > > > Review request for cloudstack and edison su. > > > Bugs: CLOUDSTACK-4405 > > > Repository: cloudstack-git > > > Description > --- > > There still exist two issues after Edison's commits. > (1) Migration from new hosts to old hosts failed. > The bridge name on old host is set to cloudVirBr* if > network.bridge.name.schema is set to 3.0 in > /etc/cloudstack/agent/agent.properties, but the actual bridge name is > breth*-* after running cloudstack-agent-upgrade. > > (2) all ports of vms (Basic zone, or Advanced zone with security groups) on > old hosts are open, because the iptables rules are binding to device (bridge) > name which is changed by cloudstack-agent-upgrade. > > > Diffs > - > > agent/bindir/cloudstack-agent-upgrade.in 4972d39 > debian/cloudstack-agent.postinst 499ae6a > debian/rules 5e3d58c > packaging/centos63/cloud.spec 2b814f8 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java > e3779a7 > scripts/vm/network/security_group.py 0ac8b74 > > Diff: https://reviews.apache.org/r/13992/diff/ > > > Testing > --- > > tested ok on my environment. > > After this, the KVM upgrade steps : > a. Install 4.2 cloudstack agent on each kvm host > b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing > bridge name to new bridge name, and update related firewall rules. >c. install a libvirt hook: > c1. mkdir /etc/libvirt/hooks > c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook > /etc/libvirt/hooks/qemu > c3. chmod +x /etc/libvirt/hooks/qemu > c4. service libvirtd restart > c5. service cloudstack-agent restart > > > Thanks, > > Wei Zhou > >
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name and firewall rules issues after KVM upgrade to 4.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13992/#review26348 --- Commit 7b4f84622051b532a7e272dc1ed87310ea119cbc in branch refs/heads/master from Edison Su [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7b4f846 ] CLOUDSTACK-4405: add a tool: cloudstack-agent-upgrade to upgrade bridge name on kvm host (cherry picked from commit 0ef6084d2c838a78eda29d258b1af98df96451b3) Signed-off-by: Wei Zhou - ASF Subversion and Git Services On Sept. 9, 2013, 8:09 a.m., Wei Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13992/ > --- > > (Updated Sept. 9, 2013, 8:09 a.m.) > > > Review request for cloudstack and edison su. > > > Bugs: CLOUDSTACK-4405 > > > Repository: cloudstack-git > > > Description > --- > > There still exist two issues after Edison's commits. > (1) Migration from new hosts to old hosts failed. > The bridge name on old host is set to cloudVirBr* if > network.bridge.name.schema is set to 3.0 in > /etc/cloudstack/agent/agent.properties, but the actual bridge name is > breth*-* after running cloudstack-agent-upgrade. > > (2) all ports of vms (Basic zone, or Advanced zone with security groups) on > old hosts are open, because the iptables rules are binding to device (bridge) > name which is changed by cloudstack-agent-upgrade. > > > Diffs > - > > agent/bindir/cloudstack-agent-upgrade.in 4972d39 > debian/cloudstack-agent.postinst 499ae6a > debian/rules 5e3d58c > packaging/centos63/cloud.spec 2b814f8 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java > e3779a7 > scripts/vm/network/security_group.py 0ac8b74 > > Diff: https://reviews.apache.org/r/13992/diff/ > > > Testing > --- > > tested ok on my environment. > > After this, the KVM upgrade steps : > a. Install 4.2 cloudstack agent on each kvm host > b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing > bridge name to new bridge name, and update related firewall rules. >c. install a libvirt hook: > c1. mkdir /etc/libvirt/hooks > c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook > /etc/libvirt/hooks/qemu > c3. chmod +x /etc/libvirt/hooks/qemu > c4. service libvirtd restart > c5. service cloudstack-agent restart > > > Thanks, > > Wei Zhou > >
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name and firewall rules issues after KVM upgrade to 4.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13992/#review26347 --- Commit e325fb66ab1fa0796ade6b5d3d70c688b57e5409 in branch refs/heads/master from Edison Su [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e325fb6 ] CLOUDSTACK-4405: fix vm migration during the upgrade to 4.2 Signed-off-by: Wei Zhou - ASF Subversion and Git Services On Sept. 9, 2013, 8:09 a.m., Wei Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13992/ > --- > > (Updated Sept. 9, 2013, 8:09 a.m.) > > > Review request for cloudstack and edison su. > > > Bugs: CLOUDSTACK-4405 > > > Repository: cloudstack-git > > > Description > --- > > There still exist two issues after Edison's commits. > (1) Migration from new hosts to old hosts failed. > The bridge name on old host is set to cloudVirBr* if > network.bridge.name.schema is set to 3.0 in > /etc/cloudstack/agent/agent.properties, but the actual bridge name is > breth*-* after running cloudstack-agent-upgrade. > > (2) all ports of vms (Basic zone, or Advanced zone with security groups) on > old hosts are open, because the iptables rules are binding to device (bridge) > name which is changed by cloudstack-agent-upgrade. > > > Diffs > - > > agent/bindir/cloudstack-agent-upgrade.in 4972d39 > debian/cloudstack-agent.postinst 499ae6a > debian/rules 5e3d58c > packaging/centos63/cloud.spec 2b814f8 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java > e3779a7 > scripts/vm/network/security_group.py 0ac8b74 > > Diff: https://reviews.apache.org/r/13992/diff/ > > > Testing > --- > > tested ok on my environment. > > After this, the KVM upgrade steps : > a. Install 4.2 cloudstack agent on each kvm host > b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing > bridge name to new bridge name, and update related firewall rules. >c. install a libvirt hook: > c1. mkdir /etc/libvirt/hooks > c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook > /etc/libvirt/hooks/qemu > c3. chmod +x /etc/libvirt/hooks/qemu > c4. service libvirtd restart > c5. service cloudstack-agent restart > > > Thanks, > > Wei Zhou > >
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name and firewall rules issues after KVM upgrade to 4.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13992/#review26345 --- Commit 164e3e33b414861d4c49457df66dbd7a73830303 in branch refs/heads/master from Wei Zhou [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=164e3e3 ] CLOUDSTACK-4405: change rpm and debian packaging to support automatic update (KVM upgrade) Including following steps: b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules. c. install a libvirt hook: c1. mkdir /etc/libvirt/hooks c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu c3. chmod +x /etc/libvirt/hooks/qemu c4. service libvirtd restart (cherry picked from commit a0988780ad88bb56becb0a13efedcd79c1bee142) Signed-off-by: Wei Zhou - ASF Subversion and Git Services On Sept. 9, 2013, 8:09 a.m., Wei Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13992/ > --- > > (Updated Sept. 9, 2013, 8:09 a.m.) > > > Review request for cloudstack and edison su. > > > Bugs: CLOUDSTACK-4405 > > > Repository: cloudstack-git > > > Description > --- > > There still exist two issues after Edison's commits. > (1) Migration from new hosts to old hosts failed. > The bridge name on old host is set to cloudVirBr* if > network.bridge.name.schema is set to 3.0 in > /etc/cloudstack/agent/agent.properties, but the actual bridge name is > breth*-* after running cloudstack-agent-upgrade. > > (2) all ports of vms (Basic zone, or Advanced zone with security groups) on > old hosts are open, because the iptables rules are binding to device (bridge) > name which is changed by cloudstack-agent-upgrade. > > > Diffs > - > > agent/bindir/cloudstack-agent-upgrade.in 4972d39 > debian/cloudstack-agent.postinst 499ae6a > debian/rules 5e3d58c > packaging/centos63/cloud.spec 2b814f8 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java > e3779a7 > scripts/vm/network/security_group.py 0ac8b74 > > Diff: https://reviews.apache.org/r/13992/diff/ > > > Testing > --- > > tested ok on my environment. > > After this, the KVM upgrade steps : > a. Install 4.2 cloudstack agent on each kvm host > b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing > bridge name to new bridge name, and update related firewall rules. >c. install a libvirt hook: > c1. mkdir /etc/libvirt/hooks > c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook > /etc/libvirt/hooks/qemu > c3. chmod +x /etc/libvirt/hooks/qemu > c4. service libvirtd restart > c5. service cloudstack-agent restart > > > Thanks, > > Wei Zhou > >
Re: Review Request 13992: (CLOUDSTACK-4405) additional patch for bridge name and firewall rules issues after KVM upgrade to 4.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13992/#review26372 --- Commit 164e3e33b414861d4c49457df66dbd7a73830303 in branch refs/heads/disk-cache from Wei Zhou [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=164e3e3 ] CLOUDSTACK-4405: change rpm and debian packaging to support automatic update (KVM upgrade) Including following steps: b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing bridge name to new bridge name, and update related firewall rules. c. install a libvirt hook: c1. mkdir /etc/libvirt/hooks c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook /etc/libvirt/hooks/qemu c3. chmod +x /etc/libvirt/hooks/qemu c4. service libvirtd restart (cherry picked from commit a0988780ad88bb56becb0a13efedcd79c1bee142) Signed-off-by: Wei Zhou - ASF Subversion and Git Services On Sept. 9, 2013, 8:09 a.m., Wei Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13992/ > --- > > (Updated Sept. 9, 2013, 8:09 a.m.) > > > Review request for cloudstack and edison su. > > > Bugs: CLOUDSTACK-4405 > > > Repository: cloudstack-git > > > Description > --- > > There still exist two issues after Edison's commits. > (1) Migration from new hosts to old hosts failed. > The bridge name on old host is set to cloudVirBr* if > network.bridge.name.schema is set to 3.0 in > /etc/cloudstack/agent/agent.properties, but the actual bridge name is > breth*-* after running cloudstack-agent-upgrade. > > (2) all ports of vms (Basic zone, or Advanced zone with security groups) on > old hosts are open, because the iptables rules are binding to device (bridge) > name which is changed by cloudstack-agent-upgrade. > > > Diffs > - > > agent/bindir/cloudstack-agent-upgrade.in 4972d39 > debian/cloudstack-agent.postinst 499ae6a > debian/rules 5e3d58c > packaging/centos63/cloud.spec 2b814f8 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java > e3779a7 > scripts/vm/network/security_group.py 0ac8b74 > > Diff: https://reviews.apache.org/r/13992/diff/ > > > Testing > --- > > tested ok on my environment. > > After this, the KVM upgrade steps : > a. Install 4.2 cloudstack agent on each kvm host > b. Run "cloudstack-agent-upgrade". This script will upgrade all the existing > bridge name to new bridge name, and update related firewall rules. >c. install a libvirt hook: > c1. mkdir /etc/libvirt/hooks > c2. cp /usr/share/cloudstack-agent/lib/libvirtqemuhook > /etc/libvirt/hooks/qemu > c3. chmod +x /etc/libvirt/hooks/qemu > c4. service libvirtd restart > c5. service cloudstack-agent restart > > > Thanks, > > Wei Zhou > >
Re: Review Request 13770: CLOUDSTACK-3363 UI > fix list Events/Alerts screen is in processing state forever with Delete Events/Alerts request having no filter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13770/#review26442 --- Commit 38b94e934c38556ed3974ab16a35d5be33f4edc4 in branch refs/heads/master from brito wang [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=38b94e9 ] CLOUDSTACK-3363 UI > fix list Events/Alerts screen is in processing state forever with Delete Events/Alerts request having no filter - ASF Subversion and Git Services On Aug. 28, 2013, 7:46 a.m., bo wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13770/ > --- > > (Updated Aug. 28, 2013, 7:46 a.m.) > > > Review request for cloudstack, Brian Federle and bharat kumar. > > > Bugs: CLOUDSTACK-3363 > > > Repository: cloudstack-git > > > Description > --- > > 1.The loading screen won't disappear when delete the events or alerts with > incorrect parameters ,Because there is no handling for exception in the js > code. > 2.Error messages are not completely correct, it should be "Either type or > enddate must be specified". > > > Diffs > - > > ui/scripts/events.js 46d45c0 > > Diff: https://reviews.apache.org/r/13770/diff/ > > > Testing > --- > > 1.The loading screen will disappear when close the error message dialog. > 2.The error message will be "Either type or enddate must be specified". > > > Thanks, > > bo wang > >
Re: Review Request 14307: CLOUDSTACK-702: New test for deploying vm in new cidr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14307/#review26472 --- Commit ff2bd3d44325ef915cb3d7b11a966c9c7c387cb3 in branch refs/heads/master from sanjeevneelarapu [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ff2bd3d ] CLOUDSTACK-702: Adding test for deploying vm in new cidr 1. Add guest ip range in new cidr and deploy vm in that Signed-off-by: sanjeevneelarapu Signed-off-by: venkataswamybabu budumuru - ASF Subversion and Git Services On Sept. 24, 2013, 5:28 a.m., sanjeev n wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14307/ > --- > > (Updated Sept. 24, 2013, 5:28 a.m.) > > > Review request for cloudstack, venkata swamy babu budumuru, SrikanteswaraRao > Talluri, and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > --- > > This test will add new guest ip range in new cird in the basic zone. > Deploys vm and make sure that VM gets IP address from new CIDR added in the > test. > > > Diffs > - > > test/integration/component/maint/test_multiple_ip_ranges.py PRE-CREATION > > Diff: https://reviews.apache.org/r/14307/diff/ > > > Testing > --- > > Yes. > > > Thanks, > > sanjeev n > >
Re: Review Request 14307: CLOUDSTACK-702: New test for deploying vm in new cidr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14307/#review26473 --- Commit a34bf457dfb3726842c1fde002be61c53b0a60d7 in branch refs/heads/4.2-forward from sanjeevneelarapu [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a34bf45 ] CLOUDSTACK-702: Adding test for deploying vm in new cidr 1. Add guest ip range in new cidr and deploy vm in that Signed-off-by: sanjeevneelarapu Signed-off-by: venkataswamybabu budumuru (cherry picked from commit ff2bd3d44325ef915cb3d7b11a966c9c7c387cb3) - ASF Subversion and Git Services On Sept. 24, 2013, 5:28 a.m., sanjeev n wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14307/ > --- > > (Updated Sept. 24, 2013, 5:28 a.m.) > > > Review request for cloudstack, venkata swamy babu budumuru, SrikanteswaraRao > Talluri, and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > --- > > This test will add new guest ip range in new cird in the basic zone. > Deploys vm and make sure that VM gets IP address from new CIDR added in the > test. > > > Diffs > - > > test/integration/component/maint/test_multiple_ip_ranges.py PRE-CREATION > > Diff: https://reviews.apache.org/r/14307/diff/ > > > Testing > --- > > Yes. > > > Thanks, > > sanjeev n > >
Re: Review Request 14333: CLOUDSTACK-4691: move egress rules host maintenance tests to maint folder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14333/#review26476 --- Commit 65da24c35e58ac7dd796f48edaccc87400735f1c in branch refs/heads/master from SrikanteswaraRao Talluri [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=65da24c ] CLOUDSTACK-4691: move egress rules host maintenance tests to maint folder Signed-off-by: venkataswamybabu budumuru (cherry picked from commit 6b28e03d6d88e9b6bd9d0521a45c93d5b4af6501) - ASF Subversion and Git Services On Sept. 25, 2013, 9:50 a.m., SrikanteswaraRao Talluri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14333/ > --- > > (Updated Sept. 25, 2013, 9:50 a.m.) > > > Review request for cloudstack, venkata swamy babu budumuru and Prasanna > Santhanam. > > > Bugs: CLOUDSTACK-4691 > > > Repository: cloudstack-git > > > Description > --- > > move host maintenance tests to maint folder and correct few typos > > > Diffs > - > > test/integration/component/maint/test_egress_rules_host_maintenance.py > PRE-CREATION > test/integration/component/maint/test_host_high_availability.py 5fb047b > test/integration/component/test_egress_rules.py 10e0d03 > tools/marvin/marvin/integration/lib/base.py df81406 > tools/marvin/marvin/sandbox/demo/simulator/testcase/libs/base.py 0b5da5c > > Diff: https://reviews.apache.org/r/14333/diff/ > > > Testing > --- > > tested > > > Thanks, > > SrikanteswaraRao Talluri > >
Re: Review Request 14333: CLOUDSTACK-4691: move egress rules host maintenance tests to maint folder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14333/#review26475 --- Commit 6b28e03d6d88e9b6bd9d0521a45c93d5b4af6501 in branch refs/heads/4.2-forward from SrikanteswaraRao Talluri [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6b28e03 ] CLOUDSTACK-4691: move egress rules host maintenance tests to maint folder Signed-off-by: venkataswamybabu budumuru - ASF Subversion and Git Services On Sept. 25, 2013, 9:50 a.m., SrikanteswaraRao Talluri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14333/ > --- > > (Updated Sept. 25, 2013, 9:50 a.m.) > > > Review request for cloudstack, venkata swamy babu budumuru and Prasanna > Santhanam. > > > Bugs: CLOUDSTACK-4691 > > > Repository: cloudstack-git > > > Description > --- > > move host maintenance tests to maint folder and correct few typos > > > Diffs > - > > test/integration/component/maint/test_egress_rules_host_maintenance.py > PRE-CREATION > test/integration/component/maint/test_host_high_availability.py 5fb047b > test/integration/component/test_egress_rules.py 10e0d03 > tools/marvin/marvin/integration/lib/base.py df81406 > tools/marvin/marvin/sandbox/demo/simulator/testcase/libs/base.py 0b5da5c > > Diff: https://reviews.apache.org/r/14333/diff/ > > > Testing > --- > > tested > > > Thanks, > > SrikanteswaraRao Talluri > >
Re: Review Request 14332: CLOUDSTACK-4646: increase the delay for the routers to go into stopped state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14332/#review26477 --- Commit 55ef4b8c3c6d583c7e4de4b11613db718c590b82 in branch refs/heads/master from SrikanteswaraRao Talluri [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=55ef4b8 ] CLOUDSTACK-4646: Increase the wait time for the routers to go into stopped state Signed-off-by: venkataswamybabu budumuru - ASF Subversion and Git Services On Sept. 25, 2013, 6:38 a.m., SrikanteswaraRao Talluri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14332/ > --- > > (Updated Sept. 25, 2013, 6:38 a.m.) > > > Review request for cloudstack, venkata swamy babu budumuru and Prasanna > Santhanam. > > > Bugs: CLOUDSTACK-4646 > > > Repository: cloudstack-git > > > Description > --- > > I don't see any failure while running this script. I am increasing delay to > see why is it failing when run as part of the regression suite > > > Diffs > - > > test/integration/component/test_redundant_router_cleanups.py 303ca8b > > Diff: https://reviews.apache.org/r/14332/diff/ > > > Testing > --- > > done > > > Thanks, > > SrikanteswaraRao Talluri > >
Re: Review Request 14332: CLOUDSTACK-4646: increase the delay for the routers to go into stopped state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14332/#review26479 --- Commit 07a6daf6cb8d096ee661362d57632302cbf12422 in branch refs/heads/4.2-forward from SrikanteswaraRao Talluri [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=07a6daf ] CLOUDSTACK-4646: Increase the wait time for the routers to go into stopped state Signed-off-by: venkataswamybabu budumuru (cherry picked from commit 55ef4b8c3c6d583c7e4de4b11613db718c590b82) - ASF Subversion and Git Services On Sept. 25, 2013, 6:38 a.m., SrikanteswaraRao Talluri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14332/ > --- > > (Updated Sept. 25, 2013, 6:38 a.m.) > > > Review request for cloudstack, venkata swamy babu budumuru and Prasanna > Santhanam. > > > Bugs: CLOUDSTACK-4646 > > > Repository: cloudstack-git > > > Description > --- > > I don't see any failure while running this script. I am increasing delay to > see why is it failing when run as part of the regression suite > > > Diffs > - > > test/integration/component/test_redundant_router_cleanups.py 303ca8b > > Diff: https://reviews.apache.org/r/14332/diff/ > > > Testing > --- > > done > > > Thanks, > > SrikanteswaraRao Talluri > >
Re: Review Request 14197: CLOUDSTACK-4696 Handle Netscaler provider enable for multiple zones
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14197/#review26543 --- Commit a5ede3af7f5837f9e8a1fb80e2a1f20f24ecb870 in branch refs/heads/master from Sowmya Krishnan [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a5ede3a ] CLOUDSTACK-4696 Handle Netscaler Provider enable for both zones Signed-off-by: venkataswamybabu budumuru - ASF Subversion and Git Services On Sept. 18, 2013, 6:59 a.m., Sowmya Krishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14197/ > --- > > (Updated Sept. 18, 2013, 6:59 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Bugs: CLOUDSTACK-4696 > > > Repository: cloudstack-git > > > Description > --- > > Handle Netscaler service provider enable for multiple zones > > > Diffs > - > > test/integration/component/test_netscaler_nw_off.py cb49dbe > > Diff: https://reviews.apache.org/r/14197/diff/ > > > Testing > --- > > Tested locally. > nosetests -v --with-marvin --marvin-config=datacenter.cfg --load > test/integration/component/test_netscaler_nw_off.py:TestAddMultipleNSDiffZone > > Test add netscaler devices in different zones ... ok > > -- > Ran 1 test in 20.605s > > OK > > > Thanks, > > Sowmya Krishnan > >
Re: Review Request 14197: CLOUDSTACK-4696 Handle Netscaler provider enable for multiple zones
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14197/#review26544 --- Commit f0b4f894695939270a4415352070e33aff02763b in branch refs/heads/4.2-forward from Sowmya Krishnan [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f0b4f89 ] CLOUDSTACK-4696 Handle Netscaler Provider enable for both zones Signed-off-by: venkataswamybabu budumuru (cherry picked from commit a5ede3af7f5837f9e8a1fb80e2a1f20f24ecb870) - ASF Subversion and Git Services On Sept. 18, 2013, 6:59 a.m., Sowmya Krishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14197/ > --- > > (Updated Sept. 18, 2013, 6:59 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Bugs: CLOUDSTACK-4696 > > > Repository: cloudstack-git > > > Description > --- > > Handle Netscaler service provider enable for multiple zones > > > Diffs > - > > test/integration/component/test_netscaler_nw_off.py cb49dbe > > Diff: https://reviews.apache.org/r/14197/diff/ > > > Testing > --- > > Tested locally. > nosetests -v --with-marvin --marvin-config=datacenter.cfg --load > test/integration/component/test_netscaler_nw_off.py:TestAddMultipleNSDiffZone > > Test add netscaler devices in different zones ... ok > > -- > Ran 1 test in 20.605s > > OK > > > Thanks, > > Sowmya Krishnan > >
Re: Review Request 14060: CLOUDSTACK-4634 - CPU Limits/ test_maximum_limits.py - -Fixed issues arising due to wrong indentation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14060/#review26546 --- Commit 7d15b50704b3b177d2b39fe55e30a9bba0f7b40a in branch refs/heads/4.2-forward from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7d15b50 ] CLOUDSTACK-4634: Fixed issue arising due to wrong indentation - ASF Subversion and Git Services On Sept. 10, 2013, 11:22 a.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14060/ > --- > > (Updated Sept. 10, 2013, 11:22 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > --- > > The indentation in createInstance function was wrong. Whenever we would pass > value to api_client parameter, the instance would not get created. Fixed the > indentation. > > > Diffs > - > > test/integration/component/cpu_limits/test_maximum_limits.py 2302504 > > Diff: https://reviews.apache.org/r/14060/diff/ > > > Testing > --- > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 14197: CLOUDSTACK-4696 Handle Netscaler provider enable for multiple zones
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14197/#review26611 --- Commit a5ede3af7f5837f9e8a1fb80e2a1f20f24ecb870 in branch refs/heads/ui-restyle from Sowmya Krishnan [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a5ede3a ] CLOUDSTACK-4696 Handle Netscaler Provider enable for both zones Signed-off-by: venkataswamybabu budumuru - ASF Subversion and Git Services On Sept. 18, 2013, 6:59 a.m., Sowmya Krishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14197/ > --- > > (Updated Sept. 18, 2013, 6:59 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Bugs: CLOUDSTACK-4696 > > > Repository: cloudstack-git > > > Description > --- > > Handle Netscaler service provider enable for multiple zones > > > Diffs > - > > test/integration/component/test_netscaler_nw_off.py cb49dbe > > Diff: https://reviews.apache.org/r/14197/diff/ > > > Testing > --- > > Tested locally. > nosetests -v --with-marvin --marvin-config=datacenter.cfg --load > test/integration/component/test_netscaler_nw_off.py:TestAddMultipleNSDiffZone > > Test add netscaler devices in different zones ... ok > > -- > Ran 1 test in 20.605s > > OK > > > Thanks, > > Sowmya Krishnan > >
Re: Review Request 14060: CLOUDSTACK-4634 - CPU Limits/ test_maximum_limits.py - -Fixed issues arising due to wrong indentation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14060/#review26644 --- Commit 7d15b50704b3b177d2b39fe55e30a9bba0f7b40a in branch refs/heads/4.2 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7d15b50 ] CLOUDSTACK-4634: Fixed issue arising due to wrong indentation - ASF Subversion and Git Services On Sept. 10, 2013, 11:22 a.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14060/ > --- > > (Updated Sept. 10, 2013, 11:22 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > --- > > The indentation in createInstance function was wrong. Whenever we would pass > value to api_client parameter, the instance would not get created. Fixed the > indentation. > > > Diffs > - > > test/integration/component/cpu_limits/test_maximum_limits.py 2302504 > > Diff: https://reviews.apache.org/r/14060/diff/ > > > Testing > --- > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 14335: CLOUDSTACK-4262: Fix TestVPCNetworkGc.test_01_wait_network_gc
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14335/#review26732 --- Commit abdb84bb05abc9f2bd102bca1c1b34865f34d771 in branch refs/heads/4.2-forward from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=abdb84b ] CLOUDSTACK-4262: Fix TestVPCNetworkGc.test_01_wait_network_gc As per the test plan, after waiting for network gc LB rules should be cleared. Added that check instead of router being in stopped state. Signed-off-by: venkataswamybabu budumuru - ASF Subversion and Git Services On Oct. 7, 2013, 4:54 a.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14335/ > --- > > (Updated Oct. 7, 2013, 4:54 a.m.) > > > Review request for cloudstack, Harikrishna Patnala and venkata swamy babu > budumuru. > > > Bugs: CLOUDSTACK-4262 > > > Repository: cloudstack-git > > > Description > --- > > As per the test plan, after waiting for network gc > LB rules should be cleared. Added that check instead of router > being in stopped state. > > > Diffs > - > > test/integration/component/test_vpc_network.py 970a625 > > Diff: https://reviews.apache.org/r/14335/diff/ > > > Testing > --- > > > Thanks, > > Girish Shilamkar > >
Re: Review Request 14335: CLOUDSTACK-4262: Fix TestVPCNetworkGc.test_01_wait_network_gc
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14335/#review26733 --- Commit fbf057a3236dcce96c0f08b419963831e411c243 in branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=fbf057a ] CLOUDSTACK-4262: Fix TestVPCNetworkGc.test_01_wait_network_gc As per the test plan, after waiting for network gc LB rules should be cleared. Added that check instead of router being in stopped state. Signed-off-by: venkataswamybabu budumuru (cherry picked from commit abdb84bb05abc9f2bd102bca1c1b34865f34d771) - ASF Subversion and Git Services On Oct. 7, 2013, 4:54 a.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14335/ > --- > > (Updated Oct. 7, 2013, 4:54 a.m.) > > > Review request for cloudstack, Harikrishna Patnala and venkata swamy babu > budumuru. > > > Bugs: CLOUDSTACK-4262 > > > Repository: cloudstack-git > > > Description > --- > > As per the test plan, after waiting for network gc > LB rules should be cleared. Added that check instead of router > being in stopped state. > > > Diffs > - > > test/integration/component/test_vpc_network.py 970a625 > > Diff: https://reviews.apache.org/r/14335/diff/ > > > Testing > --- > > > Thanks, > > Girish Shilamkar > >
Re: Review Request 14468: CLOUDSTACK-702: Added test for verifying dns service on alias IP
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14468/#review26768 --- Commit 1efd544ee27fd0c7c9eac4649568647c0dcbc85b in branch refs/heads/4.2-forward from sanjeevneelarapu [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1efd544 ] CLOUDSTACK-702: 1. Moved common code to setupClass method 2. Added a test to deply vm in new CIDR and verify dns service on alias IP Conflicts: test/integration/component/maint/test_multiple_ip_ranges.py Signed-off-by: sanjeevneelarapu Signed-off-by: venkataswamybabu budumuru - ASF Subversion and Git Services On Oct. 3, 2013, 11:49 a.m., sanjeev n wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14468/ > --- > > (Updated Oct. 3, 2013, 11:49 a.m.) > > > Review request for cloudstack, venkata swamy babu budumuru, SrikanteswaraRao > Talluri, and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > --- > > 1. Moved some code from test to setupClass method since it is required for > all the tests > 2. Added new test which will deploy vm in new cidr and verifies dns service > on alias ip on VR. > > > Diffs > - > > test/integration/component/maint/test_multiple_ip_ranges.py 782957c > > Diff: https://reviews.apache.org/r/14468/diff/ > > > Testing > --- > > Yes > > > Thanks, > > sanjeev n > >
Re: Review Request 14468: CLOUDSTACK-702: Added test for verifying dns service on alias IP
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14468/#review26769 --- Commit f6c6f03fad5dafa2f28a7a8e8b9d8ab89bf22bf8 in branch refs/heads/master from sanjeevneelarapu [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f6c6f03 ] CLOUDSTACK-702: 1. Moved common code to setupClass method 2. Added a test to deply vm in new CIDR and verify dns service on alias IP Conflicts: test/integration/component/maint/test_multiple_ip_ranges.py Signed-off-by: sanjeevneelarapu Signed-off-by: venkataswamybabu budumuru (cherry picked from commit 1efd544ee27fd0c7c9eac4649568647c0dcbc85b) - ASF Subversion and Git Services On Oct. 3, 2013, 11:49 a.m., sanjeev n wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14468/ > --- > > (Updated Oct. 3, 2013, 11:49 a.m.) > > > Review request for cloudstack, venkata swamy babu budumuru, SrikanteswaraRao > Talluri, and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > --- > > 1. Moved some code from test to setupClass method since it is required for > all the tests > 2. Added new test which will deploy vm in new cidr and verifies dns service > on alias ip on VR. > > > Diffs > - > > test/integration/component/maint/test_multiple_ip_ranges.py 782957c > > Diff: https://reviews.apache.org/r/14468/diff/ > > > Testing > --- > > Yes > > > Thanks, > > sanjeev n > >
Re: Review Request 14227: CLOUDSTACK-4707: "sourcetemplateid" field is not getting set for derived templates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14227/#review26862 --- Commit bb7493775c202f9a0345482b7a9cb478ed48ba11 in branch refs/heads/master from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=bb74937 ] CLOUDSTACK-4707: "sourcetemplateid" field is not getting set for derived templates Template created from a volume or snapshot did not have the sourcetemplateid field set in vm_template table. - ASF Subversion and Git Services On Oct. 9, 2013, 11:03 a.m., Harikrishna Patnala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14227/ > --- > > (Updated Oct. 9, 2013, 11:03 a.m.) > > > Review request for cloudstack and Kishan Kavala. > > > Bugs: CLOUDSTACK-4707 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-4707: "sourcetemplateid" field is not getting set for derived > templates > Template created from a volume or snapshot did not have the sourcetemplateid > field set in vm_template table. > > > Diffs > - > > engine/schema/src/com/cloud/storage/VolumeVO.java ea3d6bf > > Diff: https://reviews.apache.org/r/14227/diff/ > > > Testing > --- > > Tested by > 1) creating template from root volume of VM > 2) created snapshot of root volume and create template from that snapshot > In both the cases sourcetemplateId is set in vm_template table > > > Thanks, > > Harikrishna Patnala > >
Re: Review Request 14227: CLOUDSTACK-4707: "sourcetemplateid" field is not getting set for derived templates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14227/#review26861 --- Commit 4392a47d1dfac656e645ac7620ac95a839745a29 in branch refs/heads/4.2 from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4392a47 ] CLOUDSTACK-4707: "sourcetemplateid" field is not getting set for derived templates Template created from a volume or snapshot did not have the sourcetemplateid field set in vm_template table. - ASF Subversion and Git Services On Oct. 9, 2013, 11:03 a.m., Harikrishna Patnala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14227/ > --- > > (Updated Oct. 9, 2013, 11:03 a.m.) > > > Review request for cloudstack and Kishan Kavala. > > > Bugs: CLOUDSTACK-4707 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-4707: "sourcetemplateid" field is not getting set for derived > templates > Template created from a volume or snapshot did not have the sourcetemplateid > field set in vm_template table. > > > Diffs > - > > engine/schema/src/com/cloud/storage/VolumeVO.java ea3d6bf > > Diff: https://reviews.apache.org/r/14227/diff/ > > > Testing > --- > > Tested by > 1) creating template from root volume of VM > 2) created snapshot of root volume and create template from that snapshot > In both the cases sourcetemplateId is set in vm_template table > > > Thanks, > > Harikrishna Patnala > >
Re: Review Request 14531: CLOUDSTACK-702: Verify Userdata and Password service on alias ip on VR
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14531/#review26864 --- Commit d5eda578cd1dafe24d6ab3b633113468acbecd4f in branch refs/heads/4.2 from sanjeevneelarapu [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d5eda57 ] CLOUDSTACK-702: 1. Moved common code to setupClass method 2. Added a test to deply vm in new CIDR and verify dns service on alias IP Conflicts: test/integration/component/maint/test_multiple_ip_ranges.py Signed-off-by: sanjeevneelarapu Signed-off-by: venkataswamybabu budumuru (cherry picked from commit 1efd544ee27fd0c7c9eac4649568647c0dcbc85b) - ASF Subversion and Git Services On Oct. 8, 2013, 11:17 a.m., sanjeev n wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14531/ > --- > > (Updated Oct. 8, 2013, 11:17 a.m.) > > > Review request for cloudstack, venkata swamy babu budumuru, SrikanteswaraRao > Talluri, and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > --- > > Verify Userdata and Password service on alias ip on VR > 1.Added two tests to verify userdata and password service after ip alias > creation on VR. > 2.Tests will deploy vm in new CIDR,checks alias creation and verify services > on alias ip addresses on VR. > > > Diffs > - > > test/integration/component/maint/test_multiple_ip_ranges.py 68b5979 > > Diff: https://reviews.apache.org/r/14531/diff/ > > > Testing > --- > > yes > > > Thanks, > > sanjeev n > >
Re: Review Request 14335: CLOUDSTACK-4262: Fix TestVPCNetworkGc.test_01_wait_network_gc
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14335/#review26924 --- Commit 808b96070e17976f8ae7424b437713f329be7ac4 in branch refs/heads/4.2 from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=808b960 ] CLOUDSTACK-4262: Fix TestVPCNetworkGc.test_01_wait_network_gc As per the test plan, after waiting for network gc LB rules should be cleared. Added that check instead of router being in stopped state. Signed-off-by: venkataswamybabu budumuru (cherry picked from commit abdb84bb05abc9f2bd102bca1c1b34865f34d771) - ASF Subversion and Git Services On Oct. 7, 2013, 4:54 a.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14335/ > --- > > (Updated Oct. 7, 2013, 4:54 a.m.) > > > Review request for cloudstack, Harikrishna Patnala and venkata swamy babu > budumuru. > > > Bugs: CLOUDSTACK-4262 > > > Repository: cloudstack-git > > > Description > --- > > As per the test plan, after waiting for network gc > LB rules should be cleared. Added that check instead of router > being in stopped state. > > > Diffs > - > > test/integration/component/test_vpc_network.py 970a625 > > Diff: https://reviews.apache.org/r/14335/diff/ > > > Testing > --- > > > Thanks, > > Girish Shilamkar > >
Re: Review Request 14646: CLOUDSTACK-4780: Fixed-BVT-test-case-TestSnapshotRootDisk.test_01_snapshot_root_disk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14646/#review27010 --- Commit 986ac0f124ab2960e13455736dfd467350e7f9e1 in branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=986ac0f ] CLOUDSTACK-4780: Fixed BVT test case TestSnapshotRootDisk.test_01_snapshot_root_disk Signed-off-by: Prasanna Santhanam - ASF Subversion and Git Services On Oct. 15, 2013, 7:51 a.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14646/ > --- > > (Updated Oct. 15, 2013, 7:51 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Repository: cloudstack-git > > > Description > --- > > Fixed-BVT-test-case-TestSnapshotRootDisk.test_01_snapshot_root_disk > Used a utility function to check whether the snapshot exists in the secondary > storage. > > This patch should be applied on top of https://reviews.apache.org/r/14346/ > which contains the fix for the utility function used here. > > > Diffs > - > > test/integration/smoke/test_snapshots.py 06777e4 > > Diff: https://reviews.apache.org/r/14646/diff/ > > > Testing > --- > > Tested locally on KVM Advanced setup: > > ==> client.log <== > 2013-10-14 20:50:32,626 - DEBUG - test_01_snapshot_root_disk > (test_snapshots_fixed.TestSnapshotRootDisk) - Snapshot created: ID - > b3161412-1cd3-4387-8bfb-aaa2ca > 545eeb > 2013-10-14 20:50:32,641 - DEBUG - test_01_snapshot_root_disk > (test_snapshots_fixed.TestSnapshotRootDisk) - select backup_snap_id, > account_id, volume_id from sna > pshots where uuid = 'b3161412-1cd3-4387-8bfb-aaa2ca545eeb'; > > ==> result.log <== > test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk) > Test Snapshot Root Disk ... ok > > -- > Ran 1 test in 259.875s > > OK > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 14646: CLOUDSTACK-4780: Fixed-BVT-test-case-TestSnapshotRootDisk.test_01_snapshot_root_disk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14646/#review27011 --- Commit 79d702cf975a482de2235741076348386ca072dd in branch refs/heads/4.2 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=79d702c ] CLOUDSTACK-4780: Fixed BVT test case TestSnapshotRootDisk.test_01_snapshot_root_disk Signed-off-by: Prasanna Santhanam (cherry picked from commit b12ff1d6ce964e30d0b919c29ab92af450e4dcf9) - ASF Subversion and Git Services On Oct. 15, 2013, 7:51 a.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14646/ > --- > > (Updated Oct. 15, 2013, 7:51 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Repository: cloudstack-git > > > Description > --- > > Fixed-BVT-test-case-TestSnapshotRootDisk.test_01_snapshot_root_disk > Used a utility function to check whether the snapshot exists in the secondary > storage. > > This patch should be applied on top of https://reviews.apache.org/r/14346/ > which contains the fix for the utility function used here. > > > Diffs > - > > test/integration/smoke/test_snapshots.py 06777e4 > > Diff: https://reviews.apache.org/r/14646/diff/ > > > Testing > --- > > Tested locally on KVM Advanced setup: > > ==> client.log <== > 2013-10-14 20:50:32,626 - DEBUG - test_01_snapshot_root_disk > (test_snapshots_fixed.TestSnapshotRootDisk) - Snapshot created: ID - > b3161412-1cd3-4387-8bfb-aaa2ca > 545eeb > 2013-10-14 20:50:32,641 - DEBUG - test_01_snapshot_root_disk > (test_snapshots_fixed.TestSnapshotRootDisk) - select backup_snap_id, > account_id, volume_id from sna > pshots where uuid = 'b3161412-1cd3-4387-8bfb-aaa2ca545eeb'; > > ==> result.log <== > test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk) > Test Snapshot Root Disk ... ok > > -- > Ran 1 test in 259.875s > > OK > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 14646: CLOUDSTACK-4780: Fixed-BVT-test-case-TestSnapshotRootDisk.test_01_snapshot_root_disk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14646/#review27041 --- Commit 986ac0f124ab2960e13455736dfd467350e7f9e1 in branch refs/heads/ui-restyle from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=986ac0f ] CLOUDSTACK-4780: Fixed BVT test case TestSnapshotRootDisk.test_01_snapshot_root_disk Signed-off-by: Prasanna Santhanam - ASF Subversion and Git Services On Oct. 15, 2013, 7:51 a.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14646/ > --- > > (Updated Oct. 15, 2013, 7:51 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Repository: cloudstack-git > > > Description > --- > > Fixed-BVT-test-case-TestSnapshotRootDisk.test_01_snapshot_root_disk > Used a utility function to check whether the snapshot exists in the secondary > storage. > > This patch should be applied on top of https://reviews.apache.org/r/14346/ > which contains the fix for the utility function used here. > > > Diffs > - > > test/integration/smoke/test_snapshots.py 06777e4 > > Diff: https://reviews.apache.org/r/14646/diff/ > > > Testing > --- > > Tested locally on KVM Advanced setup: > > ==> client.log <== > 2013-10-14 20:50:32,626 - DEBUG - test_01_snapshot_root_disk > (test_snapshots_fixed.TestSnapshotRootDisk) - Snapshot created: ID - > b3161412-1cd3-4387-8bfb-aaa2ca > 545eeb > 2013-10-14 20:50:32,641 - DEBUG - test_01_snapshot_root_disk > (test_snapshots_fixed.TestSnapshotRootDisk) - select backup_snap_id, > account_id, volume_id from sna > pshots where uuid = 'b3161412-1cd3-4387-8bfb-aaa2ca545eeb'; > > ==> result.log <== > test_01_snapshot_root_disk (test_snapshots_fixed.TestSnapshotRootDisk) > Test Snapshot Root Disk ... ok > > -- > Ran 1 test in 259.875s > > OK > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 14557: CLOUDSTACK-4747: Rename testcase name to use lesser characters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14557/#review27114 --- Commit c5e1c4725c3658cae967c63cbae0ffe598f227ef in branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c5e1c47 ] CLOUDSTACK-4747: Rename testcase name to use lesser characters Renamed testcase name and also initialised _cleanup so that it does not break on non-NS Cloudstack setup. Signed-off-by: venkataswamybabu budumuru - ASF Subversion and Git Services On Oct. 11, 2013, 8:31 a.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14557/ > --- > > (Updated Oct. 11, 2013, 8:31 a.m.) > > > Review request for cloudstack, Sowmya Krishnan and SrikanteswaraRao Talluri. > > > Repository: cloudstack-git > > > Description > --- > > Renamed testcase name and also initialised _cleanup so that > it does not break on non-NS Cloudstack setup. > > > Diffs > - > > test/integration/component/test_netscaler_nw_off.py 3139257 > > Diff: https://reviews.apache.org/r/14557/diff/ > > > Testing > --- > > > Thanks, > > Girish Shilamkar > >
Re: Review Request 14557: CLOUDSTACK-4747: Rename testcase name to use lesser characters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14557/#review27115 --- Commit 08e69f130f142b0b034b6f42715ae0d1ca390c12 in branch refs/heads/4.2 from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=08e69f1 ] CLOUDSTACK-4747: Rename testcase name to use lesser characters Renamed testcase name and also initialised _cleanup so that it does not break on non-NS Cloudstack setup. Signed-off-by: venkataswamybabu budumuru (cherry picked from commit c5e1c4725c3658cae967c63cbae0ffe598f227ef) - ASF Subversion and Git Services On Oct. 11, 2013, 8:31 a.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14557/ > --- > > (Updated Oct. 11, 2013, 8:31 a.m.) > > > Review request for cloudstack, Sowmya Krishnan and SrikanteswaraRao Talluri. > > > Repository: cloudstack-git > > > Description > --- > > Renamed testcase name and also initialised _cleanup so that > it does not break on non-NS Cloudstack setup. > > > Diffs > - > > test/integration/component/test_netscaler_nw_off.py 3139257 > > Diff: https://reviews.apache.org/r/14557/diff/ > > > Testing > --- > > > Thanks, > > Girish Shilamkar > >
Re: Review Request 14556: CLOUDSTACK-4766: Add timeout if vm does not reach running state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14556/#review27116 --- Commit e3bcdc16a11d7452b5bf6ce5e5993dcd008526a6 in branch refs/heads/4.2 from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e3bcdc1 ] CLOUDSTACK-4766: Add timeout if vm does not reach running state The tests use to wait for ever for the vm to attain Running state. Added a timeout so it does not get into infinite loop. Signed-off-by: venkataswamybabu budumuru - ASF Subversion and Git Services On Oct. 9, 2013, 9:50 a.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14556/ > --- > > (Updated Oct. 9, 2013, 9:50 a.m.) > > > Review request for cloudstack, sanjeev n and venkata swamy babu budumuru. > > > Bugs: CLOUDSTACK-4766 > https://issues.apache.org/jira/browse/CLOUDSTACK-4766 > > > Repository: cloudstack-git > > > Description > --- > > The test use to wait for ever for the vm to attain Running state. > Added a timeout so it does not get into infinite loop. > > > Diffs > - > > test/integration/component/test_reset_ssh_keypair.py ace4499 > > Diff: https://reviews.apache.org/r/14556/diff/ > > > Testing > --- > > Verified that the timeout works. > > test_01_reset_keypair_normal_user > (test_reset_ssh_keypair.TestResetSSHKeyUserRights)Verify API > resetSSHKeyForVirtualMachine for non admin non root ... FAIL > test_02_reset_keypair_domain_admin > (test_reset_ssh_keypair.TestResetSSHKeyUserRights) > Verify API resetSSHKeyForVirtualMachine for domain admin non root ... ok > test_03_reset_keypair_root_admin > (test_reset_ssh_keypair.TestResetSSHKeyUserRights) > Verify API resetSSHKeyForVirtualMachine for domain admin root ... ok > test_01_reset_ssh_keys (test_reset_ssh_keypair.TestResetSSHKeypair) > Test Reset SSH keys for VM already having SSH key ... ok > test_02_reset_ssh_key_password_enabled_template > (test_reset_ssh_keypair.TestResetSSHKeypair) > Reset SSH keys for VM created from password enabled template and ... ok > test_03_reset_ssh_with_no_key (test_reset_ssh_keypair.TestResetSSHKeypair) > Reset SSH key for VM having no SSH key ... ok > test_04_reset_key_passwd_enabled_no_key > (test_reset_ssh_keypair.TestResetSSHKeypair) > Reset SSH keys for VM created from password enabled template and ... ok > test_05_reset_key_in_running_state > (test_reset_ssh_keypair.TestResetSSHKeypair) > Reset SSH keys for VM already having SSH key when VM is in running ... ok > test_06_reset_key_passwd_enabled_vm_running > (test_reset_ssh_keypair.TestResetSSHKeypair) > Reset SSH keys for VM created from password enabled template and ... ok > test_07_reset_keypair_invalid_params > (test_reset_ssh_keypair.TestResetSSHKeypair) > Verify API resetSSHKeyForVirtualMachine with incorrect parameters … ok > > == > FAIL: test_01_reset_keypair_normal_user > (test_reset_ssh_keypair.TestResetSSHKeyUserRights) > Verify API resetSSHKeyForVirtualMachine for non admin non root > -- > Traceback (most recent call last): > File "/root/girish/test_reset_ssh_keypair.py", line 1218, in > test_01_reset_keypair_normal_user > % (vms[0].name, self.services["timeout"])) > AssertionError: The virtual machine 974d1275-b747-441c-83b2-1795de4d87df > failed to start even after 10 minutes > > -- > > > Thanks, > > Girish Shilamkar > >
Re: Review Request 14556: CLOUDSTACK-4766: Add timeout if vm does not reach running state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14556/#review27117 --- Commit 9cc557509265d8faacca134e8bfeb3a31ddbeb31 in branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9cc5575 ] CLOUDSTACK-4766: Add timeout if vm does not reach running state The tests use to wait for ever for the vm to attain Running state. Added a timeout so it does not get into infinite loop. Signed-off-by: venkataswamybabu budumuru (cherry picked from commit e3bcdc16a11d7452b5bf6ce5e5993dcd008526a6) - ASF Subversion and Git Services On Oct. 9, 2013, 9:50 a.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14556/ > --- > > (Updated Oct. 9, 2013, 9:50 a.m.) > > > Review request for cloudstack, sanjeev n and venkata swamy babu budumuru. > > > Bugs: CLOUDSTACK-4766 > https://issues.apache.org/jira/browse/CLOUDSTACK-4766 > > > Repository: cloudstack-git > > > Description > --- > > The test use to wait for ever for the vm to attain Running state. > Added a timeout so it does not get into infinite loop. > > > Diffs > - > > test/integration/component/test_reset_ssh_keypair.py ace4499 > > Diff: https://reviews.apache.org/r/14556/diff/ > > > Testing > --- > > Verified that the timeout works. > > test_01_reset_keypair_normal_user > (test_reset_ssh_keypair.TestResetSSHKeyUserRights)Verify API > resetSSHKeyForVirtualMachine for non admin non root ... FAIL > test_02_reset_keypair_domain_admin > (test_reset_ssh_keypair.TestResetSSHKeyUserRights) > Verify API resetSSHKeyForVirtualMachine for domain admin non root ... ok > test_03_reset_keypair_root_admin > (test_reset_ssh_keypair.TestResetSSHKeyUserRights) > Verify API resetSSHKeyForVirtualMachine for domain admin root ... ok > test_01_reset_ssh_keys (test_reset_ssh_keypair.TestResetSSHKeypair) > Test Reset SSH keys for VM already having SSH key ... ok > test_02_reset_ssh_key_password_enabled_template > (test_reset_ssh_keypair.TestResetSSHKeypair) > Reset SSH keys for VM created from password enabled template and ... ok > test_03_reset_ssh_with_no_key (test_reset_ssh_keypair.TestResetSSHKeypair) > Reset SSH key for VM having no SSH key ... ok > test_04_reset_key_passwd_enabled_no_key > (test_reset_ssh_keypair.TestResetSSHKeypair) > Reset SSH keys for VM created from password enabled template and ... ok > test_05_reset_key_in_running_state > (test_reset_ssh_keypair.TestResetSSHKeypair) > Reset SSH keys for VM already having SSH key when VM is in running ... ok > test_06_reset_key_passwd_enabled_vm_running > (test_reset_ssh_keypair.TestResetSSHKeypair) > Reset SSH keys for VM created from password enabled template and ... ok > test_07_reset_keypair_invalid_params > (test_reset_ssh_keypair.TestResetSSHKeypair) > Verify API resetSSHKeyForVirtualMachine with incorrect parameters … ok > > == > FAIL: test_01_reset_keypair_normal_user > (test_reset_ssh_keypair.TestResetSSHKeyUserRights) > Verify API resetSSHKeyForVirtualMachine for non admin non root > -- > Traceback (most recent call last): > File "/root/girish/test_reset_ssh_keypair.py", line 1218, in > test_01_reset_keypair_normal_user > % (vms[0].name, self.services["timeout"])) > AssertionError: The virtual machine 974d1275-b747-441c-83b2-1795de4d87df > failed to start even after 10 minutes > > -- > > > Thanks, > > Girish Shilamkar > >
Re: Review Request 14531: CLOUDSTACK-702: Verify Userdata and Password service on alias ip on VR
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14531/#review27118 --- Commit 7a7fb61a17911987838a2b6744d594c840df7c2e in branch refs/heads/master from sanjeevneelarapu [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7a7fb61 ] CLOUDSTACK-702: Verify Userdata,password services 1.Added two tests to vefiy userdata and password services on alias ip on VR Conflicts: test/integration/component/maint/test_multiple_ip_ranges.py Signed-off-by: sanjeevneelarapu Signed-off-by: venkataswamybabu budumuru - ASF Subversion and Git Services On Oct. 8, 2013, 11:17 a.m., sanjeev n wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14531/ > --- > > (Updated Oct. 8, 2013, 11:17 a.m.) > > > Review request for cloudstack, venkata swamy babu budumuru, SrikanteswaraRao > Talluri, and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > --- > > Verify Userdata and Password service on alias ip on VR > 1.Added two tests to verify userdata and password service after ip alias > creation on VR. > 2.Tests will deploy vm in new CIDR,checks alias creation and verify services > on alias ip addresses on VR. > > > Diffs > - > > test/integration/component/maint/test_multiple_ip_ranges.py 68b5979 > > Diff: https://reviews.apache.org/r/14531/diff/ > > > Testing > --- > > yes > > > Thanks, > > sanjeev n > >
Re: Review Request 14531: CLOUDSTACK-702: Verify Userdata and Password service on alias ip on VR
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14531/#review27119 --- Commit 8b0894b27c45c3e89824ece3a6c47c8143d3ae76 in branch refs/heads/4.2 from sanjeevneelarapu [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8b0894b ] CLOUDSTACK-702: Verify Userdata,password services 1.Added two tests to vefiy userdata and password services on alias ip on VR Conflicts: test/integration/component/maint/test_multiple_ip_ranges.py Signed-off-by: sanjeevneelarapu Signed-off-by: venkataswamybabu budumuru (cherry picked from commit 7a7fb61a17911987838a2b6744d594c840df7c2e) - ASF Subversion and Git Services On Oct. 8, 2013, 11:17 a.m., sanjeev n wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14531/ > --- > > (Updated Oct. 8, 2013, 11:17 a.m.) > > > Review request for cloudstack, venkata swamy babu budumuru, SrikanteswaraRao > Talluri, and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > --- > > Verify Userdata and Password service on alias ip on VR > 1.Added two tests to verify userdata and password service after ip alias > creation on VR. > 2.Tests will deploy vm in new CIDR,checks alias creation and verify services > on alias ip addresses on VR. > > > Diffs > - > > test/integration/component/maint/test_multiple_ip_ranges.py 68b5979 > > Diff: https://reviews.apache.org/r/14531/diff/ > > > Testing > --- > > yes > > > Thanks, > > sanjeev n > >
Re: Review Request 14715: [CLOUDSTACK-4887] CLVM broken
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14715/#review27157 --- Commit a504c004bf10555e5ea67ec89fe7bf6f00fe4622 in branch refs/heads/master from Marcus Sorensen [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a504c00 ] CLOUDSTACK-4887: Fix CLVM template download from storage refactoring work - ASF Subversion and Git Services On Oct. 17, 2013, 6:59 p.m., Chris Suich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14715/ > --- > > (Updated Oct. 17, 2013, 6:59 p.m.) > > > Review request for cloudstack, edison su and Marcus Sorensen. > > > Repository: cloudstack-git > > > Description > --- > > Fixed a bug with backup snapshot condition logic causing snapshots to not be > backed up and the API to fail. > > > Diffs > - > > core/src/com/cloud/storage/resource/StorageSubsystemCommandHandlerBase.java > 002143f > > Diff: https://reviews.apache.org/r/14715/diff/ > > > Testing > --- > > > Thanks, > > Chris Suich > >
Re: Review Request 14469: CLOUDSTACK-4637: Fix failures in test_egress_fw_rules.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14469/#review27158 --- Commit a65f1ebefca7b22512762faf1832291153782f58 in branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a65f1eb ] CLOUDSTACK-4637: Fix failures in test_egress_fw_rules.py Removed log_test_exceptions which did not add any value. Skipped few tests which are incomplete. Added timeout logic and to wait for router to boot. - ASF Subversion and Git Services On Oct. 16, 2013, 2:27 p.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14469/ > --- > > (Updated Oct. 16, 2013, 2:27 p.m.) > > > Review request for cloudstack, Harikrishna Patnala and venkata swamy babu > budumuru. > > > Bugs: CLOUDSTACK-4637 > https://issues.apache.org/jira/browse/CLOUDSTACK-4637 > > > Repository: cloudstack-git > > > Description > --- > > Add logic to wait for router to boot. > > > Diffs > - > > test/integration/component/test_egress_fw_rules.py 5c18f9c > > Diff: https://reviews.apache.org/r/14469/diff/ > > > Testing > --- > > test_01_1_egress_fr1 (test_egress_fw_rules.TestEgressFWRules) > Test By-default the communication from guest n/w to public n/w is NOT > allowed. ... ok > test_01_egress_fr1 (test_egress_fw_rules.TestEgressFWRules) > Test By-default the communication from guest n/w to public n/w is allowed. > ... ok > test_02_1_egress_fr2 (test_egress_fw_rules.TestEgressFWRules) > Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. > ... ok > test_02_egress_fr2 (test_egress_fw_rules.TestEgressFWRules) > Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. > ... ok > test_03_1_egress_fr3 (test_egress_fw_rules.TestEgressFWRules) > Test Communication blocked with network that is other than specified ... ok > test_03_egress_fr3 (test_egress_fw_rules.TestEgressFWRules) > Test Communication blocked with network that is other than specified ... ok > test_04_1_egress_fr4 (test_egress_fw_rules.TestEgressFWRules) > Test Create Egress rule and check the Firewall_Rules DB table ... ok > test_04_egress_fr4 (test_egress_fw_rules.TestEgressFWRules) > Test Create Egress rule and check the Firewall_Rules DB table ... ok > test_05_1_egress_fr5 (test_egress_fw_rules.TestEgressFWRules) > Test Create Egress rule and check the IP tables ... ok > test_05_egress_fr5 (test_egress_fw_rules.TestEgressFWRules) > Test Create Egress rule and check the IP tables ... ok > test_06_1_egress_fr6 (test_egress_fw_rules.TestEgressFWRules) > Test Create Egress rule without CIDR ... ok > test_06_egress_fr6 (test_egress_fw_rules.TestEgressFWRules) > Test Create Egress rule without CIDR ... ok > test_07_1_egress_fr7 (test_egress_fw_rules.TestEgressFWRules) > Test Create Egress rule without End Port ... ok > test_07_egress_fr7 (test_egress_fw_rules.TestEgressFWRules) > Test Create Egress rule without End Port ... ok > test_08_1_egress_fr8 (test_egress_fw_rules.TestEgressFWRules) > Test Port Forwarding and Egress Conflict ... ok > test_08_egress_fr8 (test_egress_fw_rules.TestEgressFWRules) > Test Port Forwarding and Egress Conflict ... ok > test_09_1_egress_fr9 (test_egress_fw_rules.TestEgressFWRules) > Test Delete Egress rule ... ok > test_09_egress_fr9 (test_egress_fw_rules.TestEgressFWRules) > Test Delete Egress rule ... ok > test_10_1_egress_fr10 (test_egress_fw_rules.TestEgressFWRules) > Test Invalid CIDR and Invalid Port ranges ... ok > test_10_egress_fr10 (test_egress_fw_rules.TestEgressFWRules) > Test Invalid CIDR and Invalid Port ranges ... ok > test_11_1_egress_fr11 (test_egress_fw_rules.TestEgressFWRules) > Test Regression on Firewall + PF + LB + SNAT ... ok > test_11_egress_fr11 (test_egress_fw_rules.TestEgressFWRules) > Test Regression on Firewall + PF + LB + SNAT ... ok > test_12_1_egress_fr12 (test_egress_fw_rules.TestEgressFWRules) > Test Reboot Router ... ok > test_13_1_egress_fr13 (test_egress_fw_rules.TestEgressFWRules) > Test Redundant Router : Master failover ... ok > test_13_egress_fr13 (test_egress_fw_rules.TestEgressFWRules) > Test Redundant Router : Master failover ... ok > > -- > Ran 26 tests in 15127.540s > > OK > > > Thanks, > > Girish Shilamkar > >
Re: Review Request 14469: CLOUDSTACK-4637: Fix failures in test_egress_fw_rules.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14469/#review27160 --- Commit 833229c416cfee3e3dec3762d2e9c8e734696f90 in branch refs/heads/4.2 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=833229c ] CLOUDSTACK-4637: Fix failures in test_egress_fw_rules.py Removed log_test_exceptions which did not add any value. Skipped few tests which are incomplete. Added timeout logic and to wait for router to boot. (cherry picked from commit a65f1ebefca7b22512762faf1832291153782f58) Signed-off-by: Sangeetha - ASF Subversion and Git Services On Oct. 16, 2013, 2:27 p.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14469/ > --- > > (Updated Oct. 16, 2013, 2:27 p.m.) > > > Review request for cloudstack, Harikrishna Patnala and venkata swamy babu > budumuru. > > > Bugs: CLOUDSTACK-4637 > https://issues.apache.org/jira/browse/CLOUDSTACK-4637 > > > Repository: cloudstack-git > > > Description > --- > > Add logic to wait for router to boot. > > > Diffs > - > > test/integration/component/test_egress_fw_rules.py 5c18f9c > > Diff: https://reviews.apache.org/r/14469/diff/ > > > Testing > --- > > test_01_1_egress_fr1 (test_egress_fw_rules.TestEgressFWRules) > Test By-default the communication from guest n/w to public n/w is NOT > allowed. ... ok > test_01_egress_fr1 (test_egress_fw_rules.TestEgressFWRules) > Test By-default the communication from guest n/w to public n/w is allowed. > ... ok > test_02_1_egress_fr2 (test_egress_fw_rules.TestEgressFWRules) > Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. > ... ok > test_02_egress_fr2 (test_egress_fw_rules.TestEgressFWRules) > Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. > ... ok > test_03_1_egress_fr3 (test_egress_fw_rules.TestEgressFWRules) > Test Communication blocked with network that is other than specified ... ok > test_03_egress_fr3 (test_egress_fw_rules.TestEgressFWRules) > Test Communication blocked with network that is other than specified ... ok > test_04_1_egress_fr4 (test_egress_fw_rules.TestEgressFWRules) > Test Create Egress rule and check the Firewall_Rules DB table ... ok > test_04_egress_fr4 (test_egress_fw_rules.TestEgressFWRules) > Test Create Egress rule and check the Firewall_Rules DB table ... ok > test_05_1_egress_fr5 (test_egress_fw_rules.TestEgressFWRules) > Test Create Egress rule and check the IP tables ... ok > test_05_egress_fr5 (test_egress_fw_rules.TestEgressFWRules) > Test Create Egress rule and check the IP tables ... ok > test_06_1_egress_fr6 (test_egress_fw_rules.TestEgressFWRules) > Test Create Egress rule without CIDR ... ok > test_06_egress_fr6 (test_egress_fw_rules.TestEgressFWRules) > Test Create Egress rule without CIDR ... ok > test_07_1_egress_fr7 (test_egress_fw_rules.TestEgressFWRules) > Test Create Egress rule without End Port ... ok > test_07_egress_fr7 (test_egress_fw_rules.TestEgressFWRules) > Test Create Egress rule without End Port ... ok > test_08_1_egress_fr8 (test_egress_fw_rules.TestEgressFWRules) > Test Port Forwarding and Egress Conflict ... ok > test_08_egress_fr8 (test_egress_fw_rules.TestEgressFWRules) > Test Port Forwarding and Egress Conflict ... ok > test_09_1_egress_fr9 (test_egress_fw_rules.TestEgressFWRules) > Test Delete Egress rule ... ok > test_09_egress_fr9 (test_egress_fw_rules.TestEgressFWRules) > Test Delete Egress rule ... ok > test_10_1_egress_fr10 (test_egress_fw_rules.TestEgressFWRules) > Test Invalid CIDR and Invalid Port ranges ... ok > test_10_egress_fr10 (test_egress_fw_rules.TestEgressFWRules) > Test Invalid CIDR and Invalid Port ranges ... ok > test_11_1_egress_fr11 (test_egress_fw_rules.TestEgressFWRules) > Test Regression on Firewall + PF + LB + SNAT ... ok > test_11_egress_fr11 (test_egress_fw_rules.TestEgressFWRules) > Test Regression on Firewall + PF + LB + SNAT ... ok > test_12_1_egress_fr12 (test_egress_fw_rules.TestEgressFWRules) > Test Reboot Router ... ok > test_13_1_egress_fr13 (test_egress_fw_rules.TestEgressFWRules) > Test Redundant Router : Master failover ... ok > test_13_egress_fr13 (test_egress_fw_rules.TestEgressFWRules) > Test Redundant Router : Master failover ... ok > > -- > Ran 26 tests in 15127.540s > > OK > > > Thanks, > > Girish Shilamkar > >
Re: Review Request 14739: CLOUDSTACK-4783: Unable to see a derieved template if the parent template is deleted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14739/#review27188 --- Commit 5eb5594e8e646dbba29746c5aeb8cb8dd2a3c343 in branch refs/heads/4.2 from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5eb5594 ] CLOUDSTACK-4783: Added supported for listing all templates/ISOs with showremoved = true - ASF Subversion and Git Services On Oct. 18, 2013, 12:17 p.m., Harikrishna Patnala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14739/ > --- > > (Updated Oct. 18, 2013, 12:17 p.m.) > > > Review request for cloudstack and Kishan Kavala. > > > Bugs: CLOUDSTACK-4783 > https://issues.apache.org/jira/browse/CLOUDSTACK-4783 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-4783: Unable to see a derieved template if the parent template is > deleted > > > Diffs > - > > api/src/org/apache/cloudstack/api/ApiConstants.java d71db40 > api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java b490ca9 > > api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java > 0b937be > server/src/com/cloud/api/query/QueryManagerImpl.java 6104ec0 > server/src/com/cloud/api/query/vo/TemplateJoinVO.java bb1cfed > > Diff: https://reviews.apache.org/r/14739/diff/ > > > Testing > --- > > > Thanks, > > Harikrishna Patnala > >
Re: Review Request 14782: [CLOUDSTACK-4910] Take VM snapshot instantly returns success regardless of actual result
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14782/#review27253 --- Commit 5c5326f6f710932afc121fd2528681933c716bdc in branch refs/heads/master from Chris Suich [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5c5326f ] CLOUDSTACK-4910 Fixed issue with Take VM Snapshot UI always returning success - ASF Subversion and Git Services On Oct. 21, 2013, 3:27 p.m., Chris Suich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14782/ > --- > > (Updated Oct. 21, 2013, 3:27 p.m.) > > > Review request for cloudstack, Brian Federle and Jessica Wang. > > > Repository: cloudstack-git > > > Description > --- > > Fixed a typo causing vm snapshot requests to always instantly return > successful in the CloudStack UI. > > > Diffs > - > > ui/scripts/instances.js 41d1772 > > Diff: https://reviews.apache.org/r/14782/diff/ > > > Testing > --- > > > Thanks, > > Chris Suich > >
Re: Review Request 14305: CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14305/#review27274 --- Commit f9731144cda4d7982cc4be1e60c1e4aa3b3ca2e2 in branch refs/heads/4.2 from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f973114 ] CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key) Changing the response object of register and list ssh keypairs APIs Signed-off-by: Koushik Das - ASF Subversion and Git Services On Oct. 21, 2013, 5:14 a.m., Harikrishna Patnala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14305/ > --- > > (Updated Oct. 21, 2013, 5:14 a.m.) > > > Review request for cloudstack and Koushik Das. > > > Bugs: CLOUDSTACK-4493 > https://issues.apache.org/jira/browse/CLOUDSTACK-4493 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response > (private key) > Changing the response object of register and list ssh keypairs APIs > > > Diffs > - > > api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java > 56bec7e > api/src/org/apache/cloudstack/api/response/CreateSSHKeyPairResponse.java > PRE-CREATION > api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java 2791853 > > Diff: https://reviews.apache.org/r/14305/diff/ > > > Testing > --- > > > Thanks, > > Harikrishna Patnala > >
Re: Review Request 14305: CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14305/#review27276 --- Commit 54e365d00b5ae504c59c025b37387b9c9d166422 in branch refs/heads/master from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=54e365d ] CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response (private key) Changing the response object of register and list ssh keypairs APIs Signed-off-by: Koushik Das Conflicts: api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java - ASF Subversion and Git Services On Oct. 21, 2013, 5:14 a.m., Harikrishna Patnala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14305/ > --- > > (Updated Oct. 21, 2013, 5:14 a.m.) > > > Review request for cloudstack and Koushik Das. > > > Bugs: CLOUDSTACK-4493 > https://issues.apache.org/jira/browse/CLOUDSTACK-4493 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-4493: registerSSHKeyPair API doc contains wrong API response > (private key) > Changing the response object of register and list ssh keypairs APIs > > > Diffs > - > > api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java > 56bec7e > api/src/org/apache/cloudstack/api/response/CreateSSHKeyPairResponse.java > PRE-CREATION > api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java 2791853 > > Diff: https://reviews.apache.org/r/14305/diff/ > > > Testing > --- > > > Thanks, > > Harikrishna Patnala > >
Re: Review Request 14647: CLOUDSTACK-3583: Management server stop is not removing the PID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14647/#review27294 --- Commit 770bfe43542fea0f25fda2fab026361e7c701a5b in branch refs/heads/master from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=770bfe4 ] CLOUDSTACK-3583: Fix for Management server stop is not removing the PID - ASF Subversion and Git Services On Oct. 15, 2013, 10:05 a.m., Saksham Srivastava wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14647/ > --- > > (Updated Oct. 15, 2013, 10:05 a.m.) > > > Review request for cloudstack and Rajesh Battala. > > > Bugs: CLOUDSTACK-3583 > https://issues.apache.org/jira/browse/CLOUDSTACK-3583 > > > Repository: cloudstack-git > > > Description > --- > > The current implementation of #service cloudstack-management stop > kills the process. The PID file and the lock file both continue to exist > until the the service is started again, which replaces them. > When the service has been stopped this causes #service cloudstack-management > status to return message like: > cloudstack-management dead but pid file exists > The pid file locates at /var/run/cloudstack-management.pid and lock file at > /var/lock/subsys/cloudstack-management. > Starting cloudstack-management will take care of them or you can manually > clean up > > In the fix I am removing the PID and the lock file once the service has been > successfully killed. > Also when the service is cleanly stopped the return value is 3, added the > same check in handle_pid_file(). > > > Diffs > - > > packaging/centos63/cloud-management.rc 35f31b2 > > Diff: https://reviews.apache.org/r/14647/diff/ > > > Testing > --- > > Tested locally : > The status is now as #service cloudstack-management status > cloudstack-management is stopped > > > Thanks, > > Saksham Srivastava > >
Re: Review Request 14647: CLOUDSTACK-3583: Management server stop is not removing the PID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14647/#review27295 --- Commit 2a914cb3c4ff61c5d29733cac77dca67030b in branch refs/heads/4.2 from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2a9 ] CLOUDSTACK-3583: Fix for Management server stop is not removing the PID - ASF Subversion and Git Services On Oct. 15, 2013, 10:05 a.m., Saksham Srivastava wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14647/ > --- > > (Updated Oct. 15, 2013, 10:05 a.m.) > > > Review request for cloudstack and Rajesh Battala. > > > Bugs: CLOUDSTACK-3583 > https://issues.apache.org/jira/browse/CLOUDSTACK-3583 > > > Repository: cloudstack-git > > > Description > --- > > The current implementation of #service cloudstack-management stop > kills the process. The PID file and the lock file both continue to exist > until the the service is started again, which replaces them. > When the service has been stopped this causes #service cloudstack-management > status to return message like: > cloudstack-management dead but pid file exists > The pid file locates at /var/run/cloudstack-management.pid and lock file at > /var/lock/subsys/cloudstack-management. > Starting cloudstack-management will take care of them or you can manually > clean up > > In the fix I am removing the PID and the lock file once the service has been > successfully killed. > Also when the service is cleanly stopped the return value is 3, added the > same check in handle_pid_file(). > > > Diffs > - > > packaging/centos63/cloud-management.rc 35f31b2 > > Diff: https://reviews.apache.org/r/14647/diff/ > > > Testing > --- > > Tested locally : > The status is now as #service cloudstack-management status > cloudstack-management is stopped > > > Thanks, > > Saksham Srivastava > >
Re: Review Request 14843: CLOUDSTACK-1049 : git commit by using command cloudstack-sccs from installed setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14843/#review27338 --- Commit c5c5e2367edfba7b2240ede5563cab769f60620a in branch refs/heads/master from rayeesn [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c5c5e23 ] follow up fix for CLOUDSTACK-1049 - ASF Subversion and Git Services On Oct. 22, 2013, 7:21 p.m., Rayees Namathponnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14843/ > --- > > (Updated Oct. 22, 2013, 7:21 p.m.) > > > Review request for cloudstack, Chip Childers, Frank Zhang, and Hugo Trippaers. > > > Bugs: CLOUDSTACK-1049 > https://issues.apache.org/jira/browse/CLOUDSTACK-1049 > > > Repository: cloudstack-git > > > Description > --- > > The generation of sccs-info was done by WAF but has been broken from 4.2 > onwords; > > updated cloud.spec file to generate git commit and package with rpm > > if you are building outside git tree, this file will be blank; and packaging > works fine > > > Diffs > - > > packaging/centos63/cloud.spec 17fb2b1 > packaging/centos63/cloudstack-sccs PRE-CREATION > > Diff: https://reviews.apache.org/r/14843/diff/ > > > Testing > --- > > Tested > > > Thanks, > > Rayees Namathponnan > >
Re: Review Request 14843: CLOUDSTACK-1049 : git commit by using command cloudstack-sccs from installed setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14843/#review27341 --- Commit aca6c420b40a411aebcc2eecad00e8341222348e in branch refs/heads/master from Frank.Zhang [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=aca6c42 ] follow up fix for CLOUDSTACK-1049 add license header to cloudstack-sccs - ASF Subversion and Git Services On Oct. 22, 2013, 7:21 p.m., Rayees Namathponnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14843/ > --- > > (Updated Oct. 22, 2013, 7:21 p.m.) > > > Review request for cloudstack, Chip Childers, Frank Zhang, and Hugo Trippaers. > > > Bugs: CLOUDSTACK-1049 > https://issues.apache.org/jira/browse/CLOUDSTACK-1049 > > > Repository: cloudstack-git > > > Description > --- > > The generation of sccs-info was done by WAF but has been broken from 4.2 > onwords; > > updated cloud.spec file to generate git commit and package with rpm > > if you are building outside git tree, this file will be blank; and packaging > works fine > > > Diffs > - > > packaging/centos63/cloud.spec 17fb2b1 > packaging/centos63/cloudstack-sccs PRE-CREATION > > Diff: https://reviews.apache.org/r/14843/diff/ > > > Testing > --- > > Tested > > > Thanks, > > Rayees Namathponnan > >
Re: Review Request 14871: CLOUDSTACK-4927: ISO and Template test cases failing duing listiso api call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14871/#review27378 --- Commit 2a6905a9ce5c6499a5632afb3d8b7e8af71ef7fa in branch refs/heads/4.2 from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2a6905a ] CLOUDSTACK-4927: ISO and Template test cases failing duing listiso api call Removed check for deleted template/ISOs to throw exception as all list APIs returns empty response on deleted entities - ASF Subversion and Git Services On Oct. 23, 2013, 7:25 a.m., Harikrishna Patnala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14871/ > --- > > (Updated Oct. 23, 2013, 7:25 a.m.) > > > Review request for cloudstack and Kishan Kavala. > > > Bugs: CLOUDSTACK-4927 > https://issues.apache.org/jira/browse/CLOUDSTACK-4927 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-4927: ISO and Template test cases failing duing listiso api call > Removed check for deleted template/ISOs to throw exception as all list APIs > returns empty response on deleted entities > > > Diffs > - > > server/src/com/cloud/api/query/QueryManagerImpl.java 9963d42 > > Diff: https://reviews.apache.org/r/14871/diff/ > > > Testing > --- > > > Thanks, > > Harikrishna Patnala > >
Re: Review Request 14843: CLOUDSTACK-1049 : git commit by using command cloudstack-sccs from installed setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14843/#review27466 --- Commit 435689c9ea9959492068c235cb73e7745541124e in branch refs/heads/4.2 from rayeesn [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=435689c ] CLOUDSTACK-1049 : git commit from installed cloudstack setup - ASF Subversion and Git Services On Oct. 23, 2013, 12:12 a.m., Rayees Namathponnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14843/ > --- > > (Updated Oct. 23, 2013, 12:12 a.m.) > > > Review request for cloudstack, Chip Childers, Frank Zhang, and Hugo Trippaers. > > > Bugs: CLOUDSTACK-1049 > https://issues.apache.org/jira/browse/CLOUDSTACK-1049 > > > Repository: cloudstack-git > > > Description > --- > > The generation of sccs-info was done by WAF but has been broken from 4.2 > onwords; > > updated cloud.spec file to generate git commit and package with rpm > > if you are building outside git tree, this file will be blank; and packaging > works fine > > > Diffs > - > > packaging/centos63/cloud.spec 17fb2b1 > packaging/centos63/cloudstack-sccs PRE-CREATION > > Diff: https://reviews.apache.org/r/14843/diff/ > > > Testing > --- > > Tested > > > File Attachments > > > We need to merge with 4.2 branch; submitting patch for this > > https://reviews.apache.org/media/uploaded/files/2013/10/23/0001-CLOUDSTACK-1049-git-commit-from-installed-cloudstack.patch > > > Thanks, > > Rayees Namathponnan > >
Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14737/#review27517 --- Commit d50e6a5b3ec63d1ff6dd4030ec2325c2bdb13307 in branch refs/heads/4.2 from sanjeevneelarapu [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d50e6a5 ] CLOUDSTACK-702: Added tests for alias ip verifications on VR 1. Moved vm deployment code to setup and vm deletion code teadDown methods 2. Added two tests which would verify alias removal after last vm expunge in CIDR and alias status after VR reboot CLOUDSTACK-702: Test for verifying ip alias after VR stop start 1.Deploy vm in new cidr which will create ip alias on existing VR Stop,start VR and verify ip alias Conflicts: test/integration/component/maint/test_multiple_ip_ranges.py Signed-off-by: SrikanteswaraRao Talluri - ASF Subversion and Git Services On Oct. 21, 2013, 9:29 a.m., sanjeev n wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14737/ > --- > > (Updated Oct. 21, 2013, 9:29 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Repository: cloudstack-git > > > Description > --- > > Added following code in the existing test > 1.Moved vm deployment code to setUp method and vm destroy code to tearDown > method > 2.Added test to verify ip alias removal after destroying last vm in the cidr > 3.Added tests to verify ip alias verification on VR after reboot and > stop/start VR > > > Diffs > - > > test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e > > Diff: https://reviews.apache.org/r/14737/diff/ > > > Testing > --- > > Yes > > > Thanks, > > sanjeev n > >
Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14737/#review27516 --- Commit d50e6a5b3ec63d1ff6dd4030ec2325c2bdb13307 in branch refs/heads/4.2 from sanjeevneelarapu [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d50e6a5 ] CLOUDSTACK-702: Added tests for alias ip verifications on VR 1. Moved vm deployment code to setup and vm deletion code teadDown methods 2. Added two tests which would verify alias removal after last vm expunge in CIDR and alias status after VR reboot CLOUDSTACK-702: Test for verifying ip alias after VR stop start 1.Deploy vm in new cidr which will create ip alias on existing VR Stop,start VR and verify ip alias Conflicts: test/integration/component/maint/test_multiple_ip_ranges.py Signed-off-by: SrikanteswaraRao Talluri - ASF Subversion and Git Services On Oct. 21, 2013, 9:29 a.m., sanjeev n wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14737/ > --- > > (Updated Oct. 21, 2013, 9:29 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Repository: cloudstack-git > > > Description > --- > > Added following code in the existing test > 1.Moved vm deployment code to setUp method and vm destroy code to tearDown > method > 2.Added test to verify ip alias removal after destroying last vm in the cidr > 3.Added tests to verify ip alias verification on VR after reboot and > stop/start VR > > > Diffs > - > > test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e > > Diff: https://reviews.apache.org/r/14737/diff/ > > > Testing > --- > > Yes > > > Thanks, > > sanjeev n > >
Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14737/#review27518 --- Commit 2103068816d024cf090797168bfd309b031e3e1c in branch refs/heads/master from sanjeevneelarapu [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2103068 ] CLOUDSTACK-702: Added tests for alias ip verifications on VR 1. Moved vm deployment code to setup and vm deletion code teadDown methods 2. Added two tests which would verify alias removal after last vm expunge in CIDR and alias status after VR reboot CLOUDSTACK-702: Test for verifying ip alias after VR stop start 1.Deploy vm in new cidr which will create ip alias on existing VR Stop,start VR and verify ip alias Conflicts: test/integration/component/maint/test_multiple_ip_ranges.py Signed-off-by: SrikanteswaraRao Talluri - ASF Subversion and Git Services On Oct. 21, 2013, 9:29 a.m., sanjeev n wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14737/ > --- > > (Updated Oct. 21, 2013, 9:29 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Repository: cloudstack-git > > > Description > --- > > Added following code in the existing test > 1.Moved vm deployment code to setUp method and vm destroy code to tearDown > method > 2.Added test to verify ip alias removal after destroying last vm in the cidr > 3.Added tests to verify ip alias verification on VR after reboot and > stop/start VR > > > Diffs > - > > test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e > > Diff: https://reviews.apache.org/r/14737/diff/ > > > Testing > --- > > Yes > > > Thanks, > > sanjeev n > >
Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14737/#review27519 --- Commit 2103068816d024cf090797168bfd309b031e3e1c in branch refs/heads/master from sanjeevneelarapu [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2103068 ] CLOUDSTACK-702: Added tests for alias ip verifications on VR 1. Moved vm deployment code to setup and vm deletion code teadDown methods 2. Added two tests which would verify alias removal after last vm expunge in CIDR and alias status after VR reboot CLOUDSTACK-702: Test for verifying ip alias after VR stop start 1.Deploy vm in new cidr which will create ip alias on existing VR Stop,start VR and verify ip alias Conflicts: test/integration/component/maint/test_multiple_ip_ranges.py Signed-off-by: SrikanteswaraRao Talluri - ASF Subversion and Git Services On Oct. 21, 2013, 9:29 a.m., sanjeev n wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14737/ > --- > > (Updated Oct. 21, 2013, 9:29 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Repository: cloudstack-git > > > Description > --- > > Added following code in the existing test > 1.Moved vm deployment code to setUp method and vm destroy code to tearDown > method > 2.Added test to verify ip alias removal after destroying last vm in the cidr > 3.Added tests to verify ip alias verification on VR after reboot and > stop/start VR > > > Diffs > - > > test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e > > Diff: https://reviews.apache.org/r/14737/diff/ > > > Testing > --- > > Yes > > > Thanks, > > sanjeev n > >
Re: Review Request 14333: CLOUDSTACK-4691: move egress rules host maintenance tests to maint folder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14333/#review27521 --- Commit 3958095676874e652517270f683cf8c4ba852f41 in branch refs/heads/4.2 from SrikanteswaraRao Talluri [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3958095 ] CLOUDSTACK-4691: Deleted host maintenance tests from this file - ASF Subversion and Git Services On Sept. 25, 2013, 9:50 a.m., SrikanteswaraRao Talluri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14333/ > --- > > (Updated Sept. 25, 2013, 9:50 a.m.) > > > Review request for cloudstack, venkata swamy babu budumuru and Prasanna > Santhanam. > > > Bugs: CLOUDSTACK-4691 > https://issues.apache.org/jira/browse/CLOUDSTACK-4691 > > > Repository: cloudstack-git > > > Description > --- > > move host maintenance tests to maint folder and correct few typos > > > Diffs > - > > test/integration/component/maint/test_egress_rules_host_maintenance.py > PRE-CREATION > test/integration/component/maint/test_host_high_availability.py 5fb047b > test/integration/component/test_egress_rules.py 10e0d03 > tools/marvin/marvin/integration/lib/base.py df81406 > tools/marvin/marvin/sandbox/demo/simulator/testcase/libs/base.py 0b5da5c > > Diff: https://reviews.apache.org/r/14333/diff/ > > > Testing > --- > > tested > > > Thanks, > > SrikanteswaraRao Talluri > >
Re: Review Request 14333: CLOUDSTACK-4691: move egress rules host maintenance tests to maint folder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14333/#review27522 --- Commit da7d2fe4f3676be7d159a1235a2434ef1f8b in branch refs/heads/master from SrikanteswaraRao Talluri [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=da7d2fe ] CLOUDSTACK-4691: Deleted host maintenance tests from this file - ASF Subversion and Git Services On Sept. 25, 2013, 9:50 a.m., SrikanteswaraRao Talluri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14333/ > --- > > (Updated Sept. 25, 2013, 9:50 a.m.) > > > Review request for cloudstack, venkata swamy babu budumuru and Prasanna > Santhanam. > > > Bugs: CLOUDSTACK-4691 > https://issues.apache.org/jira/browse/CLOUDSTACK-4691 > > > Repository: cloudstack-git > > > Description > --- > > move host maintenance tests to maint folder and correct few typos > > > Diffs > - > > test/integration/component/maint/test_egress_rules_host_maintenance.py > PRE-CREATION > test/integration/component/maint/test_host_high_availability.py 5fb047b > test/integration/component/test_egress_rules.py 10e0d03 > tools/marvin/marvin/integration/lib/base.py df81406 > tools/marvin/marvin/sandbox/demo/simulator/testcase/libs/base.py 0b5da5c > > Diff: https://reviews.apache.org/r/14333/diff/ > > > Testing > --- > > tested > > > Thanks, > > SrikanteswaraRao Talluri > >
Re: Review Request 14011: CLOUDSTACK-4612: Specified locale keyboard language is not showing as default in consoleView passed during deployVM.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14011/#review27527 --- Commit d188534f3de95a174c0bb4bcf2073b5fe62870af in branch refs/heads/4.2 from Sanjay Tripathi [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d188534 ] CLOUDSTACK-4612: Specified locale keyboard language is not showing as default in consoleView passed during deployVM. While deploying a VM, user passes the "keyboard" parameter to specify the default language for that VM but in the consoleView, the default language selected is en-us irrespective of the default language of the VM. - ASF Subversion and Git Services On Sept. 6, 2013, 8:41 a.m., Sanjay Tripathi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14011/ > --- > > (Updated Sept. 6, 2013, 8:41 a.m.) > > > Review request for cloudstack, Devdeep Singh, Fang Wang, and Kelven Yang. > > > Bugs: CLOUDSTACK-4612 > https://issues.apache.org/jira/browse/CLOUDSTACK-4612 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-4612: Specified locale keyboard language is not showing as default > in consoleView passed during deployVM. > > While deploying a VM, user passes the "keyboard" parameter to specify the > default language for that VM but in the consoleView, the default language > selected is en-us irrespective of the default language of the VM. > > > This patch is for 4.2-forward branch. I'll send a seperate patch for master > as there are some conflicts with the master branch. > > > Diffs > - > > server/src/com/cloud/servlet/ConsoleProxyClientParam.java e420110 > server/src/com/cloud/servlet/ConsoleProxyServlet.java f6559a5 > services/console-proxy/server/js/ajaxviewer.js 9643204 > > services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java > 6cadeca > > services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java > 07a1b6f > > services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientParam.java > 8de4955 > > services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java > 297e711 > > Diff: https://reviews.apache.org/r/14011/diff/ > > > Testing > --- > > Verified the fix locally by deploying a VM with keyboard=uk and keyboard=jp. > > > Thanks, > > Sanjay Tripathi > >
Re: Review Request 14200: CLOUDSTACK-4686: Fixed volume limit for domain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14200/#review27594 --- Commit c8b91f1b72d228b9979bdd38d62138eb84cb69c3 in branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c8b91f1 ] CLOUDSTACK-4686: Fixed volume limit for domain - ASF Subversion and Git Services On Sept. 18, 2013, noon, Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14200/ > --- > > (Updated Sept. 18, 2013, noon) > > > Review request for cloudstack and sailaja mada. > > > Bugs: CLOUDSTACK-4686 > https://issues.apache.org/jira/browse/CLOUDSTACK-4686 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-4686: Fixed volume limit for domain > > > Diffs > - > > test/integration/component/test_resource_limits.py 833723c > > Diff: https://reviews.apache.org/r/14200/diff/ > > > Testing > --- > > > Thanks, > > Girish Shilamkar > >
Re: Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15018/#review27731 --- Commit bed42deb8835760e98a39902a698c38dbd17b414 in branch refs/heads/master from Brian Federle [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=bed42de ] CLOUDSTACK-4908: UI for report CPU sockets -Adds socket info for hypervisors on infrastructure chart -Displays # of sockets, and # of hosts -Currently only dummy data set to 0 for all info - ASF Subversion and Git Services On Oct. 29, 2013, 9:29 a.m., Harikrishna Patnala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15018/ > --- > > (Updated Oct. 29, 2013, 9:29 a.m.) > > > Review request for cloudstack and Kishan Kavala. > > > Bugs: CLOUDSTACK-4908 > https://issues.apache.org/jira/browse/CLOUDSTACK-4908 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-4908: CPU socket count of host > Adding cpu socket count of the host in hostresponse > > > Diffs > - > > api/src/com/cloud/host/Host.java 17b0ba8 > api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java > 95b9ac3 > api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d > core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b > core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java > 1b68276 > > engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java > 249c2db > engine/schema/src/com/cloud/host/HostVO.java c814b94 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > 286d0f7 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 423abe6 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > 6c1efe7 > server/src/com/cloud/api/query/QueryManagerImpl.java a7d85cf > server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9 > server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd > server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193 > setup/db/db/schema-421to430.sql 0e78875 > vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec > vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java > f7288f1 > > vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java > fa11dc3 > > Diff: https://reviews.apache.org/r/15018/diff/ > > > Testing > --- > > > Thanks, > > Harikrishna Patnala > >
Re: Review Request 15001: CLOUDSTACK-4967: Bugfix: Guest network isn't created correctly in rare case when vxlan is used for isolation method
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15001/#review27733 --- Commit 4a9f05bda075d03c4a5a015e081c70b3d8b72267 in branch refs/heads/master from Marcus Sorensen [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4a9f05b ] CLOUDSTACK-4967 1) vxlan will use bridge scheme 'brvx-'. Multiple physical networks can host guest traffic type with vxlan isolation, so long as they don't use the same VNI range. 2) Guest traffic labels can be physical interface if bridge by given name is not found. Normally we take traffic label name, find the matching bridge, then resolve that to a physical interface. Then we create guest bridges on that interface. Now we can just specify the interface. - ASF Subversion and Git Services On Oct. 29, 2013, 12:51 a.m., Yoshikazu Nojima wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15001/ > --- > > (Updated Oct. 29, 2013, 12:51 a.m.) > > > Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano. > > > Bugs: CLOUDSTACK-4967 > https://issues.apache.org/jira/browse/CLOUDSTACK-4967 > > > Repository: cloudstack-git > > > Description > --- > > Guest network isn't created correctly when vxlan is used for isolation > method, VNI is bigger than 1000, and physical network interface name > length is longer than 4. > This patch fix this issue by raising error when long interface name is > specified. > > Issue remained: document that physical interface name length must be shorter > than 5. > > > Diffs > - > > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java > f945b74 > > plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/15001/diff/ > > > Testing > --- > > I confirmed it passes the unit tests I add. > > > Thanks, > > Yoshikazu Nojima > >
Re: Review Request 15012: CLOUDSTACK-4984: decrement MAX_VXLAN_VNI to be aligned with Linux kernel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15012/#review27778 --- Commit 089026f6afb4de1a1f81b71d291a79d6e327a3e1 in branch refs/heads/master from ynojima [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=089026f ] CLOUDSTACK-4984: decrement MAX_VXLAN_VNI to be aligned with Linux kernel Linux vxlan interface doesn't accept VNI:16777215 now. Signed-off-by: Toshiaki Hatano - ASF Subversion and Git Services On Oct. 29, 2013, 5 a.m., Yoshikazu Nojima wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15012/ > --- > > (Updated Oct. 29, 2013, 5 a.m.) > > > Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano. > > > Repository: cloudstack-git > > > Description > --- > > Linux vxlan interface doesn't accept VNI:16777215. > https://github.com/torvalds/linux/blob/master/drivers/net/vxlan.c#L2140 > > As far as I read internet draft ( > http://tools.ietf.org/html/draft-mahalingam-dutt-dcops-vxlan-05 ), > 16777215 is a valid VNI, but it cannot be used in Linux now. > > This patch decrements MAX_VXLAN_VNI to 16777214. > > > Diffs > - > > server/src/com/cloud/network/NetworkServiceImpl.java 61c070a > > Diff: https://reviews.apache.org/r/15012/diff/ > > > Testing > --- > > I confirmed VNI validation works by specifying 16777215-16777215 to id range > via add zone wizard. > > > Thanks, > > Yoshikazu Nojima > >
Re: Review Request 14868: CLOUDSTACK-4932: Bugfix: listNetworks API doesn't return vlan id / VNI ( Virtual Network Identifier in VXLAN )
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14868/#review27781 --- Commit a6b6fa65facf83444262eb37ca65371a16900a04 in branch refs/heads/master from ynojima [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a6b6fa6 ] CLOUDSTACK-4932: bugfix : listNetworks API doesn't return VLAN ID (VNI) Signed-off-by: ynojima Signed-off-by: Toshiaki Hatano - ASF Subversion and Git Services On Oct. 23, 2013, 6:38 a.m., Yoshikazu Nojima wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14868/ > --- > > (Updated Oct. 23, 2013, 6:38 a.m.) > > > Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali > Reddy, Hugo Trippaers, and Toshiaki Hatano. > > > Bugs: CLOUDSTACK-4932 > https://issues.apache.org/jira/browse/CLOUDSTACK-4932 > > > Repository: cloudstack-git > > > Description > --- > > Issue to resolve: > When listNetworks API is called with root admin account, it must return vlan > id, but it returns "N/A". > I tested with the branch "master". > > http://cloudstack.apache.org/docs/api/apidocs-4.2/root_admin/listNetworks.html > > This patch fixed comparison bug of BroadCastDomainType instance to make this > api return vlan id, and made this api returns VNI ( Virtual Network > Identifier in VXLAN ) when network is configured to use VXLAN. > > > Diffs > - > > server/src/com/cloud/api/ApiResponseHelper.java f4ca112 > > Diff: https://reviews.apache.org/r/14868/diff/ > > > Testing > --- > > I confirmed appropriate VLAN ID is returned by listNetworks API, and it is > displayed in the "Network"/"Guest networks"/"details" tab in CloudStack > WebGUI. > > > Thanks, > > Yoshikazu Nojima > >
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base image update faclity
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14459/#review27881 --- Commit c53d4e9e141d5048a4ed2ea040fbef545c7ae9d1 in branch refs/heads/master from Ashutosh Kelkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c53d4e9 ] CLOUDSTACK-2243: Add automation tests for VMs base image update faclity Signed-off-by: Girish Shilamkar - ASF Subversion and Git Services On Oct. 31, 2013, 6:39 a.m., Ashutosh Kelkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14459/ > --- > > (Updated Oct. 31, 2013, 6:39 a.m.) > > > Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-2243 > https://issues.apache.org/jira/browse/CLOUDSTACK-2243 > > > Repository: cloudstack-git > > > Description > --- > > Added new test class to test Base Image Updation Facility. > > > Diffs > - > > test/integration/component/test_base_image_updation.py PRE-CREATION > tools/marvin/marvin/codes.py 3da90d6 > tools/marvin/marvin/integration/lib/base.py 4f15137 > > Diff: https://reviews.apache.org/r/14459/diff/ > > > Testing > --- > > Tested locally on KVM advanced setup: > > Log: > > ==> result.log <== > test_01_deploy_instance_with_is_volatile_offering > (test_base_image_updation.TestBaseImageUpdate) > Test deploy an instance with service offerings with IsVolatile set. ... ok > test_02_reboot_instance_with_is_volatile_offering > (test_base_image_updation.TestBaseImageUpdate) > Test rebooting instances created with isVolatile service offerings ... > ==> client.log <== > 2013-10-09 20:22:30,659 - DEBUG - > test_02_reboot_instance_with_is_volatile_offering > (test_base_image_updation.TestBaseImageUpdate) - Checking root > th isVolatile=True > 2013-10-09 20:22:30,695 - DEBUG - > test_02_reboot_instance_with_is_volatile_offering > (test_base_image_updation.TestBaseImageUpdate) - Checking root > th isVolatile=False > > ==> result.log <== > ok > test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) > Test restoring a vm with different template than the one it was created with > ... > ==> client.log <== > 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo > ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0 > 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem > : 5a9190a9-8a59-487f-b90f-4a76a0f509a0 > 2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM > le=True > 2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM > le=False > 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot > po > disk on vm created with IsVolatile=True > 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : > HOURL > inute : 53 > 2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till > t > snapshoted > > ==> result.log <== > ok > test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) ... > ==> client.log <== > 2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of > atile=True was destroyed > 2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot > rule > isVolatile=True was destroyed > > ==> result.log <== > ok > > -- > Ran 4 tests in 3534.241s > > OK > > > Thanks, > > Ashutosh Kelkar > >
Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base image update faclity
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14459/#review27882 --- Commit e47dfb673cc71a0014fc320a0a14cb8942145e8f in branch refs/heads/4.2 from Ashutosh Kelkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e47dfb6 ] CLOUDSTACK-2243: Add automation tests for VMs base image update faclity Signed-off-by: Girish Shilamkar - ASF Subversion and Git Services On Oct. 31, 2013, 6:39 a.m., Ashutosh Kelkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14459/ > --- > > (Updated Oct. 31, 2013, 6:39 a.m.) > > > Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-2243 > https://issues.apache.org/jira/browse/CLOUDSTACK-2243 > > > Repository: cloudstack-git > > > Description > --- > > Added new test class to test Base Image Updation Facility. > > > Diffs > - > > test/integration/component/test_base_image_updation.py PRE-CREATION > tools/marvin/marvin/codes.py 3da90d6 > tools/marvin/marvin/integration/lib/base.py 4f15137 > > Diff: https://reviews.apache.org/r/14459/diff/ > > > Testing > --- > > Tested locally on KVM advanced setup: > > Log: > > ==> result.log <== > test_01_deploy_instance_with_is_volatile_offering > (test_base_image_updation.TestBaseImageUpdate) > Test deploy an instance with service offerings with IsVolatile set. ... ok > test_02_reboot_instance_with_is_volatile_offering > (test_base_image_updation.TestBaseImageUpdate) > Test rebooting instances created with isVolatile service offerings ... > ==> client.log <== > 2013-10-09 20:22:30,659 - DEBUG - > test_02_reboot_instance_with_is_volatile_offering > (test_base_image_updation.TestBaseImageUpdate) - Checking root > th isVolatile=True > 2013-10-09 20:22:30,695 - DEBUG - > test_02_reboot_instance_with_is_volatile_offering > (test_base_image_updation.TestBaseImageUpdate) - Checking root > th isVolatile=False > > ==> result.log <== > ok > test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) > Test restoring a vm with different template than the one it was created with > ... > ==> client.log <== > 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo > ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0 > 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem > : 5a9190a9-8a59-487f-b90f-4a76a0f509a0 > 2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM > le=True > 2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM > le=False > 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot > po > disk on vm created with IsVolatile=True > 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : > HOURL > inute : 53 > 2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till > t > snapshoted > > ==> result.log <== > ok > test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) ... > ==> client.log <== > 2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of > atile=True was destroyed > 2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot > rule > isVolatile=True was destroyed > > ==> result.log <== > ok > > -- > Ran 4 tests in 3534.241s > > OK > > > Thanks, > > Ashutosh Kelkar > >
Re: Review Request 15115: CLOUDSTACK-4335: Delete test_deployVmSharedNetworkWithoutIpRange
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15115/#review27891 --- Commit 58179d28840a37e6b098d731d4fe6e6e5ea8ecf9 in branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=58179d2 ] CLOUDSTACK-4335: Delete test_deployVmSharedNetworkWithoutIpRange test_deployVmSharedNetworkWithoutIpRange creates a shared network without start and end ip. This is no longer permitted and creation of shared network will fail with error "insufficient capacity". So remove this test which is invalid. Signed-off-by: Girish Shilamkar - ASF Subversion and Git Services On Oct. 31, 2013, 8:32 a.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15115/ > --- > > (Updated Oct. 31, 2013, 8:32 a.m.) > > > Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-4335 > https://issues.apache.org/jira/browse/CLOUDSTACK-4335 > > > Repository: cloudstack-git > > > Description > --- > > test_deployVmSharedNetworkWithoutIpRange creates a shared network > without start and end ip. This is no longer permitted and creation > of shared network will fail with error insufficient capacity. So > remove this test which is invalid. > > > Diffs > - > > test/integration/component/test_shared_network_offering.py 85f0892 > > Diff: https://reviews.apache.org/r/15115/diff/ > > > Testing > --- > > > Thanks, > > Girish Shilamkar > >
Re: Review Request 15115: CLOUDSTACK-4335: Delete test_deployVmSharedNetworkWithoutIpRange
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15115/#review27893 --- Commit 733c355eaa364e5402876b1347b206454b3bec66 in branch refs/heads/4.2 from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=733c355 ] CLOUDSTACK-4335: Delete test_deployVmSharedNetworkWithoutIpRange test_deployVmSharedNetworkWithoutIpRange creates a shared network without start and end ip. This is no longer permitted and creation of shared network will fail with error "insufficient capacity". So remove this test which is invalid. Signed-off-by: Girish Shilamkar - ASF Subversion and Git Services On Oct. 31, 2013, 8:32 a.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15115/ > --- > > (Updated Oct. 31, 2013, 8:32 a.m.) > > > Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-4335 > https://issues.apache.org/jira/browse/CLOUDSTACK-4335 > > > Repository: cloudstack-git > > > Description > --- > > test_deployVmSharedNetworkWithoutIpRange creates a shared network > without start and end ip. This is no longer permitted and creation > of shared network will fail with error insufficient capacity. So > remove this test which is invalid. > > > Diffs > - > > test/integration/component/test_shared_network_offering.py 85f0892 > > Diff: https://reviews.apache.org/r/15115/diff/ > > > Testing > --- > > > Thanks, > > Girish Shilamkar > >
Re: Review Request 15080: CLOUDSTACK-4855: Throttle based on the # of outstanding requests to the directly managed HV host (direct agents)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15080/#review28091 --- Commit 269a4ef11ee151fa408a7dd1f2e69cd1f7f05191 in branch refs/heads/master from Koushik Das [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=269a4ef ] CLOUDSTACK-4855: Throttle based on the # of outstanding requests to the directly managed HV host (direct agents) Cloudstack sends requests to directly managed HV hosts (direct agents) using the direct agent thread pool. The size of the pool is determined by global config direct.agent.pool.size defaulted to 500. Currently there is no restriction on the number of threads a direct agent can use from this shared thread pool to send requests to the host. This is fine as long as the host is responding to requests in a reasonable amount of time. But if there is a considerable delay in getting response, the thread remain blocked for that much time. As more commands are send to the slow host threads keep getting blocked. This can eventually lead to a situation where requests to healthy hosts cannot be processed as there are not enough free threads. The problem being addressed here is to localize the impact of few bad hosts, so that entire management server is not affected. One such way is to throttle based on the # of outstanding requests on per host basis. The outstanding requests to a host will be a % of direct agent pool size. This is configurable based on direct.agent.thread.cap. The default value is 0.1 or 10%, a value of 1 would mean the old behavior where there is no upper cap. This will ensure that the impacted host will be bound by a upper cap on the number of threads it can use to process requests and not the entire pool. - ASF Subversion and Git Services On Oct. 30, 2013, 10:51 a.m., Koushik Das wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15080/ > --- > > (Updated Oct. 30, 2013, 10:51 a.m.) > > > Review request for cloudstack, Alex Huang, Chiradeep Vittal, and Darren > Shepherd. > > > Bugs: CLOUDSTACK-4855 > https://issues.apache.org/jira/browse/CLOUDSTACK-4855 > > > Repository: cloudstack-git > > > Description > --- > > Cloudstack sends requests to directly managed HV hosts (direct agents) using > the direct agent thread pool. The size of the pool is determined by global > config direct.agent.pool.size defaulted to 500. > > Currently there is no restriction on the number of threads a direct agent can > use from this shared thread pool to send requests to the host. This is fine > as long as the host is responding to requests > in a reasonable amount of time. But if there is a considerable delay in > getting response, the thread remain blocked for that much time. As more > commands are send to the slow host threads keep getting > blocked. This can eventually lead to a situation where requests to healthy > hosts cannot be processed as there are not enough free threads. > > The problem being addressed here is to localize the impact of few bad hosts, > so that entire management server is not affected. > > One such way is to throttle based on the # of outstanding requests on per > host basis. The outstanding requests to a host will be a % of direct agent > pool size. This is configurable based on > direct.agent.thread.cap. This will ensure that the impacted host will be > bound by a upper cap on the number of threads it can use to process requests > and not the entire pool. > > > Note: The reason for checking the outstanding request count in the Task.run() > method is to take into account cron jobs that gets scheduled at agent startup. > > > Diffs > - > > engine/orchestration/src/com/cloud/agent/manager/AgentAttache.java ff35255 > engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java > 3e684cc > engine/orchestration/src/com/cloud/agent/manager/DirectAgentAttache.java > 7d3f765 > > Diff: https://reviews.apache.org/r/15080/diff/ > > > Testing > --- > > Verified by tweaking the per agent upper cap to a value of 1 and checked that > the requests are getting scheduled but the executor thread simply bails out. > > > Thanks, > > Koushik Das > >
Re: Review Request 12994: CLOUDSTACK-3216 Logs in the Software router are not being rotated
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12994/#review28107 --- Commit 5cc9b1de661f3189dcd1e3eb65d7e1d15c05e9e6 in branch refs/heads/4.2 from Marcus Sorensen [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5cc9b1d ] CLOUDSTACK-3216 /var/log/cloud.log did not have a logrotate script, here is a basic one. - ASF Subversion and Git Services On July 27, 2013, 1:09 p.m., Rajesh Battala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12994/ > --- > > (Updated July 27, 2013, 1:09 p.m.) > > > Review request for cloudstack, Alex Huang, Devdeep Singh, Ram Ganesh, and > Hugo Trippaers. > > > Bugs: 3216 > https://issues.apache.org/jira/browse/3216 > > > Repository: cloudstack-git > > > Description > --- > > Issue: > == > logrotate.conf and logrotate config files in logrotate.d folder are having > "x" permission. > hence logrotate daemon not able to use this config > logrotate reports the error as > /etc# /usr/sbin/logrotate -d -v /etc/logrotate.conf > reading config file /etc/logrotate.conf > including /etc/logrotate.d > Ignoring apache2 because of bad file mode. > reading config file apt > reading config file aptitude > reading config file conntrackd > Ignoring dnsmasq because of bad file mode. > reading config file dpkg > Ignoring haproxy because of bad file mode. > reading config file monit > Ignoring ppp because of bad file mode. > Ignoring rsyslog because of bad file mode. > == > > Fix: > === > while generating the cloudscripts.tgz file, I had modified to include the > logrotate.conf and logrotate config files under logrotate.d with 644 > permission which will fix the issue. > this is will fix the "bad file mode" error. > > > Diffs > - > > patches/pom.xml 00eec02 > > Diff: https://reviews.apache.org/r/12994/diff/ > > > Testing > --- > > 1. after generating new systemvm.iso tested the new router/ssvm/console proxy. > > logrotate -d -v /etc/logrotate.conf > reading config file /etc/logrotate.conf > including /etc/logrotate.d > reading config file apache2 > reading config file apt > reading config file aptitude > reading config file conntrackd > reading config file dnsmasq > reading config file dpkg > reading config file haproxy > reading config file monit > reading config file ppp > reading config file rsyslog > > > 2. Verified after launching the VR, new instances are getting IP and hostname > properly. > > > Thanks, > > Rajesh Battala > >
Re: Review Request 12994: CLOUDSTACK-3216 Logs in the Software router are not being rotated
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12994/#review28106 --- Commit 70330f5cf32f4a0463edf5024cf841e0e678f423 in branch refs/heads/master from Marcus Sorensen [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=70330f5 ] CLOUDSTACK-3216 /var/log/cloud.log did not have a logrotate script, here is a basic one. - ASF Subversion and Git Services On July 27, 2013, 1:09 p.m., Rajesh Battala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12994/ > --- > > (Updated July 27, 2013, 1:09 p.m.) > > > Review request for cloudstack, Alex Huang, Devdeep Singh, Ram Ganesh, and > Hugo Trippaers. > > > Bugs: 3216 > https://issues.apache.org/jira/browse/3216 > > > Repository: cloudstack-git > > > Description > --- > > Issue: > == > logrotate.conf and logrotate config files in logrotate.d folder are having > "x" permission. > hence logrotate daemon not able to use this config > logrotate reports the error as > /etc# /usr/sbin/logrotate -d -v /etc/logrotate.conf > reading config file /etc/logrotate.conf > including /etc/logrotate.d > Ignoring apache2 because of bad file mode. > reading config file apt > reading config file aptitude > reading config file conntrackd > Ignoring dnsmasq because of bad file mode. > reading config file dpkg > Ignoring haproxy because of bad file mode. > reading config file monit > Ignoring ppp because of bad file mode. > Ignoring rsyslog because of bad file mode. > == > > Fix: > === > while generating the cloudscripts.tgz file, I had modified to include the > logrotate.conf and logrotate config files under logrotate.d with 644 > permission which will fix the issue. > this is will fix the "bad file mode" error. > > > Diffs > - > > patches/pom.xml 00eec02 > > Diff: https://reviews.apache.org/r/12994/diff/ > > > Testing > --- > > 1. after generating new systemvm.iso tested the new router/ssvm/console proxy. > > logrotate -d -v /etc/logrotate.conf > reading config file /etc/logrotate.conf > including /etc/logrotate.d > reading config file apache2 > reading config file apt > reading config file aptitude > reading config file conntrackd > reading config file dnsmasq > reading config file dpkg > reading config file haproxy > reading config file monit > reading config file ppp > reading config file rsyslog > > > 2. Verified after launching the VR, new instances are getting IP and hostname > properly. > > > Thanks, > > Rajesh Battala > >
Re: Review Request 12994: CLOUDSTACK-3216 Logs in the Software router are not being rotated
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12994/#review28145 --- Commit 70330f5cf32f4a0463edf5024cf841e0e678f423 in branch refs/heads/ui-restyle from Marcus Sorensen [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=70330f5 ] CLOUDSTACK-3216 /var/log/cloud.log did not have a logrotate script, here is a basic one. - ASF Subversion and Git Services On July 27, 2013, 1:09 p.m., Rajesh Battala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12994/ > --- > > (Updated July 27, 2013, 1:09 p.m.) > > > Review request for cloudstack, Alex Huang, Devdeep Singh, Ram Ganesh, and > Hugo Trippaers. > > > Bugs: 3216 > https://issues.apache.org/jira/browse/3216 > > > Repository: cloudstack-git > > > Description > --- > > Issue: > == > logrotate.conf and logrotate config files in logrotate.d folder are having > "x" permission. > hence logrotate daemon not able to use this config > logrotate reports the error as > /etc# /usr/sbin/logrotate -d -v /etc/logrotate.conf > reading config file /etc/logrotate.conf > including /etc/logrotate.d > Ignoring apache2 because of bad file mode. > reading config file apt > reading config file aptitude > reading config file conntrackd > Ignoring dnsmasq because of bad file mode. > reading config file dpkg > Ignoring haproxy because of bad file mode. > reading config file monit > Ignoring ppp because of bad file mode. > Ignoring rsyslog because of bad file mode. > == > > Fix: > === > while generating the cloudscripts.tgz file, I had modified to include the > logrotate.conf and logrotate config files under logrotate.d with 644 > permission which will fix the issue. > this is will fix the "bad file mode" error. > > > Diffs > - > > patches/pom.xml 00eec02 > > Diff: https://reviews.apache.org/r/12994/diff/ > > > Testing > --- > > 1. after generating new systemvm.iso tested the new router/ssvm/console proxy. > > logrotate -d -v /etc/logrotate.conf > reading config file /etc/logrotate.conf > including /etc/logrotate.d > reading config file apache2 > reading config file apt > reading config file aptitude > reading config file conntrackd > reading config file dnsmasq > reading config file dpkg > reading config file haproxy > reading config file monit > reading config file ppp > reading config file rsyslog > > > 2. Verified after launching the VR, new instances are getting IP and hostname > properly. > > > Thanks, > > Rajesh Battala > >
Re: Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15018/#review28156 --- Commit 57678257a123da1f74fa2a81407beb94450444b3 in branch refs/heads/master from Jessica Wang [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5767825 ] CLOUDSTACK-4908: UI > Infrastructure > Sockets > view all > calculate Hosts for each hypervisor. - ASF Subversion and Git Services On Oct. 31, 2013, 10:14 a.m., Harikrishna Patnala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15018/ > --- > > (Updated Oct. 31, 2013, 10:14 a.m.) > > > Review request for cloudstack and Kishan Kavala. > > > Bugs: CLOUDSTACK-4908 > https://issues.apache.org/jira/browse/CLOUDSTACK-4908 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-4908: CPU socket count of host > Adding cpu socket count of the host in hostresponse > > > Diffs > - > > api/src/com/cloud/host/Host.java 17b0ba8 > api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java > 95b9ac3 > api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d > core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b > core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java > 1b68276 > > engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java > 249c2db > engine/schema/src/com/cloud/host/HostVO.java c814b94 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > 8d3a0e9 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 423abe6 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > 3323a15 > server/src/com/cloud/api/query/QueryManagerImpl.java 51ee249 > server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9 > server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd > server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193 > setup/db/db/schema-421to430.sql 803f1d9 > vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec > vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java > f7288f1 > > vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java > fa11dc3 > > Diff: https://reviews.apache.org/r/15018/diff/ > > > Testing > --- > > > Thanks, > > Harikrishna Patnala > >
Re: Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15018/#review28182 --- Commit a286dec098ec9fe663c2bbead128f88bf9f18418 in branch refs/heads/master from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a286dec ] CLOUDSTACK-4908: CPU socket count of host Adding cpu socket count of the host in hostresponse Signed-off-by: Koushik Das - ASF Subversion and Git Services On Nov. 5, 2013, 10:34 a.m., Harikrishna Patnala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15018/ > --- > > (Updated Nov. 5, 2013, 10:34 a.m.) > > > Review request for cloudstack and Kishan Kavala. > > > Bugs: CLOUDSTACK-4908 > https://issues.apache.org/jira/browse/CLOUDSTACK-4908 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-4908: CPU socket count of host > Adding cpu socket count of the host in hostresponse > > > Diffs > - > > api/src/com/cloud/host/Host.java 17b0ba8 > api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java > 95b9ac3 > api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d > core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b > core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java > 1b68276 > > engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java > 249c2db > engine/schema/src/com/cloud/host/HostVO.java c814b94 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > e3f60f2 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > f6f84f6 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > ccb27ea > server/src/com/cloud/api/query/QueryManagerImpl.java 735bbc9 > server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9 > server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd > server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193 > setup/db/db/schema-421to430.sql 1c99e3f > vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec > vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java > f7288f1 > > vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java > fa11dc3 > > Diff: https://reviews.apache.org/r/15018/diff/ > > > Testing > --- > > > Thanks, > > Harikrishna Patnala > >
Re: Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15018/#review28210 --- Commit c61d2eedf4a87107ae9a77c8c39b7f584995e617 in branch refs/heads/master from Jessica Wang [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c61d2ee ] CLOUDSTACK-4908: UI > Infrastructure > Sockets > (1) calculate total number of CPU Sockets for all hypervisors. (2) > view all > calculate CPU Sockets for each hypervisor. - ASF Subversion and Git Services On Nov. 5, 2013, 10:34 a.m., Harikrishna Patnala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15018/ > --- > > (Updated Nov. 5, 2013, 10:34 a.m.) > > > Review request for cloudstack and Kishan Kavala. > > > Bugs: CLOUDSTACK-4908 > https://issues.apache.org/jira/browse/CLOUDSTACK-4908 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-4908: CPU socket count of host > Adding cpu socket count of the host in hostresponse > > > Diffs > - > > api/src/com/cloud/host/Host.java 17b0ba8 > api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java > 95b9ac3 > api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d > core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b > core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java > 1b68276 > > engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java > 249c2db > engine/schema/src/com/cloud/host/HostVO.java c814b94 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > e3f60f2 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > f6f84f6 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > ccb27ea > server/src/com/cloud/api/query/QueryManagerImpl.java 735bbc9 > server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9 > server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd > server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193 > setup/db/db/schema-421to430.sql 1c99e3f > vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec > vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java > f7288f1 > > vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java > fa11dc3 > > Diff: https://reviews.apache.org/r/15018/diff/ > > > Testing > --- > > > Thanks, > > Harikrishna Patnala > >
Re: Review Request 14200: CLOUDSTACK-4686: Fixed volume limit for domain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14200/#review28262 --- Commit ed76e8a610c66724c2b5f5c9a29bbbd3a2503e98 in branch refs/heads/4.2 from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ed76e8a ] CLOUDSTACK-4686: Fixed volume limit for domain - ASF Subversion and Git Services On Sept. 18, 2013, noon, Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14200/ > --- > > (Updated Sept. 18, 2013, noon) > > > Review request for cloudstack and sailaja mada. > > > Bugs: CLOUDSTACK-4686 > https://issues.apache.org/jira/browse/CLOUDSTACK-4686 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-4686: Fixed volume limit for domain > > > Diffs > - > > test/integration/component/test_resource_limits.py 833723c > > Diff: https://reviews.apache.org/r/14200/diff/ > > > Testing > --- > > > Thanks, > > Girish Shilamkar > >
Re: Review Request 15305: CLOUDSTACK-4996: Resolved gateway accessibility issue.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15305/#review28363 --- Commit 5d75c6b75c3ee65a15563d4c6b62cae7761afd86 in branch refs/heads/master from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5d75c6b ] CLOUDSTACK-4996: Resolved gateway accessibility issue Gateway of isolated network is pinged instead of shared network Signed-off-by: Girish Shilamkar - ASF Subversion and Git Services On Nov. 7, 2013, 10:22 a.m., Ashutosh Kelkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15305/ > --- > > (Updated Nov. 7, 2013, 10:22 a.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Bugs: CLOUDSTACK-4996 > https://issues.apache.org/jira/browse/CLOUDSTACK-4996 > > > Repository: cloudstack-git > > > Description > --- > > Gateway of isolated network is pinged instead of shared > network > > > Diffs > - > > test/integration/component/test_vpc_vm_life_cycle.py 425c284 > > Diff: https://reviews.apache.org/r/15305/diff/ > > > Testing > --- > > Yes > > > Thanks, > > Ashutosh Kelkar > >
Re: Review Request 15238: CLOUDSTACK-5039: bugfix: live migration failed : Domain not found: no domain with matching uuid ''
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15238/#review28372 --- Commit b864e677e5d007e10b73f10120d86dc97684de6c in branch refs/heads/master from ynojima [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b864e67 ] CLOUDSTACK-5039 bugfix: live migration failure in KVM env. Signed-off-by: ynojima - ASF Subversion and Git Services On Nov. 5, 2013, 5:17 a.m., Yoshikazu Nojima wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15238/ > --- > > (Updated Nov. 5, 2013, 5:17 a.m.) > > > Review request for cloudstack, Marcus Sorensen, Toshiaki Hatano, and Wido den > Hollander. > > > Bugs: CLOUDSTACK-5039 > https://issues.apache.org/jira/browse/CLOUDSTACK-5039 > > > Repository: cloudstack-git > > > Description > --- > > * Issue to be solved: > > Live migration failed with following error message: > > 2013-11-05 04:39:29,345 DEBUG [kvm.resource.LibvirtComputingResource] > (agentRequest-Handler-1:null) Can't migrate domain: Domain not found: no > domain with matching uuid '87c06b76-5ee6-3f1b-8c89-54e75de6bd3d' > > It seems CloudStack doesn't specify correct UUID. > This commit revert the domain lookup code change made in the commit ( > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java;h=203587a06f63f23d487ae65dcf5c397cd2702166;hp=94ee9ae676ef8d0202e7fa617e712352a934ffcb;hb=a709f34f;hpb=5410901aebed4ada581b853e0ca02d9f855a68f1 > ). > > > Diffs > - > > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > e3f60f2 > > Diff: https://reviews.apache.org/r/15238/diff/ > > > Testing > --- > > I confirmed live migration works. > > > Thanks, > > Yoshikazu Nojima > >
Re: Review Request 14872: CLOUDSTACK-4934: Rename Limit resources tests so that they have unique names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14872/#review28497 --- Commit 5d6d14bc1f1579006406a68cd069fba14ba3fa0c in branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5d6d14b ] CLOUDSTACK-4934: Rename Limit resources tests so that they have unique names. Signed-off-by: SrikanteswaraRao Talluri - ASF Subversion and Git Services On Oct. 23, 2013, 8:35 a.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14872/ > --- > > (Updated Oct. 23, 2013, 8:35 a.m.) > > > Review request for cloudstack and Rayees Namathponnan. > > > Bugs: CLOUDSTACK-4934 > https://issues.apache.org/jira/browse/CLOUDSTACK-4934 > > > Repository: cloudstack-git > > > Description > --- > > Patch for master branch. > > > Diffs > - > > test/integration/component/cpu_limits/test_cpu_limits.py d721a45 > test/integration/component/cpu_limits/test_domain_limits.py 4e8fc6d > test/integration/component/cpu_limits/test_maximum_limits.py 9161cee > test/integration/component/cpu_limits/test_project_limits.py 63d1a98 > test/integration/component/memory_limits/test_domain_limits.py d87db84 > test/integration/component/memory_limits/test_maximum_limits.py b1ebbb4 > test/integration/component/memory_limits/test_memory_limits.py 18eab4c > test/integration/component/memory_limits/test_project_limits.py 1c0ed92 > test/integration/component/test_cpu_domain_limits.py PRE-CREATION > test/integration/component/test_cpu_limits.py PRE-CREATION > test/integration/component/test_cpu_max_limits.py PRE-CREATION > test/integration/component/test_cpu_project_limits.py PRE-CREATION > test/integration/component/test_memory_limits.py PRE-CREATION > test/integration/component/test_mm_domain_limits.py PRE-CREATION > test/integration/component/test_mm_max_limits.py PRE-CREATION > test/integration/component/test_mm_project_limits.py PRE-CREATION > > Diff: https://reviews.apache.org/r/14872/diff/ > > > Testing > --- > > > Thanks, > > Girish Shilamkar > >
Re: Review Request 14872: CLOUDSTACK-4934: Rename Limit resources tests so that they have unique names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14872/#review28500 --- Commit 8f76c49a994a630bfdd583c3515ac06c11c7c662 in branch refs/heads/4.2 from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8f76c49 ] CLOUDSTACK-4934: Renamed Limit Resources tests so that they have unique name. Signed-off-by: SrikanteswaraRao Talluri - ASF Subversion and Git Services On Oct. 23, 2013, 8:35 a.m., Girish Shilamkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14872/ > --- > > (Updated Oct. 23, 2013, 8:35 a.m.) > > > Review request for cloudstack and Rayees Namathponnan. > > > Bugs: CLOUDSTACK-4934 > https://issues.apache.org/jira/browse/CLOUDSTACK-4934 > > > Repository: cloudstack-git > > > Description > --- > > Patch for master branch. > > > Diffs > - > > test/integration/component/cpu_limits/test_cpu_limits.py d721a45 > test/integration/component/cpu_limits/test_domain_limits.py 4e8fc6d > test/integration/component/cpu_limits/test_maximum_limits.py 9161cee > test/integration/component/cpu_limits/test_project_limits.py 63d1a98 > test/integration/component/memory_limits/test_domain_limits.py d87db84 > test/integration/component/memory_limits/test_maximum_limits.py b1ebbb4 > test/integration/component/memory_limits/test_memory_limits.py 18eab4c > test/integration/component/memory_limits/test_project_limits.py 1c0ed92 > test/integration/component/test_cpu_domain_limits.py PRE-CREATION > test/integration/component/test_cpu_limits.py PRE-CREATION > test/integration/component/test_cpu_max_limits.py PRE-CREATION > test/integration/component/test_cpu_project_limits.py PRE-CREATION > test/integration/component/test_memory_limits.py PRE-CREATION > test/integration/component/test_mm_domain_limits.py PRE-CREATION > test/integration/component/test_mm_max_limits.py PRE-CREATION > test/integration/component/test_mm_project_limits.py PRE-CREATION > > Diff: https://reviews.apache.org/r/14872/diff/ > > > Testing > --- > > > Thanks, > > Girish Shilamkar > >
Re: Review Request 15342: CLOUDSTACK-4648: Fixed Snapshots test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15342/#review28508 --- Commit b9547b07c059d229e6aed6213366cc3ab59fa26e in branch refs/heads/4.2 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b9547b0 ] CLOUDSTACK-4648: Fixed Snapshots test cases Fixed following test cases: 1) test_01_volume_from_snapshot 2) test_03_snapshot_detachedDisk 3) test_07_template_from_snapshot All three test cases are running successfully on XenServer but test cases (01 and 07) failing on KVM due to a common issue. Product defect logged for this: https://issues.apache.org/jira/browse/CLOUDSTACK-5097 test_03 is running ok on KVM too, the problem was - disk was not getting detached because it was not unmounted before detaching. Added code to unmount the disk. Signed-off-by: Girish Shilamkar - ASF Subversion and Git Services On Nov. 8, 2013, 7:07 a.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15342/ > --- > > (Updated Nov. 8, 2013, 7:07 a.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-4648 > https://issues.apache.org/jira/browse/CLOUDSTACK-4648 > > > Repository: cloudstack-git > > > Description > --- > > Fixed following test cases: > 1) test_01_volume_from_snapshot > 2) test_03_snapshot_detachedDisk > 3) test_07_template_from_snapshot > > All three test cases are running successfully on XenServer but test cases (01 > and 07) failing on KVM due to a common issue. > Product defect logged for this: > https://issues.apache.org/jira/browse/CLOUDSTACK-5097 > > test_03 is running ok on KVM too, the problem was - disk was not getting > detached because it was not unmounted before detaching. Added code to unmount > the disk. > > > Diffs > - > > test/integration/component/test_snapshots.py 1c2537c > tools/marvin/marvin/integration/lib/common.py 164ef20 > > Diff: https://reviews.apache.org/r/15342/diff/ > > > Testing > --- > > Log on Xen: > > test_01_createVM_snapshotTemplate > (test_snapshots.TestCreateVMSnapshotTemplate) > Test create VM, Snapshot and Template ... ok > test_05_snapshot_events (test_snapshots.TestSnapshotEvents) > Test snapshot events ... skipped 'Skip' > test_01_volume_from_snapshot (test_snapshots.TestSnapshots) > Test Creating snapshot from volume having spaces in name(KVM) ... skipped > 'Skip' > test_02_snapshot_data_disk (test_snapshots.TestSnapshots) > Test Snapshot Data Disk ... skipped 'Skip' > test_03_snapshot_detachedDisk (test_snapshots.TestSnapshots) > Test snapshot from detached disk ... ok > test_04_delete_snapshot (test_snapshots.TestSnapshots) > Test Delete Snapshot ... skipped 'Skip' > test_07_template_from_snapshot (test_snapshots.TestSnapshots) > Create Template from snapshot ... ok > > -- > Ran 7 tests in 529.398s > > OK (skipped=4) > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 15342: CLOUDSTACK-4648: Fixed Snapshots test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15342/#review28509 --- Commit 3c350ab0b8ce1687a8f7e27e9e2f8e8d0fa68c47 in branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3c350ab ] CLOUDSTACK-4648: Fixed Snapshots test cases Fixed following test cases: 1) test_01_volume_from_snapshot 2) test_03_snapshot_detachedDisk 3) test_07_template_from_snapshot All three test cases are running successfully on XenServer but test cases (01 and 07) failing on KVM due to a common issue. Product defect logged for this: https://issues.apache.org/jira/browse/CLOUDSTACK-5097 test_03 is running ok on KVM too, the problem was - disk was not getting detached because it was not unmounted before detaching. Added code to unmount the disk. Signed-off-by: Girish Shilamkar - ASF Subversion and Git Services On Nov. 8, 2013, 7:07 a.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15342/ > --- > > (Updated Nov. 8, 2013, 7:07 a.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-4648 > https://issues.apache.org/jira/browse/CLOUDSTACK-4648 > > > Repository: cloudstack-git > > > Description > --- > > Fixed following test cases: > 1) test_01_volume_from_snapshot > 2) test_03_snapshot_detachedDisk > 3) test_07_template_from_snapshot > > All three test cases are running successfully on XenServer but test cases (01 > and 07) failing on KVM due to a common issue. > Product defect logged for this: > https://issues.apache.org/jira/browse/CLOUDSTACK-5097 > > test_03 is running ok on KVM too, the problem was - disk was not getting > detached because it was not unmounted before detaching. Added code to unmount > the disk. > > > Diffs > - > > test/integration/component/test_snapshots.py 1c2537c > tools/marvin/marvin/integration/lib/common.py 164ef20 > > Diff: https://reviews.apache.org/r/15342/diff/ > > > Testing > --- > > Log on Xen: > > test_01_createVM_snapshotTemplate > (test_snapshots.TestCreateVMSnapshotTemplate) > Test create VM, Snapshot and Template ... ok > test_05_snapshot_events (test_snapshots.TestSnapshotEvents) > Test snapshot events ... skipped 'Skip' > test_01_volume_from_snapshot (test_snapshots.TestSnapshots) > Test Creating snapshot from volume having spaces in name(KVM) ... skipped > 'Skip' > test_02_snapshot_data_disk (test_snapshots.TestSnapshots) > Test Snapshot Data Disk ... skipped 'Skip' > test_03_snapshot_detachedDisk (test_snapshots.TestSnapshots) > Test snapshot from detached disk ... ok > test_04_delete_snapshot (test_snapshots.TestSnapshots) > Test Delete Snapshot ... skipped 'Skip' > test_07_template_from_snapshot (test_snapshots.TestSnapshots) > Create Template from snapshot ... ok > > -- > Ran 7 tests in 529.398s > > OK (skipped=4) > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 15350: CLOUDSTACK-5107: Decreased memory in service offering so as not to run out of resources
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15350/#review28539 --- Commit 9e6a1eaffe3df0981703dc26ab4cc7043d4ca23f in branch refs/heads/4.2 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9e6a1ea ] CLOUDSTACK-5107: Decreasing memory in service offering so as not to run out of resources Signed-off-by: Girish Shilamkar - ASF Subversion and Git Services On Nov. 8, 2013, 12:44 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15350/ > --- > > (Updated Nov. 8, 2013, 12:44 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5107 > https://issues.apache.org/jira/browse/CLOUDSTACK-5107 > > > Repository: cloudstack-git > > > Description > --- > > This change will prevent test cases from failing in daily runs due to running > out of resources. > Decreased the memory from 5 GB to 2 GB in service offering and made according > changes in test cases. > > > Diffs > - > > test/integration/component/test_memory_limits.py 18eab4c > test/integration/component/test_mm_domain_limits.py d87db84 > test/integration/component/test_mm_project_limits.py 1c0ed92 > > Diff: https://reviews.apache.org/r/15350/diff/ > > > Testing > --- > > Tested locally on KVM. > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 15350: CLOUDSTACK-5107: Decreased memory in service offering so as not to run out of resources
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15350/#review28540 --- Commit a2117d46f90ae6a96e3d046e306e524756609f5d in branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a2117d4 ] CLOUDSTACK-5107: Decreasing memory in service offering so as not to run out of resources Signed-off-by: Girish Shilamkar - ASF Subversion and Git Services On Nov. 8, 2013, 12:44 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15350/ > --- > > (Updated Nov. 8, 2013, 12:44 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5107 > https://issues.apache.org/jira/browse/CLOUDSTACK-5107 > > > Repository: cloudstack-git > > > Description > --- > > This change will prevent test cases from failing in daily runs due to running > out of resources. > Decreased the memory from 5 GB to 2 GB in service offering and made according > changes in test cases. > > > Diffs > - > > test/integration/component/test_memory_limits.py 18eab4c > test/integration/component/test_mm_domain_limits.py d87db84 > test/integration/component/test_mm_project_limits.py 1c0ed92 > > Diff: https://reviews.apache.org/r/15350/diff/ > > > Testing > --- > > Tested locally on KVM. > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 15393: Fix for bug CLOUDSTACK-5121
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15393/#review28636 --- Commit 175ead4ea96b72168aaa61b061b3345b1f29f5c2 in branch refs/heads/master from Santhosh Edukulla [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=175ead4 ] CLOUDSTACK-5121: There was one wrong initialization of cloudstackConnection. The bug mentioned is causing test cases to fail. Signed-off-by: Santhosh Edukulla - ASF Subversion and Git Services On Nov. 10, 2013, 7:16 p.m., Santhosh Edukulla wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15393/ > --- > > (Updated Nov. 10, 2013, 7:16 p.m.) > > > Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. > > > Bugs: CLOUDSTACK-5121 > https://issues.apache.org/jira/browse/CLOUDSTACK-5121 > > > Repository: cloudstack-git > > > Description > --- > > There were few test cases failing because of wrong way of object creation. > Fixed it. > > > Diffs > - > > tools/marvin/marvin/cloudstackConnection.py 2c027c3 > tools/marvin/marvin/cloudstackTestClient.py 3e833c7 > tools/marvin/marvin/integration/lib/utils.py 0fe3c26 > tools/marvin/marvin/sandbox/demo/simulator/testcase/libs/utils.py f26d2c0 > > Diff: https://reviews.apache.org/r/15393/diff/ > > > Testing > --- > > Yes, Worked to create deploydatacenters and few test cases thereafter > > > Thanks, > > Santhosh Edukulla > >
Re: Review Request 15393: Fix for bug CLOUDSTACK-5121
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15393/#review28639 --- Commit e82fe016920d42afd3c648d370dfc5de61e03c48 in branch refs/heads/4.2 from Santhosh Edukulla [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e82fe01 ] CLOUDSTACK-5121: There was one wrong initialization of cloudstackConnection. The bug mentioned is causing test cases to fail. Signed-off-by: Santhosh Edukulla Conflicts: tools/marvin/marvin/cloudstackConnection.py - ASF Subversion and Git Services On Nov. 10, 2013, 7:16 p.m., Santhosh Edukulla wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15393/ > --- > > (Updated Nov. 10, 2013, 7:16 p.m.) > > > Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. > > > Bugs: CLOUDSTACK-5121 > https://issues.apache.org/jira/browse/CLOUDSTACK-5121 > > > Repository: cloudstack-git > > > Description > --- > > There were few test cases failing because of wrong way of object creation. > Fixed it. > > > Diffs > - > > tools/marvin/marvin/cloudstackConnection.py 2c027c3 > tools/marvin/marvin/cloudstackTestClient.py 3e833c7 > tools/marvin/marvin/integration/lib/utils.py 0fe3c26 > tools/marvin/marvin/sandbox/demo/simulator/testcase/libs/utils.py f26d2c0 > > Diff: https://reviews.apache.org/r/15393/diff/ > > > Testing > --- > > Yes, Worked to create deploydatacenters and few test cases thereafter > > > Thanks, > > Santhosh Edukulla > >
Re: Review Request 15323: CLOUDSTACK-5080: Hypervisor Capabilities table missing entry for Simulator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15323/#review28642 --- Commit dfb81ac1274d8ebe4a47223d10f3de44aa9091bf in branch refs/heads/master from David Grizzanti [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=dfb81ac ] CLOUDSTACK-5080: Hypervisor Capabilities table missing entry for Simulator Signed-off-by: Prasanna Santhanam - ASF Subversion and Git Services On Nov. 7, 2013, 8:31 p.m., David Grizzanti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15323/ > --- > > (Updated Nov. 7, 2013, 8:31 p.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-5080 > https://issues.apache.org/jira/browse/CLOUDSTACK-5080 > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-5080: Hypervisor Capabilities table missing entry for Simulator > - Added new SQL file to db/setup so that a row gets inserted during simulator > DB setup for a 'Simulator' hypervisor (in hypervisor_capabilities). > - Updated developer/pom.xml to include this new file > > > Diffs > - > > developer/pom.xml 0eb18bf > setup/db/hypervisor_capabilities.simulator.sql PRE-CREATION > > Diff: https://reviews.apache.org/r/15323/diff/ > > > Testing > --- > > Tested on master and 4.2 > > > Thanks, > > David Grizzanti > >
Re: Review Request 15453: CLOUDSTACK-5146: Removed tags basic and sg from test case TestRouterRestart.test_01_restart_network_cleanup which should not be run on basic zone setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15453/#review28788 --- Commit 5deefb1ec56a0d96a7c4a850a6d2943bb337e1ee in branch refs/heads/4.2 from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5deefb1 ] CLOUDSTACK-5146: Removing basic and sg tags from the test case which is invalid for the basic zone TestRouterRestart.test_01_restart_network_cleanup test scenario is invalid for basic zone. The test case tries to restart the Router assigned to individual account but in basic zone, there is only one router i.e of shared network and there is only one guest(shared) network per zone. Hence the API fails to list the router of the individual account. More over, we will not try to restart the Router of the shared network because it is used by many accounts and restarting it may affect the execution of other test cases. - ASF Subversion and Git Services On Nov. 12, 2013, 1:09 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15453/ > --- > > (Updated Nov. 12, 2013, 1:09 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5146 > https://issues.apache.org/jira/browse/CLOUDSTACK-5146 > > > Repository: cloudstack-git > > > Description > --- > > TestRouterRestart.test_01_restart_network_cleanup test scenario is invalid > for basic zone. The test case tries to restart the Router assigned to > individual account but in basic zone, there is only one router i.e of shared > network and there is only one guest(shared) network per zone. Hence the API > fails to list the router of the individual account. > > More over, we will not try to restart the Router of the shared network > because it is used by many accounts and restarting it may affect the > execution of other test cases. > > > Diffs > - > > test/integration/component/test_blocker_bugs.py 62800f8 > > Diff: https://reviews.apache.org/r/15453/diff/ > > > Testing > --- > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 15453: CLOUDSTACK-5146: Removed tags basic and sg from test case TestRouterRestart.test_01_restart_network_cleanup which should not be run on basic zone setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15453/#review28789 --- Commit b894a3820ce48d777631cffb0610040c97ffafce in branch refs/heads/4.3 from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b894a38 ] CLOUDSTACK-5146: Removing basic and sg tags from the test case which is invalid for the basic zone TestRouterRestart.test_01_restart_network_cleanup test scenario is invalid for basic zone. The test case tries to restart the Router assigned to individual account but in basic zone, there is only one router i.e of shared network and there is only one guest(shared) network per zone. Hence the API fails to list the router of the individual account. More over, we will not try to restart the Router of the shared network because it is used by many accounts and restarting it may affect the execution of other test cases. - ASF Subversion and Git Services On Nov. 12, 2013, 1:09 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15453/ > --- > > (Updated Nov. 12, 2013, 1:09 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5146 > https://issues.apache.org/jira/browse/CLOUDSTACK-5146 > > > Repository: cloudstack-git > > > Description > --- > > TestRouterRestart.test_01_restart_network_cleanup test scenario is invalid > for basic zone. The test case tries to restart the Router assigned to > individual account but in basic zone, there is only one router i.e of shared > network and there is only one guest(shared) network per zone. Hence the API > fails to list the router of the individual account. > > More over, we will not try to restart the Router of the shared network > because it is used by many accounts and restarting it may affect the > execution of other test cases. > > > Diffs > - > > test/integration/component/test_blocker_bugs.py 62800f8 > > Diff: https://reviews.apache.org/r/15453/diff/ > > > Testing > --- > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 15453: CLOUDSTACK-5146: Removed tags basic and sg from test case TestRouterRestart.test_01_restart_network_cleanup which should not be run on basic zone setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15453/#review28790 --- Commit 967a5bded4b34c3e92a3860f79980d5ebe4c14e0 in branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=967a5bd ] CLOUDSTACK-5146: Removing basic and sg tags from the test case which is invalid for the basic zone TestRouterRestart.test_01_restart_network_cleanup test scenario is invalid for basic zone. The test case tries to restart the Router assigned to individual account but in basic zone, there is only one router i.e of shared network and there is only one guest(shared) network per zone. Hence the API fails to list the router of the individual account. More over, we will not try to restart the Router of the shared network because it is used by many accounts and restarting it may affect the execution of other test cases. - ASF Subversion and Git Services On Nov. 12, 2013, 1:09 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15453/ > --- > > (Updated Nov. 12, 2013, 1:09 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5146 > https://issues.apache.org/jira/browse/CLOUDSTACK-5146 > > > Repository: cloudstack-git > > > Description > --- > > TestRouterRestart.test_01_restart_network_cleanup test scenario is invalid > for basic zone. The test case tries to restart the Router assigned to > individual account but in basic zone, there is only one router i.e of shared > network and there is only one guest(shared) network per zone. Hence the API > fails to list the router of the individual account. > > More over, we will not try to restart the Router of the shared network > because it is used by many accounts and restarting it may affect the > execution of other test cases. > > > Diffs > - > > test/integration/component/test_blocker_bugs.py 62800f8 > > Diff: https://reviews.apache.org/r/15453/diff/ > > > Testing > --- > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 15454: CLOUDSTACK-5147: Removing basic and sg tag from the test case which should not be run on basic zone setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15454/#review28791 --- Commit c6195c355643a0768a805491079ba9727ae44a00 in branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c6195c3 ] CLOUDSTACK-5147: Removing basic and sg tag from the test case which should not be run on basic zone setup component.test_project_limits.TestMaxProjectNetworks.test_maxAccountNetworks tries to create multiple guest networks in an project of account which is not possible in basic zone as there is only one guest network allowed per zone in basic zone setup. Hence removing the tags basic and sg so that this test case won't be picked up to run on basic zone setup. - ASF Subversion and Git Services On Nov. 12, 2013, 1:39 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15454/ > --- > > (Updated Nov. 12, 2013, 1:39 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5147 > https://issues.apache.org/jira/browse/CLOUDSTACK-5147 > > > Repository: cloudstack-git > > > Description > --- > > component.test_project_limits.TestMaxProjectNetworks.test_maxAccountNetworks > tries to create multiple guest networks in an project of account which is not > possible in basic zone as there is only one guest network allowed per zone in > basic zone setup. > > Hence removing the tags basic and sg so that this test case won't be picked > up to run on basic zone setup. > > > Diffs > - > > test/integration/component/test_project_limits.py c6df7f3 > > Diff: https://reviews.apache.org/r/15454/diff/ > > > Testing > --- > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 15454: CLOUDSTACK-5147: Removing basic and sg tag from the test case which should not be run on basic zone setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15454/#review28792 --- Commit c2ea4fc3c7a880a2dedd9b21e7a8dca287557b39 in branch refs/heads/4.3 from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c2ea4fc ] CLOUDSTACK-5147: Removing basic and sg tag from the test case which should not be run on basic zone setup component.test_project_limits.TestMaxProjectNetworks.test_maxAccountNetworks tries to create multiple guest networks in an project of account which is not possible in basic zone as there is only one guest network allowed per zone in basic zone setup. Hence removing the tags basic and sg so that this test case won't be picked up to run on basic zone setup. - ASF Subversion and Git Services On Nov. 12, 2013, 1:39 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15454/ > --- > > (Updated Nov. 12, 2013, 1:39 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5147 > https://issues.apache.org/jira/browse/CLOUDSTACK-5147 > > > Repository: cloudstack-git > > > Description > --- > > component.test_project_limits.TestMaxProjectNetworks.test_maxAccountNetworks > tries to create multiple guest networks in an project of account which is not > possible in basic zone as there is only one guest network allowed per zone in > basic zone setup. > > Hence removing the tags basic and sg so that this test case won't be picked > up to run on basic zone setup. > > > Diffs > - > > test/integration/component/test_project_limits.py c6df7f3 > > Diff: https://reviews.apache.org/r/15454/diff/ > > > Testing > --- > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 15454: CLOUDSTACK-5147: Removing basic and sg tag from the test case which should not be run on basic zone setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15454/#review28794 --- Commit 1aec43370faf626348897489ec3d32a315cd32f4 in branch refs/heads/4.2 from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1aec433 ] CLOUDSTACK-5147: Removing basic and sg tag from the test case which should not be run on basic zone setup component.test_project_limits.TestMaxProjectNetworks.test_maxAccountNetworks tries to create multiple guest networks in an project of account which is not possible in basic zone as there is only one guest network allowed per zone in basic zone setup. Hence removing the tags basic and sg so that this test case won't be picked up to run on basic zone setup. - ASF Subversion and Git Services On Nov. 12, 2013, 1:39 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15454/ > --- > > (Updated Nov. 12, 2013, 1:39 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5147 > https://issues.apache.org/jira/browse/CLOUDSTACK-5147 > > > Repository: cloudstack-git > > > Description > --- > > component.test_project_limits.TestMaxProjectNetworks.test_maxAccountNetworks > tries to create multiple guest networks in an project of account which is not > possible in basic zone as there is only one guest network allowed per zone in > basic zone setup. > > Hence removing the tags basic and sg so that this test case won't be picked > up to run on basic zone setup. > > > Diffs > - > > test/integration/component/test_project_limits.py c6df7f3 > > Diff: https://reviews.apache.org/r/15454/diff/ > > > Testing > --- > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 15475: CLOUDSTACK-5154: Fixed test script issue related to failure in creating snapshot from volume
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15475/#review28797
---
Commit b5d3b99307668269d74b4c2fc3c71e6650b88b03 in branch refs/heads/4.2 from
Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b5d3b99 ]
CLOUDSTACK-5154: Fixed test script issue related to failure
in creating snapshot from volume
Signed-off-by: Girish Shilamkar
- ASF Subversion and Git Services
On Nov. 13, 2013, 11:48 a.m., Ashutosh Kelkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15475/
> ---
>
> (Updated Nov. 13, 2013, 11:48 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5154
> https://issues.apache.org/jira/browse/CLOUDSTACK-5154
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Fixed
> component.test_project_limits.TestResourceLimitsProject.test_05_snapshots_per_project
>
> Test was failing in creating snapshot because the volume from which the
> snapshot is getting created is incorrect. It is obtained by listing the
> volumes belonging to the project, which sometimes can list volumes belonging
> to expunging vms. Passed virtualmachineid to the list_volumes method so as to
> get the correct volume.
>
>
> Diffs
> -
>
> test/integration/component/test_project_limits.py 04e6922
>
> Diff: https://reviews.apache.org/r/15475/diff/
>
>
> Testing
> ---
>
> Tested locally on XenServer Basic Zone setup:
>
> Result log:
> test_maxAccountNetworks (test_project_limits.TestMaxProjectNetworks)
> Test Limit number of guest account specific networks ... skipped 'skip'
> test_01_project_limits (test_project_limits.TestProjectLimits)
> Test project limits for domain admin ... skipped 'skip'
> test_02_project_limits_normal_user (test_project_limits.TestProjectLimits)
> Test project limits for normal user ... skipped 'skip'
> test_03_vm_per_project (test_project_limits.TestResourceLimitsProject)
> Test VM limit per project ... skipped 'skip'
> test_04_publicip_per_project (test_project_limits.TestResourceLimitsProject)
> Test Public IP limit per project ... skipped 'skip'
> test_05_snapshots_per_project (test_project_limits.TestResourceLimitsProject)
> Test Snapshot limit per project ... ok
> test_06_volumes_per_project (test_project_limits.TestResourceLimitsProject)
> Test Volumes limit per project ... skipped 'skip'
> test_07_templates_per_project (test_project_limits.TestResourceLimitsProject)
> Test Templates limit per project ... skipped 'skip'
>
> --
> Ran 8 tests in 156.657s
>
> OK (skipped=7)
>
> Client Log:
> 2013-11-12 23:25:44,629 - DEBUG - test_05_snapshots_per_project
> (test_project_limits.TestResourceLimitsProject) - Updating snapshot resource
> limits for
> project: 540a482c-8add-4b08-9c67-1d551280eb56
> 2013-11-12 23:25:44,651 - DEBUG - test_05_snapshots_per_project
> (test_project_limits.TestResourceLimitsProject) - Deploying VM in project:
> 540a482c-8add-4b08-
> 9c67-1d551280eb56
> 2013-11-12 23:25:59,970 - DEBUG - test_05_snapshots_per_project
> (test_project_limits.TestResourceLimitsProject) -
> 6e611bc3-ebf3-4b41-9af9-3411b8093ea5
> 2013-11-12 23:25:59,989 - DEBUG - test_05_snapshots_per_project
> (test_project_limits.TestResourceLimitsProject) - [{domain :
> u'Domain-MW39F9', domainid :
> u'97742857-7330-4c22-994c-48471d5e26bb', projectid :
> u'540a482c-8add-4b08-9c67-1d551280eb56', zoneid :
> u'2c42d5dc-7377-4385-b2fa-dd6fd837380f', vmname :
> u'6e611bc3-ebf3-4b41-9af9-3411b8093ea5', id :
> u'bc2720d9-ece4-4ce0-afc3-8243f28ccf86', size : 21474836480, storage :
> u'primary0clus0', displayvolume : False,
> destroyed : False, state : u'Ready', serviceofferingdisplaytext : u'Tiny
> Instance', vmdisplayname : u'TestVM', type : u'ROOT', serviceofferingid :
> u'aac1cc50-
> 0d2e-4d47-ae0b-1e8f4f9777e7', zonename : u'test0', tags : [], isextractable :
> True, name : u'ROOT-259', virtualmachineid : u'6e611bc3-ebf3-4b41-9af9-
> 3411b8093ea5', storagetype : u'shared', hypervisor : u'XenServer', created :
> u'2013-11-13T02:59:13-0800', vmstate : u'Running', project :
> u'Project-VDCYWI',
> deviceid : 0, serviceofferingname : u'Tiny Instance'}]
> 2013-11-12 23:25:59,989 - DEBUG - test_05_snapshots_per_project
> (test_project_limits.TestResourceLimitsProject) - Creating snapshot from
> volume: bc2720d9-ece4-
> 4ce0-afc3-8243f28ccf86
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 15475: CLOUDSTACK-5154: Fixed test script issue related to failure in creating snapshot from volume
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15475/#review28798
---
Commit 57c782527554028d3cf6cf51eff59914b7b1b10e in branch refs/heads/4.3 from
Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=57c7825 ]
CLOUDSTACK-5154: Fixed test script issue related to failure
in creating snapshot from volume
Signed-off-by: Girish Shilamkar
- ASF Subversion and Git Services
On Nov. 13, 2013, 11:48 a.m., Ashutosh Kelkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15475/
> ---
>
> (Updated Nov. 13, 2013, 11:48 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5154
> https://issues.apache.org/jira/browse/CLOUDSTACK-5154
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Fixed
> component.test_project_limits.TestResourceLimitsProject.test_05_snapshots_per_project
>
> Test was failing in creating snapshot because the volume from which the
> snapshot is getting created is incorrect. It is obtained by listing the
> volumes belonging to the project, which sometimes can list volumes belonging
> to expunging vms. Passed virtualmachineid to the list_volumes method so as to
> get the correct volume.
>
>
> Diffs
> -
>
> test/integration/component/test_project_limits.py 04e6922
>
> Diff: https://reviews.apache.org/r/15475/diff/
>
>
> Testing
> ---
>
> Tested locally on XenServer Basic Zone setup:
>
> Result log:
> test_maxAccountNetworks (test_project_limits.TestMaxProjectNetworks)
> Test Limit number of guest account specific networks ... skipped 'skip'
> test_01_project_limits (test_project_limits.TestProjectLimits)
> Test project limits for domain admin ... skipped 'skip'
> test_02_project_limits_normal_user (test_project_limits.TestProjectLimits)
> Test project limits for normal user ... skipped 'skip'
> test_03_vm_per_project (test_project_limits.TestResourceLimitsProject)
> Test VM limit per project ... skipped 'skip'
> test_04_publicip_per_project (test_project_limits.TestResourceLimitsProject)
> Test Public IP limit per project ... skipped 'skip'
> test_05_snapshots_per_project (test_project_limits.TestResourceLimitsProject)
> Test Snapshot limit per project ... ok
> test_06_volumes_per_project (test_project_limits.TestResourceLimitsProject)
> Test Volumes limit per project ... skipped 'skip'
> test_07_templates_per_project (test_project_limits.TestResourceLimitsProject)
> Test Templates limit per project ... skipped 'skip'
>
> --
> Ran 8 tests in 156.657s
>
> OK (skipped=7)
>
> Client Log:
> 2013-11-12 23:25:44,629 - DEBUG - test_05_snapshots_per_project
> (test_project_limits.TestResourceLimitsProject) - Updating snapshot resource
> limits for
> project: 540a482c-8add-4b08-9c67-1d551280eb56
> 2013-11-12 23:25:44,651 - DEBUG - test_05_snapshots_per_project
> (test_project_limits.TestResourceLimitsProject) - Deploying VM in project:
> 540a482c-8add-4b08-
> 9c67-1d551280eb56
> 2013-11-12 23:25:59,970 - DEBUG - test_05_snapshots_per_project
> (test_project_limits.TestResourceLimitsProject) -
> 6e611bc3-ebf3-4b41-9af9-3411b8093ea5
> 2013-11-12 23:25:59,989 - DEBUG - test_05_snapshots_per_project
> (test_project_limits.TestResourceLimitsProject) - [{domain :
> u'Domain-MW39F9', domainid :
> u'97742857-7330-4c22-994c-48471d5e26bb', projectid :
> u'540a482c-8add-4b08-9c67-1d551280eb56', zoneid :
> u'2c42d5dc-7377-4385-b2fa-dd6fd837380f', vmname :
> u'6e611bc3-ebf3-4b41-9af9-3411b8093ea5', id :
> u'bc2720d9-ece4-4ce0-afc3-8243f28ccf86', size : 21474836480, storage :
> u'primary0clus0', displayvolume : False,
> destroyed : False, state : u'Ready', serviceofferingdisplaytext : u'Tiny
> Instance', vmdisplayname : u'TestVM', type : u'ROOT', serviceofferingid :
> u'aac1cc50-
> 0d2e-4d47-ae0b-1e8f4f9777e7', zonename : u'test0', tags : [], isextractable :
> True, name : u'ROOT-259', virtualmachineid : u'6e611bc3-ebf3-4b41-9af9-
> 3411b8093ea5', storagetype : u'shared', hypervisor : u'XenServer', created :
> u'2013-11-13T02:59:13-0800', vmstate : u'Running', project :
> u'Project-VDCYWI',
> deviceid : 0, serviceofferingname : u'Tiny Instance'}]
> 2013-11-12 23:25:59,989 - DEBUG - test_05_snapshots_per_project
> (test_project_limits.TestResourceLimitsProject) - Creating snapshot from
> volume: bc2720d9-ece4-
> 4ce0-afc3-8243f28ccf86
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 15475: CLOUDSTACK-5154: Fixed test script issue related to failure in creating snapshot from volume
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15475/#review28799
---
Commit 52b0484812641ddcffef5715d97f39a1fc38c75e in branch refs/heads/master
from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=52b0484 ]
CLOUDSTACK-5154: Fixed test script issue related to failure
in creating snapshot from volume
Signed-off-by: Girish Shilamkar
- ASF Subversion and Git Services
On Nov. 13, 2013, 11:48 a.m., Ashutosh Kelkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15475/
> ---
>
> (Updated Nov. 13, 2013, 11:48 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5154
> https://issues.apache.org/jira/browse/CLOUDSTACK-5154
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Fixed
> component.test_project_limits.TestResourceLimitsProject.test_05_snapshots_per_project
>
> Test was failing in creating snapshot because the volume from which the
> snapshot is getting created is incorrect. It is obtained by listing the
> volumes belonging to the project, which sometimes can list volumes belonging
> to expunging vms. Passed virtualmachineid to the list_volumes method so as to
> get the correct volume.
>
>
> Diffs
> -
>
> test/integration/component/test_project_limits.py 04e6922
>
> Diff: https://reviews.apache.org/r/15475/diff/
>
>
> Testing
> ---
>
> Tested locally on XenServer Basic Zone setup:
>
> Result log:
> test_maxAccountNetworks (test_project_limits.TestMaxProjectNetworks)
> Test Limit number of guest account specific networks ... skipped 'skip'
> test_01_project_limits (test_project_limits.TestProjectLimits)
> Test project limits for domain admin ... skipped 'skip'
> test_02_project_limits_normal_user (test_project_limits.TestProjectLimits)
> Test project limits for normal user ... skipped 'skip'
> test_03_vm_per_project (test_project_limits.TestResourceLimitsProject)
> Test VM limit per project ... skipped 'skip'
> test_04_publicip_per_project (test_project_limits.TestResourceLimitsProject)
> Test Public IP limit per project ... skipped 'skip'
> test_05_snapshots_per_project (test_project_limits.TestResourceLimitsProject)
> Test Snapshot limit per project ... ok
> test_06_volumes_per_project (test_project_limits.TestResourceLimitsProject)
> Test Volumes limit per project ... skipped 'skip'
> test_07_templates_per_project (test_project_limits.TestResourceLimitsProject)
> Test Templates limit per project ... skipped 'skip'
>
> --
> Ran 8 tests in 156.657s
>
> OK (skipped=7)
>
> Client Log:
> 2013-11-12 23:25:44,629 - DEBUG - test_05_snapshots_per_project
> (test_project_limits.TestResourceLimitsProject) - Updating snapshot resource
> limits for
> project: 540a482c-8add-4b08-9c67-1d551280eb56
> 2013-11-12 23:25:44,651 - DEBUG - test_05_snapshots_per_project
> (test_project_limits.TestResourceLimitsProject) - Deploying VM in project:
> 540a482c-8add-4b08-
> 9c67-1d551280eb56
> 2013-11-12 23:25:59,970 - DEBUG - test_05_snapshots_per_project
> (test_project_limits.TestResourceLimitsProject) -
> 6e611bc3-ebf3-4b41-9af9-3411b8093ea5
> 2013-11-12 23:25:59,989 - DEBUG - test_05_snapshots_per_project
> (test_project_limits.TestResourceLimitsProject) - [{domain :
> u'Domain-MW39F9', domainid :
> u'97742857-7330-4c22-994c-48471d5e26bb', projectid :
> u'540a482c-8add-4b08-9c67-1d551280eb56', zoneid :
> u'2c42d5dc-7377-4385-b2fa-dd6fd837380f', vmname :
> u'6e611bc3-ebf3-4b41-9af9-3411b8093ea5', id :
> u'bc2720d9-ece4-4ce0-afc3-8243f28ccf86', size : 21474836480, storage :
> u'primary0clus0', displayvolume : False,
> destroyed : False, state : u'Ready', serviceofferingdisplaytext : u'Tiny
> Instance', vmdisplayname : u'TestVM', type : u'ROOT', serviceofferingid :
> u'aac1cc50-
> 0d2e-4d47-ae0b-1e8f4f9777e7', zonename : u'test0', tags : [], isextractable :
> True, name : u'ROOT-259', virtualmachineid : u'6e611bc3-ebf3-4b41-9af9-
> 3411b8093ea5', storagetype : u'shared', hypervisor : u'XenServer', created :
> u'2013-11-13T02:59:13-0800', vmstate : u'Running', project :
> u'Project-VDCYWI',
> deviceid : 0, serviceofferingname : u'Tiny Instance'}]
> 2013-11-12 23:25:59,989 - DEBUG - test_05_snapshots_per_project
> (test_project_limits.TestResourceLimitsProject) - Creating snapshot from
> volume: bc2720d9-ece4-
> 4ce0-afc3-8243f28ccf86
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 15478: CLOUDSTACK-5156: Fixed test script issue related to detach volume
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15478/#review28801 --- Commit 2e373d58e0cc5843e4c59a9e6aaca64d003db785 in branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2e373d5 ] CLOUDSTACK-5156: Fixed test script issue related to detach volume - ASF Subversion and Git Services On Nov. 13, 2013, 2:06 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15478/ > --- > > (Updated Nov. 13, 2013, 2:06 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5156 > https://issues.apache.org/jira/browse/CLOUDSTACK-5156 > > > Repository: cloudstack-git > > > Description > --- > > component.test_stopped_vm.TestDeployVM.test_08_deploy_attached_volume > This test was failing during detaching volume from a virtual machine. > But the volume which was being detached from the virtual machine was obtained > from listing the volumes belonging to the same account and picking up the > first element in the list which does not guarantee that it is the same volume > belonging to the VM as the same account is used in many test cases. > > Passed virtualmachineid parameter to get the exact volume belonging to the > virtual machine and now the test case works. > > > Diffs > - > > test/integration/component/test_stopped_vm.py 2586c0b > > Diff: https://reviews.apache.org/r/15478/diff/ > > > Testing > --- > > Tested locally on XenServer basic zone setup. > > Log: > > ==> client.log <== > 2013-11-13 02:03:42,866 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Verify listVirtualMachines response for > virtual machine: 20930 > 0b9-0f42-4c73-941d-93c75b168203 > 2013-11-13 02:03:42,866 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Deploying instance in the account: > test-P6HACO > 2013-11-13 02:04:08,353 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Deployed instance in account: test-P6HACO > 2013-11-13 02:04:08,395 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Verify listVirtualMachines response for > virtual machine: 8f68e > fd6-9d64-44e1-9998-ce03d0158cb8 > 2013-11-13 02:04:08,395 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Fetching DATADISK details for instance: > 8f68efd6-9d64-44e1-999 > 8-ce03d0158cb8 > 2013-11-13 02:04:08,418 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Detaching the disk: DATA-263 > 2013-11-13 02:04:13,537 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Datadisk DATA-263 detached! > 2013-11-13 02:04:13,537 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Attaching volume to instance: > 209300b9-0f42-4c73-941d-93c75b16 > 8203 > 2013-11-13 02:04:18,668 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Cleaning up the resources > 2013-11-13 02:04:33,825 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Cleanup complete! > > ==> result.log <== > Test Deploy Virtual Machine with no startVM parameter ... skipped 'Skip' > test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) > Test Upload volume and attach to VM in stopped state ... skipped 'Skip' > test_vm_per_account (test_stopped_vm.TestVMAccountLimit) > Test VM limit per account ... skipped 'Skip' > > -- > Ran 17 tests in 56.691s > > OK (skipped=16) > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 15478: CLOUDSTACK-5156: Fixed test script issue related to detach volume
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15478/#review28802 --- Commit 4d21591bf81af12469c913e4ccfb50e1a76dce73 in branch refs/heads/4.3 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4d21591 ] CLOUDSTACK-5156: Fixed test script issue related to detach volume - ASF Subversion and Git Services On Nov. 13, 2013, 2:06 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15478/ > --- > > (Updated Nov. 13, 2013, 2:06 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5156 > https://issues.apache.org/jira/browse/CLOUDSTACK-5156 > > > Repository: cloudstack-git > > > Description > --- > > component.test_stopped_vm.TestDeployVM.test_08_deploy_attached_volume > This test was failing during detaching volume from a virtual machine. > But the volume which was being detached from the virtual machine was obtained > from listing the volumes belonging to the same account and picking up the > first element in the list which does not guarantee that it is the same volume > belonging to the VM as the same account is used in many test cases. > > Passed virtualmachineid parameter to get the exact volume belonging to the > virtual machine and now the test case works. > > > Diffs > - > > test/integration/component/test_stopped_vm.py 2586c0b > > Diff: https://reviews.apache.org/r/15478/diff/ > > > Testing > --- > > Tested locally on XenServer basic zone setup. > > Log: > > ==> client.log <== > 2013-11-13 02:03:42,866 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Verify listVirtualMachines response for > virtual machine: 20930 > 0b9-0f42-4c73-941d-93c75b168203 > 2013-11-13 02:03:42,866 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Deploying instance in the account: > test-P6HACO > 2013-11-13 02:04:08,353 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Deployed instance in account: test-P6HACO > 2013-11-13 02:04:08,395 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Verify listVirtualMachines response for > virtual machine: 8f68e > fd6-9d64-44e1-9998-ce03d0158cb8 > 2013-11-13 02:04:08,395 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Fetching DATADISK details for instance: > 8f68efd6-9d64-44e1-999 > 8-ce03d0158cb8 > 2013-11-13 02:04:08,418 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Detaching the disk: DATA-263 > 2013-11-13 02:04:13,537 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Datadisk DATA-263 detached! > 2013-11-13 02:04:13,537 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Attaching volume to instance: > 209300b9-0f42-4c73-941d-93c75b16 > 8203 > 2013-11-13 02:04:18,668 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Cleaning up the resources > 2013-11-13 02:04:33,825 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Cleanup complete! > > ==> result.log <== > Test Deploy Virtual Machine with no startVM parameter ... skipped 'Skip' > test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) > Test Upload volume and attach to VM in stopped state ... skipped 'Skip' > test_vm_per_account (test_stopped_vm.TestVMAccountLimit) > Test VM limit per account ... skipped 'Skip' > > -- > Ran 17 tests in 56.691s > > OK (skipped=16) > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 15478: CLOUDSTACK-5156: Fixed test script issue related to detach volume
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15478/#review28804 --- Commit 9e2b7bfa7b740b732de98eb4e138373dc920dc7e in branch refs/heads/4.2 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9e2b7bf ] CLOUDSTACK-5156: Fixed test script issue related to detach volume - ASF Subversion and Git Services On Nov. 13, 2013, 2:06 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15478/ > --- > > (Updated Nov. 13, 2013, 2:06 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5156 > https://issues.apache.org/jira/browse/CLOUDSTACK-5156 > > > Repository: cloudstack-git > > > Description > --- > > component.test_stopped_vm.TestDeployVM.test_08_deploy_attached_volume > This test was failing during detaching volume from a virtual machine. > But the volume which was being detached from the virtual machine was obtained > from listing the volumes belonging to the same account and picking up the > first element in the list which does not guarantee that it is the same volume > belonging to the VM as the same account is used in many test cases. > > Passed virtualmachineid parameter to get the exact volume belonging to the > virtual machine and now the test case works. > > > Diffs > - > > test/integration/component/test_stopped_vm.py 2586c0b > > Diff: https://reviews.apache.org/r/15478/diff/ > > > Testing > --- > > Tested locally on XenServer basic zone setup. > > Log: > > ==> client.log <== > 2013-11-13 02:03:42,866 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Verify listVirtualMachines response for > virtual machine: 20930 > 0b9-0f42-4c73-941d-93c75b168203 > 2013-11-13 02:03:42,866 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Deploying instance in the account: > test-P6HACO > 2013-11-13 02:04:08,353 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Deployed instance in account: test-P6HACO > 2013-11-13 02:04:08,395 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Verify listVirtualMachines response for > virtual machine: 8f68e > fd6-9d64-44e1-9998-ce03d0158cb8 > 2013-11-13 02:04:08,395 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Fetching DATADISK details for instance: > 8f68efd6-9d64-44e1-999 > 8-ce03d0158cb8 > 2013-11-13 02:04:08,418 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Detaching the disk: DATA-263 > 2013-11-13 02:04:13,537 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Datadisk DATA-263 detached! > 2013-11-13 02:04:13,537 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Attaching volume to instance: > 209300b9-0f42-4c73-941d-93c75b16 > 8203 > 2013-11-13 02:04:18,668 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Cleaning up the resources > 2013-11-13 02:04:33,825 - DEBUG - test_08_deploy_attached_volume > (test_stopped_vm.TestDeployVM) - Cleanup complete! > > ==> result.log <== > Test Deploy Virtual Machine with no startVM parameter ... skipped 'Skip' > test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) > Test Upload volume and attach to VM in stopped state ... skipped 'Skip' > test_vm_per_account (test_stopped_vm.TestVMAccountLimit) > Test VM limit per account ... skipped 'Skip' > > -- > Ran 17 tests in 56.691s > > OK (skipped=16) > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 15477: CLOUDSTACK-5155: Removing basic and sg tags from test case which is invalid for basic zone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15477/#review28807 --- Commit 6aff6aa601a165f00bfaad6543e4b2a33d798806 in branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6aff6aa ] CLOUDSTACK-5155: Removing basic and sg tags from test case which is invalid for basic zone - ASF Subversion and Git Services On Nov. 13, 2013, 1:43 p.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15477/ > --- > > (Updated Nov. 13, 2013, 1:43 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5155 > https://issues.apache.org/jira/browse/CLOUDSTACK-5155 > > > Repository: cloudstack-git > > > Description > --- > > component.test_stopped_vm.TestRouterStateAfterDeploy.test_01_deploy_vm_no_startvm > This test case assumes that each new VM deployment will create a router in > that account, which is invalid scenario for the basic zone. > Removing basic and sg tags. > > > Diffs > - > > test/integration/component/test_stopped_vm.py 2586c0b > > Diff: https://reviews.apache.org/r/15477/diff/ > > > Testing > --- > > > Thanks, > > Gaurav Aradhye > >
