Re: [PR] Allow users to send requests from CMK using POST requests. [cloudstack-cloudmonkey]

2025-04-29 Thread via GitHub 


DaanHoogland commented on code in PR #161:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/pull/161#discussion_r2065677030


##
config/config.go:
##
@@ -284,7 +284,7 @@ func saveConfig(cfg *Config) *Config {
core.AutoComplete = true
core.Output = JSON
}
-   if conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") {
+   if !conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") { {

Review Comment:
   ```suggestion
if !conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Allow users to send requests from CMK using POST requests. [cloudstack-cloudmonkey]

2025-04-29 Thread via GitHub 


sureshanaparti commented on code in PR #161:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/pull/161#discussion_r2065928001


##
config/config.go:
##
@@ -284,7 +284,7 @@ func saveConfig(cfg *Config) *Config {
core.AutoComplete = true
core.Output = JSON
}
-   if conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") {
+   if !conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") { {

Review Comment:
   @kevin-lii seems some confusion here, core here is not reflected from the 
_defaultCoreConfig()_, and core.PostRequest is false by default. possible to 
check the conf section has  postrequest and is true, to set `core.PostRequest = 
true`? Are you able to verify the GET & POST calls with this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Allow users to send requests from CMK using POST requests. [cloudstack-cloudmonkey]

2025-04-29 Thread via GitHub 


sureshanaparti commented on code in PR #161:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/pull/161#discussion_r2065928001


##
config/config.go:
##
@@ -284,7 +284,7 @@ func saveConfig(cfg *Config) *Config {
core.AutoComplete = true
core.Output = JSON
}
-   if conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") {
+   if !conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") { {

Review Comment:
   @kevin-lii seems some confusion here, core here is not reflected from the 
_defaultCoreConfig()_, and core.PostRequest is false by default. possible to 
check the conf section has  postrequest and is true, to set `core.PostRequest = 
true`? Are you able to verify the GET & POST calls with this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Allow users to send requests from CMK using POST requests. [cloudstack-cloudmonkey]

2025-04-29 Thread via GitHub 


sureshanaparti commented on code in PR #161:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/pull/161#discussion_r2065928001


##
config/config.go:
##
@@ -284,7 +284,7 @@ func saveConfig(cfg *Config) *Config {
core.AutoComplete = true
core.Output = JSON
}
-   if conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") {
+   if !conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") { {

Review Comment:
   @kevin-lii seems some confusion here, core here is not reflected from the 
_defaultCoreConfig()_, and core.PostRequest is false by default. possible to 
check the conf section has  postrequest and is true, to set `core.PostRequest = 
true`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Allow users to send requests from CMK using POST requests. [cloudstack-cloudmonkey]

2025-04-29 Thread via GitHub 


sureshanaparti commented on code in PR #161:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/pull/161#discussion_r2065936280


##
config/config.go:
##
@@ -282,6 +284,9 @@ func saveConfig(cfg *Config) *Config {
core.AutoComplete = true
core.Output = JSON
}
+   if !conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") { {
+   core.PostRequest = false
+   }

Review Comment:
   @kevin-lii seems some confusion here, core here is not reflected from the 
defaultCoreConfig(), and core.PostRequest is false by default. possible to 
check the conf section has _postrequest_ key and it's value is true, to set 
core.PostRequest = true? Are you able to verify the GET & POST calls with this 
change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Allow users to send requests from CMK using POST requests. [cloudstack-cloudmonkey]

2025-04-29 Thread via GitHub 


sureshanaparti commented on code in PR #161:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/pull/161#discussion_r2065933526


##
config/config.go:
##
@@ -284,7 +284,7 @@ func saveConfig(cfg *Config) *Config {
core.AutoComplete = true
core.Output = JSON
}
-   if conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") {
+   if !conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") { {

Review Comment:
   @kevin-lii check this, build fails



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Changing executeAPI to utilize POST request [cloudstack-csbench]

2025-04-29 Thread via GitHub 


sureshanaparti commented on code in PR #18:
URL: https://github.com/apache/cloudstack-csbench/pull/18#discussion_r2065907383


##
apirunner/apirunner.go:
##
@@ -124,11 +125,12 @@ func executeAPIandCalculate(profileName string, apiURL 
string, command string, p
var avgTime float64
var totalTime float64
var count float64
+   isGetRequest, _ := regexp.MatchString("^(get|list|query|find)(\\w+)+$", 
command)

Review Comment:
   @kevin-lii can you check and address this ^^^



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Multi Management Server

2025-04-29 Thread TechnologyRss 
I am try to using guide but I see error log

Please see my mgmt log and then help me what's my wrong.

https://drive.google.com/file/d/1a1OvT05H3k7QlZ3NSycs6enDAyK3jrZ3/view?usp=drive_link


--


*Thanks & Regards.**Support Admin*
--


*Facebook  | Twitter
 | YouTube
 | LinkedIn
**Address : *Rayerbagh
Complex Super Market
Level #04, Shop No #66, Rayerbagh Bus Stand
Dhaka. Bangladesh
*Mob :* +88 01716915504
*Email :* support.ad...@technologyrss.com
*Web :* www.technologyrss.com


On Mon, Apr 28, 2025 at 11:15 AM Jithin Raju 
wrote:

> Hi ,
>
> Install an additional management server, use Galera Cluster with Maria DB
> if that’s what you are looking for, since you mentioned 3 nodes.
>
>
> https://docs.cloudstack.apache.org/en/4.20.0.0/installguide/management-server/index.html#additional-management-servers
>
>
> https://github.com/apache/cloudstack/discussions/10471#discussioncomment-12377352
>
>
> -Jithin
>
>
>
>
> From: TechnologyRss 
> Date: Sunday, 27 April 2025 at 6:39 PM
> To: users , dev ,
> Wei ZHOU 
> Subject: Multi Management Server
> Hello,
>
> Which process can I use in my below configuration?
>
> 2 nodes for management 3 nodes for database
>
> any idea please let me know...
> --
>
>
> *Thanks & Regards.**Support Admin*
> --
>
>
> *Facebook  | Twitter
>  | YouTube
>  | LinkedIn
> **Address : *Rayerbagh
> Complex Super Market
> Level #04, Shop No #66, Rayerbagh Bus Stand
> Dhaka. Bangladesh
> *Mob :* +88 01716915504
> *Email :* support.ad...@technologyrss.com
> *Web :* www.technologyrss.com
>

Re: [PR] release 1.1.1 for playtika [cloudstack-kubernetes-provider]

2025-04-29 Thread via GitHub 


CodeBleu commented on PR #72:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/72#issuecomment-2840133563

   @Pearl1594 @rohityadavcloud 
   Am I missing something here?  I was needing the changes in this 
https://github.com/apache/cloudstack-kubernetes-provider/commit/a315d9e1c2aa3d571abf2ef992c230d5cbcf58c6
 and see that it was tagged` v1.1.1` however it has not been updated in the 
`releases`, but shows under `tags` and now I see this PR is closed.
   
   For my testing, I manually updated the 
[deployment.yaml](https://github.com/apache/cloudstack-kubernetes-provider/blob/a315d9e1c2aa3d571abf2ef992c230d5cbcf58c6/deployment.yaml#L146)
 so it would pull from here:
   
![image](https://github.com/user-attachments/assets/e9b58699-2b4f-4480-b5a9-5e0837b067b2)
   
   Just trying to understand if this `v1.1.1` was just forgotten to update the 
in the `releases`, or there is an issues that caused the close of this PR and 
it shouldn't be used?
   
   
![image](https://github.com/user-attachments/assets/d9a95cf5-e888-48ad-916a-0071f9cc1a61)
   
![image](https://github.com/user-attachments/assets/0e861c06-bdf2-44d2-ad7f-8677d712bb7d)
   
![image](https://github.com/user-attachments/assets/cdb311a6-bf59-4456-8208-43c331eb5e4b)
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org