[PR] Instructions about alerts via SMTP and Thresholds [cloudstack-documentation]
daviftorres opened a new pull request, #498: URL: https://github.com/apache/cloudstack-documentation/pull/498 Currently there is no instructions about how to setup the Administrator Alerts. The list of alert type numbers was transformed into a table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update kvm.rst - iptables before rule [cloudstack-documentation]
dtorressn commented on PR #479: URL: https://github.com/apache/cloudstack-documentation/pull/479#issuecomment-2809965029 @DaanHoogland do you think you can help with this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Modify State Changing Requests to Utilize POST Request [cloudstack-go]
kevin-lii commented on code in PR #107:
URL: https://github.com/apache/cloudstack-go/pull/107#discussion_r2047779261
##
generate/generate.go:
##
@@ -560,7 +560,7 @@ func (as *allServices) GeneralCode() ([]byte, error) {
pn("// Execute the request against a CS API. Will return the raw JSON
data returned by the API and nil if")
pn("// no error occurred. If the API returns an error the result will
be nil and the HTTP error code and CS")
pn("// error details. If a processing (code) error occurs the result
will be nil and the generated error")
- pn("func (cs *CloudStackClient) newRequest(api string, params
url.Values) (json.RawMessage, error) {")
+ pn("func (cs *CloudStackClient) newPostRequest(api string, params
url.Values) (json.RawMessage, error) {")
Review Comment:
Sorry I think I accidentally replaced that. I will fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Modify State Changing Requests to Utilize POST Request [cloudstack-go]
rohityadavcloud commented on code in PR #107:
URL: https://github.com/apache/cloudstack-go/pull/107#discussion_r2046235561
##
generate/generate.go:
##
@@ -560,7 +560,7 @@ func (as *allServices) GeneralCode() ([]byte, error) {
pn("// Execute the request against a CS API. Will return the raw JSON
data returned by the API and nil if")
pn("// no error occurred. If the API returns an error the result will
be nil and the HTTP error code and CS")
pn("// error details. If a processing (code) error occurs the result
will be nil and the generated error")
- pn("func (cs *CloudStackClient) newRequest(api string, params
url.Values) (json.RawMessage, error) {")
+ pn("func (cs *CloudStackClient) newPostRequest(api string, params
url.Values) (json.RawMessage, error) {")
Review Comment:
@kevin-lii should all API calls be POST by default? Or, we should compare if
it's a list/get API ?
cc @Pearl1594 @weizhouapache @sureshanaparti @vishesh92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] chore(deps): bump golang.org/x/net from 0.23.0 to 0.38.0 [cloudstack-terraform-provider]
dependabot[bot] opened a new pull request, #171: URL: https://github.com/apache/cloudstack-terraform-provider/pull/171 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.23.0 to 0.38.0. Commits https://github.com/golang/net/commit/e1fcd82abba34df74614020343be8eb1fe85f0d9";>e1fcd82 html: properly handle trailing solidus in unquoted attribute value in foreign... https://github.com/golang/net/commit/ebed060e8f30f20235f74808c22125fd86b15edd";>ebed060 internal/http3: fix build of tests with GOEXPERIMENT=nosynctest https://github.com/golang/net/commit/1f1fa29e0a46fffe18c43a9da8daa5a0b180dfa9";>1f1fa29 publicsuffix: regenerate table https://github.com/golang/net/commit/12150816f701c912a32a376754ab28dd3878833a";>1215081 http2: improve error when server sends HTTP/1 https://github.com/golang/net/commit/312450e473eae9f9e6173ad895c80bc5ea2f79ad";>312450e html: ensuretag closes and update tests https://github.com/golang/net/commit/09731f9bf919b00b344c763894cd1920b3d96d90";>09731f9 http2: improve handling of lost PING in Server https://github.com/golang/net/commit/55989e24b972a90ab99308fdc7ea1fb58a96fef1";>55989e2 http2/h2c: use ResponseController for hijacking connections https://github.com/golang/net/commit/2914f46773171f4fa13e276df1135bafef677801";>2914f46 websocket: re-recommend gorilla/websocket https://github.com/golang/net/commit/99b3ae0643f9a2f9d820fcbba5f9e4c83b23bd48";>99b3ae0 go.mod: update golang.org/x dependencies https://github.com/golang/net/commit/85d1d54551b68719346cb9fec24b911da4e452a1";>85d1d54 go.mod: update golang.org/x dependencies Additional commits viewable in https://github.com/golang/net/compare/v0.23.0...v0.38.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/cloudstack-terraform-provider/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump golang.org/x/net from 0.26.0 to 0.36.0 [cloudstack-go]
dependabot[bot] commented on PR #106: URL: https://github.com/apache/cloudstack-go/pull/106#issuecomment-2810947852 Superseded by #108. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump golang.org/x/net from 0.26.0 to 0.38.0 [cloudstack-go]
dependabot[bot] opened a new pull request, #108: URL: https://github.com/apache/cloudstack-go/pull/108 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.26.0 to 0.38.0. Commits https://github.com/golang/net/commit/e1fcd82abba34df74614020343be8eb1fe85f0d9";>e1fcd82 html: properly handle trailing solidus in unquoted attribute value in foreign... https://github.com/golang/net/commit/ebed060e8f30f20235f74808c22125fd86b15edd";>ebed060 internal/http3: fix build of tests with GOEXPERIMENT=nosynctest https://github.com/golang/net/commit/1f1fa29e0a46fffe18c43a9da8daa5a0b180dfa9";>1f1fa29 publicsuffix: regenerate table https://github.com/golang/net/commit/12150816f701c912a32a376754ab28dd3878833a";>1215081 http2: improve error when server sends HTTP/1 https://github.com/golang/net/commit/312450e473eae9f9e6173ad895c80bc5ea2f79ad";>312450e html: ensuretag closes and update tests https://github.com/golang/net/commit/09731f9bf919b00b344c763894cd1920b3d96d90";>09731f9 http2: improve handling of lost PING in Server https://github.com/golang/net/commit/55989e24b972a90ab99308fdc7ea1fb58a96fef1";>55989e2 http2/h2c: use ResponseController for hijacking connections https://github.com/golang/net/commit/2914f46773171f4fa13e276df1135bafef677801";>2914f46 websocket: re-recommend gorilla/websocket https://github.com/golang/net/commit/99b3ae0643f9a2f9d820fcbba5f9e4c83b23bd48";>99b3ae0 go.mod: update golang.org/x dependencies https://github.com/golang/net/commit/85d1d54551b68719346cb9fec24b911da4e452a1";>85d1d54 go.mod: update golang.org/x dependencies Additional commits viewable in https://github.com/golang/net/compare/v0.26.0...v0.38.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/cloudstack-go/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump golang.org/x/net from 0.26.0 to 0.36.0 [cloudstack-go]
dependabot[bot] closed pull request #106: Bump golang.org/x/net from 0.26.0 to 0.36.0 URL: https://github.com/apache/cloudstack-go/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
