Re: [PR] Changing executeAPI to utilize POST request [cloudstack-csbench]
rohityadavcloud commented on code in PR #18:
URL: https://github.com/apache/cloudstack-csbench/pull/18#discussion_r2046178000
##
apirunner/apirunner.go:
##
@@ -253,10 +253,14 @@ func saveData(apiURL string, count float64, minTime
float64, maxTime float64, av
func executeAPI(apiURL string, params url.Values) (float64, float64, bool) {
// Send the API request and calculate the time
- apiURL = fmt.Sprintf("%s?%s", apiURL, params.Encode())
+ data := strings.NewReader(params.Encode())
log.Infof("Running the API %s", apiURL)
start := time.Now()
- resp, err := http.Get(apiURL)
+ resp, err := http.Post(
Review Comment:
Should all APIs be Post?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Updating LDAP integration instructions [cloudstack-documentation]
davift commented on PR #494: URL: https://github.com/apache/cloudstack-documentation/pull/494#issuecomment-2805011369 All good! Thank YOU for your hard excellent work keeping this project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): bump golang.org/x/crypto from 0.21.0 to 0.35.0 [cloudstack-terraform-provider]
DaanHoogland closed pull request #170: chore(deps): bump golang.org/x/crypto from 0.21.0 to 0.35.0 URL: https://github.com/apache/cloudstack-terraform-provider/pull/170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): bump golang.org/x/crypto from 0.21.0 to 0.35.0 [cloudstack-terraform-provider]
dependabot[bot] commented on PR #170: URL: https://github.com/apache/cloudstack-terraform-provider/pull/170#issuecomment-2804489576 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updating LDAP integration instructions [cloudstack-documentation]
DaanHoogland commented on PR #494: URL: https://github.com/apache/cloudstack-documentation/pull/494#issuecomment-2804487456 btw @daviftorres , as this is based on main it will not reach the docs for the next dot-releases, only for v21. If you wish you can rebase it on 4.19 to have it in earlier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updating LDAP integration instructions [cloudstack-documentation]
DaanHoogland commented on PR #494: URL: https://github.com/apache/cloudstack-documentation/pull/494#issuecomment-2804479294 tnx @daviftorres -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Changing executeAPI to utilize POST request [cloudstack-csbench]
kevin-lii opened a new pull request, #18: URL: https://github.com/apache/cloudstack-csbench/pull/18 Changing executeAPI to utilize POST request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Modify State Changing Requests to Utilize POST Request [cloudstack-go]
kevin-lii opened a new pull request, #107: URL: https://github.com/apache/cloudstack-go/pull/107 Currently State Changing Request utilize GET request but this is a potential security vulnerability since attackers may be able to intercept and extract the query parameters of GET requests. Utilizing POST requests will help mitigate this security vulnerability since the parameters of the POST body will be encrypted in transport. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add more sudoers documentation [cloudstack-documentation]
deajan opened a new pull request, #497: URL: https://github.com/apache/cloudstack-documentation/pull/497 Improve documentation to setup security hardened KVM hypervisors (OpenSCAP profiles) which limit sudo commands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updating LDAP integration instructions [cloudstack-documentation]
DaanHoogland merged PR #494: URL: https://github.com/apache/cloudstack-documentation/pull/494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
