Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-04-27 Thread via GitHub


fabiomatavelli commented on code in PR #71:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1581799304


##
.github/workflows/acceptance.yml:
##
@@ -73,18 +81,35 @@ jobs:
   - name: Create extra resources
 run: |
   cmk -u $CLOUDSTACK_API_URL -k $CLOUDSTACK_API_KEY -s 
$CLOUDSTACK_SECRET_KEY -o json create project name=terraform 
displaytext=terraform
+  - uses: hashicorp/setup-terraform@v2
+with:
+  terraform_version: ${{ matrix.terraform-version }}
+  terraform_wrapper: false
   - name: Run acceptance test
 run: |
   make testacc
 services:
   cloudstack-simulator:
-image: apache/cloudstack-simulator:${{ matrix.cloudstack_version }}
+image: apache/cloudstack-simulator:${{ matrix.cloudstack-version }}
 ports:
   - 8080:5050
 strategy:
   fail-fast: false
   matrix:
-cloudstack_version:
+terraform-version:
+  - '0.12.*'
+  - '0.13.*'
+  - '0.14.*'
+  - '0.15.*'
+  - '1.0.*'
+  - '1.1.*'
+  - '1.2.*'
+  - '1.3.*'
+  - '1.4.*'
+  - '1.5.*'
+  - '1.6.*'
+  - '1.7.*'

Review Comment:
   good catch @CodeBleu, I've added it now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-04-27 Thread via GitHub


fabiomatavelli commented on PR #71:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2080450193

   @rohityadavcloud I've added the OpenTofu acceptance test CI also as 
suggested by @CodeBleu . If you can allow the actions again so we can check the 
run 🙏 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-04-27 Thread via GitHub


fabiomatavelli commented on PR #71:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2080915377

   Looks like the `opentofu/setup-opentofu@v1` action is not allowed. Is it 
possible to allow it @rohityadavcloud ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org