Re: [PR] add api call createConsoleEndpoint [cloudstack-go]
vishesh92 merged PR #78: URL: https://github.com/apache/cloudstack-go/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Restore methods with optional params for 4.19 compatability [cloudstack-go]
weizhouapache commented on PR #80: URL: https://github.com/apache/cloudstack-go/pull/80#issuecomment-1993901948 @vishesh92 clustertype is always an optional parameter, right? In the official ACS/cloudstack-go releases I mean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Restore methods with optional params for 4.19 compatability [cloudstack-go]
weizhouapache commented on PR #80:
URL: https://github.com/apache/cloudstack-go/pull/80#issuecomment-1994006010
I checked the diff betwen this PR and latest v2.15.0
1. guest OS (**_no need to fix I think_**)
```
type GuestOSServiceIface interface {
AddGuestOs(p *AddGuestOsParams) (*AddGuestOsResponse, error)
- NewAddGuestOsParams(details map[string]string, oscategoryid string,
osdisplayname string) *AddGuestOsParams
+ NewAddGuestOsParams(oscategoryid string, osdisplayname string)
*AddGuestOsParams
AddGuestOsMapping(p *AddGuestOsMappingParams)
(*AddGuestOsMappingResponse, error)
...
- NewUpdateGuestOsParams(details map[string]string, id string,
osdisplayname string) *UpdateGuestOsParams
+ NewUpdateGuestOsParams(id string, osdisplayname string)
*UpdateGuestOsParams
```
2. CKS
```
diff --git a/cloudstack/KubernetesService.go
b/cloudstack/KubernetesService.go
index 07bcd3e..4dcf1f1 100644
--- a/cloudstack/KubernetesService.go
+++ b/cloudstack/KubernetesService.go
@@ -31,7 +31,7 @@ type KubernetesServiceIface interface {
AddKubernetesSupportedVersion(p
*AddKubernetesSupportedVersionParams) (*AddKubernetesSupportedVersionResponse,
error)
NewAddKubernetesSupportedVersionParams(mincpunumber int, minmemory
int, semanticversion string) *AddKubernetesSupportedVersionParams
CreateKubernetesCluster(p *CreateKubernetesClusterParams)
(*CreateKubernetesClusterResponse, error)
- NewCreateKubernetesClusterParams(description string,
kubernetesversionid string, name string, serviceofferingid string, size int64,
zoneid string) *CreateKubernetesClusterParams
+ NewCreateKubernetesClusterParams(clustertype string, name string,
zoneid string) *CreateKubernetesClusterParams
DeleteKubernetesCluster(p *DeleteKubernetesClusterParams)
(*DeleteKubernetesClusterResponse, error)
NewDeleteKubernetesClusterParams(id string)
*DeleteKubernetesClusterParams
DeleteKubernetesSupportedVersion(p
*DeleteKubernetesSupportedVersionParams)
(*DeleteKubernetesSupportedVersionResponse, error)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PROPOSE] ACS 4.18.2.0
Hi Wei, all, Considering that there are some security issues, we can postpone the 4.18.2.0 release for another week. We will have two weeks before the first RC cut. Would that be enough time to solve all concerns? I'd rather not postpone the release too much or it might affect the next ones (4.19.1.0 and 4.20.0.0). Best regards, João Jandre On 3/12/24 09:40, Wei ZHOU wrote: Hi João, Unfortunately yes, there are SOME other security issues. The PMC is working on the fixes. I suggest we postpone the 4.18.2.0 release, otherwise we most likely will have a 4.18.2.1 release. -Wei On Tue, Mar 12, 2024 at 1:21 PM João Jandre Paraquetti wrote: Hi Wei, Are you referring to #8729? If so, it was marked as critical (a few minutes ago); therefore, as I announced yesterday: "From now onward, we will only accept critical/blocker issues or any stabilization fixes" we are still accepting fixes for critical/blocker issues, and we will not release the RC until #8729 is fixed; same for #8745. Thus, we can keep the freeze anyway. Or is there other security issues that I'm missing? Best regards, João Jandre On 3/12/24 08:45, Wei ZHOU wrote: Hi João, As you might know, we/community are working on some security issues. Please hold on. -Wei On Mon, Mar 11, 2024 at 7:19 PM João Jandre Paraquetti wrote: Hi all, I would like to announce the code freeze of the 4.18 branch now. From now onward, we will only accept critical/blocker issues or any stabilization fixes. We have 70 open items in the 4.18.2.0 milestone [1] at the moment. Most of them will be moved to the next milestone. Currently, there is one critical issue [1]. Which has an open PR to fix the same. I count on your support on working towards cutting RC1 in the coming week. Regards, João Jandre [1] https://github.com/apache/cloudstack/milestone/29 [2] https://github.com/apache/cloudstack/issues/8745 On 2/8/24 16:06, João Jandre Paraquetti wrote: Hi, Rohit, all I don't see any critical problems that should be addressed ASAP on the 4.18 branch; therefore, there should be no problem with postponing 4.18.2 a little bit. We still have several issues targeted at 4.18.2 that have yet to be addressed, so a couple more weeks before the freeze could be good. Yes, I still want to be the RM for 4.18.2. I triaged all the issues a couple of weeks ago and removed/added some issues to the milestone as I deemed necessary, but as Rohit said, if anyone has any issues/PRs they want in 4.18.2, please ping me so we can discuss/address any concerns. That being said, here's the updated schedule I propose: - Until the second week of March: accept bug fixes and minor improvements; - Third week of March: accept only blocker and critical bug fixes, aiming to stabilize the branch; - End of March: start cutting RCs, vote, and finish release work. Best regards, João Jandre On 2/8/24 03:22, Rohit Yadav wrote: Hi Joao, all, Given we’re only now more available after the major 4.19 release to work on other releases, could we reconsider the timeline and come up with an updated plan. I think we should target early March to give us some space to work on the issues and PRs. Joao - I’m assuming you still want to be RM for the release, have you triaged the current issues and PRs to identify the must haves and good to haves for 4.18.2 ? And anyone else have any must have issues and PRs they want in 4.18? Regards. Regards. From: João Jandre Paraquetti Sent: Monday, December 11, 2023 6:18:34 PM To: dev@cloudstack.apache.org Subject: Re: [PROPOSE] ACS 4.18.2.0 I think we can push a week or two earlier on the proposed schedule, it would look something like this: - From now till the final week of January (1.5 months): accept bug fixes and minor improvements - First week of February: accept only blocker and critical bug fixes, aiming to stabilize the branch. - Second week of February: start cutting RCs, vote and finish release work. What do you think? Best regards, João Jandre. On 12/9/23 17:22, Rohit Yadav wrote: +1 Given, 4.18 branch is benefitting from maintenance work already, I wouldn't mind if you want to push it earlier to even say end of Jan, and target release in Feb 2024. Regards. From: João Jandre Paraquetti Sent: Friday, December 8, 2023 23:32 To: dev@cloudstack.apache.org Subject: [PROPOSE] ACS 4.18.2.0 Hi all, As suggested on the 4.20.0.0 discussion thread (see https://lists.apache.org/thread/nyoddmwydz2t59hsfs7gf0vozlf7n434), I'd like to propose the release of version 4.18.2.0 with myself as the RM, here's a rough timeline: - From now till the second week of February (2 months): accept bug fixes and minor improvements - Third week of February: accept only blocker and critical bug fixes, aiming to stabilize the branch. - End of February: start cutting RCs, vote and finish release work. We currently have 7 open PRs [1] and 51 open issues [2] with
Re: [PR] Skip failing tests [cloudstack-terraform-provider]
rohityadavcloud merged PR #100: URL: https://github.com/apache/cloudstack-terraform-provider/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Terraform Github Actions Integration Tests failing [cloudstack-terraform-provider]
rohityadavcloud closed issue #98: Terraform Github Actions Integration Tests failing URL: https://github.com/apache/cloudstack-terraform-provider/issues/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup network_id in ipaddress when vpc_id is specified [cloudstack-terraform-provider]
rohityadavcloud closed pull request #99: Fixup network_id in ipaddress when vpc_id is specified URL: https://github.com/apache/cloudstack-terraform-provider/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
