Re: [DISCUSS] Upgrading Mockito & phasing out powermock

2023-09-27 Thread Rohit Yadav
Good work Vishesh!


Regards.


From: Nicolas Vazquez 
Sent: Tuesday, September 26, 2023 20:23
To: dev@cloudstack.apache.org 
Subject: Re: [DISCUSS] Upgrading Mockito & phasing out powermock

Great work Vishesh, thanks!

Regards,
Nicolas Vazquez


From: Daan Hoogland 
Date: Tuesday, 26 September 2023 at 11:15
To: dev@cloudstack.apache.org 
Subject: Re: [DISCUSS] Upgrading Mockito & phasing out powermock
great, thanks you for your persistence and effort in general.

On Tue, Sep 26, 2023 at 1:51 PM Vishesh Jindal 
wrote:

> Hi all,
>
> I wanted to update everyone that powermock is completely removed from main
> branch now. Thank you everyone for helping out on this.
>
> Regards,
> Vishesh
>
> 
> From: Kishan Kavala 
> Sent: Friday, June 9, 2023 1:30 PM
> To: dev@cloudstack.apache.org 
> Subject: RE: [DISCUSS] Upgrading Mockito & phasing out powermock
>
> +1
> Agree with the approach, Vishesh.
>
>
>
>
>
>
>
> -Original Message-
> From: Wei ZHOU 
> Sent: Tuesday, June 6, 2023 8:11 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] Upgrading Mockito & phasing out powermock
>
> lgtm. go ahead Vishesh.
>
> -Wei
>
>
> On Tue, 6 Jun 2023 at 14:17, Vishesh Jindal 
> wrote:
>
> > Hi all,
> >
> > I am working on upgrading Mockito's version & phasing out powermock.
> > For new maven modules, I would request all to use Mockito's mockStatic
> > instead of Powermock.
> >
> > Why?
> > Powermock's last release was on Nov 2, 2020. The project seems to have
> > been abandoned. Powermock has compatibility issues with Mockito's
> > latest version as well.
> >
> > How?
> > The only usage for PowerMock I could see in code was for mocking
> > static methods. Since Mockito v3.4.0, it has the capability to mock
> static methods.
> > I plan to migrate tests to Mockito's mockStatic instead of PowerMock.
> > This will have to be done module by module and will take some time.
> >
> > I have prepared a PR here:
> > https://github.com/apache/cloudstack/pull/7577
> >
> > This PR upgrades mockito from v3.2.4 to v3.12.4 and removes the usage
> > of PowerMock from utils module.
> >
> >
> > Let me know if you have any questions/concerns.
> >
> > Regards,
> > Vishesh
> >
> >
> >
> >
> >
>


--
Daan




 



[DISCUSS] Timeout for Command execution on System VM & Agents

2023-09-27 Thread Vishesh Jindal
Hi all,

I came across an interesting bug today which can result in high wait times on 
System VMs & agents.

While processing a Command on system VM or an agent, even if the management 
server is no longer waiting for an answer the Command still keeps on getting 
processed. This can lead to high wait times if a lot of Commands get queued up 
on the system VM or the agent. I have added more details in the github issue 
here: https://github.com/apache/cloudstack/issues/8011
[https://opengraph.githubassets.com/fe2392c1a388867e98583043755129fedbe3ef20bf8d4f103711ab87e9426532/apache/cloudstack/issues/8011]
Add timeout for handling of Command on agent's implementation · Issue #8011 · 
apache/cloudstack
ISSUE TYPE Improvement Request COMPONENT NAME Agent, ServerResource CLOUDSTACK 
VERSION All versions CONFIGURATION N/A OS / ENVIRONMENT N/A SUMMARY The value 
for wait set in Command is not honored b...
github.com

One of the possible solutions would be to add a timeout on agents for all 
Commands. Cancelling the Command's execution on timeout will leave things in an 
intermediate state which can cause issues.

Anyone has any ideas or suggestions on a better approach to resolve this?

Regards,
Vishesh


 



Resize root disk from windows vm

2023-09-27 Thread Technology Mail

*Hello,*

I am follow below step, I am not sure am I right or wrong.

01. Check volume name from vm : https://prnt.sc/2PYYgOn9bQdA
02. Then going to volume root : https://prnt.sc/-_vPmrdHDsCz
03. Then Resize volume : 100 (previous is 50GB)
then click *OK*
04. now start vm
05. I see not change my root disk after login windows vm. But I see 
added 50GB disk is unallocated.
06. If I use disk management and extend this unallocated disk, Then 
resize my full root disk.


But my question is :

Can I resize my root disk without step 06? (I want to just I resize my 
root disk using volume from UI and restart vm)


Another question is : same process for linux vm or other?

--

*Thanks & Regards.*

*Support Admin*



*Facebook  | Twitter 
 | YouTube 
 | LinkedIn 
*


*Address : *116/1 West Malibagh, D. I. T Road

Dhaka-1217, Bangladesh

*Mob :* +88 01716915504

*Email :* support.ad...@technologyrss.com

*Web :* www.technologyrss.com


Re: Resize root disk from windows vm

2023-09-27 Thread Wei ZHOU
You can try cloudbase-init for windows. Normally we use cloud-init for
linux vms.

-Wei

On Thu, 28 Sept 2023 at 08:51, Technology Mail 
wrote:

> *Hello,*
>
> I am follow below step, I am not sure am I right or wrong.
>
> 01. Check volume name from vm : https://prnt.sc/2PYYgOn9bQdA
> 02. Then going to volume root : https://prnt.sc/-_vPmrdHDsCz
> 03. Then Resize volume : 100 (previous is 50GB)
> then click *OK*
> 04. now start vm
> 05. I see not change my root disk after login windows vm. But I see
> added 50GB disk is unallocated.
> 06. If I use disk management and extend this unallocated disk, Then
> resize my full root disk.
>
> But my question is :
>
> Can I resize my root disk without step 06? (I want to just I resize my
> root disk using volume from UI and restart vm)
>
> Another question is : same process for linux vm or other?
>
> --
>
> *Thanks & Regards.*
>
> *Support Admin*
>
> 
>
> *Facebook  | Twitter
>  | YouTube
>  | LinkedIn
> *
>
> *Address : *116/1 West Malibagh, D. I. T Road
>
> Dhaka-1217, Bangladesh
>
> *Mob :* +88 01716915504
>
> *Email :* support.ad...@technologyrss.com
>
> *Web :* www.technologyrss.com
>