[GitHub] [cloudstack-documentation] shwstppr commented on pull request #294: metrics notes
shwstppr commented on PR #294: URL: https://github.com/apache/cloudstack-documentation/pull/294#issuecomment-1408206396 @andrijapanicsb @borisstoyanov are you good on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on a diff in pull request #294: metrics notes
DaanHoogland commented on code in PR #294: URL: https://github.com/apache/cloudstack-documentation/pull/294#discussion_r1090331472 ## source/adminguide/virtual_machines.rst: ## @@ -1281,6 +1281,42 @@ CloudStack follows the below sequence of operations to provide GPU/vGPU support GPU resources are released automatically when you stop a VM. Once the destroy VM is successful, CloudStack will make a resource call to the host to get the remaining GPU capacity in the card and update the database accordingly. +Virtual Machine Metrics +=== + +VM statistics are collected on a regular interval (defined by global +setting vm.stats.interval with a default of 6 milliseconds). +VM statistics include include compute, storage and network statistics. + +VM statistics are stored in the database for historical data for a desired time period. These historical statistics then can be retrieved using listVirtualMachinesUsageHistory API. For system VMs, the same historical stats can be retrieved using listSystemVmsUsageHistory API Review Comment: ```suggestion VM statistics are stored in the database as historical data for a desired time period. These historical statistics then can be retrieved using listVirtualMachinesUsageHistory API. For system VMs, the same historical statistics can be retrieved using listSystemVmsUsageHistory API ``` ## source/adminguide/virtual_machines.rst: ## @@ -1281,6 +1281,42 @@ CloudStack follows the below sequence of operations to provide GPU/vGPU support GPU resources are released automatically when you stop a VM. Once the destroy VM is successful, CloudStack will make a resource call to the host to get the remaining GPU capacity in the card and update the database accordingly. +Virtual Machine Metrics +=== + +VM statistics are collected on a regular interval (defined by global +setting vm.stats.interval with a default of 6 milliseconds). +VM statistics include include compute, storage and network statistics. + +VM statistics are stored in the database for historical data for a desired time period. These historical statistics then can be retrieved using listVirtualMachinesUsageHistory API. For system VMs, the same historical stats can be retrieved using listSystemVmsUsageHistory API + +VM statistics retention time in the database is controlled by the global configuration - `vm.stats.max.retention.time`. Default value is 720 minutes, i.e., 12 hours. Other global configurations that affects virtual machine statistics is: Review Comment: ```suggestion VM statistics retention time in the database is controlled by the global configuration - `vm.stats.max.retention.time`. Default value is 720 minutes, i.e., 12 hours. Another global configuration that affects virtual machine statistics is: ``` ## source/adminguide/virtual_machines.rst: ## @@ -1281,6 +1281,42 @@ CloudStack follows the below sequence of operations to provide GPU/vGPU support GPU resources are released automatically when you stop a VM. Once the destroy VM is successful, CloudStack will make a resource call to the host to get the remaining GPU capacity in the card and update the database accordingly. +Virtual Machine Metrics +=== + +VM statistics are collected on a regular interval (defined by global +setting vm.stats.interval with a default of 6 milliseconds). +VM statistics include include compute, storage and network statistics. + +VM statistics are stored in the database for historical data for a desired time period. These historical statistics then can be retrieved using listVirtualMachinesUsageHistory API. For system VMs, the same historical stats can be retrieved using listSystemVmsUsageHistory API + +VM statistics retention time in the database is controlled by the global configuration - `vm.stats.max.retention.time`. Default value is 720 minutes, i.e., 12 hours. Other global configurations that affects virtual machine statistics is: + +- `vm.stats.user.vm.only` - When set to 'false' stats for system VMs will be collected otherwise stats collection will be done only for user VMs. + +In UI, historical VM statistics are shown in the Metrics tab in an individual VM view, as shown in the image below. + +|vm-metrics-ui.png| + + +VM Disk Metrics +--- + +Similar to VM statistics, VM disk statistics can also be collected on a regular interval (defined by global setting vm.disk.stats.interval with a default value of 0 seconds which disables VM disk stats collection). VM disk stats are collected in form of diskiopstotal, diskioread, diskiowrite, diskkbsread and diskkbswrite. Review Comment: ```suggestion Similar to VM statistics, VM disk statistics (disk stats) can also be collected on a regular interval (defined by global setting vm.disk.stats.interval with a default value of 0 seconds which disables disk s
[GitHub] [cloudstack-documentation] shwstppr commented on pull request #294: metrics notes
shwstppr commented on PR #294: URL: https://github.com/apache/cloudstack-documentation/pull/294#issuecomment-1408230773 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #294: metrics notes
blueorangutan commented on PR #294: URL: https://github.com/apache/cloudstack-documentation/pull/294#issuecomment-1408232199 @shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #294: metrics notes
blueorangutan commented on PR #294: URL: https://github.com/apache/cloudstack-documentation/pull/294#issuecomment-1408233044 QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/294. (QA-JID 32) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland merged pull request #294: metrics notes
DaanHoogland merged PR #294: URL: https://github.com/apache/cloudstack-documentation/pull/294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on a diff in pull request #49: Rahulbcn27 GitHub actions 1
rohityadavcloud commented on code in PR #49: URL: https://github.com/apache/cloudstack-terraform-provider/pull/49#discussion_r1090418118 ## .github/workflows/build.yml: ## @@ -0,0 +1,26 @@ +name: Build-Check Review Comment: @rahulbcn27 pl add license -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on pull request #49: Rahulbcn27 GitHub actions 1
rohityadavcloud commented on PR #49: URL: https://github.com/apache/cloudstack-terraform-provider/pull/49#issuecomment-1408335670 @rahulbcn27 could you review https://github.com/apache/cloudstack-terraform-provider#testing-the-provider -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on a diff in pull request #49: Rahulbcn27 GitHub actions 1
rohityadavcloud commented on code in PR #49:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/49#discussion_r1090419904
##
.github/workflows/build.yml:
##
@@ -0,0 +1,26 @@
+name: Build-Check
+
+on: [push, pull_request]
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ build:
+runs-on: ubuntu-22.04
+
+steps:
+- uses: actions/checkout@v3
+
+- name: Set up Go
+ uses: actions/setup-go@v3
+ with:
+go-version: 1.16.x
Review Comment:
Should we bump the version to latest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rahulbcn27 commented on a diff in pull request #49: Rahulbcn27 GitHub actions 1
rahulbcn27 commented on code in PR #49:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/49#discussion_r1090435227
##
.github/workflows/build.yml:
##
@@ -0,0 +1,26 @@
+name: Build-Check
Review Comment:
license added
##
.github/workflows/build.yml:
##
@@ -0,0 +1,26 @@
+name: Build-Check
+
+on: [push, pull_request]
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ build:
+runs-on: ubuntu-22.04
+
+steps:
+- uses: actions/checkout@v3
+
+- name: Set up Go
+ uses: actions/setup-go@v3
+ with:
+go-version: 1.16.x
Review Comment:
version updated to 1.19.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on pull request #49: Rahulbcn27 GitHub actions 1
rohityadavcloud commented on PR #49: URL: https://github.com/apache/cloudstack-terraform-provider/pull/49#issuecomment-1408364806 For basic build and unit tests this is good. However, we need to explore if some basic CI/CD using https://github.com/apache/cloudstack-terraform-provider#testing-the-provider (simulator) can be achieved as well. I'll merge this but explore further with @rahulbcn27 about this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud merged pull request #49: Rahulbcn27 GitHub actions 1
rohityadavcloud merged PR #49: URL: https://github.com/apache/cloudstack-terraform-provider/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on a diff in pull request #296: infra: edge zones
DaanHoogland commented on code in PR #296: URL: https://github.com/apache/cloudstack-documentation/pull/296#discussion_r1090493573 ## source/installguide/configuration.rst: ## @@ -764,6 +768,56 @@ Advanced Zone Configuration #. Click Launch. +Edge Zone +* + +.. note:: + Support for Edge zone has been added with 4.18.0 and these zones will only support KVM hypervisor Review Comment: ```suggestion Support for Edge zones has been added with 4.18.0 and these zones will only be supported on KVM hypervisors ``` ## source/installguide/configuration.rst: ## @@ -521,8 +521,12 @@ Basic Zone Configuration Advanced Zone Configuration ~~~ -#. After you select Advanced in the Add Zone wizard and click Next, you - will be asked to enter the following details. Then click Next. +For Advanced zone, you may chose Edge which will allow creating an Edge. If Edge is not selected then wizard will allow creating a Core zone. Review Comment: can you explain or modify this sentence? this is a checkbox ? maybe you mean ```suggestion For Advanced zone, you may chose to select Edge which will allow creating an Edge Zone. If Edge is not selected then wizard will continue creating a Core zone. ``` ## source/installguide/configuration.rst: ## @@ -764,6 +768,56 @@ Advanced Zone Configuration #. Click Launch. +Edge Zone +* + +.. note:: + Support for Edge zone has been added with 4.18.0 and these zones will only support KVM hypervisor + +Edge zone is a simpler, light-weight zone which may often contain a single hypervisor host. There will be no need for shared storage, public and management physical networks for an Edge zone. Review Comment: ```suggestion An Edge Zone is a simpler, light-weight zone which may often contain a single hypervisor host. There will be no need for shared storage, public and management physical networks for an Edge zone. ``` ## source/installguide/configuration.rst: ## @@ -764,6 +768,56 @@ Advanced Zone Configuration #. Click Launch. +Edge Zone +* + +.. note:: + Support for Edge zone has been added with 4.18.0 and these zones will only support KVM hypervisor + +Edge zone is a simpler, light-weight zone which may often contain a single hypervisor host. There will be no need for shared storage, public and management physical networks for an Edge zone. +To work with limited compute resources, an Edge zone will not deploy system VMs. This type of zone only support shared and L2 guest networks. For virtual routers of a shared guest network, a direct-download System VM must be added after adding the zone. Review Comment: ```suggestion To work with limited compute resources, an Edge zone will not deploy system VMs. This type of zone only supports shared and L2 guest networks. For virtual routers of a shared guest network, a direct-download System VM must be added after adding the zone. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] shwstppr commented on pull request #296: infra: edge zones
shwstppr commented on PR #296: URL: https://github.com/apache/cloudstack-documentation/pull/296#issuecomment-1409906677 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #296: infra: edge zones
blueorangutan commented on PR #296: URL: https://github.com/apache/cloudstack-documentation/pull/296#issuecomment-1409907543 @shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #296: infra: edge zones
blueorangutan commented on PR #296: URL: https://github.com/apache/cloudstack-documentation/pull/296#issuecomment-1409908185 QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/296. (QA-JID 33) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
