tungsten libraries
LS, TL;DR we are about to merge a reference to a dependency in a (privare) fork of an apl2 licensed project. We are planning to merge the (backend-) plugin for tungsten in the coming days. If regression tests show no big failures of course. There is one issue I want devs and PMCs opinions on. Please see our esteemed comment on the subject [1]. Do we find including a dependency this way acceptable? I personally have no problem with it but want to make sure I am not violating any laws, by-laws or feelings with merging it like this. We are still doing regression tests in advanced zon with security groups for this, and lazy consensus applies. Please be heard if you see a reason not to do this. [1] https://github.com/apache/cloudstack/pull/7065#issuecomment-1398857494 thanks,
[GitHub] [cloudstack-go] vdombrovski opened a new pull request, #45: Implement resourceiconresponse as interface{}
vdombrovski opened a new pull request, #45:
URL: https://github.com/apache/cloudstack-go/pull/45
All "icon" fields are set to be of resourceiconresponse type, however that
type is not defined anywhere, making the icon field resolving to a string.
This isn't correct as ACS returns the Icon as an object, which in term
causes these types of error:
```sh
json: cannot unmarshal object into Go struct field
VirtualMachinesMetric.virtualmachine.icon of type string
```
This change sets the type of resourceiconresponse type to be an empty
interface{}, to guarantee some backward compatibility and ensure that the
unmarshalling works as intended.
Tested againt ACS 4.17.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-go] vdombrovski commented on pull request #38: Add ACS 4.17 support
vdombrovski commented on PR #38: URL: https://github.com/apache/cloudstack-go/pull/38#issuecomment-1401504357 Hello, I've created a PR which fixes Icon type behavior in 4.17: https://github.com/apache/cloudstack-go/pull/45. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
