[GitHub] [cloudstack-go] davidjumani commented on a diff in pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached

2022-04-18 Thread GitBox


davidjumani commented on code in PR #26:
URL: https://github.com/apache/cloudstack-go/pull/26#discussion_r851972228


##
generate/generate.go:
##
@@ -1849,6 +1849,8 @@ func mapType(aName string, pName string, pType string) 
string {
case "list":
if pName == "downloaddetails" || pName == "owner" {
return "[]map[string]string"
+   } else if pName == "network" {
+   return "[]Network"

Review Comment:
   ```suggestion
return "[]*Network"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack-go] davidjumani merged pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached

2022-04-18 Thread GitBox


davidjumani merged PR #26:
URL: https://github.com/apache/cloudstack-go/pull/26


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack-go] davidjumani commented on pull request #32: Autogenerate tests

2022-04-18 Thread GitBox


davidjumani commented on PR #32:
URL: https://github.com/apache/cloudstack-go/pull/32#issuecomment-1101257523

   @rohityadavcloud Thats right, the test files are now autogenerated and 
fetches the API response from the json files to ensure that the structs match 
the response


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [DISCUSS] Community CI/CD/Triage Bot

2022-04-18 Thread Rohit Yadav
All,

I've some updates on the initiative:

  *   I've added some initial support of @acs-robot which along with Github 
actions is used to (a) detect UI changes and kick UI QA builds, (b) detect 
java/xml changes and kick quality check and report coverage report on the PR
  *   Enabled coverage/quality, example the coverage reports can be seen here: 
http://qa.cloudstack.cloud/coverage/ (I'll set up a daily job, on main branch)
  *   Quality metrics/analysis re-setup with Sonar: 
https://sonarcloud.io/project/overview?id=apachecloudstack (will set up a daily 
job on main branch)

To explore and investigate: (based on feedback)

  *   Build/re-kick failed Travis jobs
  *   Assign (latest) milestones to new issues and PRs
  *   Detect if PR needs packaging and running smoketests, build/re-kick failed 
pkg jobs
  *   Assign PR approvers based on file-path matching
  *   Explore automatic triaging of issues (label, assign to maintainers)
  *   Label PRs by size of the PR changes (similar to k8s, s/m/l/xl/xxl/...)
  *   Per PR Sonar-cloud integration (not sure if this is necessary unless 
contributors want this)

Please do share your ideas and thoughts. Thanks.


Regards.


From: Rohit Yadav 
Sent: Thursday, April 7, 2022 13:37
To: dev@cloudstack.apache.org 
Subject: Re: [DISCUSS] Community CI/CD/Triage Bot

Thanks for the feedback and suggestions Nicolas.

I've been exploring the ASF infra wiki and docs to see what's already out there 
we can adapt and use. So far I've report progress [1][2]:

  *   boring-cyborg: this probot based Github app/bot approved by ASF-infra and 
used by other projects such as Airflow. This allows automatic tagging of PRs by 
filepath changes [1], and can help put welcome messages and encouraging msg to 
a new contributor's first PR merge
  *   merge-conflict checker: based on Nicolas's feedback I put together this 
Github Action workflow [2] which labels PRs with merge conflicts and comments 
to the PR author to address the conflict
  *   dependabot: not enabled by me, but it appears ASF-infra is enabling this 
asf-repo wide (https://github.com/apache/cloudstack/pulls/app%2Fdependabot)

I'll be exploring the following:

  *   Jacoco/code coverage stats on a PR (unit test coverage for changes)
  *   Explore automatic changes in the following to assist and reduce release 
management effort:
 *   assign milestone to new PRs and issues (or maybe a triage label?)
 *   re-kick of failed Travis tests (for ex. try 2-3 times before giving)
 *   detect if a PR needs smoke tests or not; kick UI builds if needed
  *   Assign reviewers/approvers on PRs based on file paths (or last commit 
changes?) - this may need some thinking, as most projects such as k8s keep an 
owner file in directories to keep track of who's best to review changes
  *   Explore how issues can be triaged and automatically labeled
  *   Explore other things mentioned in this thread and report findings to dev@

[1] https://github.com/apache/cloudstack/blob/main/.github/boring-cyborg.yml
[2] 
https://github.com/apache/cloudstack/blob/main/.github/workflows/merge-conflict-checker.yml

[3] 
https://github.com/apache/cloudstack/pulls?q=is%3Apr+is%3Aopen+label%3Astatus%3Ahas-conflicts


Regards.


From: Nicolas Vazquez 
Sent: Wednesday, April 6, 2022 19:29
To: dev@cloudstack.apache.org 
Subject: Re: [DISCUSS] Community CI/CD/Triage Bot

Thanks Rohit for this initiative, I think it is very useful. From the list of 
tasks I’m not really sure about the automatic merging of PRs – but the rest 
could be very useful, specially the merge conflicts detection which is a very 
common case near the releases freeze date.

I would like to propose a few more tasks:

  *   For new issues/PRs - assign the milestone in case it is not set
  *   Close/reopen a PR in case of failures on the checks
  *   Detect whether to build packages and run tests or build only UI based on 
the files changed/labels

Regards,
Nicolas Vazquez


From: Rohit Yadav 
Date: Tuesday, 5 April 2022 at 16:37
To: dev@cloudstack.apache.org 
Subject: [DISCUSS] Community CI/CD/Triage Bot
All,

I'm trying to investigate and experiment with a few things and new ideas around 
our QA/automation and CI/CD. I want to build initial support around this and 
ask if anybody has any feedback, objections on this;

Taking inspiration from kubernetes and other apache projects [2][3], I'm trying 
to explore the following use-cases and requirements that are initiated by a new 
community github bot [1]:

  *   Triage issues and PRs:
 *   Add labels on issues and PRs
 *   Assign reviewers and approvers for PRs
 *   Perform any other checks and misc things (for ex. welcome new 
contributors?)
 *   Have ability to remind people on issues and PRs (for ex. /remind in 2 
weeks... etc)
  *   Kick tests, lints etc using apache approved/integrated automation hooks, 
Github Actions etc.
  *   Generally, explore use

New logs for the MySQL exception ticket

2022-04-18 Thread Vladimir Petrov
Hi team,

People from Telia Latvija claim they were able to get a crash debug log and 
created a new ticket (#3965 MySQL exceptions). This is a follow-up to the old 
one (#3775), where Andrija asked for a more detailed log. Can you please take a 
look at the logs and advice if we can help them further with this issue 
investigation?

Here is a quote from the ticket:

We finally got crash with debug log enabled.

What I can see is that database is still operating - answering and writing on 
both servers.
That NPE is happening only with “consoleproxy-1”

Full log from midnight rollover on both ACS servers.
https://s3a2.telia.lv/shapeblue/04_management-server.7z?AWSAccessKeyId=IDP870XGZW0CUUP0U2CK&Expires=1651352399&Signature=4YTrpL2t9ZM9On%2B95pZIjpUGwwo%3D
https://s3a2.telia.lv/shapeblue/05_management-server.7z?AWSAccessKeyId=IDP870XGZW0CUUP0U2CK&Expires=1651352399&Signature=YNVA2uGH4OtY5ci%2FVSKE1p08aiA%3D

Small log two minutes before “2022-04-17 02:22:21,303 WARN  
[c.c.v.SystemVmLoadScanner] (consoleproxy-1:ctx-aa16da8f)
(logid:5b387a2f) Unexpected exception DB Exception on: null” on 
“04_small_02-22-21.txt” for readability.
https://s3a2.telia.lv/shapeblue/04_small_02-22-21.7z?AWSAccessKeyId=IDP870XGZW0CUUP0U2CK&Expires=1651352399&Signature=LYK6B6ncvb9pbQWkAZ%2BPDCgNFmw%3D
https://s3a2.telia.lv/shapeblue/05_small_02-20-00.7z?AWSAccessKeyId=IDP870XGZW0CUUP0U2CK&Expires=1651352399&Signature=u6jeKL%2Bs45oNzh%2BJM2po2eqHW%2BQ%3D

Best wishes,
Vladi