[GitHub] [cloudstack-documentation] davidjumani commented on pull request #207: Updating image and docs wrt the new UI

2021-05-17 Thread GitBox


davidjumani commented on pull request #207:
URL: 
https://github.com/apache/cloudstack-documentation/pull/207#issuecomment-842120392


   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #207: Updating image and docs wrt the new UI

2021-05-17 Thread GitBox


blueorangutan commented on pull request #207:
URL: 
https://github.com/apache/cloudstack-documentation/pull/207#issuecomment-842121219


   @davidjumani a Jenkins job has been kicked to build the document. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #207: Updating image and docs wrt the new UI

2021-05-17 Thread GitBox


blueorangutan commented on pull request #207:
URL: 
https://github.com/apache/cloudstack-documentation/pull/207#issuecomment-842137523


   Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/207. 
(SL-JID 68)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-cloudmonkey] rhtyd commented on a change in pull request #79: Validate arguments passed while setting configuration

2021-05-17 Thread GitBox


rhtyd commented on a change in pull request #79:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/pull/79#discussion_r633449464



##
File path: config/config.go
##
@@ -74,6 +74,18 @@ type Config struct {
ActiveProfile *ServerProfile
 }
 
+func GetOutputFormats() []string {
+ return []string {"column", "csv", "json", "table", "text"}
+}
+
+func CheckIfValuePresent(dataset []string, element string) bool {

Review comment:
   thnx, I would have loved if Go had a std library method for this. 
:facepalm: 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-cloudmonkey] rhtyd commented on a change in pull request #80: Verify user access to config file

2021-05-17 Thread GitBox


rhtyd commented on a change in pull request #80:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/pull/80#discussion_r633450212



##
File path: config/config.go
##
@@ -85,7 +86,16 @@ func (c Config) CacheFile() string {
return path.Join(cacheDir, cacheFileName)
 }
 
+func hasAccess(path string) bool {
+return unix.Access(path, unix.R_OK) == nil
+}
+
 func checkAndCreateDir(path string) string {
+   isAccsessible := hasAccess(path)

Review comment:
   @Pearl1594 could the fix to be simply to try and open the file and 
handle the failure? It's because people may use cmk on Mac and Windows.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-cloudmonkey] Pearl1594 commented on a change in pull request #80: Verify user access to config file

2021-05-17 Thread GitBox


Pearl1594 commented on a change in pull request #80:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/pull/80#discussion_r633451943



##
File path: config/config.go
##
@@ -85,7 +86,16 @@ func (c Config) CacheFile() string {
return path.Join(cacheDir, cacheFileName)
 }
 
+func hasAccess(path string) bool {
+return unix.Access(path, unix.R_OK) == nil
+}
+
 func checkAndCreateDir(path string) string {
+   isAccsessible := hasAccess(path)

Review comment:
   Right! makes sense, it slipped my mind that we support other OSs too. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-cloudmonkey] rhtyd commented on a change in pull request #80: Verify user access to config file

2021-05-17 Thread GitBox


rhtyd commented on a change in pull request #80:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/pull/80#discussion_r633450212



##
File path: config/config.go
##
@@ -85,7 +86,16 @@ func (c Config) CacheFile() string {
return path.Join(cacheDir, cacheFileName)
 }
 
+func hasAccess(path string) bool {
+return unix.Access(path, unix.R_OK) == nil
+}
+
 func checkAndCreateDir(path string) string {
+   isAccsessible := hasAccess(path)

Review comment:
   @Pearl1594 could the fix to be simply to try and open the file and 
handle the failure? It's because people may use cmk on Mac and Windows.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-cloudmonkey] rhtyd commented on a change in pull request #79: Validate arguments passed while setting configuration

2021-05-17 Thread GitBox


rhtyd commented on a change in pull request #79:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/pull/79#discussion_r633449464



##
File path: config/config.go
##
@@ -74,6 +74,18 @@ type Config struct {
ActiveProfile *ServerProfile
 }
 
+func GetOutputFormats() []string {
+ return []string {"column", "csv", "json", "table", "text"}
+}
+
+func CheckIfValuePresent(dataset []string, element string) bool {

Review comment:
   thnx, I would have loved if Go had a std library method for this. 
:facepalm: 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #207: Updating image and docs wrt the new UI

2021-05-17 Thread GitBox


blueorangutan commented on pull request #207:
URL: 
https://github.com/apache/cloudstack-documentation/pull/207#issuecomment-842121219






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] davidjumani commented on pull request #207: Updating image and docs wrt the new UI

2021-05-17 Thread GitBox


davidjumani commented on pull request #207:
URL: 
https://github.com/apache/cloudstack-documentation/pull/207#issuecomment-842120392


   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-cloudmonkey] Pearl1594 commented on a change in pull request #80: Verify user access to config file

2021-05-17 Thread GitBox


Pearl1594 commented on a change in pull request #80:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/pull/80#discussion_r633451943



##
File path: config/config.go
##
@@ -85,7 +86,16 @@ func (c Config) CacheFile() string {
return path.Join(cacheDir, cacheFileName)
 }
 
+func hasAccess(path string) bool {
+return unix.Access(path, unix.R_OK) == nil
+}
+
 func checkAndCreateDir(path string) string {
+   isAccsessible := hasAccess(path)

Review comment:
   Right! makes sense, it slipped my mind that we support other OSs too. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




GSoC'21 - UX enchancements

2021-05-17 Thread Apurv Gupta
Hello Everyone,

First of all, I would like to thank everyone, especially the mentors of the
project for giving me the opportunity to contribute to CloudStack via
GSoC'21.

I am Apurv Gupta, an open source enthusiast and a third year student from
Chhattisgarh, India. I have been selected for the project "UX -
Enhancements" (issue #4798) for Google Summer of Code 2021. I am looking
forward to be more involved with the community and contribute.

Thank you!


GSoC'21 - Clone a Virtual Machine

2021-05-17 Thread s Tms
Hi Everyone,

I'm Junxuan Wu, a third-year student from Toronto, Canada. I'm selected for
issue #10430  (Clone
a virtual VM with all the data disks) on GSOC 2021.

It's a pleasure to be selected for this opportunity. Thanks to my mentors,
Suresh, Nicolas, Rohit, and also everyone in the community for giving me
this chance. I'm looking forward to knowing more about the community and
doing contributions. Feel free to email me if you want to connect.

Thank you!

Junxuan Wu


GSoC 2021 - Synchronization of network devices on newly added hosts for Persistent Networks

2021-05-17 Thread Sangwoo Bae
Hello Everyone,

My name is Sangwoo Bae, and I am a second-year computer science student
from Berlin, Germany.
I have been selected as a GSoC student to work on the issue #4814 <
https://github.com/apache/cloudstack/issues/4814>.

Thanks to the community and my mentor Pearl for this opportunity! I am
looking forward to learning and contributing to the cloudstack community.
Please feel free to email me.

Kind regards and stay safe!

Sangwoo Bae


Re: GSoC 2021 - Synchronization of network devices on newly added hosts for Persistent Networks

2021-05-17 Thread Harikrishna Patnala
Hi Sangwoo Bae,

Welcome to the CloudStack community and congratulations on your project 
selection.

Have a great time learning and working on the project and CloudStack.

Regards,
Harikrishna

From: Sangwoo Bae 
Sent: Tuesday, May 18, 2021 2:20 AM
To: dev@cloudstack.apache.org 
Subject: GSoC 2021 - Synchronization of network devices on newly added hosts 
for Persistent Networks

Hello Everyone,

My name is Sangwoo Bae, and I am a second-year computer science student
from Berlin, Germany.
I have been selected as a GSoC student to work on the issue #4814 <
https://github.com/apache/cloudstack/issues/4814>.

Thanks to the community and my mentor Pearl for this opportunity! I am
looking forward to learning and contributing to the cloudstack community.
Please feel free to email me.

Kind regards and stay safe!

Sangwoo Bae

 



Re: GSoC'21 - Clone a Virtual Machine

2021-05-17 Thread Harikrishna Patnala
Hi Junxuan Wu,

Welcome to the CloudStack community and congratulations on your project 
selection.

Have a great time learning and working on the project and CloudStack.

Regards,
Harikrishna

From: s Tms 
Sent: Tuesday, May 18, 2021 1:48 AM
To: dev@cloudstack.apache.org 
Subject: GSoC'21 - Clone a Virtual Machine

Hi Everyone,

I'm Junxuan Wu, a third-year student from Toronto, Canada. I'm selected for
issue #10430  (Clone
a virtual VM with all the data disks) on GSOC 2021.

It's a pleasure to be selected for this opportunity. Thanks to my mentors,
Suresh, Nicolas, Rohit, and also everyone in the community for giving me
this chance. I'm looking forward to knowing more about the community and
doing contributions. Feel free to email me if you want to connect.

Thank you!

Junxuan Wu

 



GSoC '21

2021-05-17 Thread Bikram Biswas
Hi everyone. I am very glad that my proposal for Google Summer of Code has
been accepted.
I am very excited to work in GSoC'21 for Cloudstack issue #4813 (Support
multiple SSH keys for VMs)