[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on a change in pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meaning

[GitBox]

davidjumani commented on a change in pull request #29:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r629156668



##
File path: cloudstack_loadbalancer.go
##
@@ -121,8 +121,8 @@ func (cs *CSCloud) EnsureLoadBalancer(ctx context.Context, 
clusterName string, s
 
klog.V(4).Infof("Load balancer %v is associated with IP %v", lb.name, 
lb.ipAddr)
 
-   // Fetch the IP whitelist from the spec if any
-   //whitelist = service.Spec.LoadBalancerSourceRanges
+   // Fetch the IP allowlist from the spec if any
+   //allowlist = service.Spec.LoadBalancerSourceRanges

Review comment:
   I'm for removing it @onitake @joschi36 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-ec2stack] DaanHoogland commented on pull request #2: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meaningful and inclusive.

[GitBox]

DaanHoogland commented on pull request #2:
URL: https://github.com/apache/cloudstack-ec2stack/pull/2#issuecomment-836398236


   is this repo still active and does it contain functional code? Not sure if 
we should keep it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-gcestack] DaanHoogland commented on pull request #3: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meaningful and inclusive.

[GitBox]

DaanHoogland commented on pull request #3:
URL: https://github.com/apache/cloudstack-gcestack/pull/3#issuecomment-836399686


   is this still active and functional? maybe delete the repo?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on issue #16: [DISCUSS] Work on next release

[GitBox]

joschi36 commented on issue #16:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-836442553


   What's the status here now?
   Can we create the release now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Access for cwiki page: https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.16+Design+Documents

[Rene Peinthor]

Hi!

I was asked to create a design document at the subject location for the new
Linstor volume plugin. User in the cwiki has the same email as used here.

PR for reference:
https://github.com/apache/cloudstack/pull/4994

Best regards,
Rene

Re: Access for cwiki page: https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.16+Design+Documents

[Rohit Yadav]

Hi Rene,

I've pinged ASF-infra on their slack channel. I'm not sure who's the cwiki 
admins with PMCs, maybe @Daan Hoogland or 
@Pierre-Luc Dion may know if they can grant you access?


I found your username as: rene.peinthor (email rene.peint...@linbit.com) on 
cwiki but I don't have space/admin access.


Regards.


From: Rene Peinthor 
Sent: Monday, May 10, 2021 15:02
To: dev@cloudstack.apache.org 
Subject: Access for cwiki page: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.16+Design+Documents

Hi!

I was asked to create a design document at the subject location for the new
Linstor volume plugin. User in the cwiki has the same email as used here.

PR for reference:
https://github.com/apache/cloudstack/pull/4994

Best regards,
Rene

 

Re: Access for cwiki page: https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.16+Design+Documents

[Daan Hoogland]

I added Rene, you should be able to as well now, @Rohit Yadav
 .

On Mon, May 10, 2021 at 12:08 PM Rohit Yadav 
wrote:

> Hi Rene,
>
> I've pinged ASF-infra on their slack channel. I'm not sure who's the cwiki
> admins with PMCs, maybe @Daan Hoogland
> or @Pierre-Luc Dion may know if they can grant you
> access?
>
>
> I found your username as: rene.peinthor (email rene.peint...@linbit.com)
> on cwiki but I don't have space/admin access.
>
>
> Regards.
>
> 
> From: Rene Peinthor 
> Sent: Monday, May 10, 2021 15:02
> To: dev@cloudstack.apache.org 
> Subject: Access for cwiki page:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.16+Design+Documents
>
> Hi!
>
> I was asked to create a design document at the subject location for the new
> Linstor volume plugin. User in the cwiki has the same email as used here.
>
> PR for reference:
> https://github.com/apache/cloudstack/pull/4994
>
> Best regards,
> Rene
>
>
>
>

-- 
Daan

Re: [DISCUSS] 4.15.1.0 and 4.16.0.0 timeline

[Rohit Yadav]

All,

We've about 20 items on the milestone now: 
https://github.com/apache/cloudstack/milestone/17

There are currently no critical or blocker issues on the milestone, I would 
like to cut RC1 between 24-31 May 2021 depending on the 4.15 branch stability.
This will give us 2-3 weeks to test, report bugs, and get them fixed towards 
the 4.15 branch during the freeze window.

PS. We're in a process of setting up "nightly build repositories" to assist 
users with testing branch-based snapshot/developer builds going forward, I'll 
keep everyone posted once they're available.

Regards.


From: Nicolas Vazquez 
Sent: Wednesday, April 21, 2021 21:11
To: dev@cloudstack.apache.org 
Subject: Re: [DISCUSS] 4.15.1.0 and 4.16.0.0 timeline

No major blockers afaik, looks feasible

Regards,
Nicolas Vazquez


De: Rohit Yadav 
Enviado: miércoles, 21 de abril de 2021 04:52
Para: dev@cloudstack.apache.org
Asunto: Re: [DISCUSS] 4.15.1.0 and 4.16.0.0 timeline

All,

We've about 30 items on the 4.15.1.0 milestone now: 
https://github.com/apache/cloudstack/milestone/17

Considering these and the previously proposed rough timeline, I would like to 
propose 4.15 branch soft freeze around 3rd May 2021, after which only blocker 
and critical fixes will be allowed with the RC1 cut during early-mid May 
depending on branch stability.

Thoughts, objections? Thanks.

Regards.

From: Rohit Yadav 
Sent: Thursday, March 4, 2021 15:17
To: dev@cloudstack.apache.org 
Subject: [DISCUSS] 4.15.1.0 and 4.16.0.0 timeline

All,

With 4.14.1.0 released and announced yesterday, I propose an rough timeline for:

4.15.1.0 release: target for Q2 2021
(4.5 weeks) ongoing - 2 April 2021: accept all bugs, issues, improvements 
allowed in LTS [1]
(2 weeks) 8 April - 19 April 2021: accept only critical/blocker fixes
(1 week) 19 April - 23 April 2021: stabilise 4.15 branch, accept only blocker 
issues if any
WC 26 April - onwards - Cut 4.15.1.0 RC1 and further RCs if necessary, 
start/conclude vote, and finish release work

4.16.0.0 release: target for Q3/Q4 2021
Let's discuss the actual timeline after 4.15.1.0 and if anyone else wants to 
volunteer as the RM.


[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/LTS


Thoughts? Thanks.

rohit.ya...@shapeblue.com
www.shapeblue.com
3 London Bridge Street,  3rd floor, News Building, London  SE1 9SGUK
@shapeblue




rohit.ya...@shapeblue.com
www.shapeblue.com
3 London Bridge Street,  3rd floor, News Building, London  SE1 9SGUK
@shapeblue





nicolas.vazq...@shapeblue.com
www.shapeblue.com
3 London Bridge Street,  3rd floor, News Building, London  SE1 9SGUK
@shapeblue




 

[GitHub] [cloudstack-documentation] sureshanaparti commented on pull request #155: Inclusivity changes for CloudStack in the documentation - Rename default git branch name from 'master' to 'main' and

[GitBox]

sureshanaparti commented on pull request #155:
URL: 
https://github.com/apache/cloudstack-documentation/pull/155#issuecomment-836782931


   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #155: Inclusivity changes for CloudStack in the documentation - Rename default git branch name from 'master' to 'main' and

[GitBox]

blueorangutan commented on pull request #155:
URL: 
https://github.com/apache/cloudstack-documentation/pull/155#issuecomment-836783638


   @sureshanaparti a Jenkins job has been kicked to build the document. I'll 
keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-www] sureshanaparti commented on pull request #83: Inclusivity changes for CloudStack - Renamed default git branch name from 'master' to 'main', and some offensive words/terms as

[GitBox]

sureshanaparti commented on pull request #83:
URL: https://github.com/apache/cloudstack-www/pull/83#issuecomment-836785019


   > Why is this file a part of this pull request? It seems to be unrelated to 
the subject in the request. Possibly a commit that wasn't supposed to be a part 
of this PR?
   
   Thanks @nathanmcgarvey , this change is unrelated and removed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-www] sureshanaparti commented on pull request #83: Inclusivity changes for CloudStack - Renamed default git branch name from 'master' to 'main', and some offensive words/terms as

[GitBox]

sureshanaparti commented on pull request #83:
URL: https://github.com/apache/cloudstack-www/pull/83#issuecomment-836787795


   > > 22383 files with over 44000 lines changed in a single commit may hurt 
repo-wise... if this is merged, ensure that repo packing, garbage collecting, 
and index-updating is done and maybe a comparison of pre-merge to post-merge 
size is evaluated. Also, there is _no_ way anybody is reasonably doing a human 
review on this for real. :)
   > > Alternatively, do we really need to be updating the HTML tags for 4.0.0 
API documentation from [8?] years ago? Maybe it would be better to just age it 
off, or put a readme about terminology changes and just change 4.14+ versions. 
Otherwise, I could see this becoming a repeated effort if other terms are 
deemed "offensive" in the future. And I'd really rather not start having tens 
of thousands of changed source code lines be "normal" behavior for a source 
code repo.
   > 
   > @nathanmcgarvey Thanks for the review, will remove the relevant changes 
from the old apidocs.
   
   @nathanmcgarvey @DaanHoogland Removed the changes in the old api doc 
references (not relevant now).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on issue #16: [DISCUSS] Work on next release

[GitBox]

rhtyd commented on issue #16:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-836980447


   @onitake @joschi36 since this project is under ASF now, a committer or PMC 
member has right to publish source tarball and to dockerhub. I'll work with you 
both of you and with @davidjumani to figure out the build and release channels 
and start a RC1 voting soon (provide administrative assistance).
   
   @davidjumani do you want to help as a co-RM? Longer-term you can help 
maintain the repo along with @onitake and @joschi36?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Renaming default git branch name from 'master' to 'main' and replace offensive words as appropriate for inclusiveness

[Suresh Anaparti]

+1 , adding my vote as well.

Regards,
Suresh


 

On 07/05/21, 2:10 PM, "Harikrishna Patnala"  
wrote:

+1  from me.

Regards,
Harikrishna

From: Suresh Anaparti 
Sent: Friday, April 30, 2021 5:13 PM
To: dev@cloudstack.apache.org ; 
priv...@cloudstack.apache.org 
Cc: us...@cloudstack.apache.org 
Subject: [VOTE] Renaming default git branch name from 'master' to 'main' 
and replace offensive words as appropriate for inclusiveness

Hi All,

Following the discussion thread on renaming default git branch name and 
inclusiveness [1], I would like to start a vote to gather consensus on the 
following plan:

1. Accept the following rename PRs (raised against 'master' branch) which 
renames git default branch to 'main' and replaces some offensive words, and 
Merge them post acceptance.
- cloudstack => PR: https://github.com/apache/cloudstack/pull/4922
- cloudstack-documentation => PR: 
https://github.com/apache/cloudstack-documentation/pull/155
- cloudstack-www => PR: 
https://github.com/apache/cloudstack-www/pull/83
- cloudstack-cloudmonkey => PR: 
https://github.com/apache/cloudstack-cloudmonkey/pull/76
- cloudstack-kubernetes-provider => PR: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/29
- cloudstack-ec2stack => PR: 
https://github.com/apache/cloudstack-ec2stack/pull/2
- cloudstack-gcestack => PR: 
https://github.com/apache/cloudstack-gcestack/pull/3

2. Request ASF infra to disable pushes to 'master' branch.

3. Rename 'master' branch to 'main' [2][3], and Request ASF infra (open 
INFRA ticket) to make 'main' as the default branch [4], in GitHub repo settings 
for all the CloudStack repos. This will also re-target the current PRs against 
'master' branch to 'main'.

3a. The update on the central repo will be done as follows (only by a PMC 
or Infra member with access)
- Clone the repo (git clone 
https://github.com/apache/cloudstack.git)
- Sync local 'master' with the cloudstack repo (cd cloudstack && 
git checkout master && git fetch --all -p && git pull)
- Rename local 'master' branch to 'main' (git branch -m master main)
- Push renamed 'main' branch (git push -u origin main)
- Update Default Branch on GitHub [4]
- Delete 'master' branch (git push origin --delete master)
3b. After the central renaming has been done. New users can clone and 
directly checkout 'main' branch. Existing users can start using 'main' locally, 
using the below steps.
- Switch to master branch (git checkout master)
- Rename local 'master' branch to 'main' (git branch -m master main)
- Sync local 'main' with repo (git fetch)
- Remove the existing tracking connection with “origin/master” (git 
branch --unset-upstream)
- Create a new tracking connection with the new “origin/main” 
branch (git branch -u origin/main)
- All local branches should still point to the same commit as base 
revision. If there is a problem (git checkout  && git 
rebase main)

4. Update the integrated systems with CloudStack repos, mainly Travis CI 
and Jenkins configuration with 'main' branch. Check and update UI building, 
apidocs, systemvmtemplate builds; project website and docs (cwiki); and any 
other build/release jobs. Track them through the issue: 
https://github.com/apache/cloudstack/issues/4887.

5. Perform Health Checks (using a dummy PR), and ensure there are no issues 
with the build/release configuration. This PR needs to run full matrix of 
tests. Fix the issues noticed during the health checks.

6. Announce the default branch change to 'main' (and 'master' deprecation) 
on the mailing list.

The vote will be open until Fri 7th May 2021.

For sanity in tallying the vote, Can PMC members please be sure to indicate 
“(binding)” with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

[1] https://markmail.org/message/k767evgjnmzogyhf
[2] https://github.com/github/renaming
[3] 
https://docs.github.com/en/github/administering-a-repository/renaming-a-branch
[4] 
https://docs.github.com/en/github/administering-a-repository/changing-the-default-branch

Regards,
Suresh

Re: [VOTE] Renaming default git branch name from 'master' to 'main' and replace offensive words as appropriate for inclusiveness

[Suresh Anaparti]

Hi Wei,

Thanks for voting. The branch will be renamed to 'main' (as mentioned in the 
steps), and so I assume 'master' doesn't exist after that.

Regards,
Suresh

On 03/05/21, 1:13 PM, "Wei ZHOU"  wrote:

+1 (binding)

Can we keep a 'master' branch for some weeks ?

-Wei

On Fri, 30 Apr 2021 at 13:43, Suresh Anaparti 

wrote:

> Hi All,
>
> Following the discussion thread on renaming default git branch name and
> inclusiveness [1], I would like to start a vote to gather consensus on the
> following plan:
>
> 1. Accept the following rename PRs (raised against 'master' branch) which
> renames git default branch to 'main' and replaces some offensive words, 
and
> Merge them post acceptance.
> - cloudstack => PR: https://github.com/apache/cloudstack/pull/4922
> - cloudstack-documentation => PR:
> https://github.com/apache/cloudstack-documentation/pull/155
> - cloudstack-www => PR:
> https://github.com/apache/cloudstack-www/pull/83
> - cloudstack-cloudmonkey => PR:
> https://github.com/apache/cloudstack-cloudmonkey/pull/76
> - cloudstack-kubernetes-provider => PR:
> https://github.com/apache/cloudstack-kubernetes-provider/pull/29
> - cloudstack-ec2stack => PR:
> https://github.com/apache/cloudstack-ec2stack/pull/2
> - cloudstack-gcestack => PR:
> https://github.com/apache/cloudstack-gcestack/pull/3
>
> 2. Request ASF infra to disable pushes to 'master' branch.
>
> 3. Rename 'master' branch to 'main' [2][3], and Request ASF infra (open
> INFRA ticket) to make 'main' as the default branch [4], in GitHub repo
> settings for all the CloudStack repos. This will also re-target the 
current
> PRs against 'master' branch to 'main'.
>
> 3a. The update on the central repo will be done as follows (only by a PMC
> or Infra member with access)
> - Clone the repo (git clone
> https://github.com/apache/cloudstack.git)
> - Sync local 'master' with the cloudstack repo (cd cloudstack &&
> git checkout master && git fetch --all -p && git pull)
> - Rename local 'master' branch to 'main' (git branch -m master
> main)
> - Push renamed 'main' branch (git push -u origin main)
> - Update Default Branch on GitHub [4]
> - Delete 'master' branch (git push origin --delete master)
> 3b. After the central renaming has been done. New users can clone and
> directly checkout 'main' branch. Existing users can start using 'main'
> locally, using the below steps.
> - Switch to master branch (git checkout master)
> - Rename local 'master' branch to 'main' (git branch -m master
> main)
> - Sync local 'main' with repo (git fetch)
> - Remove the existing tracking connection with “origin/master”
> (git branch --unset-upstream)
> - Create a new tracking connection with the new “origin/main”
> branch (git branch -u origin/main)
> - All local branches should still point to the same commit as base
> revision. If there is a problem (git checkout  && git
> rebase main)
>
> 4. Update the integrated systems with CloudStack repos, mainly Travis CI
> and Jenkins configuration with 'main' branch. Check and update UI 
building,
> apidocs, systemvmtemplate builds; project website and docs (cwiki); and 
any
> other build/release jobs. Track them through the issue:
> https://github.com/apache/cloudstack/issues/4887.
>
> 5. Perform Health Checks (using a dummy PR), and ensure there are no
> issues with the build/release configuration. This PR needs to run full
> matrix of tests. Fix the issues noticed during the health checks.
>
> 6. Announce the default branch change to 'main' (and 'master' deprecation)
> on the mailing list.
>
> The vote will be open until Fri 7th May 2021.
>
> For sanity in tallying the vote, Can PMC members please be sure to
> indicate “(binding)” with their vote?
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
>
> [1] https://markmail.org/message/k767evgjnmzogyhf
> [2] https://github.com/github/renaming
> [3]
> 
https://docs.github.com/en/github/administering-a-repository/renaming-a-branch
> [4]
> 
https://docs.github.com/en/github/administering-a-repository/changing-the-default-branch
>
> Regards,
> Suresh
>
>
>
>
>