[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #30: Updating kubernetes version
davidjumani commented on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-828988987 @rhtyd Added docker builds to travis. Unit tests are needed which is tracked in https://github.com/apache/cloudstack-kubernetes-provider/issues/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #212: mysql update warnings
DaanHoogland commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-828998030 I've checked that the default gets applied with "MySQL [5.5.5-10.3.25-MariaDB-0ubuntu0.20.04.1]" and "5.5.68-MariaDB". In my local "MySQL [5.7.28-log]" it gets applied as well. I am not aware of the precise matrix and wouldn't mind if i had the time to explore it; i don't want to make the time right now. I'd say we enter the data we have and let the community evolve the knowledge here over time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #212: mysql update warnings
DaanHoogland commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-828999093 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #212: mysql update warnings
blueorangutan commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-828999707 @DaanHoogland a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #212: mysql update warnings
blueorangutan commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-829000478 Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/212. (SL-JID 50) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] PaulAngus commented on pull request #212: mysql update warnings
PaulAngus commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-829019918 Can someone add a link to where this potential issue was reported please. I agree with Andrija, this is a scary message that basically says: upgrading may or may not trash your database, and that the Admin needs to check their schema, looking for a non-specific problem, and then apply a non-specific fix. If there _is_ an issue, it's our job to ensure that the MySQL upgrade statements work, not the end-users. Worst case, we should check that the schema changes are applied correctly as we go (not a bad idea to do this as a standard procedure for all schema updates). We can then retry with the alternate syntax, or just fail fast. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb commented on pull request #212: mysql update warnings
andrijapanicsb commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-829047656 This was a one-time issue that our British friends have occurred when upgrading their test env from 4.13 to 4.15 while using a specific version of MySQL 5.6.xx - the SQL statement silently failed and the upgrade succeeded (SQL that failed was "ALTER TABLE nics MODIFY COLUMN update_time timestamp DEFAULT CURRENT_TIMESTAMP;" - this is the SQL statement required to support MySQL 8, but I've also seen this being required to be manually executed on MySQL 5.7.latest even with ACS 4.14 (Oracle backported something from 8.x to 5.7.latest) The British friends issue is what triggered Daan writing this statement, but that alone I think is not enough. The issue I saw is more worrying, that even MySQL 5.7.latest needs this manual fix for older version of ACS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] onitake commented on a change in pull request #30: Updating kubernetes version
onitake commented on a change in pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#discussion_r622960377 ## File path: Makefile ## @@ -34,7 +34,7 @@ CMD_SRC=\ .PHONY: all clean docker -all: cloudstack-ccm +all: clean test cloudstack-ccm Review comment: Please don't put that here. If you think a "all" build should delete build artifacts and run the unit tests, open a separate PR. ## File path: .travis.yml ## @@ -4,4 +4,7 @@ go: - 1.13 - master -script: make test +services: + - docker + +script: make docker Review comment: See below. ## File path: Dockerfile ## @@ -18,7 +18,7 @@ FROM golang:1.13 as builder COPY . /go/src/github.com/apache/cloudstack-kubernetes-provider WORKDIR /go/src/github.com/apache/cloudstack-kubernetes-provider -RUN make clean && CGO_ENABLED=0 GOOS=linux make +RUN CGO_ENABLED=0 GOOS=linux make Review comment: See comment below -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] onitake commented on a change in pull request #30: Updating kubernetes version
onitake commented on a change in pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#discussion_r622960584 ## File path: Dockerfile ## @@ -18,7 +18,7 @@ FROM golang:1.13 as builder COPY . /go/src/github.com/apache/cloudstack-kubernetes-provider WORKDIR /go/src/github.com/apache/cloudstack-kubernetes-provider -RUN make clean && CGO_ENABLED=0 GOOS=linux make +RUN CGO_ENABLED=0 GOOS=linux make Review comment: See comment above ## File path: .travis.yml ## @@ -4,4 +4,7 @@ go: - 1.13 - master -script: make test +services: + - docker + +script: make docker Review comment: See comment above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-cloudmonkey] andrijapanicsb opened a new issue #77: set display default - doesn't work
andrijapanicsb opened a new issue #77: URL: https://github.com/apache/cloudstack-cloudmonkey/issues/77 (localcloud) SBCM6> > set display default (localcloud) SBCM6> > list zones Invalid output type configured, please fix that! it allows setting display to default, but later there are errors - would be nice to error out early. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] onitake commented on issue #2: [OLD] Changing from TCP to TCP Proxy doesn't work
onitake commented on issue #2: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/2#issuecomment-829153469 I'm not sure how we can address this... Maybe we should just put a comment in the readme for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on pull request #30: Updating kubernetes version
joschi36 commented on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-829227139 Hey @davidjumani > Can use the image over at davidjumani/cloudstack-kubernetes-provider:k-v1.18.18 Is it possible that it's not build as a non-root container, as I can't start it on my cluster. ` Error: failed to start container "cloud-controller-manager": Error response from daemon: OCI runtime create failed: container_linux.go:346: starting container process caused "exec: \"/root/cloudstack-ccm\": stat /root/cloudstack-ccm: permission denied": unknown ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #212: mysql update warnings
DaanHoogland commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-829233067 @PaulAngus I like your suggestion but I think that is out of scope. Also you and @andrijapanicsb have a point about not giving to vague instructions. I have no exact version matrix and can not make the description more precise. I'll keep this open but convert to draft so we can extend it if we have more info. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #212: mysql update warnings
DaanHoogland commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-829236065 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #212: mysql update warnings
blueorangutan commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-829236877 @DaanHoogland a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #212: mysql update warnings
blueorangutan commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-829237520 Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/212. (SL-JID 51) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] sureshanaparti commented on a change in pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are mean
sureshanaparti commented on a change in pull request #29: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r623089878 ## File path: README.md ## @@ -145,7 +145,7 @@ The CCM supports the same cloud-config configuration file format used by [the cs so you can simply point it to that. ```bash -./cloudstack-ccm --cloud-provider external-cloudstack --cloud-config ~/.cloud-config --master k8s-apiserver +./cloudstack-ccm --cloud-provider external-cloudstack --cloud-config ~/.cloud-config --main k8s-apiserver Review comment: third party changes, i'll revert @davidjumani -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] onitake commented on a change in pull request #30: Updating kubernetes version
onitake commented on a change in pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#discussion_r623466535 ## File path: .travis.yml ## @@ -4,4 +4,7 @@ go: - 1.13 - master -script: make test +services: + - docker + +script: make docker Review comment: The correct wait to run both tests and a release build in Travis is to use build stages: https://docs.travis-ci.com/user/build-stages/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] rhtyd merged pull request #209: Optional deploy-as-is
rhtyd merged pull request #209: URL: https://github.com/apache/cloudstack-documentation/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] rhtyd commented on pull request #209: Optional deploy-as-is
rhtyd commented on pull request #209: URL: https://github.com/apache/cloudstack-documentation/pull/209#issuecomment-829793604 @nvazquez can you raise the same against 4.15 branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #30: Updating kubernetes version
davidjumani commented on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-829803339 @joschi36 I've rebuilt it, can you pull it again and try ? @onitake Reverted the change and will open a separate PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
