[GitHub] [cloudstack-cloudmonkey] DaanHoogland commented on issue #75: list templates doesn't work with variables
DaanHoogland commented on issue #75: URL: https://github.com/apache/cloudstack-cloudmonkey/issues/75#issuecomment-827398426 Did it really @andrijapanicsb? The shell would always expand the var to include the spaces and than cmk would only get the first part as the value of the parameter. I don't think this was ever supposed to work without quotes. i.e. `cloudmonkey list templates name="$template_name" templatefilter=all` instead of `cloudmonkey list templates name=$template_name templatefilter=all` cmk has no control over CLI expansion/passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-cloudmonkey] andrijapanicsb commented on issue #75: list templates doesn't work with variables
andrijapanicsb commented on issue #75: URL: https://github.com/apache/cloudstack-cloudmonkey/issues/75#issuecomment-827399781 Join the Bootcamp in May, and I can show you :) this is how it did work for last few years with CMK 5.3.3, we can take this offline if you want -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] rhtyd commented on pull request #211: Update docs
rhtyd commented on pull request #211: URL: https://github.com/apache/cloudstack-documentation/pull/211#issuecomment-827498434 @davidjumani conflict on master branch, or is it for 4.15 branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Missing Features in the new UI
Hi, I was going through the new UI and noticed that a few features are not yet implemented in the new UI which exist in the legacy UI and APIs exist in the backend (not sure whether they're still functional). I've made a list of them over at https://github.com/apache/cloudstack/issues/4937 and wanted to get feedback on whether there's a need or sufficient users who still use them to implement them in the new UI. The primary ones are : * * Global Server Load Balancing Support http://docs.cloudstack.apache.org/en/latest/adminguide/networking/global_server_load_balancing.html * AutoScale without Netscaler http://docs.cloudstack.apache.org/en/latest/adminguide/autoscale_without_netscaler.html * Override default traffic label for VMware with nexus / dvswitch when adding a cluster If anyone is still using them, please shoutout so a call can be taken whether to implement them in the new UI or not
[GitHub] [cloudstack-documentation] davidjumani commented on pull request #207: Updating image and docs wrt the new UI
davidjumani commented on pull request #207: URL: https://github.com/apache/cloudstack-documentation/pull/207#issuecomment-827505762 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #207: Updating image and docs wrt the new UI
blueorangutan commented on pull request #207: URL: https://github.com/apache/cloudstack-documentation/pull/207#issuecomment-827506180 @davidjumani a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] davidjumani commented on pull request #211: Update docs
davidjumani commented on pull request #211: URL: https://github.com/apache/cloudstack-documentation/pull/211#issuecomment-827506189 @rhtyd It's for 4.15, to be merged after #207 is merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] davidjumani commented on pull request #211: Update docs
davidjumani commented on pull request #211: URL: https://github.com/apache/cloudstack-documentation/pull/211#issuecomment-827506347 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #211: Update docs
blueorangutan commented on pull request #211: URL: https://github.com/apache/cloudstack-documentation/pull/211#issuecomment-827506696 @davidjumani a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #207: Updating image and docs wrt the new UI
blueorangutan commented on pull request #207: URL: https://github.com/apache/cloudstack-documentation/pull/207#issuecomment-827506735 Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/207. (SL-JID 47) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #211: Update docs
blueorangutan commented on pull request #211: URL: https://github.com/apache/cloudstack-documentation/pull/211#issuecomment-827507184 Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/211. (SL-JID 48) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #27: Provider should not be a DaemonSet
davidjumani commented on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-827556759 @onitake Agreed, but in the case of a smaller env, there will be 3 pods on maybe 1 or 2 nodes. I'd prefer to have the replicas proportional to the nodes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani edited a comment on pull request #27: Provider should not be a DaemonSet
davidjumani edited a comment on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-827556759 @onitake Agreed so not necessarily a deamonset, but in the case of a smaller env, there will be 3 pods on maybe 1 or 2 nodes. I'd prefer to have the replicas proportional to the nodes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani edited a comment on pull request #27: Provider should not be a DaemonSet
davidjumani edited a comment on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-827556759 @onitake Agreed so not necessarily a deamonset, but in the case of a smaller env, there will be 3 pods on maybe 1 or 2 nodes, since most users will just apply the deployment. I'd prefer to have the replicas proportional to the nodes. I plan to add this as an automatic deployment as part of a CKS cluster creation once it's officially released -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [DISCUSS] Renaming default git branch name from 'master' to 'main'
great thanks Suresh, I think we should merge these with extreme prejudice so we can smoothen our way of working in time before the 4.16 release pressure kicks in. On Mon, Apr 26, 2021 at 4:02 PM Suresh Anaparti < suresh.anapa...@shapeblue.com> wrote: > Hi all, > > Here is the list of CloudStack repos and respective renaming PRs, which > renames default git branch name from ‘master’ to ‘main’ and replaces some > offensive words/terms as appropriate for inclusiveness. These PRs are > raised against master branch, and should be accepted first before > proceeding with the actual renaming of the default git branch name from > ‘master’ to ‘main’. > > - cloudstack => PR: https://github.com/apache/cloudstack/pull/4922 > - cloudstack-documentation => PR: > https://github.com/apache/cloudstack-documentation/pull/155 > - cloudstack-www => PR: https://github.com/apache/cloudstack-www/pull/83 > - cloudstack-cloudmonkey => PR: > https://github.com/apache/cloudstack-cloudmonkey/pull/76 > - cloudstack-kubernetes-provider => PR: > https://github.com/apache/cloudstack-kubernetes-provider/pull/29 > - cloudstack-ec2stack => PR: > https://github.com/apache/cloudstack-ec2stack/pull/2 > - cloudstack-gcestack => PR: > https://github.com/apache/cloudstack-gcestack/pull/3 > > I’ll start a voting thread sometime later this week, with the integration > steps. > > Please let me know your thoughts/suggestions. > > Regards, > Suresh > > On 01/04/21, 2:47 PM, "Suresh Anaparti" > wrote: > > Thank you Rohit, Paul, Simon, Gabriel for your response on this > proposal, and agreeing to the change. > > I've created a ticket here: > https://github.com/apache/cloudstack/issues/4887, to check the impacted > systems/endpoints and track the changes. I agree with what Paul mentioned, > it is better to deprecate master as soon as renaming change is done, and > the changes (in all the impacted systems/endpoints) should be completed in > short window time. > > Regards, > Suresh > > On 30/03/21, 8:36 PM, "Paul Angus" wrote: > > Maybe we could add main immediately and depricate master > immediately after the next full release. I'd be -1 on any longer. > Otherwise they'll _always_ be someone who wants 'a little bit more time'. > > Kind regards > > > > Paul Angus > > > > From: Wei ZHOU > Sent: Tuesday, March 30, 2021 3:57:25 PM > To: dev@cloudstack.apache.org > Subject: Re: [DISCUSS] Renaming default git branch name from > 'master' to 'main' > > yeah. > It is a small change on github, but it has large impacts. > we can keep both 'main' and 'master' branches for a period of > time, and > keep them sync (e.g. by cron job). > > -Wei > > > suresh.anapa...@shapeblue.com > www.shapeblue.com > 3 London Bridge Street, 3rd floor, News Building, London SE1 9SGUK > @shapeblue > > > > > suresh.anapa...@shapeblue.com > www.shapeblue.com > 3 London Bridge Street, 3rd floor, News Building, London SE1 9SGUK > @shapeblue > > > > On Mon, 29 Mar 2021 at 09:46, Rohit Yadav > wrote: > > > Agree with your proposal Suresh, we need to review all > endpoint/systems > > that integrate which many likely break won't work after the > update, to list > > a few we need to manage post such a change: > > > > * Rename and push the branch and request ASF infra to change > default > > branch to 'main' in Github repo settings for all the repos > > * Travis and Jenkins/ASF integration > > * Community/external CI systems that do rpm/deb packaging, UI > > building, apidocs and systemvmtemplate builds; website and > project docs > > repos build jobs > > * Git mirrors including the ASF mirror (unless we need to do > something > > different) > > * Update usage of 'master' branch on project website, cwiki, > internal > > readme/install docs > > * External docs/blogs/repos/integration and 3rd party > tools/libraries > > that intergrate/use/link with CloudStack > > * Check if Github/Git support a way to still allow pulling > from > > 'master' branch which internally links to 'main' (some like of > aliasing > > like > > > https://stackoverflow.com/questions/549920/is-it-possible-to-alias-a-branch-in-git/549949#549949 > > ) > > > > Regards. > > > > From: Simon Weller > > Sent: Thursday, March 25, 2021 21:08 > > To: dev > > Subject: Re: [DISCUSS] Renaming default git branch name from > 'master' to > > 'main' > > > > +1 > > > > From: Gabriel Beims Bräscher > > Sent: Thursday, March 25, 2021 6:56 AM > > To: dev > > Subject: Re: [DISCUSS] Renaming
[GitHub] [cloudstack-documentation] DaanHoogland opened a new pull request #212: mysql update warnings
DaanHoogland opened a new pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212 This adds a mysql specific upgrade notes page -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #212: mysql update warnings
DaanHoogland commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-827616946 @rhtyd @andrijapanicsb I'm not sure if this is working and enough but please chime in @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #212: mysql update warnings
blueorangutan commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-827617689 @DaanHoogland a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #212: mysql update warnings
blueorangutan commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-827618334 Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/212. (SL-JID 49) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #27: Provider should not be a DaemonSet
onitake commented on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-827637589 3+ replicas of the cloud provider seems like total overkill. It doesn't store any state, and it doesn't need to be highly available. It will synchronize to the environment on startup anyway. This PR is only about the DaemonSet, however. That line in the documentation is no longer relevant and should be removed before 1.0 is released. @davidjumani Can you open a separate issue to discuss the example deployment (number of replicas, recommendations, etc.)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #27: Provider should not be a DaemonSet
davidjumani commented on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-828134379 Right, unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #27: Provider should not be a DaemonSet
davidjumani commented on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-828134518 @rhtyd Can you merge ? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on a change in pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meaning
davidjumani commented on a change in pull request #29: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r621822210 ## File path: README.md ## @@ -145,7 +145,7 @@ The CCM supports the same cloud-config configuration file format used by [the cs so you can simply point it to that. ```bash -./cloudstack-ccm --cloud-provider external-cloudstack --cloud-config ~/.cloud-config --master k8s-apiserver +./cloudstack-ccm --cloud-provider external-cloudstack --cloud-config ~/.cloud-config --main k8s-apiserver Review comment: This requires changes from the Kubernetes control manager Ref: https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on a change in pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meaning
davidjumani commented on a change in pull request #29:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r621824001
##
File path: Makefile
##
@@ -21,7 +21,7 @@ GIT_COMMIT_SHORT=$(shell git rev-parse --short HEAD)
GIT_TAG=$(shell git describe --abbrev=0 --tags 2>/dev/null || echo v0.0.0)
GIT_IS_TAG=$(shell git describe --exact-match --abbrev=0 --tags 2>/dev/null ||
echo NOT_A_TAG)
ifeq (${GIT_IS_TAG},NOT_A_TAG)
-GIT_VERSION?=$(patsubst v%,%,${GIT_TAG})-master+${GIT_COMMIT}
+GIT_VERSION?=$(patsubst v%,%,${GIT_TAG})-main+${GIT_COMMIT}
Review comment:
Might require changes from k8s.io/kubernetes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani opened a new pull request #30: Updating kubernetes version
davidjumani opened a new pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30 Fixes https://github.com/apache/cloudstack-kubernetes-provider/issues/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #30: Updating kubernetes version
davidjumani commented on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-828166025 @onitake @joschi36 Can you review ? Can use the image over at `davidjumani/cloudstack-kubernetes-provider:k-v1.18.18` Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #27: Provider should not be a DaemonSet
rhtyd merged pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
