[GitHub] [cloudstack-documentation] shwstppr commented on a change in pull request #199: ui: added customization details

2021-04-07 Thread GitBox


shwstppr commented on a change in pull request #199:
URL: 
https://github.com/apache/cloudstack-documentation/pull/199#discussion_r608518579



##
File path: source/adminguide/ui.rst
##
@@ -273,6 +280,47 @@ Some assorted primary theme colours:
 - Green: #52C41A
 - Purple: #722ED1
 
+Contextual help documentation URLs can be customized with the help of 
`docBase` and `docHelpMappings` properties.
+A list of documentation help suffixes in code can be obtained using following 
command:

Review comment:
   @rhtyd done

##
File path: source/adminguide/ui.rst
##
@@ -273,6 +280,47 @@ Some assorted primary theme colours:
 - Green: #52C41A
 - Purple: #722ED1
 
+Contextual help documentation URLs can be customized with the help of 
`docBase` and `docHelpMappings` properties.
+A list of documentation help suffixes in code can be obtained using following 
command:
+
+.. parsed-literal::
+
+   grep -rnw cloudstack/ui/src/config/section -e 'docHelp:'
+
+Below example shows configuration changes for custom documentation help URLs:
+
+.. parsed-literal::
+
+   {
+  ...
+  "docBase": http://mycustomwebsite.com,
+  ...
+  "docHelpMappings": {
+ "adminguide/virtual_machines.html": "custom_vm_page.html",
+ "adminguide/templates.html": "custom_templates_page.html"
+  },
+  ...
+   }
+
+UI also provides option to show custom plugins by displaying a custom HTML 
page or service in an iframe. Such plugins can be listed in the config file 
using `plugins` property.
+Example for adding a custom plugin:
+
+.. parsed-literal::
+
+   {
+  ...
+  plugins: [
+ {
+"name": "ExamplePlugin",
+"icon": "appstore",
+"path": "example.html"

Review comment:
   @rhtyd done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] shwstppr commented on pull request #199: ui: added customization details

2021-04-07 Thread GitBox


shwstppr commented on pull request #199:
URL: 
https://github.com/apache/cloudstack-documentation/pull/199#issuecomment-814789305


   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #199: ui: added customization details

2021-04-07 Thread GitBox


blueorangutan commented on pull request #199:
URL: 
https://github.com/apache/cloudstack-documentation/pull/199#issuecomment-814789763


   @shwstppr a Jenkins job has been kicked to build the document. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #199: ui: added customization details

2021-04-07 Thread GitBox


blueorangutan commented on pull request #199:
URL: 
https://github.com/apache/cloudstack-documentation/pull/199#issuecomment-814790254


   Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/199. 
(SL-JID 37)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] shwstppr commented on pull request #199: ui: added customization details

2021-04-07 Thread GitBox


shwstppr commented on pull request #199:
URL: 
https://github.com/apache/cloudstack-documentation/pull/199#issuecomment-814796647


   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #199: ui: added customization details

2021-04-07 Thread GitBox


blueorangutan commented on pull request #199:
URL: 
https://github.com/apache/cloudstack-documentation/pull/199#issuecomment-814797088


   @shwstppr a Jenkins job has been kicked to build the document. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #199: ui: added customization details

2021-04-07 Thread GitBox


blueorangutan commented on pull request #199:
URL: 
https://github.com/apache/cloudstack-documentation/pull/199#issuecomment-814797719


   Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/199. 
(SL-JID 38)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] shwstppr commented on pull request #199: ui: added customization details

2021-04-07 Thread GitBox


shwstppr commented on pull request #199:
URL: 
https://github.com/apache/cloudstack-documentation/pull/199#issuecomment-814845438


   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #199: ui: added customization details

2021-04-07 Thread GitBox


blueorangutan commented on pull request #199:
URL: 
https://github.com/apache/cloudstack-documentation/pull/199#issuecomment-814845984


   @shwstppr a Jenkins job has been kicked to build the document. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #199: ui: added customization details

2021-04-07 Thread GitBox


blueorangutan commented on pull request #199:
URL: 
https://github.com/apache/cloudstack-documentation/pull/199#issuecomment-814846656


   Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/199. 
(SL-JID 39)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-kubernetes-provider] joschi36 opened a new pull request #25: use non-root container

2021-04-07 Thread GitBox


joschi36 opened a new pull request #25:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/25


   I have detected that our container
   1. does run as root user
   2. can't run as non-root user
   
   Therefore, I updated the deployment to run as user 1000 by default and moved 
the binary out of the `/root/` directory.
   
   Also, I changed the `CMD` to `ENTRYPOINT`, so you can use `args` in the 
Kubernetes deployment. Then you don't need to know the command to start the 
daemon and can just add multiple arguments
   
   Ref:
   - https://amazicworld.com/get-the-evil-out-dont-run-containers-as-root/
   - 
https://engineering.bitnami.com/articles/why-non-root-containers-are-important-for-security.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] shwstppr opened a new pull request #206: vm: note about read-only details

2021-04-07 Thread GitBox


shwstppr opened a new pull request #206:
URL: https://github.com/apache/cloudstack-documentation/pull/206


   Adds a note about VM read-only details for users.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org