[GitHub] [cloudstack-primate] blueorangutan commented on pull request #898: Add multiple management server support

2020-12-22 Thread GitBox


blueorangutan commented on pull request #898:
URL: 
https://github.com/apache/cloudstack-primate/pull/898#issuecomment-749405284


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/898 (JID-3766)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #905: Fix tooltip for API parameter

2020-12-22 Thread GitBox


blueorangutan commented on pull request #905:
URL: 
https://github.com/apache/cloudstack-primate/pull/905#issuecomment-749404110


   @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #905: Fix tooltip for API parameter

2020-12-22 Thread GitBox


blueorangutan commented on pull request #905:
URL: 
https://github.com/apache/cloudstack-primate/pull/905#issuecomment-749408334


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/905 (JID-3767)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #876: Handle redirect to sub menu when click parent menu

2020-12-22 Thread GitBox


davidjumani commented on pull request #876:
URL: 
https://github.com/apache/cloudstack-primate/pull/876#issuecomment-749411104


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #876: Handle redirect to sub menu when click parent menu

2020-12-22 Thread GitBox


blueorangutan commented on pull request #876:
URL: 
https://github.com/apache/cloudstack-primate/pull/876#issuecomment-749411556


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #876: Handle redirect to sub menu when click parent menu

2020-12-22 Thread GitBox


blueorangutan commented on pull request #876:
URL: 
https://github.com/apache/cloudstack-primate/pull/876#issuecomment-749416020


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/876 (JID-3768)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #876: Handle redirect to sub menu when click parent menu

2020-12-22 Thread GitBox


rhtyd commented on pull request #876:
URL: 
https://github.com/apache/cloudstack-primate/pull/876#issuecomment-749482838


   LGTM, @davidjumani are you lgtm on it for merging?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #876: Handle redirect to sub menu when click parent menu

2020-12-22 Thread GitBox


davidjumani commented on pull request #876:
URL: 
https://github.com/apache/cloudstack-primate/pull/876#issuecomment-749483018


   @utchoang Looks like navigation sometimes breaks now if anything other than 
the first sub-menu item is selected :(



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #903: Allowing user to use browser timezone

2020-12-22 Thread GitBox


davidjumani commented on pull request #903:
URL: 
https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749484289


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #903: Allowing user to use browser timezone

2020-12-22 Thread GitBox


blueorangutan commented on pull request #903:
URL: 
https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749484822


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #903: Allowing user to use browser timezone

2020-12-22 Thread GitBox


blueorangutan commented on pull request #903:
URL: 
https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749489051


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/903 (JID-3769)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd merged pull request #905: Fix tooltip for API parameter

2020-12-22 Thread GitBox


rhtyd merged pull request #905:
URL: https://github.com/apache/cloudstack-primate/pull/905


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #904: [BUG] Wrong info shown for "Network Rate" label in Compute Offering

2020-12-22 Thread GitBox


rhtyd commented on issue #904:
URL: 
https://github.com/apache/cloudstack-primate/issues/904#issuecomment-749501286


   @sureshanaparti can you test latest master and close, Pearl fixed the issue.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #903: Allowing user to use browser timezone

2020-12-22 Thread GitBox


DaanHoogland commented on pull request #903:
URL: 
https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749560419


   out of interest @davidjumani ; are we looking at a 13:30 timezone difference 
in your example?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #903: Allowing user to use browser timezone

2020-12-22 Thread GitBox


davidjumani commented on pull request #903:
URL: 
https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749591462


   @DaanHoogland yes, the admin's timezone is set to PST while my local time is 
in IST



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on pull request #876: Handle redirect to sub menu when click parent menu

2020-12-22 Thread GitBox


utchoang commented on pull request #876:
URL: 
https://github.com/apache/cloudstack-primate/pull/876#issuecomment-749859438


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #876: Handle redirect to sub menu when click parent menu

2020-12-22 Thread GitBox


blueorangutan commented on pull request #876:
URL: 
https://github.com/apache/cloudstack-primate/pull/876#issuecomment-749859754


   @utchoang a Jenkins job has been kicked to build primate packages. I'll keep 
you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #876: Handle redirect to sub menu when click parent menu

2020-12-22 Thread GitBox


blueorangutan commented on pull request #876:
URL: 
https://github.com/apache/cloudstack-primate/pull/876#issuecomment-749863529


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/876 (JID-3771)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #876: Handle redirect to sub menu when click parent menu

2020-12-22 Thread GitBox


rhtyd commented on pull request #876:
URL: 
https://github.com/apache/cloudstack-primate/pull/876#issuecomment-749957444


   @blueorangutan package 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #876: Handle redirect to sub menu when click parent menu

2020-12-22 Thread GitBox


blueorangutan commented on pull request #876:
URL: 
https://github.com/apache/cloudstack-primate/pull/876#issuecomment-749957850


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep 
you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #903: Allowing user to use browser timezone

2020-12-22 Thread GitBox


rhtyd commented on pull request #903:
URL: 
https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749958009


   @davidjumani nit - should it say local or computer timezone? 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #903: Allowing user to use browser timezone

2020-12-22 Thread GitBox


davidjumani commented on pull request #903:
URL: 
https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749959551


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #903: Allowing user to use browser timezone

2020-12-22 Thread GitBox


blueorangutan commented on pull request #903:
URL: 
https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749959961


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #876: Handle redirect to sub menu when click parent menu

2020-12-22 Thread GitBox


blueorangutan commented on pull request #876:
URL: 
https://github.com/apache/cloudstack-primate/pull/876#issuecomment-749961492


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/876 (JID-3772)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #903: Allowing user to use browser timezone

2020-12-22 Thread GitBox


blueorangutan commented on pull request #903:
URL: 
https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749963681


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/903 (JID-3773)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #903: Allowing user to use browser timezone

2020-12-22 Thread GitBox


davidjumani commented on pull request #903:
URL: 
https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749966226


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #903: Allowing user to use browser timezone

2020-12-22 Thread GitBox


blueorangutan commented on pull request #903:
URL: 
https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749966384


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #903: Allowing user to use browser timezone

2020-12-22 Thread GitBox


blueorangutan commented on pull request #903:
URL: 
https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749970392


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/903 (JID-3774)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #903: Allowing user to use browser timezone

2020-12-22 Thread GitBox


rhtyd commented on a change in pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#discussion_r547725003



##
File path: src/locales/en.json
##
@@ -2155,6 +2155,7 @@
 "label.usageinterface": "Usage Interface",
 "label.usagename": "Usage Type",
 "label.usageunit": "Unit",
+"label.use.system.timezone": "Use System Timezone",

Review comment:
   As I said that was just nit-picking. This is actually more misleading 
(which system?), the previous one made more sense (I think most users may 
prefer Computer timezone or local timezone... consult with others?)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #876: Handle redirect to sub menu when click parent menu

2020-12-22 Thread GitBox


rhtyd commented on pull request #876:
URL: 
https://github.com/apache/cloudstack-primate/pull/876#issuecomment-749974580


   LGTM - on latest testing on desktop and mobile; the only case it doesn't 
work is when you click on right on the nav title (not on the expand button but 
between the title/label and the right expand button, it expands than open the 
first child) - still better than what we've now.
   @davidjumani can you test your cases?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org