[GitHub] [cloudstack-primate] davidjumani commented on pull request #871: Disallowing udp as a lb protocol

2020-11-26 Thread GitBox 


davidjumani commented on pull request #871:
URL: 
https://github.com/apache/cloudstack-primate/pull/871#issuecomment-734172511


   Closing this as other load balancers might support udp



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani closed pull request #871: Disallowing udp as a lb protocol

2020-11-26 Thread GitBox 


davidjumani closed pull request #871:
URL: https://github.com/apache/cloudstack-primate/pull/871


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [DISCUSS] python test framework

2020-11-26 Thread Daan Hoogland 
Thanks PL,

I have focussed on a nose2 on python3 implementation so far [1]. If anybody
feels like contributing there, be welcome. I is only a PoC yet but looks
promising. The total work seems like a moderately large job and pretty
straight forward, with the most challenging part the redesign of the
callbacks being provided by nose2 in comparison to nose. We still have to
test verification through ssh and db connectors but these are so widely
used by the larger python community that I'm not too scared of those.
I hope that nose2 has a lively community as I see more issues than answers
on github [2]
serverspec seems like a good model, so I'll give that a look as well

@Peter (peter.murysh...@zv.fraunhofer.de) I saw a separate mail [3] by you
about your test setup, but couldn't grasp it yet. I hope we can have a ccc
one day soon again to discuss in close quarters.

[1] https://github.com/apache/cloudstack/pull/4479
[2]
https://github.com/nose-devs/nose2/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc
[3]
https://lists.apache.org/thread.html/r0788da5cdb0cebf349b12cc5f488621c48e509e880216989cb35%40%3Cdev.cloudstack.apache.org%3E



On Mon, 16 Nov 2020, 15:03 Pierre-Luc Dion,  wrote:

> It would be interesting if we could come up with a  catalogue of api tests,
> as serverspec [1] did for infrastructure tests.
> if we would have some kind of library of tests, then the only  things we
> would define in our tests suite would be the order of
> unit tests and pretty much no code.
>
> I don't know if there is an equivalent of serverspec framework on Python,
> serverspec is the predecessor to Chef-inspec, unit tests for infra.
> This could be a reference starting point.
>
> Via nose2 seems to make sense.
>
> [1] https://serverspec.org/
>
>
> On Mon, Nov 16, 2020 at 5:34 AM  wrote:
>
> > Hi there Dan,
> >
> > we work to setup the test environment and will share relevant output
> > fragments with the limitation we can't share complete logs publicly.
> >
> > kind regards
> > Peter
> > 
> > Von: Daan Hoogland 
> > Gesendet: Montag, 16. November 2020 11:12:55
> > An: dev
> > Betreff: Re: [DISCUSS] python test framework
> >
> > sounds like I am on my own. Any body cares to chime in?
> >
> > On Thu, Nov 12, 2020 at 10:21 PM Nicolas Vazquez <
> > nicolas.vazq...@shapeblue.com> wrote:
> >
> > > LGTM
> > >
> > >
> > > Regards,
> > >
> > > Nicolas Vazquez
> > >
> > > 
> > > From: Daan Hoogland 
> > > Sent: Thursday, November 12, 2020 1:05 PM
> > > To: dev 
> > > Subject: Re: [DISCUSS] python test framework
> > >
> > > I checked the source code and the last commit is from the 3rd of March.
> > > nose2 might require some effort from the community @here as well.
> > >
> > > On Thu, Nov 12, 2020 at 12:58 PM David Jumani <
> > david.jum...@shapeblue.com>
> > > wrote:
> > >
> > > > ++1 and like Boris said, need to look into backward compatibility
> > > > 
> > > > From: Boris Stoyanov 
> > > > Sent: Thursday, November 12, 2020 2:26 PM
> > > > To: dev@cloudstack.apache.org 
> > > > Subject: Re: [DISCUSS] python test framework
> > > >
> > > > +1 on nose2, as the marvin plugin is built on nose, it seems the
> > natural
> > > > choice to upgrade to. We need to investigate backwards compatibility
> > > > though..
> > > >
> > > > Bobby.
> > > >
> > > > On 11.11.20, 21:28, "Daan Hoogland" 
> > > wrote:
> > > >
> > > > devs,
> > > > Investigating an new organization of test categories , I found
> that
> > > > our framework in use, nose, is no longer in maintenance. Its
> maintainer
> > > has
> > > > stopped his support in 2017. As it is quite stable it has slipped our
> > > > attention, but it is urgent that we discuss and choose a way forward.
> > > There
> > > > is a successor, nose2, which as the documentation tells me, has less
> > > > support for underlying test types but is also extensible. This is my
> > goto
> > > > choice to investigate further the coming days, but I’d like input
> from
> > of
> > > > you as many as possible.
> > > > Regards,
> > > >
> > > > daan.hoogl...@shapeblue.com
> > > > www.shapeblue.com
> > > > 3 London Bridge Street,  3rd floor, News Building, London  SE1
> > 9SGUK
> > > > @shapeblue
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > boris.stoya...@shapeblue.com
> > > > www.shapeblue.com
> > > > 3 London Bridge Street,  3rd floor, News Building, London  SE1 9SGUK
> > > > @shapeblue
> > > >
> > > >
> > > >
> > > >
> > > > david.jum...@shapeblue.com
> > > > www.shapeblue.com
> > > > 3 London Bridge Street,  3rd floor, News Building, London  SE1 9SGUK
> > > > @shapeblue
> > > >
> > > >
> > > >
> > > >
> > >
> > > --
> > > Daan
> > >
> > > nicolas.vazq...@shapeblue.com
> > > www.shapeblue.com
> > > 3 London Bridge Street,  3rd floor, News Building, London  SE1 9SGUK
> > > @shapeblue
> > >
> > >
> > >
>

[GitHub] [cloudstack-primate] svenvogel commented on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage

2020-11-26 Thread GitBox 


svenvogel commented on pull request #808:
URL: 
https://github.com/apache/cloudstack-primate/pull/808#issuecomment-734373369


   @davidjumani can you clarify where you use "quiescevm" in VMware and which 
feature you want to test? there are normal VM Snapshots and i only know volume 
snapshot like VVOLs. Do you speak about VVOLs? Can you link or clarify the test?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] svenvogel edited a comment on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage

2020-11-26 Thread GitBox 


svenvogel edited a comment on pull request #808:
URL: 
https://github.com/apache/cloudstack-primate/pull/808#issuecomment-734373369


   @davidjumani can you clarify where you use "quiescevm" in VMware and which 
feature you want to test? there are normal VM Snapshots and i only know volume 
snapshot like VVOLs. Do you speak about VVOLs (virtual volumes)? Can you link 
or clarify the test?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] svenvogel edited a comment on pull request #808: FIX - compute - Create snapshot from virtual machine with managed storage

2020-11-26 Thread GitBox 


svenvogel edited a comment on pull request #808:
URL: 
https://github.com/apache/cloudstack-primate/pull/808#issuecomment-734373369


   @davidjumani can you clarify where you use "quiescevm" in VMware and which 
feature you want to test? there are normal VM Snapshots and i only know volume 
snapshot like VVOLs. Do you speak about VVOLs (virtual volumes)? Can you link 
or clarify the test?
   
   Maybe we dont need an VMware test because there is no functionality they use 
the volume snapshot and qiescing.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #872: Support for spcifying VR IP in shared networks

2020-11-26 Thread GitBox 


Pearl1594 commented on pull request #872:
URL: 
https://github.com/apache/cloudstack-primate/pull/872#issuecomment-734657337


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #872: Support for spcifying VR IP in shared networks

2020-11-26 Thread GitBox 


blueorangutan commented on pull request #872:
URL: 
https://github.com/apache/cloudstack-primate/pull/872#issuecomment-734657694


   @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #872: Support for spcifying VR IP in shared networks

2020-11-26 Thread GitBox 


blueorangutan commented on pull request #872:
URL: 
https://github.com/apache/cloudstack-primate/pull/872#issuecomment-734660269


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/872 (JID-3695)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org