[GitHub] [cloudstack-primate] borisstoyanov commented on issue #869: [BUG] Hypervisor version shows ACS version instead

2020-11-24 Thread GitBox


borisstoyanov commented on issue #869:
URL: 
https://github.com/apache/cloudstack-primate/issues/869#issuecomment-732724609


   ![Screenshot 2020-11-24 at 9 59 
38](https://user-images.githubusercontent.com/13551960/100064930-d10a6680-2e3b-11eb-99f3-dc5452e60fe6.png)
   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] borisstoyanov closed issue #869: [BUG] Hypervisor version shows ACS version instead

2020-11-24 Thread GitBox


borisstoyanov closed issue #869:
URL: https://github.com/apache/cloudstack-primate/issues/869


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #871: Disallowing udp as a lb protocol

2020-11-24 Thread GitBox


davidjumani commented on pull request #871:
URL: 
https://github.com/apache/cloudstack-primate/pull/871#issuecomment-732727670


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #871: Disallowing udp as a lb protocol

2020-11-24 Thread GitBox


blueorangutan commented on pull request #871:
URL: 
https://github.com/apache/cloudstack-primate/pull/871#issuecomment-732727987


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #871: Disallowing udp as a lb protocol

2020-11-24 Thread GitBox


blueorangutan commented on pull request #871:
URL: 
https://github.com/apache/cloudstack-primate/pull/871#issuecomment-732732597


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/871 (JID-3689)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #871: Disallowing udp as a lb protocol

2020-11-24 Thread GitBox


rhtyd commented on pull request #871:
URL: 
https://github.com/apache/cloudstack-primate/pull/871#issuecomment-732838414


   To be merged only if backend PR is merged. Can you review/advise 
@weizhouapache @ravening ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] rhtyd commented on pull request #150: 4.15 Release & Upgrade Notes

2020-11-24 Thread GitBox


rhtyd commented on pull request #150:
URL: 
https://github.com/apache/cloudstack-documentation/pull/150#issuecomment-732845777


   If there are no objections I'll merge this, any new changes can be submitted 
as new PR
   
   requesting docbuild
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] ravening commented on pull request #871: Disallowing udp as a lb protocol

2020-11-24 Thread GitBox


ravening commented on pull request #871:
URL: 
https://github.com/apache/cloudstack-primate/pull/871#issuecomment-732847453


   > To be merged only if backend PR is merged. Can you review/advise 
@weizhouapache @ravening ?
   
   @davidjumani @rhtyd it does support udp
   
   ```
   (local) 🐱 > create loadbalancerrule name=test privateport=80 publicport=8080 
protocol=udp account=admin domainid=04dfd1c6-c28e-11ea-9a43-0617bc003377 
networkid=d396de4e-0e23-4e3b-a19a-1fe1ac35227c 
publicipid=6275b645-fac5-4b03-a2f1-40848655ffd0 algorithm=roundrobin
   {
 "loadbalancer": {
   "account": "admin",
   "algorithm": "roundrobin",
   "cidrlist": "",
   "domain": "ROOT",
   "domainid": "04dfd1c6-c28e-11ea-9a43-0617bc003377",
   "fordisplay": true,
   "id": "d1883751-9e55-4104-a522-c6c5c09a123b",
   "name": "test",
   "networkid": "d396de4e-0e23-4e3b-a19a-1fe1ac35227c",
   "privateport": "80",
   "protocol": "udp",
   "publicip": "10.10.20.1",
   "publicipid": "6275b645-fac5-4b03-a2f1-40848655ffd0",
   "publicport": "8080",
   "state": "Add",
   "tags": [],
   "zoneid": "8ae93aed-7db1-4a1a-9030-db0efac6ba62",
   "zonename": "mgt122-10"
 }
   }
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #150: 4.15 Release & Upgrade Notes

2020-11-24 Thread GitBox


DaanHoogland commented on pull request #150:
URL: 
https://github.com/apache/cloudstack-documentation/pull/150#issuecomment-732996469


   as you stated @rhtyd , we'll need addtional changes, but it doesn't matter 
if we add them here or in a new PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #871: Disallowing udp as a lb protocol

2020-11-24 Thread GitBox


DaanHoogland commented on pull request #871:
URL: 
https://github.com/apache/cloudstack-primate/pull/871#issuecomment-732998835


   @ravening , when you say "it does support udp" do you mean that actual udp 
based load-balancing takes place, and not just the api accepts the value for 
the protocol parameter?
   Is this on the VR based loadbalancer (i.e. a process like ha-proxy running 
on the VR) or only on an external provider?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] ravening commented on pull request #871: Disallowing udp as a lb protocol

2020-11-24 Thread GitBox


ravening commented on pull request #871:
URL: 
https://github.com/apache/cloudstack-primate/pull/871#issuecomment-733001235


   > @ravening , when you say "it does support udp" do you mean that actual udp 
based load-balancing takes place, and not just the api accepts the value for 
the protocol parameter?
   > Is this on the VR based loadbalancer (i.e. a process like ha-proxy running 
on the VR) or only on an external provider?
   
   @DaanHoogland ignore my previous comment. Found out that haproxy doesnt 
suport udp. so we can remove that option from cloudstack.
   
   
   @davidjumani I already have a PR for haproxy based loadbalancer for ui in 
https://github.com/apache/cloudstack-primate/pull/778
   If you are ok then I can make changes there only



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on pull request #568: Build and packaging improvements

2020-11-24 Thread GitBox


utchoang commented on pull request #568:
URL: 
https://github.com/apache/cloudstack-primate/pull/568#issuecomment-733419769


js/app.js reduced by >3.00 MiB
   
![image](https://user-images.githubusercontent.com/13766648/100174610-560a8400-2eff-11eb-86c6-6d6716757745.png)
   
![image](https://user-images.githubusercontent.com/13766648/100174629-5efb5580-2eff-11eb-85f4-71a02e852dee.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org