[GitHub] [cloudstack-primate] davidjumani commented on issue #847: [BUG] add ldap user button missing
davidjumani commented on issue #847: URL: https://github.com/apache/cloudstack-primate/issues/847#issuecomment-723844734 @utchoang Please go ahead and raise a PR for the change. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang opened a new pull request #851: FIX - Show clear the add LDAP account button
utchoang opened a new pull request #851: URL: https://github.com/apache/cloudstack-primate/pull/851 @rhtyd @davidjumani cc @svenvogel Fixes #847  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #851: FIX - Show clear the add LDAP account button
utchoang commented on pull request #851: URL: https://github.com/apache/cloudstack-primate/pull/851#issuecomment-723862189 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #851: FIX - Show clear the add LDAP account button
blueorangutan commented on pull request #851: URL: https://github.com/apache/cloudstack-primate/pull/851#issuecomment-723862979 @utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #851: FIX - Show clear the add LDAP account button
blueorangutan commented on pull request #851: URL: https://github.com/apache/cloudstack-primate/pull/851#issuecomment-723868850 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/851 (JID-3649) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland opened a new issue #852: [BUG] ldap add account does not return after selecting AnyDomain filter
DaanHoogland opened a new issue #852: URL: https://github.com/apache/cloudstack-primate/issues/852 **Describe the bug** https://user-images.githubusercontent.com/2486961/98532340-dbe0cb00-2281-11eb-87eb-06f4b1bafaa9.png";> selecting AnyDomain as filter does not return even with empty result set. as opposed to: https://user-images.githubusercontent.com/2486961/98532495-13e80e00-2282-11eb-9abe-14ecc78c9e86.png";> or : https://user-images.githubusercontent.com/2486961/98532596-3548fa00-2282-11eb-8666-54d151810277.png";> it is not clear to me yet, what the problematic circumstances are. some combinations of filter and domain do not return. It seems the an empty result set might be the problem. **To Reproduce** Steps to reproduce the behavior: 1. Log in as an Admin 1. Go to 'Accounts --> Add LDAP Account' 1. select different filter/domain combinations **Expected behavior** A result set should be shown within reasonable time. **Screenshots** see description **Desktop (please complete the following information):** - OS: [e.g. Windows, Mac, iOS, Android with device/screen details if applicable] - Browser [e.g. chrome, safari] - Version [e.g. 22] **Additional context** Add any other context about the problem here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #853: addldapaccount: Fix defensive check
davidjumani commented on pull request #853: URL: https://github.com/apache/cloudstack-primate/pull/853#issuecomment-723955079 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #853: addldapaccount: Fix defensive check
davidjumani opened a new pull request #853: URL: https://github.com/apache/cloudstack-primate/pull/853 Fixes https://github.com/apache/cloudstack-primate/issues/852 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #853: addldapaccount: Fix defensive check
blueorangutan commented on pull request #853: URL: https://github.com/apache/cloudstack-primate/pull/853#issuecomment-723955628 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #853: addldapaccount: Fix defensive check
davidjumani commented on a change in pull request #853:
URL: https://github.com/apache/cloudstack-primate/pull/853#discussion_r519741977
##
File path: src/views/iam/AddLdapAccount.vue
##
@@ -283,7 +283,7 @@ export default {
params.domainid = store.getters.userInfo.domainid
if (domain) {
const result = this.listDomains.filter(item => item.name === domain)
-if (result) {
+if (result.length > 0) {
Review comment:
Can't be none. Either an empty list or a single item
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on a change in pull request #853: addldapaccount: Fix defensive check
DaanHoogland commented on a change in pull request #853:
URL: https://github.com/apache/cloudstack-primate/pull/853#discussion_r519741714
##
File path: src/views/iam/AddLdapAccount.vue
##
@@ -283,7 +283,7 @@ export default {
params.domainid = store.getters.userInfo.domainid
if (domain) {
const result = this.listDomains.filter(item => item.name === domain)
-if (result) {
+if (result.length > 0) {
Review comment:
how about result == None?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #853: addldapaccount: Fix defensive check
davidjumani commented on a change in pull request #853:
URL: https://github.com/apache/cloudstack-primate/pull/853#discussion_r519741977
##
File path: src/views/iam/AddLdapAccount.vue
##
@@ -283,7 +283,7 @@ export default {
params.domainid = store.getters.userInfo.domainid
if (domain) {
const result = this.listDomains.filter(item => item.name === domain)
-if (result) {
+if (result.length > 0) {
Review comment:
Can't be none. Either an empty list of not
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #853: addldapaccount: Fix defensive check
blueorangutan commented on pull request #853: URL: https://github.com/apache/cloudstack-primate/pull/853#issuecomment-723961422 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/853 (JID-3650) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland merged pull request #851: FIX - Show clear the add LDAP account button
DaanHoogland merged pull request #851: URL: https://github.com/apache/cloudstack-primate/pull/851 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland merged pull request #853: addldapaccount: Fix defensive check
DaanHoogland merged pull request #853: URL: https://github.com/apache/cloudstack-primate/pull/853 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland closed issue #847: [BUG] add ldap user button missing
DaanHoogland closed issue #847: URL: https://github.com/apache/cloudstack-primate/issues/847 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland closed issue #852: [BUG] ldap add account does not return after selecting AnyDomain filter
DaanHoogland closed issue #852: URL: https://github.com/apache/cloudstack-primate/issues/852 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] sm97 opened a new issue #854: [BUG] DomainAdmin user has no Configure Limits tab in Project
sm97 opened a new issue #854: URL: https://github.com/apache/cloudstack-primate/issues/854 **Describe the bug** DomainAdmin role allows to update project resource limits by default but Primate hides Configure Limit tab in WEB UI. Only SuperAdmin has such tab. **Expected behavior** It's expected that every role with updateResourceLimit permission can use Configure Limit tab for project. **Screenshots** Affected account props:  Screen view for admin account;  Screen view for DomainAdmin role account:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #855: Allow domain admins to configure resource limits
Pearl1594 opened a new pull request #855: URL: https://github.com/apache/cloudstack-primate/pull/855 Fixes: https://github.com/apache/cloudstack-primate/issues/854 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #855: Allow domain admins to configure resource limits
Pearl1594 commented on pull request #855: URL: https://github.com/apache/cloudstack-primate/pull/855#issuecomment-724010541 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #855: Allow domain admins to configure resource limits
blueorangutan commented on pull request #855: URL: https://github.com/apache/cloudstack-primate/pull/855#issuecomment-724010977 @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #855: Allow domain admins to configure resource limits
blueorangutan commented on pull request #855: URL: https://github.com/apache/cloudstack-primate/pull/855#issuecomment-724017274 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/855 (JID-3651) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] sm97 commented on pull request #855: Allow domain admins to configure resource limits
sm97 commented on pull request #855: URL: https://github.com/apache/cloudstack-primate/pull/855#issuecomment-724039924 IMHO the better approach is to enable tab based on user permissons not role names. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] alexandru-bagu closed pull request #839: showing ostypeid input even if we use vmware because cloudstack api requires it
alexandru-bagu closed pull request #839: URL: https://github.com/apache/cloudstack-primate/pull/839 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #855: Allow domain admins to configure resource limits
davidjumani commented on pull request #855: URL: https://github.com/apache/cloudstack-primate/pull/855#issuecomment-724467666 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #855: Allow domain admins to configure resource limits
blueorangutan commented on pull request #855: URL: https://github.com/apache/cloudstack-primate/pull/855#issuecomment-724468065 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #855: Allow domain admins to configure resource limits
blueorangutan commented on pull request #855: URL: https://github.com/apache/cloudstack-primate/pull/855#issuecomment-724472371 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/855 (JID-3653) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang opened a new pull request #856: FIX - Project invitations - Add new filter state `expired`
utchoang opened a new pull request #856: URL: https://github.com/apache/cloudstack-primate/pull/856 @rhtyd @davidjumani cc @svenvogel   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang opened a new pull request #857: FIX - Domain - Reset tree selected when resetting search.
utchoang opened a new pull request #857: URL: https://github.com/apache/cloudstack-primate/pull/857 @rhtyd @davidjumani cc @svenvogel - Before:   - After:   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #856: FIX - Project invitations - Add new filter state `expired`
utchoang commented on pull request #856: URL: https://github.com/apache/cloudstack-primate/pull/856#issuecomment-724496134 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #856: FIX - Project invitations - Add new filter state `expired`
blueorangutan commented on pull request #856: URL: https://github.com/apache/cloudstack-primate/pull/856#issuecomment-724497218 @utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #856: FIX - Project invitations - Add new filter state `expired`
blueorangutan commented on pull request #856: URL: https://github.com/apache/cloudstack-primate/pull/856#issuecomment-724501559 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/856 (JID-3654) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] sureshanaparti opened a new pull request #169: Updated docs with the new storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
sureshanaparti opened a new pull request #169: URL: https://github.com/apache/cloudstack-documentation/pull/169 Added new storage plugin (Dell EMC PowerFlex/ScaleIO) to the documentation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #857: FIX - Domain - Reset tree selected when resetting search.
utchoang commented on pull request #857: URL: https://github.com/apache/cloudstack-primate/pull/857#issuecomment-724509214 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #857: FIX - Domain - Reset tree selected when resetting search.
blueorangutan commented on pull request #857: URL: https://github.com/apache/cloudstack-primate/pull/857#issuecomment-724509724 @utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #857: FIX - Domain - Reset tree selected when resetting search.
blueorangutan commented on pull request #857: URL: https://github.com/apache/cloudstack-primate/pull/857#issuecomment-724513571 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/857 (JID-3655) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #858: kubernetesservicetab: Fixing instance tab
davidjumani opened a new pull request #858: URL: https://github.com/apache/cloudstack-primate/pull/858 Show ip or ssh port based on the network type This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
