[GitHub] [cloudstack-primate] utchoang opened a new pull request #752: Custom: Fix background color of navigation with domain/user has logged.

2020-09-25 Thread GitBox


utchoang opened a new pull request #752:
URL: https://github.com/apache/cloudstack-primate/pull/752


   @rhtyd cc @svenvogel 
   - Before
   
![image](https://user-images.githubusercontent.com/13766648/94236441-6d48e780-ff37-11ea-9df3-85032d20d24a.png)
   
   - After
   
![image](https://user-images.githubusercontent.com/13766648/94236478-7fc32100-ff37-11ea-960b-1156ef918ba7.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd merged pull request #752: Custom: Fix background color of navigation with domain/user has logged.

2020-09-25 Thread GitBox


rhtyd merged pull request #752:
URL: https://github.com/apache/cloudstack-primate/pull/752


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #748: FIX - Domain: fix error tree domain after deleting the domain.

2020-09-25 Thread GitBox


rhtyd commented on pull request #748:
URL: 
https://github.com/apache/cloudstack-primate/pull/748#issuecomment-698768028


   LGTM
   @DaanHoogland can you review/test this? Thanks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-25 Thread GitBox


rhtyd commented on pull request #745:
URL: 
https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698767877


   LGTM
   @DaanHoogland can you review/test this? Thanks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-25 Thread GitBox


rhtyd commented on pull request #744:
URL: 
https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698767954


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-25 Thread GitBox


blueorangutan commented on pull request #744:
URL: 
https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698768282


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep 
you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-25 Thread GitBox


blueorangutan commented on pull request #744:
URL: 
https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698773011


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/744 (JID-3518)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland commented on issue #747: [BUG] Domain admin cannot edit a domain they created

2020-09-25 Thread GitBox


DaanHoogland commented on issue #747:
URL: 
https://github.com/apache/cloudstack-primate/issues/747#issuecomment-698792641


   good explanation @utchoang closing (verified that the API is not available 
for domain admins which i think is the real bug!)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland closed issue #747: [BUG] Domain admin cannot edit a domain they created

2020-09-25 Thread GitBox


DaanHoogland closed issue #747:
URL: https://github.com/apache/cloudstack-primate/issues/747


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #748: FIX - Domain: fix error tree domain after deleting the domain.

2020-09-25 Thread GitBox


DaanHoogland commented on pull request #748:
URL: 
https://github.com/apache/cloudstack-primate/pull/748#issuecomment-698801079


   renewing package to include yesterdays fixes
   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #748: FIX - Domain: fix error tree domain after deleting the domain.

2020-09-25 Thread GitBox


blueorangutan commented on pull request #748:
URL: 
https://github.com/apache/cloudstack-primate/pull/748#issuecomment-698801286


   @DaanHoogland a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #748: FIX - Domain: fix error tree domain after deleting the domain.

2020-09-25 Thread GitBox


blueorangutan commented on pull request #748:
URL: 
https://github.com/apache/cloudstack-primate/pull/748#issuecomment-698805090


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/748 (JID-3519)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland merged pull request #748: FIX - Domain: fix error tree domain after deleting the domain.

2020-09-25 Thread GitBox


DaanHoogland merged pull request #748:
URL: https://github.com/apache/cloudstack-primate/pull/748


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland closed issue #741: [BUG] when deleting a domain with a subdomain, it remains visible

2020-09-25 Thread GitBox


DaanHoogland closed issue #741:
URL: https://github.com/apache/cloudstack-primate/issues/741


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-25 Thread GitBox


DaanHoogland commented on pull request #745:
URL: 
https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698823220


   did a quick test on the pr link and got (cc @davidjumani )
   
   https://user-images.githubusercontent.com/2486961/94250023-f7398600-ff20-11ea-940c-27a3982e1447.png";>
   
   I'll have do extensive editting of roles while being logged on to test this, 
so postponing...
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-25 Thread GitBox


rhtyd commented on pull request #744:
URL: 
https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698890689


   cc @DaanHoogland 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-25 Thread GitBox


DaanHoogland commented on pull request #745:
URL: 
https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698908753


   ok , 2 extra tests done:
   https://user-images.githubusercontent.com/2486961/94268822-024edf00-ff3e-11ea-8b9b-c3d68b23503e.png";>
   
   and 
   
   https://user-images.githubusercontent.com/2486961/94268841-0975ed00-ff3e-11ea-92b5-2f57a1836f71.png";>
merging based on that.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland commented on issue #650: [BUG] After session expire the page reloads once more

2020-09-25 Thread GitBox


DaanHoogland commented on issue #650:
URL: 
https://github.com/apache/cloudstack-primate/issues/650#issuecomment-698909210


   verified with #745



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland closed issue #740: [BUG] user with special role is denied log on without sensible message

2020-09-25 Thread GitBox


DaanHoogland closed issue #740:
URL: https://github.com/apache/cloudstack-primate/issues/740


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland closed issue #650: [BUG] After session expire the page reloads once more

2020-09-25 Thread GitBox


DaanHoogland closed issue #650:
URL: https://github.com/apache/cloudstack-primate/issues/650


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland merged pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-25 Thread GitBox


DaanHoogland merged pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on pull request #8: Some fixes for Go 1.13

2020-09-25 Thread GitBox


rhtyd commented on pull request #8:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-698181704







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] rhtyd merged pull request #133: Edit OVS Plugin

2020-09-25 Thread GitBox


rhtyd merged pull request #133:
URL: https://github.com/apache/cloudstack-documentation/pull/133


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #743: [BUG] Edit instance - offer existing Groups

2020-09-25 Thread GitBox


andrijapanicsb commented on issue #743:
URL: 
https://github.com/apache/cloudstack-primate/issues/743#issuecomment-698249539


   As a user, I don't see a value of being able to just enter a group name and 
have it created automatically (plain dumb, but that's what's already there...) 
- it's just confusing.
   
   Up to you, I would prefer being able to click on it and see existing groups 
- which makes more sense than creating a group in that same "Edit instance" 
form. Thx



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on issue #741: [BUG] when deleting a domain with a subdomain, it remains visible

2020-09-25 Thread GitBox


utchoang commented on issue #741:
URL: 
https://github.com/apache/cloudstack-primate/issues/741#issuecomment-698147434


   @DaanHoogland @rhtyd cc @svenvogel 
   I tried with http://primate-qa.cloudstack.cloud:8080/client/master/ but I 
can't reproduce the error. When I removed the `sub` domain then both` sub` & 
`leaf` were removed from the tree domain. Can you retest and tell me where the 
error came from?
   
![image](https://user-images.githubusercontent.com/13766648/94109524-4de48880-fe6b-11ea-9e05-1e887c83528d.png)
   
![image](https://user-images.githubusercontent.com/13766648/94109568-62288580-fe6b-11ea-8ae2-b1e4e36871f6.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-kubernetes-provider] rhtyd closed issue #3: [OLD] Implement IP whitelists

2020-09-25 Thread GitBox


rhtyd closed issue #3:
URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/3


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] rhtyd commented on pull request #60: Volumes metrics doc update

2020-09-25 Thread GitBox


rhtyd commented on pull request #60:
URL: 
https://github.com/apache/cloudstack-documentation/pull/60#issuecomment-698186980


   @andrijapanicsb can you address conflict and move to ready for review when 
this is ready?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #9: Support loadBalancerSourceRanges

2020-09-25 Thread GitBox


rhtyd merged pull request #9:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/9


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #8: Some fixes for Go 1.13

2020-09-25 Thread GitBox


rhtyd merged pull request #8:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/8


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on pull request #748: FIX - Domain: fix error tree domain after deleting the domain.

2020-09-25 Thread GitBox


utchoang commented on pull request #748:
URL: 
https://github.com/apache/cloudstack-primate/pull/748#issuecomment-698308855


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #751: Adding multi disk selection for supported templates

2020-09-25 Thread GitBox


andrijapanicsb commented on pull request #751:
URL: 
https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698400120







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-25 Thread GitBox


davidjumani commented on pull request #744:
URL: 
https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698162174


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-kubernetes-provider] onitake commented on issue #2: [OLD] Changing from TCP to TCP Proxy doesn't work

2020-09-25 Thread GitBox


onitake commented on issue #2:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/issues/2#issuecomment-698397268


   @joschi36 can you test if this bug still occurs? I think we fixed it with 
all the changes in #9 , but I'm not completely sure.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on issue #16: [DISCUSS] Work on next release

2020-09-25 Thread GitBox


rhtyd commented on issue #16:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-698153003


   ping @onitake - pl advise whenever it's ready for the next release? Thanks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland commented on issue #741: [BUG] when deleting a domain with a subdomain, it remains visible

2020-09-25 Thread GitBox


DaanHoogland commented on issue #741:
URL: 
https://github.com/apache/cloudstack-primate/issues/741#issuecomment-698185327







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang edited a comment on issue #741: [BUG] when deleting a domain with a subdomain, it remains visible

2020-09-25 Thread GitBox


utchoang edited a comment on issue #741:
URL: 
https://github.com/apache/cloudstack-primate/issues/741#issuecomment-698147434


   @DaanHoogland @rhtyd cc @svenvogel 
   I tried with http://primate-qa.cloudstack.cloud:8080/client/master/ but I 
can't reproduce the error. When I removed the `sub` domain then both` sub` & 
`leaf` were removed from the tree domain. Can you retest and tell me where the 
error came from?
   
![image](https://user-images.githubusercontent.com/13766648/94109524-4de48880-fe6b-11ea-9e05-1e887c83528d.png)
   
![image](https://user-images.githubusercontent.com/13766648/94110023-1f1ae200-fe6c-11ea-8eb9-8f512c454aec.png)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] rhtyd merged pull request #147: secondary storage management

2020-09-25 Thread GitBox


rhtyd merged pull request #147:
URL: https://github.com/apache/cloudstack-documentation/pull/147


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-25 Thread GitBox


davidjumani commented on pull request #745:
URL: 
https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698162197







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] nvazquez commented on a change in pull request #751: Adding multi disk selection for supported templates

2020-09-25 Thread GitBox


nvazquez commented on a change in pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751#discussion_r494735051



##
File path: src/views/compute/DeployVM.vue
##
@@ -1484,6 +1524,12 @@ export default {
   deployVmData.bootintosetup = values.bootintosetup
 }
 
+// if (deployVmData) {

Review comment:
   Remove me :)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-25 Thread GitBox


blueorangutan commented on pull request #744:
URL: 
https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698125525







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] rhtyd merged pull request #145: Modified project details - role based users in projects

2020-09-25 Thread GitBox


rhtyd merged pull request #145:
URL: https://github.com/apache/cloudstack-documentation/pull/145


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #743: [BUG] Edit instance - offer existing Groups

2020-09-25 Thread GitBox


rhtyd commented on issue #743:
URL: 
https://github.com/apache/cloudstack-primate/issues/743#issuecomment-698180716


   @andrijapanicsb the API allows both changing to an existing group or add to 
a new group (a new name would also create a new group). Should we keep it as it 
is?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] rhtyd merged pull request #151: cks: root disk controller and nic adapter for CoreOS VMware

2020-09-25 Thread GitBox


rhtyd merged pull request #151:
URL: https://github.com/apache/cloudstack-documentation/pull/151


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-25 Thread GitBox


utchoang commented on pull request #744:
URL: 
https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698142524







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #8: Some fixes for Go 1.13

2020-09-25 Thread GitBox


onitake commented on pull request #8:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-698179080







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on issue #650: [BUG] After session expire the page reloads once more

2020-09-25 Thread GitBox


davidjumani commented on issue #650:
URL: 
https://github.com/apache/cloudstack-primate/issues/650#issuecomment-698170910


   @rhtyd Fixed the logout issue in 
https://github.com/apache/cloudstack-primate/pull/745 Now it logs out but 
leaves a notification that the session has expired



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #751: Adding multi disk selection for supported templates

2020-09-25 Thread GitBox


davidjumani commented on pull request #751:
URL: 
https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698422257







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-25 Thread GitBox


rhtyd commented on pull request #745:
URL: 
https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698178811







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-25 Thread GitBox


rhtyd commented on pull request #744:
URL: 
https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698125324







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] rhtyd merged pull request #149: Renamed dhclient folder to DHCP

2020-09-25 Thread GitBox


rhtyd merged pull request #149:
URL: https://github.com/apache/cloudstack-documentation/pull/149


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #751: Adding multi disk selection for supported templates

2020-09-25 Thread GitBox


blueorangutan commented on pull request #751:
URL: 
https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698400438







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on issue #747: [BUG] Domain admin cannot edit a domain they created

2020-09-25 Thread GitBox


utchoang commented on issue #747:
URL: 
https://github.com/apache/cloudstack-primate/issues/747#issuecomment-698709080


   @DaanHoogland @rhtyd cc @svenvogel  On the old UI side, Domain Admin is only 
allowed to edit resources, not edit domain names. So in the new UI, you can 
update the resource on the resource tab instead of needing the edit button like 
the old UI. Thanks.
   * Domain Admin
   
![image](https://user-images.githubusercontent.com/13766648/94225403-0b7c8380-ff1f-11ea-877b-cdd49dec2534.png)
   
   * Admin
   
![image](https://user-images.githubusercontent.com/13766648/94225453-2e0e9c80-ff1f-11ea-9c77-cf250f1b953a.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] rhtyd commented on pull request #132: cloud-init and UserData service documentation cleanup

2020-09-25 Thread GitBox


rhtyd commented on pull request #132:
URL: 
https://github.com/apache/cloudstack-documentation/pull/132#issuecomment-698185977


   @onitake can you address merge conflict, and update as necessary? Thanks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #748: FIX - Domain: fix error tree domain after deleting the domain.

2020-09-25 Thread GitBox


blueorangutan commented on pull request #748:
URL: 
https://github.com/apache/cloudstack-primate/pull/748#issuecomment-698309094







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] shwstppr commented on pull request #151: cks: root disk controller and nic adapter for CoreOS VMware

2020-09-25 Thread GitBox


shwstppr commented on pull request #151:
URL: 
https://github.com/apache/cloudstack-documentation/pull/151#issuecomment-698204359


   With root disk resize I meant when `createKubernetesCluster` API is used 
with a value for its `noderootdisksize`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-25 Thread GitBox


blueorangutan commented on pull request #745:
URL: 
https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698162597







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland merged pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-25 Thread GitBox


DaanHoogland merged pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #748: FIX - Domain: fix error tree domain after deleting the domain.

2020-09-25 Thread GitBox


rhtyd commented on pull request #748:
URL: 
https://github.com/apache/cloudstack-primate/pull/748#issuecomment-698768028


   LGTM
   @DaanHoogland can you review/test this? Thanks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-25 Thread GitBox


DaanHoogland commented on pull request #745:
URL: 
https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698823220







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland closed issue #650: [BUG] After session expire the page reloads once more

2020-09-25 Thread GitBox


DaanHoogland closed issue #650:
URL: https://github.com/apache/cloudstack-primate/issues/650


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland closed issue #740: [BUG] user with special role is denied log on without sensible message

2020-09-25 Thread GitBox


DaanHoogland closed issue #740:
URL: https://github.com/apache/cloudstack-primate/issues/740


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd merged pull request #752: Custom: Fix background color of navigation with domain/user has logged.

2020-09-25 Thread GitBox


rhtyd merged pull request #752:
URL: https://github.com/apache/cloudstack-primate/pull/752


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland closed issue #747: [BUG] Domain admin cannot edit a domain they created

2020-09-25 Thread GitBox


DaanHoogland closed issue #747:
URL: https://github.com/apache/cloudstack-primate/issues/747


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-25 Thread GitBox


DaanHoogland commented on pull request #744:
URL: 
https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698928207







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #748: FIX - Domain: fix error tree domain after deleting the domain.

2020-09-25 Thread GitBox


DaanHoogland commented on pull request #748:
URL: 
https://github.com/apache/cloudstack-primate/pull/748#issuecomment-698801079


   renewing package to include yesterdays fixes
   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland commented on issue #747: [BUG] Domain admin cannot edit a domain they created

2020-09-25 Thread GitBox


DaanHoogland commented on issue #747:
URL: 
https://github.com/apache/cloudstack-primate/issues/747#issuecomment-698792641


   good explanation @utchoang closing (verified that the API is not available 
for domain admins which i think is the real bug!)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland merged pull request #748: FIX - Domain: fix error tree domain after deleting the domain.

2020-09-25 Thread GitBox


DaanHoogland merged pull request #748:
URL: https://github.com/apache/cloudstack-primate/pull/748


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland closed issue #741: [BUG] when deleting a domain with a subdomain, it remains visible

2020-09-25 Thread GitBox


DaanHoogland closed issue #741:
URL: https://github.com/apache/cloudstack-primate/issues/741


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] andrijapanicsb merged pull request #751: Adding multi disk selection for supported templates

2020-09-25 Thread GitBox


andrijapanicsb merged pull request #751:
URL: https://github.com/apache/cloudstack-primate/pull/751


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland commented on issue #650: [BUG] After session expire the page reloads once more

2020-09-25 Thread GitBox


DaanHoogland commented on issue #650:
URL: 
https://github.com/apache/cloudstack-primate/issues/650#issuecomment-698909210


   verified with #745



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-25 Thread GitBox


utchoang commented on pull request #744:
URL: 
https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698952644


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-25 Thread GitBox


blueorangutan commented on pull request #744:
URL: 
https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698953177


   @utchoang a Jenkins job has been kicked to build primate packages. I'll keep 
you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-25 Thread GitBox


blueorangutan commented on pull request #744:
URL: 
https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698960810


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/744 (JID-3520)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] ravening commented on issue #749: [BUG] Domain admin cannot create a second user in an account

2020-09-25 Thread GitBox


ravening commented on issue #749:
URL: 
https://github.com/apache/cloudstack-primate/issues/749#issuecomment-698998889


   @DaanHoogland I was not able to reproduce the issue
   
   1. I have a domain "test" with account name "test" with "domain admin" 
access and username "test1"
   2. Login to the domain admin account with "test1/test1/test" as 
username/password/domain
   3. Now I create one more domain under test with name "test-11"
   4. I create a new "domain admin" account with name "test-11-account" and 
first user with name "test-11-user" under domain "test-11"
   5. Now I will try to create another user under account "test-11-account" 
with name "test-12-user"
   6. Didnt see any error
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #753: [BUG] Getting 404 after deleting a VM

2020-09-25 Thread GitBox


andrijapanicsb opened a new issue #753:
URL: https://github.com/apache/cloudstack-primate/issues/753


   VM deletion in progress:
   
   
![image](https://user-images.githubusercontent.com/45762285/94292071-c1b28e00-ff5c-11ea-8162-06bed43e3ee0.png)
   
   
   After it's done, instead of going back to the list of instances, I get 404:
   
   
![image](https://user-images.githubusercontent.com/45762285/94292127-d55df480-ff5c-11ea-8e74-057177852431.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-25 Thread GitBox


DaanHoogland commented on pull request #744:
URL: 
https://github.com/apache/cloudstack-primate/pull/744#issuecomment-699032300


   great @utchoang all three work now



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland closed issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

2020-09-25 Thread GitBox


DaanHoogland closed issue #678:
URL: https://github.com/apache/cloudstack-primate/issues/678


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland merged pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-25 Thread GitBox


DaanHoogland merged pull request #744:
URL: https://github.com/apache/cloudstack-primate/pull/744


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] DaanHoogland commented on issue #749: [BUG] Domain admin cannot create a second user in an account

2020-09-25 Thread GitBox


DaanHoogland commented on issue #749:
URL: 
https://github.com/apache/cloudstack-primate/issues/749#issuecomment-699033871


   @ravening the error is when you create account but enter the same name as 
the original account. a bit of a strange use case but it is documented to work 
fine. So don't "+ Add User" but "+ Add Account". You see in the help of the 
account field of that dialog that it is supposed to work.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] ravening commented on issue #749: [BUG] Domain admin cannot create a second user in an account

2020-09-25 Thread GitBox


ravening commented on issue #749:
URL: 
https://github.com/apache/cloudstack-primate/issues/749#issuecomment-699158463


   > @ravening the error is when you create account but enter the same name as 
the original account. a bit of a strange use case but it is documented to work 
fine. So don't "+ Add User" but "+ Add Account". You see in the help of the 
account field of that dialog that it is supposed to work.
   
   @DaanHoogland i didn't see add account option while adding second user



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org