[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #718: FIX - customize theme
DaanHoogland commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696556549 @utchoang I saw that only the navigation colour can be set. I would expect the main pane to be matching. Does that make sense? Or should it also be a separate colour? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
utchoang commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696559221 @DaanHoogland Regarding the adjustment of the main page, it takes quite a lot of changes (CSS, style). Can I do it if it's absolutely necessary? @rhtyd thought? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on issue #650: [BUG] After session expire the page reloads once more
DaanHoogland commented on issue #650: URL: https://github.com/apache/cloudstack-primate/issues/650#issuecomment-696560325 double checking this with the latest nightly build. results in different environments seem erratic. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #718: FIX - customize theme
DaanHoogland commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696571307 @utchoang It was just an observation with regards to the issue #714 I do consider this a feature (not broderline-) so I do not regard this part of 1.0 ga! I think we should have a full theming/cusitmization issue for 1.1. I think we should merge this and call it a release. I assure you, I'll keep coming up with issues if we don't. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on issue #731: [BUG] Volume destroy form NOT closed after submitting the job
DaanHoogland commented on issue #731: URL: https://github.com/apache/cloudstack-primate/issues/731#issuecomment-696583365 confirmed in latest This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland closed issue #731: [BUG] Volume destroy form NOT closed after submitting the job
DaanHoogland closed issue #731: URL: https://github.com/apache/cloudstack-primate/issues/731 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on issue #650: [BUG] After session expire the page reloads once more
DaanHoogland commented on issue #650: URL: https://github.com/apache/cloudstack-primate/issues/650#issuecomment-696587222 @davidjumani I notice that after i perform anything on an expired session, it first redirects to the login page and then refreshes that page. Is this as intended? seems overkill (unless there is a good reason of course) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #718: FIX - customize theme
DaanHoogland commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696591312 are you updating `customize.md` in this PR, @utchoang ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on issue #725: [FEATURE] Add CIDR next to the network name, for deploy-as-is templates
DaanHoogland commented on issue #725: URL: https://github.com/apache/cloudstack-primate/issues/725#issuecomment-696593898 works: https://user-images.githubusercontent.com/2486961/93862235-01aa1480-fcc2-11ea-83e8-8fa3a4b1437e.png";> This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland closed issue #725: [FEATURE] Add CIDR next to the network name, for deploy-as-is templates
DaanHoogland closed issue #725: URL: https://github.com/apache/cloudstack-primate/issues/725 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
utchoang commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696599663 @DaanHoogland Yes. I've updated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] PaulAngus commented on issue #714: [BUG] (UI) (borderline feature request) - can't change the navigation menu color for default view or project view
PaulAngus commented on issue #714: URL: https://github.com/apache/cloudstack-primate/issues/714#issuecomment-696632351 just to check, it was the **_background_** colour of the navigation bar, rather than links. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] PaulAngus commented on issue #714: [BUG] (UI) (borderline feature request) - can't change the navigation menu color for default view or project view
PaulAngus commented on issue #714: URL: https://github.com/apache/cloudstack-primate/issues/714#issuecomment-696632804 I may want it blue, red, white, yellow to match the branding in the data panel This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #703: [BUG] "VPN uses" missing from the network-related main menu
rhtyd commented on issue #703: URL: https://github.com/apache/cloudstack-primate/issues/703#issuecomment-696676394 I'm closing on your remark Andrija, there is a navigation management possible by going to a network -> IP -> VPN tab -> manage users. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #703: [BUG] "VPN uses" missing from the network-related main menu
rhtyd closed issue #703: URL: https://github.com/apache/cloudstack-primate/issues/703 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #650: [BUG] After session expire the page reloads once more
rhtyd commented on issue #650: URL: https://github.com/apache/cloudstack-primate/issues/650#issuecomment-696676911 @DaanHoogland if you've a form/wizard open for example and then you say restart management server, then you may redirect to login page with the form still open. I think that's why we reload, @davidjumani ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #714: [BUG] (UI) (borderline feature request) - can't change the navigation menu color for default view or project view
rhtyd commented on issue #714: URL: https://github.com/apache/cloudstack-primate/issues/714#issuecomment-696677598 @PaulAngus from one of the screenshot's I see from Hoang's PR, the background is set to brown and lgtm - https://github.com/apache/cloudstack-primate/pull/718#issuecomment-694708920 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
rhtyd commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696677919 Thanks @utchoang @DaanHoogland lgtm, but I need to do one round of test with a real deb/rpm based package. I'll merge it after that (today/tomorrow). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
rhtyd commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696678564 @utchoang can you send a doc PR to https://github.com/apache/cloudstack-documentation/blob/master/source/installguide/primate.rst#basic-customization-in-cloudstack-primate This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #650: [BUG] After session expire the page reloads once more
davidjumani commented on issue #650: URL: https://github.com/apache/cloudstack-primate/issues/650#issuecomment-696682124 That's right @rhtyd @DaanHoogland If it makes sense we can prevent the reload but if a popup form is submitted when the session expires, it will log out only when the user navigates to another page, but they will still be notified that their session has expired This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT
rhtyd commented on issue #678: URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-696684821 @davidjumani can you pick this or advise @utchoang on what/how to fix this? Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #736: [BUG] Show ISO info/name, instead of just UUID
andrijapanicsb opened a new issue #736: URL: https://github.com/apache/cloudstack-primate/issues/736 ISO, that is attached to the VM  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on pull request #9: Support loadBalancerSourceRanges
rhtyd commented on pull request #9: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-696793816 @onitake can you advise when this is ready for merging, thnx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on pull request #8: Some fixes for Go 1.13
rhtyd commented on pull request #8: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-696793893 @onitake can you advise when this is ready for merging, thnx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on pull request #6: [WIP] Improved Ingress Controller example to be clearer and more complete
rhtyd commented on pull request #6: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/6#issuecomment-696793982 @onitake can you advise when this is ready for merging, thnx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #736: [BUG] Show ISO info/name, instead of just UUID
rhtyd commented on issue #736: URL: https://github.com/apache/cloudstack-primate/issues/736#issuecomment-696794865 I'm seeing both name and uuid, what is the issue @andrijapanicsb ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] utchoang opened a new pull request #159: Menu/link background color customization
utchoang opened a new pull request #159: URL: https://github.com/apache/cloudstack-documentation/pull/159 @rhtyd cc @svenvogel This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] nvazquez opened a new pull request #737: Hide root disk controller, nic adapter and guest OS when registering deploy as is template
nvazquez opened a new pull request #737: URL: https://github.com/apache/cloudstack-primate/pull/737 Deploy as is template must not allow selecting: - Root disk controller - NIC adapter type - Guest OS That information is obtained from the OVF as-is  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
utchoang commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696559221 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland closed issue #731: [BUG] Volume destroy form NOT closed after submitting the job
DaanHoogland closed issue #731: URL: https://github.com/apache/cloudstack-primate/issues/731 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
rhtyd commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696677919 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on issue #650: [BUG] After session expire the page reloads once more
DaanHoogland commented on issue #650: URL: https://github.com/apache/cloudstack-primate/issues/650#issuecomment-696560325 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] PaulAngus commented on issue #714: [BUG] (UI) (borderline feature request) - can't change the navigation menu color for default view or project view
PaulAngus commented on issue #714: URL: https://github.com/apache/cloudstack-primate/issues/714#issuecomment-696632351 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #734: [BUG] Switch project show blank or undefined message
rhtyd closed issue #734: URL: https://github.com/apache/cloudstack-primate/issues/734 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #718: FIX - customize theme
DaanHoogland commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-696556549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland closed issue #725: [FEATURE] Add CIDR next to the network name, for deploy-as-is templates
DaanHoogland closed issue #725: URL: https://github.com/apache/cloudstack-primate/issues/725 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on pull request #6: [WIP] Improved Ingress Controller example to be clearer and more complete
rhtyd commented on pull request #6: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/6#issuecomment-696793982 @onitake can you advise when this is ready for merging, thnx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #735: [FIX] - The message empty or undefined when switch project
rhtyd merged pull request #735: URL: https://github.com/apache/cloudstack-primate/pull/735 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #703: [BUG] "VPN uses" missing from the network-related main menu
rhtyd commented on issue #703: URL: https://github.com/apache/cloudstack-primate/issues/703#issuecomment-696676394 I'm closing on your remark Andrija, there is a navigation management possible by going to a network -> IP -> VPN tab -> manage users. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on issue #731: [BUG] Volume destroy form NOT closed after submitting the job
DaanHoogland commented on issue #731: URL: https://github.com/apache/cloudstack-primate/issues/731#issuecomment-696583365 confirmed in latest This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on pull request #9: Support loadBalancerSourceRanges
rhtyd commented on pull request #9: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-696793816 @onitake can you advise when this is ready for merging, thnx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on issue #725: [FEATURE] Add CIDR next to the network name, for deploy-as-is templates
DaanHoogland commented on issue #725: URL: https://github.com/apache/cloudstack-primate/issues/725#issuecomment-696593898 works: https://user-images.githubusercontent.com/2486961/93862235-01aa1480-fcc2-11ea-83e8-8fa3a4b1437e.png";> This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT
rhtyd commented on issue #678: URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-696684821 @davidjumani can you pick this or advise @utchoang on what/how to fix this? Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #650: [BUG] After session expire the page reloads once more
davidjumani commented on issue #650: URL: https://github.com/apache/cloudstack-primate/issues/650#issuecomment-696682124 That's right @rhtyd @DaanHoogland If it makes sense we can prevent the reload but if a popup form is submitted when the session expires, it will log out only when the user navigates to another page, but they will still be notified that their session has expired This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #703: [BUG] "VPN uses" missing from the network-related main menu
rhtyd closed issue #703: URL: https://github.com/apache/cloudstack-primate/issues/703 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #714: [BUG] (UI) (borderline feature request) - can't change the navigation menu color for default view or project view
rhtyd commented on issue #714: URL: https://github.com/apache/cloudstack-primate/issues/714#issuecomment-696677598 @PaulAngus from one of the screenshot's I see from Hoang's PR, the background is set to brown and lgtm - https://github.com/apache/cloudstack-primate/pull/718#issuecomment-694708920 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on pull request #8: Some fixes for Go 1.13
rhtyd commented on pull request #8: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-696793893 @onitake can you advise when this is ready for merging, thnx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #736: [BUG] Show ISO info/name, instead of just UUID
rhtyd commented on issue #736: URL: https://github.com/apache/cloudstack-primate/issues/736#issuecomment-696794865 I'm seeing both name and uuid, what is the issue @andrijapanicsb ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #650: [BUG] After session expire the page reloads once more
rhtyd commented on issue #650: URL: https://github.com/apache/cloudstack-primate/issues/650#issuecomment-696676911 @DaanHoogland if you've a form/wizard open for example and then you say restart management server, then you may redirect to login page with the form still open. I think that's why we reload, @davidjumani ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #737: Hide root disk controller, nic adapter and guest OS when registering deploy as is template
rhtyd commented on pull request #737: URL: https://github.com/apache/cloudstack-primate/pull/737#issuecomment-697148282 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #737: Hide root disk controller, nic adapter and guest OS when registering deploy as is template
rhtyd commented on pull request #737: URL: https://github.com/apache/cloudstack-primate/pull/737#issuecomment-697148196 LGTM Need second pair of eyes, @davidjumani can you review this? @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
rhtyd commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697148486 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #737: Hide root disk controller, nic adapter and guest OS when registering deploy as is template
blueorangutan commented on pull request #737: URL: https://github.com/apache/cloudstack-primate/pull/737#issuecomment-697148478 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme
blueorangutan commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697148754 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #718: FIX - customize theme
rhtyd commented on a change in pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#discussion_r493213313
##
File path: src/views/AutogenView.vue
##
@@ -653,16 +653,9 @@ export default {
return
}
-if ([401].includes(error.response.status)) {
Review comment:
@utchoang why not dispatch logout on 401/unauthorise error?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #718: FIX - customize theme
rhtyd commented on a change in pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#discussion_r493213585
##
File path: src/views/compute/DeployVM.vue
##
@@ -1749,11 +1749,11 @@ export default {
},
fetchTemplateNics (template) {
var nics = []
- if (template && template.deployasisdetails &&
Object.keys(template.deployasisdetails).length > 0) {
Review comment:
@utchoang why is this part of the PR change?
##
File path: src/views/iam/DomainView.vue
##
@@ -181,14 +181,7 @@ export default {
duration: 0
})
-if ([401].includes(error.response.status)) {
Review comment:
@utchoang same as above?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #712: [BUG] '@link-color' does not effect the mouse-over color in details section
rhtyd commented on issue #712: URL: https://github.com/apache/cloudstack-primate/issues/712#issuecomment-697151077 LGTM, verified link and hover colour  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #718: FIX - customize theme
utchoang commented on a change in pull request #718:
URL: https://github.com/apache/cloudstack-primate/pull/718#discussion_r493215529
##
File path: src/views/AutogenView.vue
##
@@ -653,16 +653,9 @@ export default {
return
}
-if ([401].includes(error.response.status)) {
Review comment:
@rhtyd I don't have changed it. Maybe it's because I haven't merged with
the latest master yet.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #713: [BUG] '@processing' color does not affect the page loading progress or circular 'I'm thinking' graphic
rhtyd commented on issue #713: URL: https://github.com/apache/cloudstack-primate/issues/713#issuecomment-697151211 LGTM, verified action notification loading icon colour  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #714: [BUG] (UI) (borderline feature request) - can't change the navigation menu color for default view or project view
rhtyd commented on issue #714: URL: https://github.com/apache/cloudstack-primate/issues/714#issuecomment-697151475 Verified left nav bar colour for default view:  Project view is still dark-er though:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
rhtyd commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697151776 Tested, LGTM Verified left nav bar colour for default view:  Project view is still dark-er though:  @utchoang would it be possible to define a custom background colour for the navigation bar on left when we're in a project view (i.e. selected a project)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #737: Hide root disk controller, nic adapter and guest OS when registering deploy as is template
blueorangutan commented on pull request #737: URL: https://github.com/apache/cloudstack-primate/pull/737#issuecomment-697152477 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/737 (JID-3500) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme
blueorangutan commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697152756 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/718 (JID-3501) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT
davidjumani commented on issue #678: URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697155944 @utchoang I think fixing this would involve merging DetailsTab, FirewallRules, PortForwarding, LoadBalancing and VpnDetails into a single tabbed vue. Once this is done : 1. If the resource has port forwarding / load balancing rules, the enableStaticNat button should be hidden. 2. If it is an ip associated with a vpc network, allow adding firewall rules, and either port forwarding or load balancing rules. Hide the port forwarding tab if load balancing rules are present and vice versa This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
