[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
rhtyd edited a comment on issue #704: URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-693280722 I think it was like that before but then we got an issue reported here see https://github.com/apache/cloudstack-primate/issues/456 @PaulAngus @andrijapanicsb cc @borisstoyanov Is David's fix to only forget redirect path on explicit logout acceptable, or now we want to revert the fix we did for #456 (that is simply forget path on session/explicit logout)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
rhtyd commented on issue #704: URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-693280722 I think it was like that before but then we got an issue reported here see https://github.com/apache/cloudstack-primate/issues/456 @PaulAngus @andrijapanicsb cc @borisstoyanov Is David's fix to only forget redirect path on explicit logout acceptable, or now we want to revert the fix we did for #456 (that is simply forget path on session/explicit logout) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme
rhtyd commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693282324 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #710: vApps fix: use deployasisdetails instead of details
andrijapanicsb commented on pull request #710: URL: https://github.com/apache/cloudstack-primate/pull/710#issuecomment-693282564 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb merged pull request #710: vApps fix: use deployasisdetails instead of details
andrijapanicsb merged pull request #710: URL: https://github.com/apache/cloudstack-primate/pull/710 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #650: [BUG] After session expire the page reloads once more
rhtyd closed issue #650: URL: https://github.com/apache/cloudstack-primate/issues/650 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme
blueorangutan commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693283161 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #658: Fixes reload of page on session expiry
rhtyd merged pull request #658: URL: https://github.com/apache/cloudstack-primate/pull/658 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #650: [BUG] After session expire the page reloads once more
rhtyd commented on issue #650: URL: https://github.com/apache/cloudstack-primate/issues/650#issuecomment-693284006 Can you test and close @borisstoyanov @andrijapanicsb This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #714: [BUG] (UI) (borderline feature request) - can't change the navigation menu color for default view or project view
rhtyd commented on issue #714: URL: https://github.com/apache/cloudstack-primate/issues/714#issuecomment-693284779 @utchoang can you explore if we can change the background of left nav bar for light vs dark mode ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #651: Prevent form from closing if validation fails
davidjumani commented on pull request #651: URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-693286466 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #651: Prevent form from closing if validation fails
blueorangutan commented on pull request #651: URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-693287045 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme
blueorangutan commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693287727 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/718 (JID-3479) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on issue #714: [BUG] (UI) (borderline feature request) - can't change the navigation menu color for default view or project view
utchoang commented on issue #714: URL: https://github.com/apache/cloudstack-primate/issues/714#issuecomment-693290849 @rhtyd This is OK. I'll add to #718 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #651: Prevent form from closing if validation fails
blueorangutan commented on pull request #651: URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-693291581 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/651 (JID-3480) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
utchoang commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693291859 @rhtyd Do we need to add a light / dark mode to the red border area (image)? Because this will make CSS editing pretty much.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #651: Prevent form from closing if validation fails
rhtyd merged pull request #651: URL: https://github.com/apache/cloudstack-primate/pull/651 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #681: Enable tags for lb rules
rhtyd commented on pull request #681: URL: https://github.com/apache/cloudstack-primate/pull/681#issuecomment-693297032 Thanks @ravening This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
utchoang commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693299441 @rhtyd Does the dark mode of the switch to the project affect the custom theme with config.json? For example background color? = This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang edited a comment on pull request #718: FIX - customize theme
utchoang edited a comment on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693299441 @rhtyd Does the dark mode of the switch to the project affect the custom theme with config.json? For example background color? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] slavkap opened a new pull request #153: [WIP] Storage-based VM snapshots on KVM
slavkap opened a new pull request #153: URL: https://github.com/apache/cloudstack-documentation/pull/153 Documentation fo pull request - https://github.com/apache/cloudstack/pull/3724 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #716: usermenu: Forgetting path when manually logging out
rhtyd commented on a change in pull request #716:
URL: https://github.com/apache/cloudstack-primate/pull/716#discussion_r489338867
##
File path: src/components/header/UserMenu.vue
##
@@ -66,7 +66,7 @@ export default {
...mapGetters(['nickname', 'avatar']),
handleLogout () {
return this.Logout({}).then(() => {
-window.location.reload()
+this.$router.push('/user/login')
}).catch(err => {
this.$message.error({
title: '错误',
Review comment:
localise this?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #689: [BUG] Buttons not clickable while error popup present
rhtyd commented on issue #689: URL: https://github.com/apache/cloudstack-primate/issues/689#issuecomment-693325523 I'll close this as buttons are clickable once the popup error notification is closed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #689: [BUG] Buttons not clickable while error popup present
rhtyd closed issue #689: URL: https://github.com/apache/cloudstack-primate/issues/689 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani opened a new issue #719: [FEATURE] Move fetch data to created()
davidjumani opened a new issue #719: URL: https://github.com/apache/cloudstack-primate/issues/719 Move fetchData to created from mounted to reduce wait time for api calls since the data has been created but the page has not yet been rendered This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #720: [BUG] "OS Type" not shown in instance view
andrijapanicsb opened a new issue #720: URL: https://github.com/apache/cloudstack-primate/issues/720 old UI:  new UI is missing this field Would be nice for someone to systematically go through the list of details that are displayed on old UI (for instances at least) and compare to the detailed displayed in Primate for the same instance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme
utchoang commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693936388 Customize navigation background color and text color   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang removed a comment on pull request #718: FIX - customize theme
utchoang removed a comment on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693936388 Customize navigation background color and text color   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
