[GitHub] [cloudstack-primate] rhtyd closed issue #652: [BUG] Minor: update label/text
rhtyd closed issue #652: URL: https://github.com/apache/cloudstack-primate/issues/652 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #655: Changing 'to default' to 'as default'
rhtyd merged pull request #655: URL: https://github.com/apache/cloudstack-primate/pull/655 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #652: [BUG] Minor: update label/text
rhtyd commented on issue #652: URL: https://github.com/apache/cloudstack-primate/issues/652#issuecomment-685442641 @andrijapanicsb fixed in https://github.com/apache/cloudstack-primate/pull/655, please review and close the issue This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #657: vm wizard: add MAC Address validator
rhtyd commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-685443073 @blueoragutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd removed a comment on pull request #657: vm wizard: add MAC Address validator
rhtyd removed a comment on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-685443073 @blueoragutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #657: vm wizard: add MAC Address validator
rhtyd commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-68561 @utchoang in the network record if that's an isolated/shared network (or != L2 network) then you can check the `record.cidr` and you can check if the input IP is within the cidr [1][2] [1] https://tech.mybuilder.com/determining-if-an-ipv4-address-is-within-a-cidr-range-in-javascript/ [2] https://stackoverflow.com/questions/46200086/how-to-check-if-a-given-ip-falls-between-a-given-ip-range-using-node-js This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #657: vm wizard: add MAC Address validator
rhtyd commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-685444540 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #661: Hiding vlan uri for non admin users
rhtyd merged pull request #661: URL: https://github.com/apache/cloudstack-primate/pull/661 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #657: vm wizard: add MAC Address validator
blueorangutan commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-685445145 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #659: [BUG] Regular users should not see their network's VLAN
rhtyd closed issue #659: URL: https://github.com/apache/cloudstack-primate/issues/659 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #644: [BUG] Add message/questions when unmanaging an instance?
rhtyd commented on issue #644: URL: https://github.com/apache/cloudstack-primate/issues/644#issuecomment-685446005 @andrijapanicsb fixed in https://github.com/apache/cloudstack-primate/pull/656 please review and close the issue, thnx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #644: [BUG] Add message/questions when unmanaging an instance?
rhtyd closed issue #644: URL: https://github.com/apache/cloudstack-primate/issues/644 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #659: [BUG] Regular users should not see their network's VLAN
rhtyd commented on issue #659: URL: https://github.com/apache/cloudstack-primate/issues/659#issuecomment-685445509 @andrijapanicsb fixed in https://github.com/apache/cloudstack-primate/pull/661 please review and close the issue, thnx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #656: Adding message to unmanage vm
rhtyd merged pull request #656: URL: https://github.com/apache/cloudstack-primate/pull/656 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #654: template/iso listing User role regression from #642
rhtyd merged pull request #654: URL: https://github.com/apache/cloudstack-primate/pull/654 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #649: Filter vms based on zones for attaching volumes
rhtyd commented on pull request #649: URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-685446569 ping @davidjumani @Pearl1594 - can you advise if this works/break for a project view, thnx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #662: Refresh data every 30 seconds
rhtyd commented on pull request #662: URL: https://github.com/apache/cloudstack-primate/pull/662#issuecomment-685447382 This is not ideal or fail-safe, what-if it takes more than n * 30s for the batched jobs to finished (where n is the number of resources on which a group action was performed)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #658: Fixes reload of page on session expiry
rhtyd commented on pull request #658: URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-685450339 Did a quick test LGTM (I deleted the jsession cookie and click a router-link), need more testing for cases (a) on mgmt server restart, (b) on actual session expiry (say after 30mins...) cc @davidjumani This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd edited a comment on pull request #658: Fixes reload of page on session expiry
rhtyd edited a comment on pull request #658: URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-685450339 Did a quick test LGTM (I deleted the jsession cookie and click a router-link), need more testing for cases (a) on mgmt server restart, (b) on actual session expiry (say after 30mins...) cc @davidjumani However, after login it always goes to the /exception/403 page This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #662: Refresh data every 30 seconds
davidjumani commented on pull request #662: URL: https://github.com/apache/cloudstack-primate/pull/662#issuecomment-685452959 @rhtyd It refreshes the page every 30 seconds irrespective of a batch job to ensure the user always has the latest details available. It also fixes the batch job refresh since the jobs should complete at some time, and within 30 seconds of them completing, the page refreshes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on a change in pull request #649: Filter vms based on zones for attaching volumes
Pearl1594 commented on a change in pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#discussion_r481901720
##
File path: src/config/section/storage.js
##
@@ -101,6 +101,12 @@ export default {
label: 'label.action.attach.disk',
message: 'message.confirm.attach.disk',
args: ['virtualmachineid'],
+ mapping: {
+virtualmachineid: {
+ api: 'listVirtualMachines',
+ params: (record) => { return { zoneid: record.zoneid, domainid:
record.domainid, account: record.account, hypervisor: record.hypervisor } }
Review comment:
This will require some additional checks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #660: [BUG] K8s version - various issues ?
rhtyd commented on issue #660: URL: https://github.com/apache/cloudstack-primate/issues/660#issuecomment-685501566 @andrijapanicsb looks like 2CPU is a requirement and the version needs to be 1.15.0 as there is no k8s 1.15 release but 1.15.0 or 1.15.1 release. Have you followed the docs http://docs.cloudstack.apache.org/en/latest/plugins/cloudstack-kubernetes-service.html ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] shwstppr commented on issue #660: [BUG] K8s version - various issues ?
shwstppr commented on issue #660: URL: https://github.com/apache/cloudstack-primate/issues/660#issuecomment-685507076 I've added some improvements here, https://github.com/apache/cloudstack/pull/4269, error messages and API param description. I've not explicitly tied 2vCPU, 2GB memory requirement in UI as it might change once we move to a different template (from CoreOS) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #663: missing tooltips
Pearl1594 commented on pull request #663: URL: https://github.com/apache/cloudstack-primate/pull/663#issuecomment-685560595 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #663: missing tooltips
Pearl1594 opened a new pull request #663: URL: https://github.com/apache/cloudstack-primate/pull/663 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #658: Fixes reload of page on session expiry
Pearl1594 commented on pull request #658: URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-685560793 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #649: Filter vms based on zones for attaching volumes
Pearl1594 commented on pull request #649: URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-685673519 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #657: vm wizard: add MAC Address validator
utchoang commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-686190959 * Show list IP range and check valid IP range:    This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #657: vm wizard: add MAC Address validator
utchoang commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-686244939 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #664: [WIP] deployvm: Showing additoinal fields in infocard
davidjumani opened a new pull request #664: URL: https://github.com/apache/cloudstack-primate/pull/664 Adds additional fields to the infocard while creating a vm - Pod - Cluseter - Host This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #651: Prevent form from closing if validation fails
davidjumani commented on pull request #651: URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-686272652 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang removed a comment on pull request #657: vm wizard: add MAC Address validator
utchoang removed a comment on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-686244939 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #657: vm wizard: add MAC Address validator
utchoang commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-686281128 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #665: [WIP] Adding events for async job completing
davidjumani opened a new pull request #665: URL: https://github.com/apache/cloudstack-primate/pull/665 An alternative to refreshing the page every 30 seconds This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
