[GitHub] [cloudstack-primate] davidjumani commented on pull request #614: Fixing mine / all for vm list view

2020-08-25 Thread GitBox


davidjumani commented on pull request #614:
URL: 
https://github.com/apache/cloudstack-primate/pull/614#issuecomment-679843715


   @rhtyd Good to go!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] borisstoyanov commented on issue #612: [BUG] Add cluster - password is not masked

2020-08-25 Thread GitBox


borisstoyanov commented on issue #612:
URL: 
https://github.com/apache/cloudstack-primate/issues/612#issuecomment-679854185


   thanks @utchoang lets close this once we merge the PR



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd merged pull request #613: FIX - Add cluster - password is not masked

2020-08-25 Thread GitBox


rhtyd merged pull request #613:
URL: https://github.com/apache/cloudstack-primate/pull/613


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #612: [BUG] Add cluster - password is not masked

2020-08-25 Thread GitBox


rhtyd commented on issue #612:
URL: 
https://github.com/apache/cloudstack-primate/issues/612#issuecomment-679857835


   PR merged 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd closed issue #612: [BUG] Add cluster - password is not masked

2020-08-25 Thread GitBox


rhtyd closed issue #612:
URL: https://github.com/apache/cloudstack-primate/issues/612


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd closed issue #606: [BUG] "mine" VMs for Admin, shows also other account's VMs

2020-08-25 Thread GitBox


rhtyd closed issue #606:
URL: https://github.com/apache/cloudstack-primate/issues/606


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd merged pull request #610: Fixing scale VM

2020-08-25 Thread GitBox


rhtyd merged pull request #610:
URL: https://github.com/apache/cloudstack-primate/pull/610


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd merged pull request #614: Fixing mine / all for vm list view

2020-08-25 Thread GitBox


rhtyd merged pull request #614:
URL: https://github.com/apache/cloudstack-primate/pull/614


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd merged pull request #611: Contextual data

2020-08-25 Thread GitBox


rhtyd merged pull request #611:
URL: https://github.com/apache/cloudstack-primate/pull/611


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd merged pull request #602: Fixes an issue that could not search on zone select

2020-08-25 Thread GitBox


rhtyd merged pull request #602:
URL: https://github.com/apache/cloudstack-primate/pull/602


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #608: Allow renaming cluster, host, and storage

2020-08-25 Thread GitBox


rhtyd commented on a change in pull request #608:
URL: https://github.com/apache/cloudstack-primate/pull/608#discussion_r476240626



##
File path: src/config/section/infra/primaryStorages.js
##
@@ -61,7 +61,7 @@ export default {
   icon: 'edit',
   label: 'label.edit',
   dataView: true,
-  args: ['tags', 'capacitybytes', 'capacityiops']
+  args: ['name', 'tags', 'capacitybytes', 'capacityiops']

Review comment:
   @davidjumani how does it fare if mgmt server/API does not support the 
arg? 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #608: Allow renaming cluster, host, and storage

2020-08-25 Thread GitBox


davidjumani commented on a change in pull request #608:
URL: https://github.com/apache/cloudstack-primate/pull/608#discussion_r476298184



##
File path: src/config/section/infra/primaryStorages.js
##
@@ -61,7 +61,7 @@ export default {
   icon: 'edit',
   label: 'label.edit',
   dataView: true,
-  args: ['tags', 'capacitybytes', 'capacityiops']
+  args: ['name', 'tags', 'capacitybytes', 'capacityiops']

Review comment:
   it'll get passed but ignored by the backend, but yes, better add an ACS 
version check





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani opened a new issue #615: [UX] Show multple aysnc jobs horizonatally rather than vertically

2020-08-25 Thread GitBox


davidjumani opened a new issue #615:
URL: https://github.com/apache/cloudstack-primate/issues/615


   Show the async jobs in progress next to the other rather than below as it 
blocks info on the page
   
   ![Screenshot from 2020-08-25 
15-57-54](https://user-images.githubusercontent.com/8244774/91163902-f0cea900-e6eb-11ea-905b-08c8ad891108.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #609: [WIP] Fixes for vapps

2020-08-25 Thread GitBox


blueorangutan commented on pull request #609:
URL: 
https://github.com/apache/cloudstack-primate/pull/609#issuecomment-679944387


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/609 (JID-3372)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] j-porsche opened a new issue #616: [BUG] Trying to run docker.sh script

2020-08-25 Thread GitBox


j-porsche opened a new issue #616:
URL: https://github.com/apache/cloudstack-primate/issues/616


   Hey,
   
   **Describe the bug**
   I tried to install cloudstack-primate on a CentOS 8.1 VM. Everything worked 
fine until I had to run the docker.sh script. Later the command "npm run build" 
is executed. The process is stopping at this point with an error (image 
attached). 
   
   Npm run build works fine if I start it manually outside the container.  
Inside the container it isn't working. The npm versions are the same.
   
   Can somebody help me with this problem?
   
   Thank you!
   
   
   **Screenshots**
   
![debugLog](https://user-images.githubusercontent.com/61408412/91171117-3da98400-e6da-11ea-9881-66bfb35f2646.PNG)
   
   
   **Desktop (please complete the following information):**
- OS: CentOS 8.1
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] svenvogel commented on issue #616: [BUG] Trying to run docker.sh script

2020-08-25 Thread GitBox


svenvogel commented on issue #616:
URL: 
https://github.com/apache/cloudstack-primate/issues/616#issuecomment-679979935


   @rhtyd @utchoang do you have some ideas on this error?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] onitake commented on issue #616: [BUG] Trying to run docker.sh script

2020-08-25 Thread GitBox


onitake commented on issue #616:
URL: 
https://github.com/apache/cloudstack-primate/issues/616#issuecomment-679992628


   I'm trying to reproduce it here, but the build works perfectly fine on my 
system.
   
   From my experience, npm is quite a brittle tool and can break without 
meaningful error at any time - in particular when internet connectivity is not 
good.
   
   Is your error reproducible? Does it go away if you use a different internet 
connection?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #617: [BUG]

2020-08-25 Thread GitBox


andrijapanicsb opened a new issue #617:
URL: https://github.com/apache/cloudstack-primate/issues/617


   On the list of template (when deploying a VM from a template), when you 
click on the "next page" button (or number 2. for the second page) 
   
![image](https://user-images.githubusercontent.com/45762285/91174540-b65f0f00-e6df-11ea-89ee-c2212c3ada00.png)
   
   It lists the first page of the Feautred, instead of the next page of the My 
Templates:
   
   
![image](https://user-images.githubusercontent.com/45762285/91174618-d1318380-e6df-11ea-800d-a37e45fcee15.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] j-porsche commented on issue #616: [BUG] Trying to run docker.sh script

2020-08-25 Thread GitBox


j-porsche commented on issue #616:
URL: 
https://github.com/apache/cloudstack-primate/issues/616#issuecomment-680002179


   I don't understand what you mean? Can you explain? My connection should be 
good.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] j-porsche commented on issue #616: [BUG] Trying to run docker.sh script

2020-08-25 Thread GitBox


j-porsche commented on issue #616:
URL: 
https://github.com/apache/cloudstack-primate/issues/616#issuecomment-680003511


   And local (outside the container) it is working fine.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] onitake commented on issue #616: [BUG] Trying to run docker.sh script

2020-08-25 Thread GitBox


onitake commented on issue #616:
URL: 
https://github.com/apache/cloudstack-primate/issues/616#issuecomment-680032107


   Ok, so first of all: The Dockerfile works fine for me. I get no error at 
all, no matter how many times I run it.
   
   My experience with npm is that it can break easily for obscure reasons. The 
log you posted doesn't look very useful.
   Can you try deleting the `node:lts-buster` image and run the build again? Is 
it reproducible?
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] j-porsche commented on issue #616: [BUG] Trying to run docker.sh script

2020-08-25 Thread GitBox


j-porsche commented on issue #616:
URL: 
https://github.com/apache/cloudstack-primate/issues/616#issuecomment-680040724


   I tried it but it doesn't work neither. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] onitake commented on issue #616: [BUG] Trying to run docker.sh script

2020-08-25 Thread GitBox


onitake commented on issue #616:
URL: 
https://github.com/apache/cloudstack-primate/issues/616#issuecomment-680045020


   Perhaps this helps? https://github.com/vuejs/vue-cli/issues/2596



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] onitake commented on issue #616: [BUG] Trying to run docker.sh script

2020-08-25 Thread GitBox


onitake commented on issue #616:
URL: 
https://github.com/apache/cloudstack-primate/issues/616#issuecomment-680045663


   Note that Docker will copy the whole build directory into the container, so 
if you have anything left lying around there, it may disrupt the build.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #609: [WIP] Fixes for vapps

2020-08-25 Thread GitBox


andrijapanicsb commented on pull request #609:
URL: 
https://github.com/apache/cloudstack-primate/pull/609#issuecomment-680045872


   LGTM with pass length, ordering of Eula and ordering of Configurations



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #618: [BUG]

2020-08-25 Thread GitBox


andrijapanicsb opened a new issue #618:
URL: https://github.com/apache/cloudstack-primate/issues/618


   This is perhaps OK, but I find it (a little bit, not too much) confusing 
(especially when comparing to the behaviour in the old UI):
   i.e. why is the first network not selected in the checkboxes option - we 
have below selected 'which one of the selected networks is the default one" - 
but we have never "selected" (checkbox) ANY of the networks in the above list 
of networks:
   
   
![image](https://user-images.githubusercontent.com/45762285/91186139-f4affa80-e6ee-11ea-948e-327a9ca70f28.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #619: [BUG] Success on VM deployment, causes current form to be submited

2020-08-25 Thread GitBox


andrijapanicsb opened a new issue #619:
URL: https://github.com/apache/cloudstack-primate/issues/619


   VM was deploying for a long time (i.e. first time ever from a new template - 
so OVF deployment in vCenter took 5min or so)
   In the meantime I was configuring/creating a new VM (was in the new VM 
wizard, configuring options), but have NOT submited the new VM creation job.
   
   Then when the previous VM deployment finished, my CURRENT VM deployment job 
was magically submitted or something 👍 🥇 
   
   
![image](https://user-images.githubusercontent.com/45762285/91189010-37270680-e6f2-11ea-921f-833edde8e0b0.png)
   
   
   I've tested the same with template registration: while VM is being deployed, 
go and open the Register template form - and got some weird API calls to list 
templates, while I was on the Register template dialogue (but no error, as this 
was listTemplate api now)
   
   
![image](https://user-images.githubusercontent.com/45762285/91189790-27f48880-e6f3-11ea-8309-0cf2ff857ade.png)
   
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #588: [BUG] switching between Custom and Fixed/Static Compute Offering

2020-08-25 Thread GitBox


andrijapanicsb commented on issue #588:
URL: 
https://github.com/apache/cloudstack-primate/issues/588#issuecomment-680074919


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] andrijapanicsb closed issue #588: [BUG] switching between Custom and Fixed/Static Compute Offering

2020-08-25 Thread GitBox


andrijapanicsb closed issue #588:
URL: https://github.com/apache/cloudstack-primate/issues/588


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #620: [BUG] Popup errors no more visible on VM deployment wizard

2020-08-25 Thread GitBox


andrijapanicsb opened a new issue #620:
URL: https://github.com/apache/cloudstack-primate/issues/620


   I've NOT selected the EULA agreement, and when I click the button - there is 
no error shown (was showing/poping up previously)
   (same goes for the password length check - there is a red warning around the 
password-input-field, but no popup error when you try deploying VM without 
honouring the needed length)
   
   
![image](https://user-images.githubusercontent.com/45762285/91191168-b9b0c580-e6f4-11ea-8aec-d1746dc29705.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on issue #620: [BUG] Popup errors no more visible on VM deployment wizard

2020-08-25 Thread GitBox


davidjumani commented on issue #620:
URL: 
https://github.com/apache/cloudstack-primate/issues/620#issuecomment-680678525


   @andrijapanicsb it shows up as a popup. But yes, will add a message below 
the checkbox too
   
   ![Screenshot from 2020-08-26 
11-37-00](https://user-images.githubusercontent.com/8244774/91267303-b703ae00-e790-11ea-97f6-d264c9a3decc.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org