[GitHub] [cloudstack-primate] rhtyd commented on pull request #593: Improve vApps properties section adding categories and sort order
rhtyd commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-675898993 cc @shwstppr LGTM @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #593: Improve vApps properties section adding categories and sort order
blueorangutan commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-675899267 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #590: [BUG] no expunge when deleting multiple VMs at once
rhtyd commented on issue #590: URL: https://github.com/apache/cloudstack-primate/issues/590#issuecomment-675902151 With @davidjumani This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #589: [BUG] or an improvement - on new windows, move focus/cursos to the first field
rhtyd commented on issue #589: URL: https://github.com/apache/cloudstack-primate/issues/589#issuecomment-675902421 @davidjumani can you see if it's a good one - otherwise this is good to have but not mandatory for 1.0/GA This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #588: [BUG] switching between Custom and Fixed/Static Compute Offering
rhtyd commented on issue #588: URL: https://github.com/apache/cloudstack-primate/issues/588#issuecomment-675902220 With @davidjumani This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #591: [BUG] VM state in UI not updated when deployment failure
rhtyd commented on issue #591: URL: https://github.com/apache/cloudstack-primate/issues/591#issuecomment-675902791 @davidjumani is there a way we can cause the listView to refresh when the async job poll stops? Another way could be to launch the VM and move to the VM once it is deployed instead of doing to the list view (from the deployvm component)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #592: [BUG] Notification message never disapear
rhtyd commented on issue #592: URL: https://github.com/apache/cloudstack-primate/issues/592#issuecomment-675903197 @andrijapanicsb this is expected, all errors are treated like alert dialog boxes in old UI. They are not automatically closed and have a close/cross button to close them. This is so the user can copy the error or take screenshot. Only successful notification auto-close in few seconds. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #593: Improve vApps properties section adding categories and sort order
blueorangutan commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-675903649 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/593 (JID-3255) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #587: Allow creating snapshot from VM snapshot
rhtyd commented on a change in pull request #587:
URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472807049
##
File path: src/config/section/storage.js
##
@@ -325,6 +326,16 @@ export default {
details: ['name', 'id', 'displayname', 'description', 'type', 'current',
'parentName', 'virtualmachineid', 'account', 'domain', 'created'],
searchFilters: ['name', 'domainid', 'account', 'tags'],
actions: [
+{
+ api: 'createSnapshotFromVMSnapshot',
+ icon: 'camera',
+ label: 'label.action.create.snapshot.from.vmsnapshot',
+ message: 'message.action.create.snapshot.from.vmsnapshot',
+ dataView: true,
+ popup: true,
+ show: (record) => { return record.state === 'Ready' },
Review comment:
@ravening @davidjumani can we make it simpler then? maybe change the
list response to pass hypervisor and use it here. Note: 1.0/GA ships with 4.15
- so if it makes it simpler, send a PR against 4.14 branch and return the key
as part of vmsnapshot list response?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #590: [BUG] no expunge when deleting multiple VMs at once
davidjumani commented on issue #590: URL: https://github.com/apache/cloudstack-primate/issues/590#issuecomment-675909410 Fixed in https://github.com/apache/cloudstack-primate/pull/594/commits/0facb7a8e69bd33afc30fe20cb54378db7ec8051 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb closed issue #592: [BUG] Notification message never disapear
andrijapanicsb closed issue #592: URL: https://github.com/apache/cloudstack-primate/issues/592 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #592: [BUG] Notification message never disapear
andrijapanicsb commented on issue #592: URL: https://github.com/apache/cloudstack-primate/issues/592#issuecomment-675911737 Sounds good then - thx. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #593: Improve vApps properties section adding categories and sort order
rhtyd commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-675912527 Regression test LGTM, tried to deploy a VM with some changes in templates and root disk size override This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #571: [BUG] Creating Basic Type Zone not supported in primate UI ?
rhtyd commented on issue #571: URL: https://github.com/apache/cloudstack-primate/issues/571#issuecomment-675913172 Thanks for addressing limitation in docs @davidjumani I'll close as @a31amit agrees to use Adv zone as long as all the basic zone features are available (which indeed are) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #571: [BUG] Creating Basic Type Zone not supported in primate UI ?
rhtyd closed issue #571: URL: https://github.com/apache/cloudstack-primate/issues/571 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #142: Added basic and advanced customization sections to the primate doc
ACSGitBot commented on pull request #142: URL: https://github.com/apache/cloudstack-documentation/pull/142#issuecomment-675918099 Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] rhtyd commented on pull request #142: Added basic and advanced customization sections to the primate doc
rhtyd commented on pull request #142: URL: https://github.com/apache/cloudstack-documentation/pull/142#issuecomment-675918029 requesting docbuild This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #142: Added basic and advanced customization sections to the primate doc
ACSGitBot commented on pull request #142: URL: https://github.com/apache/cloudstack-documentation/pull/142#issuecomment-675919229 Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr142 Build Log Output: No log errors found to report. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] ravening commented on a change in pull request #587: Allow creating snapshot from VM snapshot
ravening commented on a change in pull request #587:
URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472854215
##
File path: src/config/section/storage.js
##
@@ -325,6 +326,16 @@ export default {
details: ['name', 'id', 'displayname', 'description', 'type', 'current',
'parentName', 'virtualmachineid', 'account', 'domain', 'created'],
searchFilters: ['name', 'domainid', 'account', 'tags'],
actions: [
+{
+ api: 'createSnapshotFromVMSnapshot',
+ icon: 'camera',
+ label: 'label.action.create.snapshot.from.vmsnapshot',
+ message: 'message.action.create.snapshot.from.vmsnapshot',
+ dataView: true,
+ popup: true,
+ show: (record) => { return record.state === 'Ready' },
Review comment:
@rhtyd if we have to return hypervisor in list snapshot response then we
need to call listvirtualmachine api for each snpashot response which might
increase response time and also burden on mgt server
As @davidjumani suggested, we have virtulamachineid parameter but we need to
call listvirtualmachine api to get the hypervisor type. Im trying to make that
work
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #587: Allow creating snapshot from VM snapshot
davidjumani commented on a change in pull request #587:
URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472866294
##
File path: src/config/section/storage.js
##
@@ -325,6 +326,16 @@ export default {
details: ['name', 'id', 'displayname', 'description', 'type', 'current',
'parentName', 'virtualmachineid', 'account', 'domain', 'created'],
searchFilters: ['name', 'domainid', 'account', 'tags'],
actions: [
+{
+ api: 'createSnapshotFromVMSnapshot',
+ icon: 'camera',
+ label: 'label.action.create.snapshot.from.vmsnapshot',
+ message: 'message.action.create.snapshot.from.vmsnapshot',
+ dataView: true,
+ popup: true,
+ show: (record) => { return record.state === 'Ready' },
Review comment:
@ravening That might not work since api calls are async and will return
after the `show` method has completed execution. It would be better to alter
the API response in the backend to include the vm's hypervisor which could be
done quite easily without calling further apis.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] ravening commented on a change in pull request #587: Allow creating snapshot from VM snapshot
ravening commented on a change in pull request #587:
URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472868568
##
File path: src/config/section/storage.js
##
@@ -325,6 +326,16 @@ export default {
details: ['name', 'id', 'displayname', 'description', 'type', 'current',
'parentName', 'virtualmachineid', 'account', 'domain', 'created'],
searchFilters: ['name', 'domainid', 'account', 'tags'],
actions: [
+{
+ api: 'createSnapshotFromVMSnapshot',
+ icon: 'camera',
+ label: 'label.action.create.snapshot.from.vmsnapshot',
+ message: 'message.action.create.snapshot.from.vmsnapshot',
+ dataView: true,
+ popup: true,
+ show: (record) => { return record.state === 'Ready' },
Review comment:
@davidjumani @rhtyd so then I will just check `record.hypervisor ===
'KVM'` here and add `hypervisor` field to listVMSnapshot response in backend.
I still need to call list virtual machine to get the hypervisor type
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #587: Allow creating snapshot from VM snapshot
davidjumani commented on a change in pull request #587:
URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472871592
##
File path: src/config/section/storage.js
##
@@ -325,6 +326,16 @@ export default {
details: ['name', 'id', 'displayname', 'description', 'type', 'current',
'parentName', 'virtualmachineid', 'account', 'domain', 'created'],
searchFilters: ['name', 'domainid', 'account', 'tags'],
actions: [
+{
+ api: 'createSnapshotFromVMSnapshot',
+ icon: 'camera',
+ label: 'label.action.create.snapshot.from.vmsnapshot',
+ message: 'message.action.create.snapshot.from.vmsnapshot',
+ dataView: true,
+ popup: true,
+ show: (record) => { return record.state === 'Ready' },
Review comment:
@ravening Yes, add that condition, once the backend has been changed to
return the hypervisor as well, we can merge this!
There won't be a need to call another API as the hypervisor field will be
added in the cloudstack backend itself
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #587: Allow creating snapshot from VM snapshot
davidjumani commented on a change in pull request #587:
URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472871592
##
File path: src/config/section/storage.js
##
@@ -325,6 +326,16 @@ export default {
details: ['name', 'id', 'displayname', 'description', 'type', 'current',
'parentName', 'virtualmachineid', 'account', 'domain', 'created'],
searchFilters: ['name', 'domainid', 'account', 'tags'],
actions: [
+{
+ api: 'createSnapshotFromVMSnapshot',
+ icon: 'camera',
+ label: 'label.action.create.snapshot.from.vmsnapshot',
+ message: 'message.action.create.snapshot.from.vmsnapshot',
+ dataView: true,
+ popup: true,
+ show: (record) => { return record.state === 'Ready' },
Review comment:
@ravening Yes, add that condition, once the backend has been changed to
return the hypervisor as well, we can merge this!
There won't be a need to call another API as the hypervisor field will be
added in the backend itself
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] ravening commented on a change in pull request #587: Allow creating snapshot from VM snapshot
ravening commented on a change in pull request #587:
URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472876586
##
File path: src/config/section/storage.js
##
@@ -325,6 +326,16 @@ export default {
details: ['name', 'id', 'displayname', 'description', 'type', 'current',
'parentName', 'virtualmachineid', 'account', 'domain', 'created'],
searchFilters: ['name', 'domainid', 'account', 'tags'],
actions: [
+{
+ api: 'createSnapshotFromVMSnapshot',
+ icon: 'camera',
+ label: 'label.action.create.snapshot.from.vmsnapshot',
+ message: 'message.action.create.snapshot.from.vmsnapshot',
+ dataView: true,
+ popup: true,
+ show: (record) => { return record.state === 'Ready' },
Review comment:
@davidjumani I have updated the code here. In the meantime I will work
on adding hypervisor type in the backend code
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #587: [WIP] Allow creating snapshot from VM snapshot
davidjumani commented on a change in pull request #587:
URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472879243
##
File path: src/config/section/storage.js
##
@@ -325,6 +326,16 @@ export default {
details: ['name', 'id', 'displayname', 'description', 'type', 'current',
'parentName', 'virtualmachineid', 'account', 'domain', 'created'],
searchFilters: ['name', 'domainid', 'account', 'tags'],
actions: [
+{
+ api: 'createSnapshotFromVMSnapshot',
+ icon: 'camera',
+ label: 'label.action.create.snapshot.from.vmsnapshot',
+ message: 'message.action.create.snapshot.from.vmsnapshot',
+ dataView: true,
+ popup: true,
+ show: (record) => { return record.state === 'Ready' },
Review comment:
@ravening `record.state === 'Ready' && record.hypervisor === 'KVM'`
:smile:
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #591: [BUG] VM state in UI not updated when deployment failure
andrijapanicsb commented on issue #591: URL: https://github.com/apache/cloudstack-primate/issues/591#issuecomment-675996030 I had a perhaps related thing - the VM was indeed deployed and started correctly, but its state after, I finished the deployment wizard, was initially "Stopped" and there was never (if I saw that correctly) a "spinning circle" that indicates that we query VMs state - and after the VM was deployed/started fine, the VM status remained as Stopped.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #589: [BUG] or an improvement - on new windows, move focus/cursos to the first field
davidjumani commented on issue #589: URL: https://github.com/apache/cloudstack-primate/issues/589#issuecomment-676005791 Fixed in https://github.com/apache/cloudstack-primate/pull/594/commits/e4580e761148815f4a4c2094bf22dc082cfe9f76 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #593: Improve vApps properties section adding categories and sort order
shwstppr commented on a change in pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593#discussion_r472897201
##
File path: src/views/compute/DeployVM.vue
##
@@ -1791,4 +1806,10 @@ export default {
.form-item-hidden {
display: none;
}
+
+ .vapp-category {
+background-color: lightblue;
Review comment:
Can we use some standard primate color. Looks different to rest of the UI
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #591: [BUG] VM state in UI not updated when deployment failure
davidjumani commented on issue #591: URL: https://github.com/apache/cloudstack-primate/issues/591#issuecomment-676084840 Refresh after deployment Fixed in https://github.com/apache/cloudstack-primate/pull/594/commits/71c875f50e9114b150599396031178fa76fa3abf This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #593: Improve vApps properties section adding categories and sort order
rhtyd commented on a change in pull request #593:
URL: https://github.com/apache/cloudstack-primate/pull/593#discussion_r472931498
##
File path: src/views/compute/DeployVM.vue
##
@@ -1791,4 +1806,10 @@ export default {
.form-item-hidden {
display: none;
}
+
+ .vapp-category {
+background-color: lightblue;
Review comment:
use the alert component
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #593: Improve vApps properties section adding categories and sort order
rhtyd commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676158848 @shwstppr would it be quicker for you to address issues or advise Nicolas? Thanks. @nvazquez @shwstppr cc @davidjumani - pl advise me accordingly happy to merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #587: [WIP] Allow creating snapshot from VM snapshot
rhtyd commented on pull request #587: URL: https://github.com/apache/cloudstack-primate/pull/587#issuecomment-676162417 @ravening is this still WIP, or ready? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #587: [WIP] Allow creating snapshot from VM snapshot
rhtyd commented on pull request #587: URL: https://github.com/apache/cloudstack-primate/pull/587#issuecomment-676161851 LGTM, wil merge this as soon as we merge the upstream 4.14 PR https://github.com/apache/cloudstack/pull/4275 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #594: [WIP] Bug Fixes
rhtyd commented on a change in pull request #594: URL: https://github.com/apache/cloudstack-primate/pull/594#discussion_r472949313 ## File path: src/config/eventBus.js ## @@ -0,0 +1,2 @@ +import Vue from 'vue' +export default new Vue() Review comment: @davidjumani what's the purpose of this, or you exploring some idea? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] ravening commented on pull request #587: [WIP] Allow creating snapshot from VM snapshot
ravening commented on pull request #587: URL: https://github.com/apache/cloudstack-primate/pull/587#issuecomment-676164060 > @ravening is this still WIP, or ready? @rhtyd this is ready.. waiting for back end pr to get merged This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #594: [WIP] Bug Fixes
davidjumani commented on a change in pull request #594: URL: https://github.com/apache/cloudstack-primate/pull/594#discussion_r472951520 ## File path: src/config/eventBus.js ## @@ -0,0 +1,2 @@ +import Vue from 'vue' +export default new Vue() Review comment: Used as an event bus to transmit a refresh event between the deployvm and autogen views since it's not a popup form and can't provide / inject the parentFetchData method This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] shwstppr commented on pull request #593: Improve vApps properties section adding categories and sort order
shwstppr commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676209477  Added a-alert component and fixed above error This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #593: Improve vApps properties section adding categories and sort order
rhtyd commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676211248 @nvazquez can you test, I can merge if it works now @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #593: Improve vApps properties section adding categories and sort order
blueorangutan commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676213006 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #593: Improve vApps properties section adding categories and sort order
blueorangutan commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676230511 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/593 (JID-3260) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #593: Improve vApps properties section adding categories and sort order
andrijapanicsb commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676254184 Not good - there should be 3 categories, instead of 1:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb removed a comment on pull request #593: Improve vApps properties section adding categories and sort order
andrijapanicsb removed a comment on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676254184 Not good - there should be 3 categories, instead of 1:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #593: Improve vApps properties section adding categories and sort order
rhtyd commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676259871 Merging this as Abhishek confirms testing this. cc @andrijapanicsb please log further issues, I'm merging this so you can then take latest Primate and carry on vApp backend testing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #593: Improve vApps properties section adding categories and sort order
rhtyd merged pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #593: Improve vApps properties section adding categories and sort order
andrijapanicsb commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676285842 LGTM - both the vApp categories and the questions in each - are sorted properly - as in the OVF thx! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #595: [BUG] minor: add "MB" to the offering field desc
andrijapanicsb opened a new issue #595: URL: https://github.com/apache/cloudstack-primate/issues/595  The unit is missing in the desc - do the sam as "Mhz" for the CPU field. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #596: [BUG] "Configuration" values from the vApp appliance vs Compute offering
andrijapanicsb opened a new issue #596: URL: https://github.com/apache/cloudstack-primate/issues/596 Deploying an OVA template with vApp Configurations (which define/require 1000Mhz CPU and 1MB of RAM - see the OVF part below). The Primate doesn't allow (me) to select Small/Medium/Bigger offering - only selecting a custom offering works - seems like the OVF parameters are not parsed or somehing (talked to @nvazquez and he suggested it seems like the Primate bug, not backend)  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] shwstppr commented on issue #596: [BUG] "Configuration" values from the vApp appliance vs Compute offering
shwstppr commented on issue #596: URL: https://github.com/apache/cloudstack-primate/issues/596#issuecomment-676408715 @andrijapanicsb current behaviour in Primate is to strictly match configurations for RAM and CPU values. This can be changed if needed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] shwstppr edited a comment on issue #596: [BUG] "Configuration" values from the vApp appliance vs Compute offering
shwstppr edited a comment on issue #596: URL: https://github.com/apache/cloudstack-primate/issues/596#issuecomment-676408715 @andrijapanicsb current behaviour in Primate is to strictly match configurations and offerings for RAM and CPU values. This can be changed if needed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #596: [BUG] "Configuration" values from the vApp appliance vs Compute offering
rhtyd commented on issue #596: URL: https://github.com/apache/cloudstack-primate/issues/596#issuecomment-676411435 @andrijapanicsb @nvazquez the compute offering does not determine the network speed, which is part of the network offering. The configuration name may therefore get misleading. I had initially proposed to @nvazquez @shwstppr to avoid showing the name selection which serves no purpose in backend (the selected option is not used) but to use it for filtering only compute offering wrt ram and cpu. Do we need to re-think how we show this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #595: [BUG] minor: add "MB" to the offering field desc
rhtyd commented on issue #595: URL: https://github.com/apache/cloudstack-primate/issues/595#issuecomment-676414482 Should be quick one - @shwstppr @davidjumani This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #596: [BUG] "Configuration" values from the vApp appliance vs Compute offering
andrijapanicsb commented on issue #596: URL: https://github.com/apache/cloudstack-primate/issues/596#issuecomment-676418803 @rhtyd this is Daans testing machinge with poor name - no problem there. I get it for the "exact match" - but didn't we communicate hiding all offerings that are "less" then the required Configuration - worst case it can stay as it is - but when I hover the offering (where mouse changes from the arrow to the red deny sign) - it would be good to have a generic message like "Offering CPU/RAM values do not match the exact values as requested by the Configuration" - or similar - since the "deny" mouse arrow doesn't explain much (except saying "not allowed", so to speak) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb edited a comment on issue #596: [BUG] "Configuration" values from the vApp appliance vs Compute offering
andrijapanicsb edited a comment on issue #596: URL: https://github.com/apache/cloudstack-primate/issues/596#issuecomment-676418803 @rhtyd this is Daan's testing machine with poor name - no problem there. I get it for the "exact match" - but didn't we communicate hiding all offerings that are "less" then the required Configuration - worst case it can stay as it is - but when I hover the offering (where mouse changes from the arrow to the red deny sign) - it would be good to have a generic message like "Offering CPU/RAM values do not match the exact values as requested by the Configuration" - or similar - since the "deny" mouse arrow doesn't explain much (except saying "not allowed", so to speak) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #595: [BUG] minor: add "MB" to the offering field desc
davidjumani commented on issue #595: URL: https://github.com/apache/cloudstack-primate/issues/595#issuecomment-676428845 Fixed in https://github.com/apache/cloudstack-primate/pull/594/commits/77c8f68364c80c0bf2866d3e3b2c735b50b1555d This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #597: [BUG] Input field for RAM in the custom compute offering needs polishing
andrijapanicsb opened a new issue #597: URL: https://github.com/apache/cloudstack-primate/issues/597 Custom compute offering:  Click inside the RAM field, hit backspace on keyboard (to delete the number 1 (which is btw a very bad default value, perhaps 256?) - the field will get value of "MB MB" then if you type a number (100), you get the stuff from the screenshot Can the "MB" be placed outside of the actual field, so it makes more sense visually - same way as the "MHz" for the CPU speed field? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #598: [BUG] the "job querying" message-box will redirect users back to the previos page
andrijapanicsb opened a new issue #598:
URL: https://github.com/apache/cloudstack-primate/issues/598
The title is ugly, but I don't know the terminology, here's what I mean
When deleting a template., the following happens:
1. Go to delete a template
2. The following screen is shows (see the top "Deleting template X in
progress" box/message)
3. now, while still this message box is shown on the top (i.e. template
deletion is not finished), go back to the list of the templates
4. when the template deletion is finished, it will redirect you back to the
specific (deleted) template screen ("one screen back"), with empty stuff:
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on issue #598: [BUG] the "job querying" message-box will redirect users back to the previos page
utchoang commented on issue #598: URL: https://github.com/apache/cloudstack-primate/issues/598#issuecomment-676947032 @rhtyd cc @svenvogel I will fix this task, Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang opened a new pull request #599: Fix page navigation error when delete template.
utchoang opened a new pull request #599: URL: https://github.com/apache/cloudstack-primate/pull/599 Open for https://github.com/apache/cloudstack-primate/issues/598 @rhtyd cc @svenvogel I've completed this task. Please review it. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang opened a new pull request #600: VM Wizard: Custom RAM field compute offering
utchoang opened a new pull request #600: URL: https://github.com/apache/cloudstack-primate/pull/600 Open for https://github.com/apache/cloudstack-primate/issues/597 @rhtyd cc @svenvogel I've completed this task. Please review it. Thanks.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on issue #597: [BUG] Input field for RAM in the custom compute offering needs polishing
utchoang commented on issue #597: URL: https://github.com/apache/cloudstack-primate/issues/597#issuecomment-67736 Fixed in https://github.com/apache/cloudstack-primate/pull/600 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
