[GitHub] [cloudstack-primate] ravening commented on pull request #543: Fix template search

2020-07-23 Thread GitBox


ravening commented on pull request #543:
URL: 
https://github.com/apache/cloudstack-primate/pull/543#issuecomment-662881797


   > > Yes i can see those parameters but cant see the centos template in ui
   > 
   > @ravening Is the api query returning the right response? Since no keyword 
is being passed to it. Or perhaps you're within a project
   
   I was logged in as root admin but if you are seeing centos then its fine



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on pull request #552: Fix users form, network SG and VPC

2020-07-23 Thread GitBox


utchoang commented on pull request #552:
URL: 
https://github.com/apache/cloudstack-primate/pull/552#issuecomment-663322470


   * Add instance from VPC tab
   
![image](https://user-images.githubusercontent.com/13766648/88356187-37e61900-cd91-11ea-9d8f-d02224aa9a60.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on pull request #552: Fix users form, network SG and VPC

2020-07-23 Thread GitBox


utchoang commented on pull request #552:
URL: 
https://github.com/apache/cloudstack-primate/pull/552#issuecomment-663322786


   @davidjumani I've completed this task. Please review. Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-23 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   Fixed in #544
   - ~Scrolling on an autogenerated options, it scrolls back to the top 
automatically~
   
   Fixed in #545
   - ~Add issystem=true systemvmtype=domainrouter to listserviceofferings 
called within VR~
   
   Fixed in https://github.com/apache/cloudstack/pull/4213
   - ~Search by tag doesn't work for vm snapshots~
   
   Fixed in https://github.com/apache/cloudstack/pull/4214
   - ~Adding pagination for listNetworkAclLists~
   - ~Adding pagination for listRoles~
   - ~Returning mshost uuid rather than msid in list hosts response~
   - ~ListVMMetrics doesn't respect hostid param~
   - ~Shows only one template setting~
   
   Fixed in #539
   - ~Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)~
   - ~Make external Id required for backup offerings (David to check and 
remove/address the issue)~
   - ~Traffic type on the network offerings redirects to offering. Could remove 
the router link~
   - ~Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)~
   - ~Template order column appears if you go back from details view to 
listview while in a project but disappears on refresh or just disappears on 
refresh~
   - ~On first time listing isos, the account column is missing~
   - ~Template actions not showing while accessing a project template~
   - ~Report bug at the bottom should redirect to bug or just say provide 
feedback (change string from "Report Bug" to "report issue")~
   - ~Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)~
   - ~Since the get health check results for VR doesn't download, consider 
changing the icon (OK)~
   - ~Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)~
   - ~Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)~
   - ~When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)~
   - ~If dynamic scalling not supported on the hypervisor, don't show it as an 
action button (systemvms; David - to check and remove/hide/show buttons based 
on hypervisor and old UI)~
   - ~The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state~
   - ~Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state~
   - ~Enter to advance search rather than submit (OK, if this is a quick one)~
   - ~Add loading while fetching tags and annotations (OK, David - Infocard)~
   - ~Deleting all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`~
   
   TO FIX :
   - Deploy VM doesn't show SG when a zone has Security Groups enabled
   - Can't take a vm storage snap in the vm detail view
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   
   Usability :
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - No point in having update template permissions if inside project sinc