[GitHub] [cloudstack-primate] davidjumani commented on issue #528: Consolidated Bug List from Testing/Review

2020-07-21 Thread GitBox


davidjumani commented on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-661687110


   @utchoang Could you work on the following :
   - Hide SG feature when there are no zones with SG enabled (may be done 
during API discovery, don't create the SG route if no zones have SG enabled)
   - Fix the add and edit users form to show timezone as list of searchable 
dropdown like in the add account form
   - Change or remove (explain?) what "Add new VM" is from VPC tiers tab; (a) 
allow users to add existing VMs or (b) deploy new VMs on the specific VPC tier, 
the deployment form does not auto-select the specific VPC tier [preferably the 
former, to add existing vms]
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-21 Thread GitBox


utchoang edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-661708393


   @davidjumani @rhtyd 
   - Hide SG feature when there are no zones with SG enabled (may be done 
during API discovery, don't create the SG route if no zones have SG enabled)
   > This means that if there is no zone with SG enabled, `networks> security 
group` will not be displayed?
   
   - Change or remove (explain?) what "Add new VM" is from VPC tiers tab; (a) 
allow users to add existing VMs or (b) deploy new VMs on the specific VPC tier, 
the deployment form does not auto-select the specific VPC tier [preferably the 
former, to add existing vms]
   > I still don't know this requirement very well, can you describe it more 
clearly?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on issue #528: Consolidated Bug List from Testing/Review

2020-07-21 Thread GitBox


utchoang commented on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-661708393


   @davidjumani @rhtyd 
   - Hide SG feature when there are no zones with SG enabled (may be done 
during API discovery, don't create the SG route if no zones have SG enabled)
   >> This means that if there is no zone with SG enabled, `networks> security 
group` will not be displayed?
   
   - Change or remove (explain?) what "Add new VM" is from VPC tiers tab; (a) 
allow users to add existing VMs or (b) deploy new VMs on the specific VPC tier, 
the deployment form does not auto-select the specific VPC tier [preferably the 
former, to add existing vms]
   >> I still don't know this requirement very well, can you describe it more 
clearly?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-21 Thread GitBox


utchoang edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-661708393


   @davidjumani @rhtyd 
   > - Hide SG feature when there are no zones with SG enabled (may be done 
during API discovery, don't create the SG route if no zones have SG enabled)
   This means that if there is no zone with SG enabled, `networks> security 
group` will not be displayed?
   
   > - Change or remove (explain?) what "Add new VM" is from VPC tiers tab; (a) 
allow users to add existing VMs or (b) deploy new VMs on the specific VPC tier, 
the deployment form does not auto-select the specific VPC tier [preferably the 
former, to add existing vms]
   I still don't know this requirement very well, can you describe it more 
clearly?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-21 Thread GitBox


utchoang edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-661708393


   @davidjumani @rhtyd 
   > - Hide SG feature when there are no zones with SG enabled (may be done 
during API discovery, don't create the SG route if no zones have SG enabled)
   
   This means that if there is no zone with SG enabled, `networks> security 
group` will not be displayed?
   
   > - Change or remove (explain?) what "Add new VM" is from VPC tiers tab; (a) 
allow users to add existing VMs or (b) deploy new VMs on the specific VPC tier, 
the deployment form does not auto-select the specific VPC tier [preferably the 
former, to add existing vms]
   
   I still don't know this requirement very well, can you describe it more 
clearly?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on issue #528: Consolidated Bug List from Testing/Review

2020-07-21 Thread GitBox


davidjumani commented on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-661712601


   > This means that if there is no zone with SG enabled, `networks> security 
group` will not be displayed?
   
   @utchoang Exactly!
   
   > I still don't know this requirement very well, can you describe it more 
clearly?
   ![Screenshot from 2020-07-21 
13-52-29](https://user-images.githubusercontent.com/8244774/88030989-945ef380-cb59-11ea-9473-a953a9268582.png)
   
   In the VPC View > Networks > Instances, when 'Add Instance' is selected, 
preferably open a new component to select a VM from the existing vms. If that 
would be too time-consuming, just rename it to deploy vm
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on issue #528: Consolidated Bug List from Testing/Review

2020-07-21 Thread GitBox


utchoang commented on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-661713471


   @davidjumani I got it. Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-21 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-661712601


   > This means that if there is no zone with SG enabled, `networks> security 
group` will not be displayed?
   
   @utchoang Exactly!
   
   > I still don't know this requirement very well, can you describe it more 
clearly?
   ![Screenshot from 2020-07-21 
13-52-29](https://user-images.githubusercontent.com/8244774/88030989-945ef380-cb59-11ea-9473-a953a9268582.png)
   
   In the VPC View > Networks > Instances, when 'Add Instance' is selected, 
preferably open a component to select a VM from the existing vms. If that would 
be too time-consuming, just rename it to deploy vm
   Could extract the modal from LoadBalancing.vue and reuse it



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] shwstppr opened a new pull request #550: vapps backend refactor

2020-07-21 Thread GitBox


shwstppr opened a new pull request #550:
URL: https://github.com/apache/cloudstack-primate/pull/550


   Changes in backend



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] shwstppr commented on pull request #550: vapps backend refactor

2020-07-21 Thread GitBox


shwstppr commented on pull request #550:
URL: 
https://github.com/apache/cloudstack-primate/pull/550#issuecomment-661724137


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #550: vapps backend refactor

2020-07-21 Thread GitBox


blueorangutan commented on pull request #550:
URL: 
https://github.com/apache/cloudstack-primate/pull/550#issuecomment-661724726


   @shwstppr a Jenkins job has been kicked to build primate packages. I'll keep 
you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #550: vapps backend refactor

2020-07-21 Thread GitBox


blueorangutan commented on pull request #550:
URL: 
https://github.com/apache/cloudstack-primate/pull/550#issuecomment-661731628


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/550 (JID-2501)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] borisstoyanov opened a new issue #551: [BUG] [Usability] Login screen - Make the cursor at username field when loading the screen

2020-07-21 Thread GitBox


borisstoyanov opened a new issue #551:
URL: https://github.com/apache/cloudstack-primate/issues/551


   **Describe the bug**
   When loading the login screen the cursor is not on the username field which 
make the user to either click on it or tab a few times until it gets on it 
   
   
   **Expected behavior**
   It will be much easier and convenient if the cursor is at the field and the 
user could just start typing his username
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-21 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   Fixed in #544
   - ~Scrolling on an autogenerated options, it scrolls back to the top 
automatically~
   
   Fixed in #545
   - ~Add issystem=true systemvmtype=domainrouter to listserviceofferings 
called within VR~
   
   Fixed in https://github.com/apache/cloudstack/pull/4213
   - ~Search by tag doesn't work for vm snapshots~
   
   Fixed in https://github.com/apache/cloudstack/pull/4214
   - ~Adding pagination for listNetworkAclLists~
   - ~Adding pagination for listRoles~
   - ~Returning mshost uuid rather than msid in list hosts response~
   - ~ListVMMetrics doesn't respect hostid param~
   
   Fixed in #539
   - ~Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)~
   - ~Make external Id required for backup offerings (David to check and 
remove/address the issue)~
   - ~Traffic type on the network offerings redirects to offering. Could remove 
the router link~
   - ~Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)~
   - ~Template order column appears if you go back from details view to 
listview while in a project but disappears on refresh or just disappears on 
refresh~
   - ~On first time listing isos, the account column is missing~
   - ~Report bug at the bottom should redirect to bug or just say provide 
feedback (change string from "Report Bug" to "report issue")~
   - ~Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)~
   - ~Since the get health check results for VR doesn't download, consider 
changing the icon (OK)~
   - ~Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)~
   
   TO FIX :
   - Deleting all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Shows only one template setting if it is within a project : Related to 
showunique flag
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Check/en

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-21 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   Fixed in #544
   - ~Scrolling on an autogenerated options, it scrolls back to the top 
automatically~
   
   Fixed in #545
   - ~Add issystem=true systemvmtype=domainrouter to listserviceofferings 
called within VR~
   
   Fixed in https://github.com/apache/cloudstack/pull/4213
   - ~Search by tag doesn't work for vm snapshots~
   
   Fixed in https://github.com/apache/cloudstack/pull/4214
   - ~Adding pagination for listNetworkAclLists~
   - ~Adding pagination for listRoles~
   - ~Returning mshost uuid rather than msid in list hosts response~
   - ~ListVMMetrics doesn't respect hostid param~
   - ~Shows only one template setting~
   
   Fixed in #539
   - ~Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)~
   - ~Make external Id required for backup offerings (David to check and 
remove/address the issue)~
   - ~Traffic type on the network offerings redirects to offering. Could remove 
the router link~
   - ~Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)~
   - ~Template order column appears if you go back from details view to 
listview while in a project but disappears on refresh or just disappears on 
refresh~
   - ~On first time listing isos, the account column is missing~
   - ~Report bug at the bottom should redirect to bug or just say provide 
feedback (change string from "Report Bug" to "report issue")~
   - ~Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)~
   - ~Since the get health check results for VR doesn't download, consider 
changing the icon (OK)~
   - ~Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)~
   
   TO FIX :
   - Deleting all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Check/ensure 500 as max page size across views/components (Dav

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects

2020-07-21 Thread GitBox


Pearl1594 commented on pull request #382:
URL: 
https://github.com/apache/cloudstack-primate/pull/382#issuecomment-661940932


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects

2020-07-21 Thread GitBox


blueorangutan commented on pull request #382:
URL: 
https://github.com/apache/cloudstack-primate/pull/382#issuecomment-661941647


   @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects

2020-07-21 Thread GitBox


blueorangutan commented on pull request #382:
URL: 
https://github.com/apache/cloudstack-primate/pull/382#issuecomment-661946389


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2509)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects

2020-07-21 Thread GitBox


Pearl1594 commented on pull request #382:
URL: 
https://github.com/apache/cloudstack-primate/pull/382#issuecomment-662009631


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects

2020-07-21 Thread GitBox


blueorangutan commented on pull request #382:
URL: 
https://github.com/apache/cloudstack-primate/pull/382#issuecomment-662010515


   @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects

2020-07-21 Thread GitBox


blueorangutan commented on pull request #382:
URL: 
https://github.com/apache/cloudstack-primate/pull/382#issuecomment-662015086


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2512)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang opened a new pull request #552: Fix users form, network SG and VPC

2020-07-21 Thread GitBox


utchoang opened a new pull request #552:
URL: https://github.com/apache/cloudstack-primate/pull/552


   @davidjumani @rhtyd cc @svenvogel 
   - [ ] Hide SG feature when there are no zones with SG enabled (may be done 
during API discovery, don't create the SG route if no zones have SG enabled)
   - [ ] Fix the add and edit users form to show timezone as a list of the 
searchable dropdown like in the add account form
   
   - [ ] Change or remove (explain?) what "Add new VM" is from VPC tiers tab; 
(a) allow users to add existing VMs or (b) deploy new VMs on the specific VPC 
tier, the deployment form does not auto-select the specific VPC tier 
[preferably the former, to add existing vms]
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on pull request #552: Fix users form, network SG and VPC

2020-07-21 Thread GitBox


utchoang commented on pull request #552:
URL: 
https://github.com/apache/cloudstack-primate/pull/552#issuecomment-662204942


   * Add user:
   
![ảnh](https://user-images.githubusercontent.com/13766648/88127324-895d9f00-cbfd-11ea-894d-31950e5306e1.png)
   
![ảnh](https://user-images.githubusercontent.com/13766648/88127356-9bd7d880-cbfd-11ea-941b-2b622ff38e3a.png)
   
   * Edit user:
   
![ảnh](https://user-images.githubusercontent.com/13766648/88127384-aabe8b00-cbfd-11ea-940a-8948d1c51bda.png)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-21 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   Fixed in #544
   - ~Scrolling on an autogenerated options, it scrolls back to the top 
automatically~
   
   Fixed in #545
   - ~Add issystem=true systemvmtype=domainrouter to listserviceofferings 
called within VR~
   
   Fixed in https://github.com/apache/cloudstack/pull/4213
   - ~Search by tag doesn't work for vm snapshots~
   
   Fixed in https://github.com/apache/cloudstack/pull/4214
   - ~Adding pagination for listNetworkAclLists~
   - ~Adding pagination for listRoles~
   - ~Returning mshost uuid rather than msid in list hosts response~
   - ~ListVMMetrics doesn't respect hostid param~
   - ~Shows only one template setting~
   
   Fixed in #539
   - ~Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)~
   - ~Make external Id required for backup offerings (David to check and 
remove/address the issue)~
   - ~Traffic type on the network offerings redirects to offering. Could remove 
the router link~
   - ~Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)~
   - ~Template order column appears if you go back from details view to 
listview while in a project but disappears on refresh or just disappears on 
refresh~
   - ~On first time listing isos, the account column is missing~
   - ~Report bug at the bottom should redirect to bug or just say provide 
feedback (change string from "Report Bug" to "report issue")~
   - ~Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)~
   - ~Since the get health check results for VR doesn't download, consider 
changing the icon (OK)~
   - ~Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)~
   - ~Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)~
   - ~When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)~
   
   
   TO FIX :
   - Deleting all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   
   Usability :
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Check/ensure 500 as max page size across views/compone

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-21 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   Fixed in #544
   - ~Scrolling on an autogenerated options, it scrolls back to the top 
automatically~
   
   Fixed in #545
   - ~Add issystem=true systemvmtype=domainrouter to listserviceofferings 
called within VR~
   
   Fixed in https://github.com/apache/cloudstack/pull/4213
   - ~Search by tag doesn't work for vm snapshots~
   
   Fixed in https://github.com/apache/cloudstack/pull/4214
   - ~Adding pagination for listNetworkAclLists~
   - ~Adding pagination for listRoles~
   - ~Returning mshost uuid rather than msid in list hosts response~
   - ~ListVMMetrics doesn't respect hostid param~
   - ~Shows only one template setting~
   
   Fixed in #539
   - ~Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)~
   - ~Make external Id required for backup offerings (David to check and 
remove/address the issue)~
   - ~Traffic type on the network offerings redirects to offering. Could remove 
the router link~
   - ~Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)~
   - ~Template order column appears if you go back from details view to 
listview while in a project but disappears on refresh or just disappears on 
refresh~
   - ~On first time listing isos, the account column is missing~
   - ~Report bug at the bottom should redirect to bug or just say provide 
feedback (change string from "Report Bug" to "report issue")~
   - ~Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)~
   - ~Since the get health check results for VR doesn't download, consider 
changing the icon (OK)~
   - ~Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)~
   - ~Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)~
   - ~When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)~
   - ~If dynamic scalling not supported on the hypervisor, don't show it as an 
action button (systemvms; David - to check and remove/hide/show buttons based 
on hypervisor and old UI)~
   
   
   TO FIX :
   - Deleting all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   
   Usability :
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - No point in having update template permissions if inside project since you 
can't modify 

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-21 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   Fixed in #544
   - ~Scrolling on an autogenerated options, it scrolls back to the top 
automatically~
   
   Fixed in #545
   - ~Add issystem=true systemvmtype=domainrouter to listserviceofferings 
called within VR~
   
   Fixed in https://github.com/apache/cloudstack/pull/4213
   - ~Search by tag doesn't work for vm snapshots~
   
   Fixed in https://github.com/apache/cloudstack/pull/4214
   - ~Adding pagination for listNetworkAclLists~
   - ~Adding pagination for listRoles~
   - ~Returning mshost uuid rather than msid in list hosts response~
   - ~ListVMMetrics doesn't respect hostid param~
   - ~Shows only one template setting~
   
   Fixed in #539
   - ~Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)~
   - ~Make external Id required for backup offerings (David to check and 
remove/address the issue)~
   - ~Traffic type on the network offerings redirects to offering. Could remove 
the router link~
   - ~Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)~
   - ~Template order column appears if you go back from details view to 
listview while in a project but disappears on refresh or just disappears on 
refresh~
   - ~On first time listing isos, the account column is missing~
   - ~Report bug at the bottom should redirect to bug or just say provide 
feedback (change string from "Report Bug" to "report issue")~
   - ~Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)~
   - ~Since the get health check results for VR doesn't download, consider 
changing the icon (OK)~
   - ~Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)~
   - ~Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)~
   - ~When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)~
   
   
   TO FIX :
   - Deleting all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   
   Usability :
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Check/ensure 500 as max page size across views/components (David?)
   - Add loading while fetching tags and annotations (OK, David - Infocar

[GitHub] [cloudstack-primate] ravening commented on pull request #543: Fix template search

2020-07-21 Thread GitBox


ravening commented on pull request #543:
URL: 
https://github.com/apache/cloudstack-primate/pull/543#issuecomment-662279302


   @davidjumani I can no longer see "Centos template" while deploying vm while 
in old ui, I can still see it
   
   ```
   "isdynamicallyscalable": false,
 "isextractable": true,
 "isfeatured": true,
 "ispublic": true,
 "isready": true,
 "name": "CentOS 5.5(64-bit) no GUI (KVM)",
 "ostypeid": "90004bff-c29e-11ea-a58c-06c95c00338b",
 "ostypename": "CentOS 5.5 (64-bit)",
   ```
   
   Old ui
   
   ![Screenshot 2020-07-22 at 08 57 
19](https://user-images.githubusercontent.com/10645273/88144530-5addc500-cbf9-11ea-9435-171512f19e3b.png)
   
   
   New ui
   
   ![Screenshot 2020-07-22 at 08 57 
39](https://user-images.githubusercontent.com/10645273/88144557-66c98700-cbf9-11ea-8933-7c9dfa9441c3.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org