[GitHub] [cloudstack-cloudmonkey] braderhart commented on issue #62: Bash completion

2020-07-19 Thread GitBox


braderhart commented on issue #62:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/issues/62#issuecomment-660638112


   Yeah agreed. Hugo, kubectl, eksctl, skaffold, and others work great.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-cloudmonkey] rhtyd commented on issue #62: Bash completion

2020-07-19 Thread GitBox


rhtyd commented on issue #62:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/issues/62#issuecomment-660674499


   @onitake cobra is not a standard Go flag package, besides it's a heavily 
bloated dependency.
   
   `cmk` provides an autocompletion for not just parameters but also parameter 
values when used in the shell mode. I'm not sure other stated dependencies 
provide value completion (by querying via a server-side request) as well. Pull 
requests are welcome!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-cloudmonkey] rhtyd edited a comment on issue #62: Bash completion

2020-07-19 Thread GitBox


rhtyd edited a comment on issue #62:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/issues/62#issuecomment-660674499


   @onitake cobra is not a standard Go flag package, besides it's a heavily 
bloated dependency. `cmk` already uses the standard `flag` package: 
https://github.com/apache/cloudstack-cloudmonkey/blob/master/cmk.go#L21
   
   `cmk` provides an autocompletion for not just parameters but also parameter 
values when used in the shell mode. I'm not sure other stated dependencies 
provide value completion (by querying via a server-side request) as well. Pull 
requests are welcome!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-cloudmonkey] onitake commented on issue #62: Bash completion

2020-07-19 Thread GitBox


onitake commented on issue #62:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/issues/62#issuecomment-660684302


   @rhtyd I totally agree with you on that one. However, by using cobra, bash 
autocompletion would be easier to add.
   The standard flag package is very primitive and cannot autogenerate bash 
autocompletion strings like many Go tools do.
   
   The semi-dynamic nature of cmk will certainly make it a bit more difficult 
to implement this - but there are many tools that do send server requests when 
autocompleting. `scp` and `kubectl` come to mind.
   
   `posener/complete` is compatible with the standard flags package, so 
integrating it into `cmk` will be easy. What will be a bit more complicated is 
adding the dynamic commands. The documentation is here: 
https://godoc.org/github.com/posener/complete



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-19 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   Fixed in #544
   - ~Scrolling on an autogenerated options, it scrolls back to the top 
automatically~
   
   Fixed in #545
   - ~Add issystem=true systemvmtype=domainrouter to listserviceofferings 
called within VR~
   
   Fixed in https://github.com/apache/cloudstack/pull/4213
   - ~Search by tag doesn't work for vm snapshots~
   
   Fixed in https://github.com/apache/cloudstack/pull/4214
   - ~Adding pagination for listNetworkAclLists~
   - ~Adding pagination for listRoles~
   - ~Returning mshost uuid rather than msid in list hosts response~
   - ~ListVMMetrics doesn't respect hostid param~
   
   Fixed in #539
   - ~Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)~
   - ~Make external Id required for backup offerings (David to check and 
remove/address the issue)~
   - ~Traffic type on the network offerings redirects to offering. Could remove 
the router link~
   - ~Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)~
   - ~Template order column appears if you go back from details view to 
listview while in a project but disappears on refresh or just disappears on 
refresh~
   - ~On first time listing isos, the account column is missing~
   
   TO FIX :
   - Deleting all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Template adding setting removes the prior existing setting after refresh 
for xen & vmware
   - Save settings in templates, should save all, not just the one added
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - Since the get health check results for VR doesn't download, consider 
changing the icon (OK)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)
   - Check/ensure 500 as max page size across views/components (David?)
   - Add loading while fetching tags and annotations (OK, David - Infocard)
   - Root Domain shows as '/' in list & detail view info

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-19 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   Fixed in #544
   - ~Scrolling on an autogenerated options, it scrolls back to the top 
automatically~
   
   Fixed in #545
   - ~Add issystem=true systemvmtype=domainrouter to listserviceofferings 
called within VR~
   
   Fixed in https://github.com/apache/cloudstack/pull/4213
   - ~Search by tag doesn't work for vm snapshots~
   
   Fixed in https://github.com/apache/cloudstack/pull/4214
   - ~Adding pagination for listNetworkAclLists~
   - ~Adding pagination for listRoles~
   - ~Returning mshost uuid rather than msid in list hosts response~
   - ~ListVMMetrics doesn't respect hostid param~
   
   Fixed in #539
   - ~Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)~
   - ~Make external Id required for backup offerings (David to check and 
remove/address the issue)~
   - ~Traffic type on the network offerings redirects to offering. Could remove 
the router link~
   - ~Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)~
   - ~Template order column appears if you go back from details view to 
listview while in a project but disappears on refresh or just disappears on 
refresh~
   - ~On first time listing isos, the account column is missing~
   
   TO FIX :
   - Deleting all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Template adding setting removes the prior existing setting after refresh 
for xen & vmware : Relate to showunique flag
   - Save settings in templates, should save all, not just the one added
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - Since the get health check results for VR doesn't download, consider 
changing the icon (OK)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)
   - Check/ensure 500 as max page size across views/components (David?)
   - Add loading while fetching tags and annotations (OK, David - Infocard)
   - Root Domain shows as '/

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-19 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   Fixed in #544
   - ~Scrolling on an autogenerated options, it scrolls back to the top 
automatically~
   
   Fixed in #545
   - ~Add issystem=true systemvmtype=domainrouter to listserviceofferings 
called within VR~
   
   Fixed in https://github.com/apache/cloudstack/pull/4213
   - ~Search by tag doesn't work for vm snapshots~
   
   Fixed in https://github.com/apache/cloudstack/pull/4214
   - ~Adding pagination for listNetworkAclLists~
   - ~Adding pagination for listRoles~
   - ~Returning mshost uuid rather than msid in list hosts response~
   - ~ListVMMetrics doesn't respect hostid param~
   
   Fixed in #539
   - ~Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)~
   - ~Make external Id required for backup offerings (David to check and 
remove/address the issue)~
   - ~Traffic type on the network offerings redirects to offering. Could remove 
the router link~
   - ~Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)~
   - ~Template order column appears if you go back from details view to 
listview while in a project but disappears on refresh or just disappears on 
refresh~
   - ~On first time listing isos, the account column is missing~
   
   TO FIX :
   - Deleting all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Shows only one template setting if it is within a project : Related to 
showunique flag
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - Since the get health check results for VR doesn't download, consider 
changing the icon (OK)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)
   - Check/ensure 500 as max page size across views/components (David?)
   - Add loading while fetching tags and annotations (OK, David - Infocard)
   - Root Domain shows as '/' in list & detail view infocard (David - to check 
in what views or check in InfoCard - domainpath?

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-19 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   Fixed in #544
   - ~Scrolling on an autogenerated options, it scrolls back to the top 
automatically~
   
   Fixed in #545
   - ~Add issystem=true systemvmtype=domainrouter to listserviceofferings 
called within VR~
   
   Fixed in https://github.com/apache/cloudstack/pull/4213
   - ~Search by tag doesn't work for vm snapshots~
   
   Fixed in https://github.com/apache/cloudstack/pull/4214
   - ~Adding pagination for listNetworkAclLists~
   - ~Adding pagination for listRoles~
   - ~Returning mshost uuid rather than msid in list hosts response~
   - ~ListVMMetrics doesn't respect hostid param~
   
   Fixed in #539
   - ~Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)~
   - ~Make external Id required for backup offerings (David to check and 
remove/address the issue)~
   - ~Traffic type on the network offerings redirects to offering. Could remove 
the router link~
   - ~Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)~
   - ~Template order column appears if you go back from details view to 
listview while in a project but disappears on refresh or just disappears on 
refresh~
   - ~On first time listing isos, the account column is missing~
   - ~Report bug at the bottom should redirect to bug or just say provide 
feedback (change string from "Report Bug" to "report issue")~
   
   TO FIX :
   - Deleting all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Shows only one template setting if it is within a project : Related to 
showunique flag
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - Since the get health check results for VR doesn't download, consider 
changing the icon (OK)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)
   - Check/ensure 500 as max page size across views/components (David?)
   - Add loading while fetching tags and annotations (OK, David - Infoc

[GitHub] [cloudstack-primate] utchoang commented on issue #510: Build and packaging improvements

2020-07-19 Thread GitBox


utchoang commented on issue #510:
URL: 
https://github.com/apache/cloudstack-primate/issues/510#issuecomment-660823292


   @rhtyd What do you think about my comment?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-19 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   Fixed in #544
   - ~Scrolling on an autogenerated options, it scrolls back to the top 
automatically~
   
   Fixed in #545
   - ~Add issystem=true systemvmtype=domainrouter to listserviceofferings 
called within VR~
   
   Fixed in https://github.com/apache/cloudstack/pull/4213
   - ~Search by tag doesn't work for vm snapshots~
   
   Fixed in https://github.com/apache/cloudstack/pull/4214
   - ~Adding pagination for listNetworkAclLists~
   - ~Adding pagination for listRoles~
   - ~Returning mshost uuid rather than msid in list hosts response~
   - ~ListVMMetrics doesn't respect hostid param~
   
   Fixed in #539
   - ~Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)~
   - ~Make external Id required for backup offerings (David to check and 
remove/address the issue)~
   - ~Traffic type on the network offerings redirects to offering. Could remove 
the router link~
   - ~Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)~
   - ~Template order column appears if you go back from details view to 
listview while in a project but disappears on refresh or just disappears on 
refresh~
   - ~On first time listing isos, the account column is missing~
   - ~Report bug at the bottom should redirect to bug or just say provide 
feedback (change string from "Report Bug" to "report issue")~
   - ~Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)~
   
   TO FIX :
   - Deleting all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Shows only one template setting if it is within a project : Related to 
showunique flag
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - Since the get health check results for VR doesn't download, consider 
changing the icon (OK)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)
   - Check/ensure

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-19 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   Fixed in #544
   - ~Scrolling on an autogenerated options, it scrolls back to the top 
automatically~
   
   Fixed in #545
   - ~Add issystem=true systemvmtype=domainrouter to listserviceofferings 
called within VR~
   
   Fixed in https://github.com/apache/cloudstack/pull/4213
   - ~Search by tag doesn't work for vm snapshots~
   
   Fixed in https://github.com/apache/cloudstack/pull/4214
   - ~Adding pagination for listNetworkAclLists~
   - ~Adding pagination for listRoles~
   - ~Returning mshost uuid rather than msid in list hosts response~
   - ~ListVMMetrics doesn't respect hostid param~
   
   Fixed in #539
   - ~Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)~
   - ~Make external Id required for backup offerings (David to check and 
remove/address the issue)~
   - ~Traffic type on the network offerings redirects to offering. Could remove 
the router link~
   - ~Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)~
   - ~Template order column appears if you go back from details view to 
listview while in a project but disappears on refresh or just disappears on 
refresh~
   - ~On first time listing isos, the account column is missing~
   - ~Report bug at the bottom should redirect to bug or just say provide 
feedback (change string from "Report Bug" to "report issue")~
   - ~Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)~
   - ~Since the get health check results for VR doesn't download, consider 
changing the icon (OK)~
   
   TO FIX :
   - Deleting all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Shows only one template setting if it is within a project : Related to 
showunique flag
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)
   - Check/ensu