[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-16 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   TO FIX :
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Scrolling on an autogenerated options, it scrolls back to the top 
automatically
   - Missing capacity fields while creating primary storage
   - Deleteing all types of Network's tags removes it on the current page but 
prrsists on refresh (Perhaps just within a project)
   - Template order column appears if you go back from details view to listview 
while in a project but disappears on refresh or just disappears on refresh
   - Template adding setting disappears after refresh for non standard input. 
Eg: cpu.corespersocket: 4
   - Pagination broken on VPN > ACL : `listnetworkacllistsresponse` does not 
support pagination so broken on primate
   - Traffic type on the network offerings redirects to offering. Could remove 
the router link ?
   - Management server on the host info card is wrong ?
   - Pagination broken on roles - Broken in the backend
   - Save settings in templates, should save all, not just the one added
   - Templates: On refresh, lists only first tag but on adding a tag, shows all
   - Add issystem=true systemvmtype=domainrouter to listserviceofferings called 
within VR
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]??
   - Search by tag doesn't work for vm snapshots
   - On first time listing isos, the account column is missing
   - Call ListVMs rather than metrics since it doesn't respect hostid param
   
   
   Usability :
   - Show EnableHA as a uservm action only if it is supported. Can perform the 
listHostHaProvider to check whether the hypervisor is supported
   - When migrating a vm / systemvm, exclude the current host from the list
   - In the migrate snapshot to different storage, exclude the current host 
storage
   - Default select a zone in deployVM
   - Is there a need to show state as well as allocated state in list zones ?
   - Add account on project dashboard
   - Enter to submit a form
   - Enter to advance search rather than submit
   - Keep the current router path while switching projects
   - Since the get health check results for VR doesn't download, consider 
changing the icon
   - No point in having update template permissions if inside project since you 
can't modify them
   - Sort the projects in the projects dropdown
   - Search for IPAddress firewall rule ?
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present)
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present)
   - While listing domains, on page refresh, it goes back to the root domain 
(context is lost)
   - Add loading while fetching tags and annotations
   - Root Domain shows as '/' in list & detail view infocard
   - Report bug at the bottom should redirect to bug or just say provide 
feedback
   - If dynamic scalling not supported on the hypervisor, don't show it as an 
action button (systemvms)
   - Why do IPs always point to the resource ?
   - Account in user info card doesn't directly go to account but to the 
account listview ?
   - LB Rule is just plain json in ilb
   - Refresh after successfully uploading an iso
   - Make external Id required for backup offerings
   - Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate
   
   
   Mobile View :
   - Project selector not visible in mobile mode ?
   - Create zone form is not aligned in mobile view
   - Header notification should be clearable (obstrucs in mobile view)
   - Edit setting icon misaligned in mobile (accounts, domain, zones, etc)
   - Page size changer doesn't show up on mobile mode
   



This is an automated message from the Apache Git Service.
To respond to the message, please log o

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-16 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   TO FIX :
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Scrolling on an autogenerated options, it scrolls back to the top 
automatically
   - Missing capacity fields while creating primary storage
   - Deleteing all types of Network's tags removes it on the current page but 
prrsists on refresh (Perhaps just within a project)
   - Template order column appears if you go back from details view to listview 
while in a project but disappears on refresh or just disappears on refresh
   - Template adding setting disappears after refresh for non standard input. 
Eg: cpu.corespersocket: 4
   - Pagination broken on VPN > ACL : `listnetworkacllistsresponse` does not 
support pagination so broken on primate
   - Traffic type on the network offerings redirects to offering. Could remove 
the router link ?
   - Management server on the host info card is wrong ?
   - Pagination broken on roles - Broken in the backend
   - Save settings in templates, should save all, not just the one added
   - Templates: On refresh, lists only first tag but on adding a tag, shows all
   - Add issystem=true systemvmtype=domainrouter to listserviceofferings called 
within VR
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]??
   - Search by tag doesn't work for vm snapshots
   - On first time listing isos, the account column is missing
   - Call ListVMMetrics doesn't respect hostid param
   
   
   Usability :
   - Show EnableHA as a uservm action only if it is supported. Can perform the 
listHostHaProvider to check whether the hypervisor is supported
   - When migrating a vm / systemvm, exclude the current host from the list
   - In the migrate snapshot to different storage, exclude the current host 
storage
   - Default select a zone in deployVM
   - Is there a need to show state as well as allocated state in list zones ?
   - Add account on project dashboard
   - Enter to submit a form
   - Enter to advance search rather than submit
   - Keep the current router path while switching projects
   - Since the get health check results for VR doesn't download, consider 
changing the icon
   - No point in having update template permissions if inside project since you 
can't modify them
   - Sort the projects in the projects dropdown
   - Search for IPAddress firewall rule ?
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present)
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present)
   - While listing domains, on page refresh, it goes back to the root domain 
(context is lost)
   - Add loading while fetching tags and annotations
   - Root Domain shows as '/' in list & detail view infocard
   - Report bug at the bottom should redirect to bug or just say provide 
feedback
   - If dynamic scalling not supported on the hypervisor, don't show it as an 
action button (systemvms)
   - Why do IPs always point to the resource ?
   - Account in user info card doesn't directly go to account but to the 
account listview ?
   - LB Rule is just plain json in ilb
   - Refresh after successfully uploading an iso
   - Make external Id required for backup offerings
   - Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate
   
   
   Mobile View :
   - Project selector not visible in mobile mode ?
   - Create zone form is not aligned in mobile view
   - Header notification should be clearable (obstrucs in mobile view)
   - Edit setting icon misaligned in mobile (accounts, domain, zones, etc)
   - Page size changer doesn't show up on mobile mode
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #544: Fix auto-scrolling issue with autogen forms

2020-07-16 Thread GitBox


Pearl1594 opened a new pull request #544:
URL: https://github.com/apache/cloudstack-primate/pull/544


   In autogenerated forms - the a-select components scroll up automatically.
   Issue: the null key defined for a case when no input needs to be provided.
   Fix: Changed the null key to and empty string



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #544: Fix auto-scrolling issue with autogen forms

2020-07-16 Thread GitBox


Pearl1594 commented on pull request #544:
URL: 
https://github.com/apache/cloudstack-primate/pull/544#issuecomment-659224419


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #544: Fix auto-scrolling issue with autogen forms

2020-07-16 Thread GitBox


blueorangutan commented on pull request #544:
URL: 
https://github.com/apache/cloudstack-primate/pull/544#issuecomment-659224952


   @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-cloudmonkey] weizhouapache closed issue #66: Error 432 while list publicipaddresses

2020-07-16 Thread GitBox


weizhouapache closed issue #66:
URL: https://github.com/apache/cloudstack-cloudmonkey/issues/66


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-cloudmonkey] weizhouapache commented on issue #66: Error 432 while list publicipaddresses

2020-07-16 Thread GitBox


weizhouapache commented on issue #66:
URL: 
https://github.com/apache/cloudstack-cloudmonkey/issues/66#issuecomment-659228167


   @rhtyd cannot reproduce the issue in 6.1.0
   however, there is still no network available for associatednetworkid



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #458: Adding quick-view options to list view

2020-07-16 Thread GitBox


rhtyd commented on pull request #458:
URL: 
https://github.com/apache/cloudstack-primate/pull/458#issuecomment-659302223


   Ping @utchoang @ravening can you test as well, thnx



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI

2020-07-16 Thread GitBox


rhtyd commented on pull request #481:
URL: 
https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659302592


   @Pearl1594 @davidjumani @ravening @nvazquez can you help review, thnx
   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI

2020-07-16 Thread GitBox


blueorangutan commented on pull request #481:
URL: 
https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659302957


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep 
you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI

2020-07-16 Thread GitBox


blueorangutan commented on pull request #481:
URL: 
https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659307203


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/481 (JID-2373)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-16 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   TO FIX :
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Scrolling on an autogenerated options, it scrolls back to the top 
automatically
   - Missing capacity fields while creating primary storage
   - Deleteing all types of Network's tags removes it on the current page but 
prrsists on refresh (Perhaps just within a project)
   - Template order column appears if you go back from details view to listview 
while in a project but disappears on refresh or just disappears on refresh
   - Template adding setting disappears after refresh for non standard input. 
Eg: cpu.corespersocket: 4
   - Pagination broken on VPN > ACL : `listnetworkacllistsresponse` does not 
support pagination so broken on primate
   - Traffic type on the network offerings redirects to offering. Could remove 
the router link ?
   - Management server on the host info card is wrong ?
   - Pagination broken on roles - Broken in the backend
   - Save settings in templates, should save all, not just the one added
   - Templates: On refresh, lists only first tag but on adding a tag, shows all
   - Add issystem=true systemvmtype=domainrouter to listserviceofferings called 
within VR
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]??
   - Search by tag doesn't work for vm snapshots
   - On first time listing isos, the account column is missing
   - Call ListVMMetrics doesn't respect hostid param
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   - Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)
   - Make external Id required for backup offerings (David to check and 
remove/address the issue)
   - Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - Since the get health check results for VR doesn't download, consider 
changing the icon (OK)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)
   - Check/ensure 500 as max page size across views/components (David?)
   - Add loading while fetching tags and annotations (OK, David - Infocard)
   - Root Domain shows as '/' in list & detail view infocard (David - to check 
in what views or check in InfoCard - domainpath?)
   - Report bug at the bottom should redirect to bug or just say provide 
feedback (change string from "Report Bug" to "report issue")
   - If dynamic scalling not supported on the hypervisor, don't show 

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-16 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   TO FIX :
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Scrolling on an autogenerated options, it scrolls back to the top 
automatically
   - Missing capacity fields while creating primary storage
   - Deleteing all types of Network's tags removes it on the current page but 
prrsists on refresh (Perhaps just within a project)
   - Template order column appears if you go back from details view to listview 
while in a project but disappears on refresh or just disappears on refresh
   - Template adding setting removes the prior existing setting after refresh 
for xen & vmware
   - Pagination broken on VPN > ACL : `listnetworkacllistsresponse` does not 
support pagination so broken on primate
   - Traffic type on the network offerings redirects to offering. Could remove 
the router link ?
   - Management server on the host info card is wrong ?
   - Pagination broken on roles - Broken in the backend
   - Save settings in templates, should save all, not just the one added
   - Templates: On refresh, lists only first tag but on adding a tag, shows all
   - Add issystem=true systemvmtype=domainrouter to listserviceofferings called 
within VR
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]??
   - Search by tag doesn't work for vm snapshots
   - On first time listing isos, the account column is missing
   - Call ListVMMetrics doesn't respect hostid param
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   - Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)
   - Make external Id required for backup offerings (David to check and 
remove/address the issue)
   - Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - Since the get health check results for VR doesn't download, consider 
changing the icon (OK)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)
   - Check/ensure 500 as max page size across views/components (David?)
   - Add loading while fetching tags and annotations (OK, David - Infocard)
   - Root Domain shows as '/' in list & detail view infocard (David - to check 
in what views or check in InfoCard - domainpath?)
   - Report bug at the bottom should redirect to bug or just say provide 
feedback (change string from "Report Bug" to "report issue")
   - If dynamic scalling not supported on the hypervisor, don't show it as an 

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-16 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   TO FIX :
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Scrolling on an autogenerated options, it scrolls back to the top 
automatically
   - Missing capacity fields while creating primary storage
   - Deleteing all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Template order column appears if you go back from details view to listview 
while in a project but disappears on refresh or just disappears on refresh
   - Template adding setting removes the prior existing setting after refresh 
for xen & vmware
   - Pagination broken on VPN > ACL : `listnetworkacllistsresponse` does not 
support pagination so broken on primate
   - Traffic type on the network offerings redirects to offering. Could remove 
the router link ?
   - Management server on the host info card is wrong ?
   - Pagination broken on roles - Broken in the backend
   - Save settings in templates, should save all, not just the one added
   - Templates: On refresh, lists only first tag but on adding a tag, shows all
   - Add issystem=true systemvmtype=domainrouter to listserviceofferings called 
within VR
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - Search by tag doesn't work for vm snapshots
   - On first time listing isos, the account column is missing
   - Call ListVMMetrics doesn't respect hostid param
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   - Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)
   - Make external Id required for backup offerings (David to check and 
remove/address the issue)
   - Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - Since the get health check results for VR doesn't download, consider 
changing the icon (OK)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)
   - Check/ensure 500 as max page size across views/components (David?)
   - Add loading while fetching tags and annotations (OK, David - Infocard)
   - Root Domain shows as '/' in list & detail view infocard (David - to check 
in what views or check in InfoCard - domainpath?)
   - Report bug at the b

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-16 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   TO FIX :
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Scrolling on an autogenerated options, it scrolls back to the top 
automatically
   - Missing capacity fields while creating primary storage
   - Deleteing all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Template order column appears if you go back from details view to listview 
while in a project but disappears on refresh or just disappears on refresh
   - Template adding setting removes the prior existing setting after refresh 
for xen & vmware
   - Pagination broken on VPN > ACL : `listnetworkacllistsresponse` does not 
support pagination so broken on primate
   - Traffic type on the network offerings redirects to offering. Could remove 
the router link ?
   - Management server on the host info card is wrong ?
   - Pagination broken on roles - Broken in the backend
   - Save settings in templates, should save all, not just the one added
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Add issystem=true systemvmtype=domainrouter to listserviceofferings called 
within VR
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - Search by tag doesn't work for vm snapshots
   - On first time listing isos, the account column is missing
   - Call ListVMMetrics doesn't respect hostid param
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   - Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)
   - Make external Id required for backup offerings (David to check and 
remove/address the issue)
   - Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - Since the get health check results for VR doesn't download, consider 
changing the icon (OK)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)
   - Check/ensure 500 as max page size across views/components (David?)
   - Add loading while fetching tags and annotations (OK, David - Infocard)
   - Root Domain shows as '/' in list & detail view infocard (David - to check 
in what views or check in InfoCard - domainpa

[GitHub] [cloudstack-cloudmonkey] mlsorensen opened a new issue #67: Name resolution doesn't work correctly on Darwin build

2020-07-16 Thread GitBox


mlsorensen opened a new issue #67:
URL: https://github.com/apache/cloudstack-cloudmonkey/issues/67


   There's a known problem with Golang's net DNS code that keeps name 
resolution from working properly on Mac.  Golang binaries compiled for Mac only 
utilize /etc/resolv.conf, and not the Mac's dynamic, native name resolution 
libraries.
   
   This is resolved generally by compiling with CGO_ENABLED=1, but you also 
have to be compiling the Darwin binary on a Mac in order to get it to work.
   
   Users who want a functioning Darwin build of cloudmonkey will need to 
compile it themselves, enabling CGO, unless the project can produce such 
binaries and publish them.
   
   See https://github.com/golang/go/issues/31705



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #543: Fix template search

2020-07-16 Thread GitBox


davidjumani commented on pull request #543:
URL: 
https://github.com/apache/cloudstack-primate/pull/543#issuecomment-659585610


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #543: Fix template search

2020-07-16 Thread GitBox


blueorangutan commented on pull request #543:
URL: 
https://github.com/apache/cloudstack-primate/pull/543#issuecomment-659586374


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #543: Fix template search

2020-07-16 Thread GitBox


blueorangutan commented on pull request #543:
URL: 
https://github.com/apache/cloudstack-primate/pull/543#issuecomment-659590747


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/543 (JID-2383)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #543: Fix template search

2020-07-16 Thread GitBox


davidjumani commented on pull request #543:
URL: 
https://github.com/apache/cloudstack-primate/pull/543#issuecomment-659831531


   @rhtyd @ravening Please review. Moved the search to DeployVM itself to 
simplify things and for consistancy



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-16 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   TO FIX :
   - Scrolling on an autogenerated options, it scrolls back to the top 
automatically
   - Deleteing all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Template order column appears if you go back from details view to listview 
while in a project but disappears on refresh or just disappears on refresh
   - Template adding setting removes the prior existing setting after refresh 
for xen & vmware
   - Pagination broken on VPN > ACL : `listnetworkacllistsresponse` does not 
support pagination so broken on primate
   - Traffic type on the network offerings redirects to offering. Could remove 
the router link ?
   - Management server on the host info card is wrong ?
   - Pagination broken on roles - Broken in the backend
   - Save settings in templates, should save all, not just the one added
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Add issystem=true systemvmtype=domainrouter to listserviceofferings called 
within VR
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - Search by tag doesn't work for vm snapshots
   - On first time listing isos, the account column is missing
   - Call ListVMMetrics doesn't respect hostid param
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   - Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)
   - Make external Id required for backup offerings (David to check and 
remove/address the issue)
   - Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - Since the get health check results for VR doesn't download, consider 
changing the icon (OK)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)
   - Check/ensure 500 as max page size across views/components (David?)
   - Add loading while fetching tags and annotations (OK, David - Infocard)
   - Root Domain shows as '/' in list & detail view infocard (David - to check 
in what views or check in InfoCard - domainpath?)
   - Report bug at the bottom should redirect to bu

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-16 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   Fixed in #539
   - ~Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)~
   
   
   TO FIX :
   - Scrolling on an autogenerated options, it scrolls back to the top 
automatically
   - Deleting all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Template order column appears if you go back from details view to listview 
while in a project but disappears on refresh or just disappears on refresh
   - Template adding setting removes the prior existing setting after refresh 
for xen & vmware
   - Pagination broken on VPN > ACL : `listnetworkacllistsresponse` does not 
support pagination so broken on primate
   - Traffic type on the network offerings redirects to offering. Could remove 
the router link ?
   - Management server on the host info card is wrong ?
   - Pagination broken on roles - Broken in the backend
   - Save settings in templates, should save all, not just the one added
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Add issystem=true systemvmtype=domainrouter to listserviceofferings called 
within VR
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - Search by tag doesn't work for vm snapshots
   - On first time listing isos, the account column is missing
   - Call ListVMMetrics doesn't respect hostid param
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   - Make external Id required for backup offerings (David to check and 
remove/address the issue)
   - Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - Since the get health check results for VR doesn't download, consider 
changing the icon (OK)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)
   - Check/ensure 500 as max page size across views/components (David?)
   - Add loading while fetching tags and annotations (OK, David - Infocard)
   - Root Domain shows as '/' in list & detail view infocard (David - to check 
in what views or check in InfoCard - domainpath?)
   - Report bug at the bo

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-16 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   Fixed in #539
   - ~Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)~
   
   TO FIX :
   - Scrolling on an autogenerated options, it scrolls back to the top 
automatically
   - Deleting all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Template order column appears if you go back from details view to listview 
while in a project but disappears on refresh or just disappears on refresh
   - Template adding setting removes the prior existing setting after refresh 
for xen & vmware
   - Traffic type on the network offerings redirects to offering. Could remove 
the router link ?
   - Management server on the host info card is wrong ?
   - Save settings in templates, should save all, not just the one added
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Add issystem=true systemvmtype=domainrouter to listserviceofferings called 
within VR
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - On first time listing isos, the account column is missing
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   - Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)
   
   Backend Fixes :
   - Pagination broken on VPN > ACL : `listnetworkacllistsresponse` does not 
support pagination so broken on primate
   - Pagination broken on roles - Broken in the backend
   - Search by tag doesn't work for vm snapshots
   - ListVMMetrics doesn't respect hostid param
   - Make external Id required for backup offerings (David to check and 
remove/address the issue)
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - Since the get health check results for VR doesn't download, consider 
changing the icon (OK)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)
   - Check/ensure 500 as max page size across views/components (David?)
   - Add loading while fetching tags and annotations (OK, David - Infocard)
   - Root Domain shows as '/' in list & detail view infocard (David - to check 
in what views or check in InfoCard - domainpath?)
   - Report

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-16 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   Fixed in #539
   - ~Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)~
   
   TO FIX :
   - Scrolling on an autogenerated options, it scrolls back to the top 
automatically
   - Deleting all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Template order column appears if you go back from details view to listview 
while in a project but disappears on refresh or just disappears on refresh
   - Template adding setting removes the prior existing setting after refresh 
for xen & vmware
   - Traffic type on the network offerings redirects to offering. Could remove 
the router link ?
   - Management server on the host info card is wrong ?
   - Save settings in templates, should save all, not just the one added
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Add issystem=true systemvmtype=domainrouter to listserviceofferings called 
within VR
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - On first time listing isos, the account column is missing
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   
   - Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)
   
   Backend Fixes :
   - Pagination broken on VPN > ACL : `listnetworkacllistsresponse` does not 
support pagination so broken on primate
   - Pagination broken on roles - Broken in the backend
   - Search by tag doesn't work for vm snapshots
   - ListVMMetrics doesn't respect hostid param
   - Make external Id required for backup offerings (David to check and 
remove/address the issue)
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - Since the get health check results for VR doesn't download, consider 
changing the icon (OK)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)
   - Check/ensure 500 as max page size across views/components (David?)
   - Add loading while fetching tags and annotations (OK, David - Infocard)
   - Root Domain shows as '/' in list & detail view infocard (David - to check 
in what views or check in InfoCard - domainpath?)
   - Re

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-16 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   Fixed in #539
   - ~Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)~
   
   Fixed in https://github.com/apache/cloudstack/pull/4213
   - ~Search by tag doesn't work for vm snapshots~
   
   TO FIX :
   - Scrolling on an autogenerated options, it scrolls back to the top 
automatically
   - Deleting all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Template order column appears if you go back from details view to listview 
while in a project but disappears on refresh or just disappears on refresh
   - Template adding setting removes the prior existing setting after refresh 
for xen & vmware
   - Traffic type on the network offerings redirects to offering. Could remove 
the router link ?
   - Management server on the host info card is wrong ?
   - Save settings in templates, should save all, not just the one added
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Add issystem=true systemvmtype=domainrouter to listserviceofferings called 
within VR
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - On first time listing isos, the account column is missing
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   - Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)
   
   Backend Fixes :
   - Pagination broken on VPN > ACL : `listnetworkacllistsresponse` does not 
support pagination so broken on primate
   - Pagination broken on roles - Broken in the backend
   - ListVMMetrics doesn't respect hostid param
   - Make external Id required for backup offerings (David to check and 
remove/address the issue)
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - Since the get health check results for VR doesn't download, consider 
changing the icon (OK)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)
   - Check/ensure 500 as max page size across views/components (David?)
   - Add loading while fetching tags and annotations (OK, David - Infocard)
   - Root Domain shows as '/' in list & detail view infocard (David - to check 

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-16 Thread GitBox


davidjumani edited a comment on issue #528:
URL: 
https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179


   Bugs :
   Fixed in #534
   - ~While changing a systemvm service offering, need to fetch system 
offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to 
the listServiceOfferings api~
   - ~In the event listview, clicking the username redirects to the event not 
the user~
   - ~When editing a role, resource admin is not in the dropdown~
   - ~VR router offering link leads to an empty page~
   - ~In DeployVM, disk offering search doesn't show 'No records' if none 
present but keeps the old rows~
   - ~In add ACL Rule, the Rule# field should be a number, not text~
   - ~No pagination for security groups ingress / egress rules~
   
   Fixed in #540
   - ~Contextual help is missing for creating service offerings~
   - ~Contextual help missing in Infra > Add SSL certificate~
   
   Fixed in #539
   - ~Refresh after successfully uploading an iso (OK, David to check and call 
parent refresh)~
   
   Fixed in https://github.com/apache/cloudstack/pull/4213
   - ~Search by tag doesn't work for vm snapshots~
   
   Fixed in https://github.com/apache/cloudstack/pull/4214
   - ~Adding pagination for listNetworkAclLists~
   
   TO FIX :
   - Scrolling on an autogenerated options, it scrolls back to the top 
automatically
   - Deleting all types of Network's tags removes it on the current page but 
persists on refresh (Perhaps just within a project) : Delete tags api returns 
an error : `Unable to execute API command deletetags due to missing parameter 
resourcetype`
   - Contextual help missing in Add Zone, although not there in the legacy UI 
either
   - Template order column appears if you go back from details view to listview 
while in a project but disappears on refresh or just disappears on refresh
   - Template adding setting removes the prior existing setting after refresh 
for xen & vmware
   - Traffic type on the network offerings redirects to offering. Could remove 
the router link ?
   - Management server on the host info card is wrong ?
   - Save settings in templates, should save all, not just the one added
   - Templates: On refresh, lists only first tag but on adding a tag, shows all 
(probably just in project view)
   - Add issystem=true systemvmtype=domainrouter to listserviceofferings called 
within VR
   - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? Probably 
has to do with the fact that deleting them is an async job
   - On first time listing isos, the account column is missing
   - The delete snapshot icons show even while the snapshot is being created 
(BackingUp state. Copies existing functionality but would be better if this 
check is present) -> David - hide the button based on state
   - Actions for templates / isos show even while they're being uploaded 
(clicking them tells you that they're not in the right state to perform any 
action. Copies existing functionality but would be better if this check is 
present) -> hide/disable buttons based on state
   - Assign to backup shows even while vm is starting in legacy UI as opposed 
to while running in primate (David - based on states show/hide the button)
   
   Backend Fixes :
   - Pagination broken on roles - Broken in the backend
   - ListVMMetrics doesn't respect hostid param
   - Make external Id required for backup offerings (David to check and 
remove/address the issue)
   
   Usability :
   - Can perform the listHostHaProvider to check whether the hypervisor is 
supported (OK, show()-> only show for KVM and Simulator)
   - When migrating a VR/systemvm, exclude the current host from the list (OK, 
check/reuse the migrate user-VM component... concern: keep it simple, don't 
expand scope)
   - In the migrate snapshot to different storage, exclude the current host 
storage (OK... -> quick framework solution -> TBD with Rohit/David)
   - Is there a need to show state as well as allocated state in list cluster 
and zones ? (David to investigate what that allocation and managed states are, 
and then remove from list view... add them in detail view and/or the info card?)
   - Add account on project dashboard (OK with this, add button on the 
accounts/project component and remove the add button from project actions)
   - Enter to advance search rather than submit (OK, if this is a quick one)
   - Since the get health check results for VR doesn't download, consider 
changing the icon (OK)
   - No point in having update template permissions if inside project since you 
can't modify them (TBD - David/Pearl/Rohit to review)
   - Sort the projects in the projects dropdown (OK with sorting the list... 
David - review the logic of loading projects)
   - Check/ensure 500 as max page size across views/components (David?)
   - Add loading while fetching tags and annotations (OK, David - Infocard)
   - Root Domain shows as '/' in list & detail view infocard (David - to check 
in wha

[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #545: add systemvmtype and issystem params to list service offering for VR

2020-07-16 Thread GitBox


Pearl1594 opened a new pull request #545:
URL: https://github.com/apache/cloudstack-primate/pull/545


   Add systemvmtype and issystem params while listing service offerings for VR



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #545: add systemvmtype and issystem params to list service offering for VR

2020-07-16 Thread GitBox


Pearl1594 commented on pull request #545:
URL: 
https://github.com/apache/cloudstack-primate/pull/545#issuecomment-659888480


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #545: add systemvmtype and issystem params to list service offering for VR

2020-07-16 Thread GitBox


blueorangutan commented on pull request #545:
URL: 
https://github.com/apache/cloudstack-primate/pull/545#issuecomment-659889133


   @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #545: add systemvmtype and issystem params to list service offering for VR

2020-07-16 Thread GitBox


blueorangutan commented on pull request #545:
URL: 
https://github.com/apache/cloudstack-primate/pull/545#issuecomment-659892902


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/545 (JID-2396)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org