[GitHub] [cloudstack-primate] utchoang commented on issue #510: Build and packaging improvements
utchoang commented on issue #510: URL: https://github.com/apache/cloudstack-primate/issues/510#issuecomment-658585116 Currently, I have only found a few issues: 1. In node_modules, we use package `@antv/g2`, this package is used in the chart. => Ignore package `@antv/g2` because I think Primate doesn't seem to use the chart. 2. Ant design icons are imported entirely including icons not used in Primate => Only import component icons to use in Primate. Refer: https://stackoverflow.com/questions/48721290/ant-design-huge-imports 3. In src/locales, JSON files are being imported directly, so its size is very large (> 2 MB) => There is still no better way.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang edited a comment on issue #510: Build and packaging improvements
utchoang edited a comment on issue #510: URL: https://github.com/apache/cloudstack-primate/issues/510#issuecomment-658585116 @rhtyd cc @svenvogel Currently, I have only found a few issues: 1. In node_modules, we use package `@antv/g2`, this package is used in the chart. => Ignore package `@antv/g2` because I think Primate doesn't seem to use the chart. 2. Ant design icons are imported entirely including icons not used in Primate => Only import component icons to use in Primate. Refer: https://stackoverflow.com/questions/48721290/ant-design-huge-imports 3. In src/locales, JSON files are being imported directly, so its size is very large (> 2 MB) => There is still no better way.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on issue #510: Build and packaging improvements
utchoang commented on issue #510: URL: https://github.com/apache/cloudstack-primate/issues/510#issuecomment-658586035 @rhtyd Also can I use `core/lazy_use` instead of `core/use` in main.js? Because to avoid arising unused components. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review
davidjumani edited a comment on issue #528: URL: https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179 Bugs : Fixed in #534 - ~While changing a systemvm service offering, need to fetch system offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to the listServiceOfferings api~ - ~In the event listview, clicking the username redirects to the event not the user~ - ~When editing a role, resource admin is not in the dropdown~ - ~VR router offering link leads to an empty page~ - ~In DeployVM, disk offering search doesn't show 'No records' if none present but keeps the old rows~ - ~In add ACL Rule, the Rule# field should be a number, not text~ - ~No pagination for security groups ingress / egress rules~ TO FIX : - Contextual help is missing for creating service offerings - Contextual help missing in Infra > Add SSL certificate - Contextual help missing in Add Zone, although not there in the legacy UI either - Scrolling on an autogenerated options, it scrolls back to the top automatically - Missing capacity fields while creating primary storage - Deleteing all types of Network's tags removes it on the current page but prrsists on refresh (Perhaps just within a project) - Template order column appears if you go back from details view to listview while in a project but disappears on refresh - Template adding setting disappears after refresh for non standard input. Eg: cpu.corespersocket: 4 - Pagination broken on VPN > ACL : `listnetworkacllistsresponse` does not support pagination so broken on primate - Traffic type on the network offerings redirects to offering. Could remove the router link ? - Management server on the host info card is wrong ? - Pagination broken on roles - Broken in the backend Usability : - Show EnableHA as a uservm action only if it is supported. Can perform the listHostHaProvider to check whether the hypervisor is supported - When migrating a vm / systemvm, exclude the current host from the list - In the migrate snapshot to different storage, exclude the current host storage - Default select a zone in deployVM - Is there a need to show state as well as allocated state in list zones ? - Add account on project dashboard - Enter to submit a form - Enter to advance search rather than submit - Keep the current router path while switching projects - Since the get health check results for VR doesn't download, consider changing the icon - No point in having update template permissions if inside project since you can't modify them - Sort the projects in the projects dropdown - Search for IPAddress firewall rule ? - The delete snapshot icons show even while the snapshot is being created (BackingUp state. Copies existing functionality but would be better if this check is present) - Actions for templates / isos show even while they're being uploaded (clicking them tells you that they're not in the right state to perform any action. Copies existing functionality but would be better if this check is present) - While listing domains, on page refresh, it goes back to the root domain (context is lost) - Add loading while fetching tags and annotations - Root Domain shows as '/' in list & detail view infocard - Report bug at the bottom should redirect to bug or just say provide feedback - If dynamic scalling not supported on the hypervisor, don't show it as an action button (systemvms) - Why do IPs always point to the resource ? - Account in user info card doesn't directly go to account but to the account listview ? Mobile View : - Project selector not visible in mobile mode ? - Create zone form is not aligned in mobile view - Header notification should be clearable (obstrucs in mobile view) - Edit setting icon misaligned in mobile (accounts, domain, zones, etc) - Page size changer doesn't show up on mobile mode This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache CloudStack CloudMonkey 6.1.0
+1 (non-binding) I tested a few common and less-common things and found no regressions. Note: I built the binary locally, didn't try the binaries on the Github release page. From: Rohit Yadav Sent: 01 July 2020 06:51 To: dev@cloudstack.apache.org ; us...@cloudstack.apache.org Subject: [VOTE] Release Apache CloudStack CloudMonkey 6.1.0 Hi All, I've created a 6.1.0 release of CloudMonkey, with the following artifacts up for a vote: Git Branch: https://github.com/apache/cloudstack-cloudmonkey/commits/abc31929e74a9f5b07507db203e75393fffc9f3e Commit: abc31929e74a9f5b07507db203e75393fffc9f3e Commits since last release 6.0.0: https://github.com/apache/cloudstack-cloudmonkey/compare/6.0.0...abc31929e74a9f5b07507db203e75393fffc9f3e Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/cloudmonkey-6.1.0 To facilitate voting and testing, the builds are uploaded in this pre-release: https://github.com/apache/cloudstack-cloudmonkey/releases/tag/6.1.0 List of changes: https://github.com/apache/cloudstack-cloudmonkey/blob/master/CHANGES.md PGP release keys (signed using 5ED1E1122DC5E8A4A45112C2484248210EE3D884): https://dist.apache.org/repos/dist/release/cloudstack/KEYS For sanity in tallying the vote, can PMC members please be sure to indicate "(binding)" with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Vote will be open for till the end of the next week (10 July 2020), otherwise, extend until we reach lazy consensus. Thanks. Regards.
[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review
davidjumani edited a comment on issue #528: URL: https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179 Bugs : Fixed in #534 - ~While changing a systemvm service offering, need to fetch system offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to the listServiceOfferings api~ - ~In the event listview, clicking the username redirects to the event not the user~ - ~When editing a role, resource admin is not in the dropdown~ - ~VR router offering link leads to an empty page~ - ~In DeployVM, disk offering search doesn't show 'No records' if none present but keeps the old rows~ - ~In add ACL Rule, the Rule# field should be a number, not text~ - ~No pagination for security groups ingress / egress rules~ Fixed in #540 - ~Contextual help is missing for creating service offerings~ - ~Contextual help missing in Infra > Add SSL certificate~ TO FIX : - Contextual help missing in Add Zone, although not there in the legacy UI either - Scrolling on an autogenerated options, it scrolls back to the top automatically - Missing capacity fields while creating primary storage - Deleting all types of Network's tags removes it on the current page but persists on refresh (Perhaps just within a project) - Template order column appears if you go back from details view to listview while in a project but disappears on refresh - Template adding setting disappears after refresh for non standard input. Eg: cpu.corespersocket: 4 - Traffic type on the network offerings redirects to offering. Could remove the router link ? - Management server on the host info card is wrong ? - Pagination broken on roles - Broken in the backend - Pagination broken on VPN > ACL : `listnetworkacllistsresponse` does not support pagination so broken on primate Usability : - Show EnableHA as a uservm action only if it is supported. Can perform the listHostHaProvider to check whether the hypervisor is supported - When migrating a vm / systemvm, exclude the current host from the list - In the migrate snapshot to different storage, exclude the current host storage - Default select a zone in deployVM - Is there a need to show state as well as allocated state in list zones ? - Add account on project dashboard - Enter to submit a form - Enter to advance search rather than submit - Keep the current router path while switching projects - Since the get health check results for VR doesn't download, consider changing the icon - No point in having update template permissions if inside project since you can't modify them - Sort the projects in the projects dropdown - Search for IPAddress firewall rule ? - The delete snapshot icons show even while the snapshot is being created (BackingUp state. Copies existing functionality but would be better if this check is present) - Actions for templates / isos show even while they're being uploaded (clicking them tells you that they're not in the right state to perform any action. Copies existing functionality but would be better if this check is present) - While listing domains, on page refresh, it goes back to the root domain (context is lost) - Add loading while fetching tags and annotations - Root Domain shows as '/' in list & detail view infocard - Report bug at the bottom should redirect to bug or just say provide feedback - If dynamic scalling not supported on the hypervisor, don't show it as an action button (systemvms) - Why do IPs always point to the resource ? - Account in user info card doesn't directly go to account but to the account listview ? Mobile View : - Project selector not visible in mobile mode ? - Create zone form is not aligned in mobile view - Header notification should be clearable (obstrucs in mobile view) - Edit setting icon misaligned in mobile (accounts, domain, zones, etc) - Page size changer doesn't show up on mobile mode This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #436: feature: template ovf properties
rhtyd merged pull request #436: URL: https://github.com/apache/cloudstack-primate/pull/436 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #527: Enable searching for templates/iso while vm deployment
rhtyd commented on pull request #527: URL: https://github.com/apache/cloudstack-primate/pull/527#issuecomment-658650838 @davidjumani can you take over and help fix this, if necessary create a new PR based on this. This is a blocker if user is not able to find/select their own templates using the tabs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #541: Fixing user bug
rhtyd merged pull request #541: URL: https://github.com/apache/cloudstack-primate/pull/541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-658656367 @utchoang can you test all views you've changed, review and add missing labels for en.json. I've seen many obvious issues where instead of translation the label is seen. For example in the footer of a table it says 'label.of' instead of `of`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #531: Add missing internationlization to search and pagination
rhtyd merged pull request #531: URL: https://github.com/apache/cloudstack-primate/pull/531 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-658657237 @utchoang can you merge latest master and fix conflicts as well, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #540: Contextual info for Service offering forms and upload custom ssl certs
rhtyd commented on pull request #540: URL: https://github.com/apache/cloudstack-primate/pull/540#issuecomment-658657694 @Pearl1594 is this ready for review/merging? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #540: Contextual info for Service offering forms and upload custom ssl certs
Pearl1594 commented on pull request #540: URL: https://github.com/apache/cloudstack-primate/pull/540#issuecomment-658658141 Yes @rhtyd This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #540: Contextual info for Service offering forms and upload custom ssl certs
rhtyd merged pull request #540: URL: https://github.com/apache/cloudstack-primate/pull/540 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #540: Contextual info for Service offering forms and upload custom ssl certs
rhtyd commented on pull request #540: URL: https://github.com/apache/cloudstack-primate/pull/540#issuecomment-658672914 LGTM, @Pearl1594 if you do work on such PRs, prioritise forms/components that are User, DomainAdmin facing than only Admin facing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #520: [BUG] DeployVM Wizard does not properly search for templates
rhtyd commented on issue #520: URL: https://github.com/apache/cloudstack-primate/issues/520#issuecomment-658680813 @davidjumani please address this issue on priority as it's blocking general usability, in addition: - As a user I should be able to search and select template based on the 4 filters (tabs) - Unless I override the root disk option, it should not force or set the rootdisk value (it should also change if I change the template, or reset if I select an ISO) - The rootdisk option shouldn't be passed via API if the override is/was not selected, also the value must be a whole number (than floating point). By default in VMware where I tested this, it is breaking VM deployment using Primate. I see there is a PR but may not address all the issues in which case you may take that may as reference or cherry-pick commit and send a new PR. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #542: Fixing rootdisk size override
davidjumani opened a new pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542 Fixes #520: - The rootdisk option shouldn't be passed via API if the override is/was not selected, also the value must be a whole number (than floating point). By default in VMware where I tested this, it is breaking VM deployment using Primate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #542: Fixing rootdisk size override
davidjumani commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658689351 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #542: Fixing rootdisk size override
blueorangutan commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658689759 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #542: Fixing rootdisk size override
blueorangutan commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658693558 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/542 (JID-2342) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #542: Fixing rootdisk size override
davidjumani commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658725579 Tested and working This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on pull request #542: Fixing rootdisk size override
davidjumani edited a comment on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658725579 @rhtyd Tested and working This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani removed a comment on pull request #542: Fixing rootdisk size override
davidjumani removed a comment on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658725579 @rhtyd Tested and working This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #542: Fixing rootdisk size override
davidjumani commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658728427 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #542: Fixing rootdisk size override
blueorangutan commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658728735 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #543: Fix template search
davidjumani opened a new pull request #543: URL: https://github.com/apache/cloudstack-primate/pull/543 Fixes #520 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #543: Fix template search
davidjumani commented on pull request #543: URL: https://github.com/apache/cloudstack-primate/pull/543#issuecomment-658752922 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #543: Fix template search
davidjumani commented on pull request #543: URL: https://github.com/apache/cloudstack-primate/pull/543#issuecomment-658753040 @rhtyd @ravening Please reveiw This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #543: Fix template search
davidjumani commented on a change in pull request #543:
URL: https://github.com/apache/cloudstack-primate/pull/543#discussion_r455034076
##
File path: src/views/compute/wizard/TemplateIsoSelection.vue
##
@@ -232,6 +236,60 @@ export default {
},
changeFilterType (value) {
this.filterType = value
+},
+getTemplatesByKeyword (keyword) {
+ let apiCommand = ''
+ let apiCommandResponse = ''
+ this.filteredItems = []
+ const promises = []
+ const templates = []
+ const params = {}
+ const templateFilter = [
+'featured',
+'community',
+'selfexecutable',
+'sharedexecutable'
+ ]
+ // Fetch templates or isos depending on active tab
+ params.zoneid = _.get(this.zone, 'id')
+ params.keyword = keyword
+ params.showunique = true
+ if (this.inputDecorator === 'templateid') {
+apiCommand = 'listTemplates'
+apiCommandResponse = 'listtemplatesresponse.template'
+ } else {
+apiCommand = 'listIsos'
+apiCommandResponse = 'listisosresponse.iso'
+params.bootable = 'true'
+ }
+ this.isLoading = true
+ // Fetch templates/isos for all filters
+ templateFilter.forEach(filter => {
+params.templatefilter = filter
+promises.push(this.fetchTemplatesIsos(apiCommand, keyword, params))
+ })
+
+ Promise.all(promises).then(response => {
+response.forEach((resItem) => {
+ const concatTemplates = _.concat(templates, _.get(resItem,
apiCommandResponse, []))
Review comment:
@rhtyd @ravening Keeping it this way to not introduce too many changes,
but since we're getting the API response per filter, we can set the datasource
here itself. Would also need changes in DeployVM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #542: Fixing rootdisk size override
davidjumani commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658755372 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #542: Fixing rootdisk size override
blueorangutan commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658756025 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] svenvogel commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
svenvogel commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-658756961 @rhtyd Additional german is ready. i will send it to @utchoang he can add this. K? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #542: Fixing rootdisk size override
davidjumani commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658759691 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #542: Fixing rootdisk size override
blueorangutan commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658760204 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #543: Fix template search
blueorangutan commented on pull request #543: URL: https://github.com/apache/cloudstack-primate/pull/543#issuecomment-658763235 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/543 (JID-2349) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #542: Fixing rootdisk size override
blueorangutan commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658764912 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/542 (JID-2350) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] svenvogel edited a comment on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
svenvogel edited a comment on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-658756961 @rhtyd Additional german is ready. i will send it to @utchoang he can add this or should @utchoang file a Separate PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #542: Fixing rootdisk size override
davidjumani commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658770208 @rhtyd good to go! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #543: Fix template search
davidjumani commented on a change in pull request #543:
URL: https://github.com/apache/cloudstack-primate/pull/543#discussion_r455058969
##
File path: src/views/compute/wizard/TemplateIsoSelection.vue
##
@@ -232,6 +236,60 @@ export default {
},
changeFilterType (value) {
this.filterType = value
+},
+getTemplatesByKeyword (keyword) {
+ let apiCommand = ''
+ let apiCommandResponse = ''
+ this.filteredItems = []
+ const promises = []
+ const templates = []
+ const params = {}
+ const templateFilter = [
+'featured',
+'community',
+'selfexecutable',
+'sharedexecutable'
+ ]
+ // Fetch templates or isos depending on active tab
+ params.zoneid = _.get(this.zone, 'id')
+ params.keyword = keyword
+ params.showunique = true
+ if (this.inputDecorator === 'templateid') {
+apiCommand = 'listTemplates'
+apiCommandResponse = 'listtemplatesresponse.template'
+ } else {
+apiCommand = 'listIsos'
+apiCommandResponse = 'listisosresponse.iso'
+params.bootable = 'true'
+ }
+ this.isLoading = true
+ // Fetch templates/isos for all filters
+ templateFilter.forEach(filter => {
+params.templatefilter = filter
+promises.push(this.fetchTemplatesIsos(apiCommand, keyword, params))
+ })
+
+ Promise.all(promises).then(response => {
+response.forEach((resItem) => {
+ const concatTemplates = _.concat(templates, _.get(resItem,
apiCommandResponse, []))
Review comment:
Also zoneid doesn't get passed, need to address that too but preferably
in another PR where we move the search functionality to DeployVM like other
view do
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] ravening commented on a change in pull request #543: Fix template search
ravening commented on a change in pull request #543:
URL: https://github.com/apache/cloudstack-primate/pull/543#discussion_r455137119
##
File path: src/views/compute/wizard/TemplateIsoSelection.vue
##
@@ -232,6 +236,60 @@ export default {
},
changeFilterType (value) {
this.filterType = value
+},
+getTemplatesByKeyword (keyword) {
+ let apiCommand = ''
+ let apiCommandResponse = ''
+ this.filteredItems = []
+ const promises = []
+ const templates = []
+ const params = {}
+ const templateFilter = [
+'featured',
+'community',
+'selfexecutable',
+'sharedexecutable'
+ ]
+ // Fetch templates or isos depending on active tab
+ params.zoneid = _.get(this.zone, 'id')
+ params.keyword = keyword
+ params.showunique = true
+ if (this.inputDecorator === 'templateid') {
+apiCommand = 'listTemplates'
+apiCommandResponse = 'listtemplatesresponse.template'
+ } else {
+apiCommand = 'listIsos'
+apiCommandResponse = 'listisosresponse.iso'
+params.bootable = 'true'
+ }
+ this.isLoading = true
+ // Fetch templates/isos for all filters
+ templateFilter.forEach(filter => {
+params.templatefilter = filter
+promises.push(this.fetchTemplatesIsos(apiCommand, keyword, params))
+ })
+
+ Promise.all(promises).then(response => {
+response.forEach((resItem) => {
+ const concatTemplates = _.concat(templates, _.get(resItem,
apiCommandResponse, []))
Review comment:
yeah zoneid is sometimes a crucial parameter. code LGTM apart from the
above mentioned missing stuffs
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-cloudmonkey] weizhouapache opened a new issue #66: Error 432 while list publicipaddresses
weizhouapache opened a new issue #66: URL: https://github.com/apache/cloudstack-cloudmonkey/issues/66 see below ``` (local) 🐵 > list publicipaddresses associatednetworkid=Error 432: The given command:listNetscalerLoadBalancerNetworks does not exist or it is not available for user with id:null ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-cloudmonkey] rhtyd commented on issue #66: Error 432 while list publicipaddresses
rhtyd commented on issue #66: URL: https://github.com/apache/cloudstack-cloudmonkey/issues/66#issuecomment-659158088 Thanks for reporting @weizhouapache can you set debug on and run this. Is this on latest cmk? We probably can get of the heuristic to use any if the related APIs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #542: Fixing rootdisk size override
rhtyd merged pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #520: [BUG] DeployVM Wizard does not properly search for templates
rhtyd closed issue #520: URL: https://github.com/apache/cloudstack-primate/issues/520 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659163484 @svenvogel please send a separate PR, you may want to include new keys introduced in this PR @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
blueorangutan commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659163647 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659163835 Can you review and test @davidjumani @Pearl1594 thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
blueorangutan commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659166140 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/481 (JID-2367) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
Pearl1594 commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659171852 On checking for translations - few success/loading/catch and error messages need translation in DeployVM.vue and IngressEgressRuleConfigure.vue - others pretty much seem to be handled. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
davidjumani commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659172379 @utchoang Could you check the english strings in the following files : src/views/iam/AddAccount.vue : Cancel OK src/views/iam/AddLdapAccount.vue : Conflict src/views/iam/ConfigureSamlSsoAuth.vue : Close This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 edited a comment on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
Pearl1594 edited a comment on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659171852 On checking for translations - few success/loading/catch and error messages need translation in DeployVM.vue and IngressEgressRuleConfigure.vue - others pretty much seem to be handled. DedicateData.vue - uses labels defined locally eg: dedicatedButtonLabel: 'Dedicate', and not translations This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 edited a comment on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
Pearl1594 edited a comment on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659171852 On checking for translations - few success/loading/catch and error messages need translation in DeployVM.vue and IngressEgressRuleConfigure.vue - others pretty much seem to be handled. DedicateData.vue - uses labels defined locally eg: dedicatedButtonLabel: 'Dedicate', and not translations Some Column titles in IngressEgressRuleConfigure.vue - eg: ICMP type, ICMP Code .. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review
davidjumani edited a comment on issue #528: URL: https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179 Bugs : Fixed in #534 - ~While changing a systemvm service offering, need to fetch system offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to the listServiceOfferings api~ - ~In the event listview, clicking the username redirects to the event not the user~ - ~When editing a role, resource admin is not in the dropdown~ - ~VR router offering link leads to an empty page~ - ~In DeployVM, disk offering search doesn't show 'No records' if none present but keeps the old rows~ - ~In add ACL Rule, the Rule# field should be a number, not text~ - ~No pagination for security groups ingress / egress rules~ Fixed in #540 - ~Contextual help is missing for creating service offerings~ - ~Contextual help missing in Infra > Add SSL certificate~ TO FIX : - Contextual help is missing for creating service offerings - Contextual help missing in Infra > Add SSL certificate - Contextual help missing in Add Zone, although not there in the legacy UI either - Scrolling on an autogenerated options, it scrolls back to the top automatically - Missing capacity fields while creating primary storage - Deleteing all types of Network's tags removes it on the current page but prrsists on refresh (Perhaps just within a project) - Template order column appears if you go back from details view to listview while in a project but disappears on refresh - Template adding setting disappears after refresh for non standard input. Eg: cpu.corespersocket: 4 - Pagination broken on VPN > ACL : `listnetworkacllistsresponse` does not support pagination so broken on primate - Traffic type on the network offerings redirects to offering. Could remove the router link ? - Management server on the host info card is wrong ? - Pagination broken on roles - Broken in the backend - Save settings in templates, should save all, not just the one added - Templates: On refresh, lists only first tag but on adding a tag, shows all - Add issystem=true systemvmtype=domainrouter to listserviceofferings called within VR - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? - Search by tag doesn't work for vm snapshots - On first time listing isos, the account column is missing - Call ListVMs rather than metrics since it doesn't respect hostid param Usability : - Show EnableHA as a uservm action only if it is supported. Can perform the listHostHaProvider to check whether the hypervisor is supported - When migrating a vm / systemvm, exclude the current host from the list - In the migrate snapshot to different storage, exclude the current host storage - Default select a zone in deployVM - Is there a need to show state as well as allocated state in list zones ? - Add account on project dashboard - Enter to submit a form - Enter to advance search rather than submit - Keep the current router path while switching projects - Since the get health check results for VR doesn't download, consider changing the icon - No point in having update template permissions if inside project since you can't modify them - Sort the projects in the projects dropdown - Search for IPAddress firewall rule ? - The delete snapshot icons show even while the snapshot is being created (BackingUp state. Copies existing functionality but would be better if this check is present) - Actions for templates / isos show even while they're being uploaded (clicking them tells you that they're not in the right state to perform any action. Copies existing functionality but would be better if this check is present) - While listing domains, on page refresh, it goes back to the root domain (context is lost) - Add loading while fetching tags and annotations - Root Domain shows as '/' in list & detail view infocard - Report bug at the bottom should redirect to bug or just say provide feedback - If dynamic scalling not supported on the hypervisor, don't show it as an action button (systemvms) - Why do IPs always point to the resource ? - Account in user info card doesn't directly go to account but to the account listview ? - LB Rule is just plain json in ilb - Refresh after successfully uploading an iso - Make external Id required for backup offerings - Assign to backup shows even while vm is starting in legacy UI as opposed to while running in primate Mobile View : - Project selector not visible in mobile mode ? - Create zone form is not aligned in mobile view - Header notification should be clearable (obstrucs in mobile view) - Edit setting icon misaligned in mobile (accounts, domain, zones, etc) - Page size changer doesn't show up on mobile mode This
[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review
davidjumani edited a comment on issue #528: URL: https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179 Bugs : Fixed in #534 - ~While changing a systemvm service offering, need to fetch system offerings by passing `issystem=true`, `virtualmachineid` and `systemvmtype` to the listServiceOfferings api~ - ~In the event listview, clicking the username redirects to the event not the user~ - ~When editing a role, resource admin is not in the dropdown~ - ~VR router offering link leads to an empty page~ - ~In DeployVM, disk offering search doesn't show 'No records' if none present but keeps the old rows~ - ~In add ACL Rule, the Rule# field should be a number, not text~ - ~No pagination for security groups ingress / egress rules~ Fixed in #540 - ~Contextual help is missing for creating service offerings~ - ~Contextual help missing in Infra > Add SSL certificate~ TO FIX : - Contextual help missing in Add Zone, although not there in the legacy UI either - Scrolling on an autogenerated options, it scrolls back to the top automatically - Missing capacity fields while creating primary storage - Deleteing all types of Network's tags removes it on the current page but prrsists on refresh (Perhaps just within a project) - Template order column appears if you go back from details view to listview while in a project but disappears on refresh - Template adding setting disappears after refresh for non standard input. Eg: cpu.corespersocket: 4 - Pagination broken on VPN > ACL : `listnetworkacllistsresponse` does not support pagination so broken on primate - Traffic type on the network offerings redirects to offering. Could remove the router link ? - Management server on the host info card is wrong ? - Pagination broken on roles - Broken in the backend - Save settings in templates, should save all, not just the one added - Templates: On refresh, lists only first tag but on adding a tag, shows all - Add issystem=true systemvmtype=domainrouter to listserviceofferings called within VR - Tags won't go unless deleted twice [vpc, ipaddress, snapshots]?? - Search by tag doesn't work for vm snapshots - On first time listing isos, the account column is missing - Call ListVMs rather than metrics since it doesn't respect hostid param Usability : - Show EnableHA as a uservm action only if it is supported. Can perform the listHostHaProvider to check whether the hypervisor is supported - When migrating a vm / systemvm, exclude the current host from the list - In the migrate snapshot to different storage, exclude the current host storage - Default select a zone in deployVM - Is there a need to show state as well as allocated state in list zones ? - Add account on project dashboard - Enter to submit a form - Enter to advance search rather than submit - Keep the current router path while switching projects - Since the get health check results for VR doesn't download, consider changing the icon - No point in having update template permissions if inside project since you can't modify them - Sort the projects in the projects dropdown - Search for IPAddress firewall rule ? - The delete snapshot icons show even while the snapshot is being created (BackingUp state. Copies existing functionality but would be better if this check is present) - Actions for templates / isos show even while they're being uploaded (clicking them tells you that they're not in the right state to perform any action. Copies existing functionality but would be better if this check is present) - While listing domains, on page refresh, it goes back to the root domain (context is lost) - Add loading while fetching tags and annotations - Root Domain shows as '/' in list & detail view infocard - Report bug at the bottom should redirect to bug or just say provide feedback - If dynamic scalling not supported on the hypervisor, don't show it as an action button (systemvms) - Why do IPs always point to the resource ? - Account in user info card doesn't directly go to account but to the account listview ? - LB Rule is just plain json in ilb - Refresh after successfully uploading an iso - Make external Id required for backup offerings - Assign to backup shows even while vm is starting in legacy UI as opposed to while running in primate Mobile View : - Project selector not visible in mobile mode ? - Create zone form is not aligned in mobile view - Header notification should be clearable (obstrucs in mobile view) - Edit setting icon misaligned in mobile (accounts, domain, zones, etc) - Page size changer doesn't show up on mobile mode This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab
