[GitHub] [cloudstack-primate] blueorangutan commented on pull request #540: Contextual info for Service offering forms and upload custom ssl certs
blueorangutan commented on pull request #540: URL: https://github.com/apache/cloudstack-primate/pull/540#issuecomment-658009104 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/540 (JID-2307) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-658033470 @utchoang can you address the review comments, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
davidjumani edited a comment on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-657968325 Missing the following labels in en.json : - label.in.progess - message.confirm.configure.ovs - label.configure.ovs - message.pod.dedicated - message.dedicate.pod - message.dedicate.host - message.error.input.name - label.manage.secondary.ipaddress @utchoang can you check if the keys are named differently in en.json, for example `message.dedicating.host` instead of `message.dedicate.host` etc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] ravening commented on a change in pull request #527: Enable searching for templates/iso while vm deployment
ravening commented on a change in pull request #527:
URL: https://github.com/apache/cloudstack-primate/pull/527#discussion_r454262974
##
File path: src/views/compute/wizard/TemplateIsoSelection.vue
##
@@ -232,6 +235,57 @@ export default {
},
changeFilterType (value) {
this.filterType = value
+},
+getTemplatesByKeyword (keyword) {
+ let apiCommand = ''
+ let apiCommandResponse = ''
+ this.filteredItems = []
+ const promises = []
+ const templates = []
+ const params = {}
+ const templateFilter = [
+'featured',
+'community',
+'selfexecutable',
+'sharedexecutable'
+ ]
+ // Fetch templates or isos depending on active tab
+ params.zoneid = _.get(this.zone, 'id')
+ params.keyword = keyword
+ if (this.inputDecorator === 'templateid') {
+apiCommand = 'listTemplates'
+apiCommandResponse = 'listtemplatesresponse.template'
+ } else {
+apiCommand = 'listIsos'
+apiCommandResponse = 'listisosresponse.iso'
+params.bootable = 'true'
+ }
+ // Fetch templates/isos for all filters
+ templateFilter.forEach(filter => {
+params.templatefilter = filter
+promises.push(this.fetchTemplatesIsos(apiCommand, keyword, params))
+ })
+
+ Promise.all(promises).then(response => {
+response.forEach((resItem) => {
+ const concatTemplates = _.concat(templates, _.get(resItem,
apiCommandResponse, []))
Review comment:
if `_.concat(templates, _.get(resItem, apiCommandResponse, []))` is not
needed then how can I extract response from `resItem`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #326: Form to Migrate data between Image stores
Pearl1594 commented on pull request #326: URL: https://github.com/apache/cloudstack-primate/pull/326#issuecomment-658124291 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #326: Form to Migrate data between Image stores
blueorangutan commented on pull request #326: URL: https://github.com/apache/cloudstack-primate/pull/326#issuecomment-658124590 @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #326: Form to Migrate data between Image stores
blueorangutan commented on pull request #326: URL: https://github.com/apache/cloudstack-primate/pull/326#issuecomment-658127812 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/326 (JID-2314) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
utchoang commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-658523587 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
blueorangutan commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-658523942 @utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
blueorangutan commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-658526122 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/481 (JID-2331) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #541: Fixing user bug
davidjumani opened a new pull request #541: URL: https://github.com/apache/cloudstack-primate/pull/541 Fixes redirect while selecting a user This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #541: Fixing user bug
davidjumani commented on pull request #541: URL: https://github.com/apache/cloudstack-primate/pull/541#issuecomment-658542019 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #541: Fixing user bug
blueorangutan commented on pull request #541: URL: https://github.com/apache/cloudstack-primate/pull/541#issuecomment-658542249 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #541: Fixing user bug
blueorangutan commented on pull request #541: URL: https://github.com/apache/cloudstack-primate/pull/541#issuecomment-658544540 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/541 (JID-2333) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #541: Fixing user bug
davidjumani commented on pull request #541: URL: https://github.com/apache/cloudstack-primate/pull/541#issuecomment-658547105 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #541: Fixing user bug
blueorangutan commented on pull request #541: URL: https://github.com/apache/cloudstack-primate/pull/541#issuecomment-658547403 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #541: Fixing user bug
blueorangutan commented on pull request #541: URL: https://github.com/apache/cloudstack-primate/pull/541#issuecomment-658549954 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/541 (JID-2335) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #541: Fixing user bug
davidjumani commented on pull request #541: URL: https://github.com/apache/cloudstack-primate/pull/541#issuecomment-658550460 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #541: Fixing user bug
blueorangutan commented on pull request #541: URL: https://github.com/apache/cloudstack-primate/pull/541#issuecomment-658550650 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #541: Fixing user bug
blueorangutan commented on pull request #541: URL: https://github.com/apache/cloudstack-primate/pull/541#issuecomment-658553069 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/541 (JID-2336) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #541: Fixing user bug
rhtyd commented on a change in pull request #541:
URL: https://github.com/apache/cloudstack-primate/pull/541#discussion_r454802473
##
File path: src/components/view/ListView.vue
##
@@ -82,7 +82,8 @@
{{ text
}}
- {{ text }}
+ {{ text
}}
+ {{ text }}
Review comment:
We'll have to test various views because of this, cannot merge without
testing all list views (or search for views with columns having 'username')
@davidjumani
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #541: Fixing user bug
davidjumani commented on a change in pull request #541:
URL: https://github.com/apache/cloudstack-primate/pull/541#discussion_r454802658
##
File path: src/components/view/ListView.vue
##
@@ -82,7 +82,8 @@
{{ text
}}
- {{ text }}
+ {{ text
}}
+ {{ text }}
Review comment:
Tested, since only vpnuser, accountuser and events use username
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #541: Fixing user bug
davidjumani commented on pull request #541: URL: https://github.com/apache/cloudstack-primate/pull/541#issuecomment-658564774 @Pearl1594 Could you review ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
