[GitHub] [cloudstack-primate] shwstppr commented on pull request #217: Identify and access - Add user - duplicated password field

2020-06-15 Thread GitBox


shwstppr commented on pull request #217:
URL: 
https://github.com/apache/cloudstack-primate/pull/217#issuecomment-643947379


   @rhtyd this can be reviewed and merged. We will need a custom form for Add 
Account but this will be useful for Add User



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #170: Modified forms when SAML is enabled

2020-06-15 Thread GitBox


shwstppr commented on a change in pull request #170:
URL: https://github.com/apache/cloudstack-primate/pull/170#discussion_r439972398



##
File path: src/views/iam/AddAccountForm.vue
##
@@ -0,0 +1,270 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+  
+
+  
+
+  
+  
+
+  
+  
+
+  
+  
+
+  
+  
+
+  
+  
+
+  
+  
+
+  
+{{ domain.name }}
+  
+
+  
+  
+
+  
+  
+

Review comment:
   @Pearl1594 wrong message here





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani opened a new pull request #419: Adding custom change affinity view

2020-06-15 Thread GitBox


davidjumani opened a new pull request #419:
URL: https://github.com/apache/cloudstack-primate/pull/419


   Fixes #386 
   
   ![Screenshot from 2020-06-15 
12-58-26](https://user-images.githubusercontent.com/8244774/84629462-f21f7080-af07-11ea-874c-25c3470752d2.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] svenvogel commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


svenvogel commented on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643954696


   > No, I think wr don't need to configure fonts, sizes etc. The feature of 
providing some way to customise the theme to the end user by means of some 
config file is enough.
   @utchoang so does it work in the built dist and changing just the 
config.json?
   
   @rhtyd we need to change the size of the logo too. We need to find a good 
way to use this with config file? I would prefer to add something or how we 
could change this by an reproducable way? cc @utchoang



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] Pearl1594 commented on a change in pull request #170: Modified forms when SAML is enabled

2020-06-15 Thread GitBox


Pearl1594 commented on a change in pull request #170:
URL: https://github.com/apache/cloudstack-primate/pull/170#discussion_r439981986



##
File path: src/views/iam/AddAccountForm.vue
##
@@ -0,0 +1,270 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+  
+
+  
+
+  
+  
+
+  
+  
+
+  
+  
+
+  
+  
+
+  
+  
+
+  
+  
+
+  
+{{ domain.name }}
+  
+
+  
+  
+
+  
+  
+

Review comment:
   Addressed it @shwstppr 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #419: Adding custom change affinity view

2020-06-15 Thread GitBox


rhtyd commented on pull request #419:
URL: 
https://github.com/apache/cloudstack-primate/pull/419#issuecomment-643959433


   @davidjumani can you check old UI, we probably want pagination and search 
support (the list API could in fact return a lot of rules in very large env; if 
the count is say less than 10 then we can hide the pagination component).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


utchoang commented on a change in pull request #372:
URL: https://github.com/apache/cloudstack-primate/pull/372#discussion_r439989945



##
File path: public/config.json
##
@@ -0,0 +1,15 @@
+{
+  "theme": {
+"@primary-color": "#1890ff",

Review comment:
   @rhtyd I checked that there are some attributes like @ link-color that 
don't seem to be used in the project so I deleted them. So you will notice that 
there are some incomplete attributes.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


rhtyd commented on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643961120


   @svenvogel which logo - the login logo, or the left-top side logo that shows 
after we login? Or any other? I think instead of config file, we can have a 
folder to put logos (svg/png, preferably svgs) and customisation can be done by 
replacing the logo file than change in config.json file, what do you think?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


rhtyd commented on a change in pull request #372:
URL: https://github.com/apache/cloudstack-primate/pull/372#discussion_r439987575



##
File path: public/config.json
##
@@ -0,0 +1,15 @@
+{
+  "theme": {
+"@primary-color": "#1890ff",

Review comment:
   @utchoang are these the complete list of variables, this has more 
variables - 
https://www.antdv.com/docs/vue/customize-theme/#Ant-Design-Vue-Less-variables ? 
Thanks (excluding fonts is okay I think). cc @svenvogel ?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] ravening opened a new issue #420: [BUG] Links not found

2020-06-15 Thread GitBox


ravening opened a new issue #420:
URL: https://github.com/apache/cloudstack-primate/issues/420


   **Describe the bug**
   All the links under 
https://github.com/apache/cloudstack-primate#primate-development are not 
accessible
   
   **To Reproduce**
   Steps to reproduce the behavior:
   1. Click on any of the link under the section 
https://github.com/apache/cloudstack-primate#primate-development
   
   
   **Expected behavior**
   A nice documentation :)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani opened a new pull request #421: Fixing enable/disable HA, OOBM across zone, cluster, host

2020-06-15 Thread GitBox


davidjumani opened a new pull request #421:
URL: https://github.com/apache/cloudstack-primate/pull/421


   Fixes #394 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


rhtyd commented on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643969510


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


blueorangutan commented on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643970133


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep 
you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #420: [BUG] Links not found

2020-06-15 Thread GitBox


rhtyd commented on issue #420:
URL: 
https://github.com/apache/cloudstack-primate/issues/420#issuecomment-643971813


   @ravening intentional, need to update the docs; the best place to start is 
vuejs v2 guide.
   They are here, I'll update links
   https://github.com/apache/cloudstack-primate/tree/master/docs



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


rhtyd commented on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643972658


   @utchoang can you move the following keys to the config.json from the 
`src/config/settings.js`; which would allow the admin configure the API request 
path, the doc base URL path and the app/tab title prefix:
   ```
 apiBase: '/client/api',
 docBase: 'http://docs.cloudstack.apache.org/en/latest',
 appTitle: 'CloudStack',
   
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


blueorangutan commented on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643974160


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/372 (JID-2005)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


utchoang commented on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643981360


   @rhtyd cc @svenvogel 
   About changing the logo size. I think the @Seven ideas would be good because 
the end-user only needs to change the logo size in the config file instead of 
using the third software to adjust it. I will try to find a way to interfere 
with the Ant Design style and I hope it works.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang edited a comment on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


utchoang edited a comment on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643981360


   @rhtyd cc @svenvogel 
   About changing the logo size. I think the @svenvogel  ideas would be good 
because the end-user only needs to change the logo size in the config file 
instead of using the third software to adjust it. I will try to find a way to 
interfere with the Ant Design style and I hope it works.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


rhtyd commented on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643982598


   @utchoang do you know which logo is @svenvogel talking about the logo in 
favicon, or login screen, or post-login (on left-top side) or anything else?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd edited a comment on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


rhtyd edited a comment on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643982598


   @utchoang do you know which logo is @svenvogel talking about the logo in 
favicon, or login screen, or post-login (on left-top side) or anything else? An 
admin would probably want to change the logos in all these places (that's why I 
thought it could be easier if we allow them to simply replace the files at 
known paths under the `dist`/install folder.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


utchoang commented on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643985051


   @rhtyd I think all logo (login screen, left-top side,...)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd closed issue #420: [BUG] Links not found

2020-06-15 Thread GitBox


rhtyd closed issue #420:
URL: https://github.com/apache/cloudstack-primate/issues/420


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


utchoang commented on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643986249


   @rhtyd He means when we wanted to change another logo, maybe its size would 
not be right, so just adjust it using the config file instead of the third 
software.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang edited a comment on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


utchoang edited a comment on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643986249


   @rhtyd cc @svenvogel  He means when we wanted to change another logo, maybe 
its size would not be right, so just adjust it using the config file instead of 
the third software.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] shwstppr commented on pull request #170: Modified forms when SAML is enabled

2020-06-15 Thread GitBox


shwstppr commented on pull request #170:
URL: 
https://github.com/apache/cloudstack-primate/pull/170#issuecomment-643988197


   @Pearl1594 Made some changes to fix translations and layout. Hopefully I've 
not broken anything
   ![Screenshot from 2020-06-15 
14-06-13](https://user-images.githubusercontent.com/153340/84635914-82ae7e80-af11-11ea-8e17-d7de5462c04f.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] shwstppr commented on pull request #257: view: add custom new account form

2020-06-15 Thread GitBox


shwstppr commented on pull request #257:
URL: 
https://github.com/apache/cloudstack-primate/pull/257#issuecomment-643988557


   Closing in favour of #170 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] shwstppr closed pull request #257: view: add custom new account form

2020-06-15 Thread GitBox


shwstppr closed pull request #257:
URL: https://github.com/apache/cloudstack-primate/pull/257


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


rhtyd commented on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643989719


   @utchoang okay, I guess first thing then - move all the banner and logo svgs 
to public/assets (I think you've moved logo, maybe even the error/403/404/500 
pngs). I think the size is bound by the navigation bar width - that would be a 
limitation. Generally, like legacy UI, all images have a fixed sized - 
otherwise it will affect how the UI looks (it will cause other components/parts 
to spill out).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #170: Modified forms when SAML is enabled

2020-06-15 Thread GitBox


rhtyd commented on pull request #170:
URL: 
https://github.com/apache/cloudstack-primate/pull/170#issuecomment-643990373


   Thanks @shwstppr 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani closed pull request #421: DO NOT MERGE : Fixing enable/disable HA, OOBM across zone, cluster, host

2020-06-15 Thread GitBox


davidjumani closed pull request #421:
URL: https://github.com/apache/cloudstack-primate/pull/421


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


rhtyd commented on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643999170


   Note for myself - we'll need to check and get some of the config from legacy 
UI such as keyboard options: 
https://github.com/apache/cloudstack/pull/3258/files



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd opened a new issue #422: UI customisation from legacy UI

2020-06-15 Thread GitBox


rhtyd opened a new issue #422:
URL: https://github.com/apache/cloudstack-primate/issues/422


   See https://github.com/apache/cloudstack/pull/3258/files



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang opened a new pull request #423: [FIX] Acquire public IP address does not give IP selection option

2020-06-15 Thread GitBox


utchoang opened a new pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423


   Open for https://github.com/apache/cloudstack-primate/issues/392
   @rhtyd cc @svenvogel I've completed this task. Please review and let me know 
any comments.
   
![image](https://user-images.githubusercontent.com/13766648/84642361-8d274300-af26-11ea-9b13-654143152cec.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #374: [FEATURE] a query component for text driven questions to a user

2020-06-15 Thread GitBox


rhtyd commented on issue #374:
URL: 
https://github.com/apache/cloudstack-primate/issues/374#issuecomment-644023081


   With @shwstppr 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd removed a comment on issue #362: [FEATURE] VR health checks feature

2020-06-15 Thread GitBox


rhtyd removed a comment on issue #362:
URL: 
https://github.com/apache/cloudstack-primate/issues/362#issuecomment-643893549


   With @davidjumani 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #362: [FEATURE] VR health checks feature

2020-06-15 Thread GitBox


rhtyd commented on issue #362:
URL: 
https://github.com/apache/cloudstack-primate/issues/362#issuecomment-644024664


   With @shwstppr 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #361: [FEATURE] Fresh install onboarding

2020-06-15 Thread GitBox


rhtyd commented on issue #361:
URL: 
https://github.com/apache/cloudstack-primate/issues/361#issuecomment-644025145


   With @rhtyd 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[DISCUSS] Change UI images in CloudStack Docs for 4.15

2020-06-15 Thread Rohit Yadav
All,

The images of CloudStack (current/legacy) UI in our documentation are old [1] 
(some of the screenshots are from UI before the current UI). In the voting 
thread [2] where we agreed to have Primate succeed the current CloudStack UI 
and proposed GA release with 4.15, we didn't discuss when and how the 
documentation should be updated.

Let's discuss - should we replace images with screenshots from Primate in the 
4.15 docs/release, or do this when we remove the current/legacy UI in the 
next-to-next major release (4.16)?
Thanks.

[1] 
https://github.com/apache/cloudstack-documentation/tree/master/source/_static/images
[2] https://markmail.org/message/tblrbrtew6cvrusr


Regards.

rohit.ya...@shapeblue.comĀ 
www.shapeblue.com
3 London Bridge Street,  3rd floor, News Building, London  SE1 9SGUK
@shapeblue
  
 



[GitHub] [cloudstack-primate] davidjumani opened a new pull request #424: Adding rolling maintenance

2020-06-15 Thread GitBox


davidjumani opened a new pull request #424:
URL: https://github.com/apache/cloudstack-primate/pull/424


   Fixes #363 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani opened a new pull request #425: Fix unmanage / manager cluster

2020-06-15 Thread GitBox


davidjumani opened a new pull request #425:
URL: https://github.com/apache/cloudstack-primate/pull/425


   Fixes #396 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] svenvogel commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


svenvogel commented on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-644149875


   @rhtyd @utchoang yes maybe the layout will give us only a fit size of the 
icon/logs and i agree with a copy and paste of the logo in a folder and 
overwrite them into. the cool thing from our templater was in the old UI there 
was a possibility to overwrite things with a "config" file if anyone want 
change different things in the UI before we build them. we dont need to hack in 
the files directly e.g. he want to change the size from logo (i know this will 
maybe no fit into the layout/design) or change other things.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


rhtyd commented on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-644562510


   @utchoang let me know when you're done with any other changes, I'll help 
review and merge this



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox


utchoang commented on pull request #372:
URL: 
https://github.com/apache/cloudstack-primate/pull/372#issuecomment-644563490


   @rhtyd I will notify you when it is completed with the new user document.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org