[GitHub] [cloudstack-documentation] andrijapanicsb merged pull request #84: VM ingestion
andrijapanicsb merged pull request #84: URL: https://github.com/apache/cloudstack-documentation/pull/84 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb commented on pull request #84: VM ingestion
andrijapanicsb commented on pull request #84: URL: https://github.com/apache/cloudstack-documentation/pull/84#issuecomment-633460438 Merging as it is, looks LGTM in general, but we can always improve it if needed. Required for 4.14 to go out. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb merged pull request #99: Update Quick/Regular Installation Guide for 4.14
andrijapanicsb merged pull request #99: URL: https://github.com/apache/cloudstack-documentation/pull/99 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [ANNOUNCE] 4.14 Freeze date
Hi all, code is free/open for merges again. Regards, Andrija On Sat, 14 Mar 2020 at 10:12, Daan Hoogland wrote: > H all, I've been working with Andrija and all of you to get as much I'm as > possible. We are now closed for features. Note however there are three > issues open for 4.13 which are blocking 4.14 as well. Please ask help in > discussing and finding fixes for those so we can release as soon as > possible. > > On Fri, 13 Mar 2020, 23:32 Andrija Panic, wrote: > > > Hi all, > > > > as already discussed, please find a general code freeze taking place in > 30 > > minutes (23.59h CET). > > > > Thanks, > > Andrija > > > > On Fri, 6 Mar 2020, 20:03 Andrija Panic, > wrote: > > > > > I do like Friday the 13th - means nobody would commit anything 😀 > > > > > > On Fri, 6 Mar 2020 at 19:29, Daan Hoogland > > > wrote: > > > > > >> And leave master open for disaster all of Friday the 13th? You hero! > 😉 > > >> > > >> On Fri, 6 Mar 2020, 18:37 Giles Sirett, > > >> wrote: > > >> > > >>> In case there is anybody superstitious, could we make it Saturday > 14th > > >>> at 00:01 ? 😊 > > >>> > > >>> > > >>> Kind regards > > >>> Giles > > >>> > > >>> giles.sir...@shapeblue.com > > >>> www.shapeblue.com > > >>> 3 London Bridge Street, 3rd floor, News Building, London SE1 9SGUK > > >>> @shapeblue > > >>> > > >>> > > >>> > > >>> > > >>> -Original Message- > > >>> From: Andrija Panic > > >>> Sent: 06 March 2020 13:59 > > >>> To: dev > > >>> Subject: [ANNOUNCE] 4.14 Freeze date > > >>> > > >>> Hi all, > > >>> > > >>> I believe we are nearly there, so I would like to propose/announce a > > >>> master/4.14 code freeze date for a week from now, on Friday the 13th > @ > > >>> 23.59h > > >>> > > >>> After this time, no more features and general fixes will be allowed, > > and > > >>> only critical and blocker issues will be fixed after the freeze. > > >>> > > >>> Please let me know if you have any questions or concerns. > > >>> > > >>> Thank you, > > >>> > > >>> -- > > >>> > > >>> Andrija Panić > > >>> > > >> > > > > > > -- > > > > > > Andrija Panić > > > > > > -- Andrija Panić
[GitHub] [cloudstack-documentation] andrijapanicsb commented on pull request #122: Primate docs with 4.14 release
andrijapanicsb commented on pull request #122: URL: https://github.com/apache/cloudstack-documentation/pull/122#issuecomment-633488091 @rhtyd @PaulAngus I'll need to merge this one as it is - for cutting the 4.14 docs branch, etc. - but we can update this if needed with a new PR against the 4.14 branch and I can easily rebuild the docs This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb commented on pull request #97: [abandoned] api changes 4.14
andrijapanicsb commented on pull request #97: URL: https://github.com/apache/cloudstack-documentation/pull/97#issuecomment-633489894 closing in order to have a single consolidated PR for release notes update This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb closed pull request #97: [abandoned] api changes 4.14
andrijapanicsb closed pull request #97: URL: https://github.com/apache/cloudstack-documentation/pull/97 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [ANNOUNCE] 4.14 Freeze date
Hi, Great! Let's get working on 4.15. >From PCextreme we have a few things coming in: - Redfish HA support: https://github.com/apache/cloudstack/issues/3624 - Python 3 support: https://github.com/apache/cloudstack/issues/3195 And as a community we should probably work on: - Ubuntu 20.04 support (and drop 16.04) - CentOS 8 support Wido On 5/25/20 11:48 AM, Andrija Panic wrote: > Hi all, > > code is free/open for merges again. > > Regards, > Andrija > > On Sat, 14 Mar 2020 at 10:12, Daan Hoogland wrote: > >> H all, I've been working with Andrija and all of you to get as much I'm as >> possible. We are now closed for features. Note however there are three >> issues open for 4.13 which are blocking 4.14 as well. Please ask help in >> discussing and finding fixes for those so we can release as soon as >> possible. >> >> On Fri, 13 Mar 2020, 23:32 Andrija Panic, wrote: >> >>> Hi all, >>> >>> as already discussed, please find a general code freeze taking place in >> 30 >>> minutes (23.59h CET). >>> >>> Thanks, >>> Andrija >>> >>> On Fri, 6 Mar 2020, 20:03 Andrija Panic, >> wrote: >>> I do like Friday the 13th - means nobody would commit anything 😀 On Fri, 6 Mar 2020 at 19:29, Daan Hoogland wrote: > And leave master open for disaster all of Friday the 13th? You hero! >> 😉 > > On Fri, 6 Mar 2020, 18:37 Giles Sirett, > wrote: > >> In case there is anybody superstitious, could we make it Saturday >> 14th >> at 00:01 ? 😊 >> >> >> Kind regards >> Giles >> >> giles.sir...@shapeblue.com >> www.shapeblue.com >> 3 London Bridge Street, 3rd floor, News Building, London SE1 9SGUK >> @shapeblue >> >> >> >> >> -Original Message- >> From: Andrija Panic >> Sent: 06 March 2020 13:59 >> To: dev >> Subject: [ANNOUNCE] 4.14 Freeze date >> >> Hi all, >> >> I believe we are nearly there, so I would like to propose/announce a >> master/4.14 code freeze date for a week from now, on Friday the 13th >> @ >> 23.59h >> >> After this time, no more features and general fixes will be allowed, >>> and >> only critical and blocker issues will be fixed after the freeze. >> >> Please let me know if you have any questions or concerns. >> >> Thank you, >> >> -- >> >> Andrija Panić >> > -- Andrija Panić >>> >> > >
[GitHub] [cloudstack-documentation] ACSGitBot removed a comment on pull request #95: Update 4.14 Release notes
ACSGitBot removed a comment on pull request #95: URL: https://github.com/apache/cloudstack-documentation/pull/95#issuecomment-623410935 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot removed a comment on pull request #95: Update 4.14 Release notes
ACSGitBot removed a comment on pull request #95: URL: https://github.com/apache/cloudstack-documentation/pull/95#issuecomment-616634763 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #95: Update 4.14 Release notes
ACSGitBot commented on pull request #95: URL: https://github.com/apache/cloudstack-documentation/pull/95#issuecomment-633508368 Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb removed a comment on pull request #95: Update 4.14 Release notes
andrijapanicsb removed a comment on pull request #95: URL: https://github.com/apache/cloudstack-documentation/pull/95#issuecomment-623410130 requesting docbuild This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #95: Update 4.14 Release notes
ACSGitBot commented on pull request #95: URL: https://github.com/apache/cloudstack-documentation/pull/95#issuecomment-633509202 Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr95 Build Log Output: No log errors found to report. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] sureshanaparti commented on a change in pull request #353: UI changes for Dynamic roles improvements
sureshanaparti commented on a change in pull request #353: URL: https://github.com/apache/cloudstack-primate/pull/353#discussion_r429892025 ## File path: src/views/iam/ImportRole.vue ## @@ -0,0 +1,267 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + + + + + + Review comment: updated the key to rules.file. @shwstppr have address other existing keys to be aligned to this pattern, may be in separate PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] sureshanaparti commented on a change in pull request #353: UI changes for Dynamic roles improvements
sureshanaparti commented on a change in pull request #353: URL: https://github.com/apache/cloudstack-primate/pull/353#discussion_r429892142 ## File path: src/views/iam/ImportRole.vue ## @@ -0,0 +1,267 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + + + + + + Review comment: > can the key here read rules.file or something? Will be more aligned to other translation keys updated the key to rules.file. @shwstppr have address other existing keys to be aligned to this pattern, may be in separate PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] sureshanaparti commented on a change in pull request #353: UI changes for Dynamic roles improvements
sureshanaparti commented on a change in pull request #353: URL: https://github.com/apache/cloudstack-primate/pull/353#discussion_r429892387 ## File path: src/views/iam/ImportRole.vue ## @@ -0,0 +1,267 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + + + + + + +
[GitHub] [cloudstack-primate] sureshanaparti commented on a change in pull request #353: UI changes for Dynamic roles improvements
sureshanaparti commented on a change in pull request #353: URL: https://github.com/apache/cloudstack-primate/pull/353#discussion_r429892889 ## File path: src/views/iam/ImportRole.vue ## @@ -0,0 +1,267 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + + + + + + + + + + + + Click or drag rule defintions CVS file to import + + + + +
[GitHub] [cloudstack-primate] sureshanaparti commented on a change in pull request #353: UI changes for Dynamic roles improvements
sureshanaparti commented on a change in pull request #353: URL: https://github.com/apache/cloudstack-primate/pull/353#discussion_r429892693 ## File path: src/views/iam/ImportRole.vue ## @@ -0,0 +1,267 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + + + + + + + + + + + + Click or drag rule defintions CVS file to import Review comment: Added this string to translation file ## File path: src/views/iam/ImportRole.vue ## @@ -0,0 +1,267 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + + + + + + + + + + + + Click or drag rule defintions CVS file to import Review comment: > can be added in the translation file Added this string to translation file This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] sureshanaparti commented on a change in pull request #353: UI changes for Dynamic roles improvements
sureshanaparti commented on a change in pull request #353: URL: https://github.com/apache/cloudstack-primate/pull/353#discussion_r429893457 ## File path: src/views/iam/ImportRole.vue ## @@ -0,0 +1,267 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + + + + + + + + + + + + Click or drag rule defintions CVS file to import + + + + + + + + + Review comment: > We can directly show the description of API parameters as placeholders. See, > https://github.com/apache/cloudstack-primate/blob/master/src/views/image/RegisterOrUploadTemplate.vue#L66 > https://github.com/apache/cloudstack-primate/blob/master/src/views/image/RegisterOrUploadTemplate.vue#L411-L415 @shwstppr Thanks for pointing to this code. I've updated the code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] sureshanaparti commented on a change in pull request #353: UI changes for Dynamic roles improvements
sureshanaparti commented on a change in pull request #353: URL: https://github.com/apache/cloudstack-primate/pull/353#discussion_r429893783 ## File path: src/views/iam/ImportRole.vue ## @@ -0,0 +1,267 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + + + + + + + + + + + + Click or drag rule defintions CVS file to import + + + + + + + + + + + + +
[GitHub] [cloudstack-primate] sureshanaparti commented on a change in pull request #353: UI changes for Dynamic roles improvements
sureshanaparti commented on a change in pull request #353: URL: https://github.com/apache/cloudstack-primate/pull/353#discussion_r429894468 ## File path: src/views/iam/ImportRole.vue ## @@ -0,0 +1,267 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + + + + + + + + + + + + Click or drag rule defintions CVS file to import + + + + + + + + + + + + + +Admin +DomainAdmin +ResourceAdmin +User Review comment: > Do we need to call listRoles API instead or the functionality limited to these roles only? @shwstppr These are role types, limited to 4 types only: Admin, DomainAdmin, ResourceAdmin, User. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] sureshanaparti commented on a change in pull request #353: UI changes for Dynamic roles improvements
sureshanaparti commented on a change in pull request #353:
URL: https://github.com/apache/cloudstack-primate/pull/353#discussion_r429894679
##
File path: src/views/iam/ImportRole.vue
##
@@ -0,0 +1,267 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+
+
+
+
+
+
+
+
+
+ Click or drag rule defintions CVS file to import
+
+
+
+
+
+
+
+
+
+
+
+
+
+Admin
+DomainAdmin
+ResourceAdmin
+User
+
+
+
+
+
+
+
+
+ {{ this.$t('Cancel') }}
+ {{
this.$t('OK') }}
+
+
+
+
+
+
+
[GitHub] [cloudstack-primate] sureshanaparti commented on a change in pull request #353: UI changes for Dynamic roles improvements
sureshanaparti commented on a change in pull request #353:
URL: https://github.com/apache/cloudstack-primate/pull/353#discussion_r429894803
##
File path: src/views/iam/ImportRole.vue
##
@@ -0,0 +1,267 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+
+
+
+
+
+
+
+
+
+ Click or drag rule defintions CVS file to import
+
+
+
+
+
+
+
+
+
+
+
+
+
+Admin
+DomainAdmin
+ResourceAdmin
+User
+
+
+
+
+
+
+
+
+ {{ this.$t('Cancel') }}
+ {{
this.$t('OK') }}
+
+
+
+
+
+
+
[GitHub] [cloudstack-primate] sureshanaparti commented on a change in pull request #353: UI changes for Dynamic roles improvements
sureshanaparti commented on a change in pull request #353:
URL: https://github.com/apache/cloudstack-primate/pull/353#discussion_r429895293
##
File path: src/views/iam/ImportRole.vue
##
@@ -0,0 +1,267 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+
+
+
+
+
+
+
+
+
+ Click or drag rule defintions CVS file to import
+
+
+
+
+
+
+
+
+
+
+
+
+
+Admin
+DomainAdmin
+ResourceAdmin
+User
+
+
+
+
+
+
+
+
+ {{ this.$t('Cancel') }}
+ {{
this.$t('OK') }}
+
+
+
+
+
+
+
[GitHub] [cloudstack-primate] sureshanaparti commented on a change in pull request #353: UI changes for Dynamic roles improvements
sureshanaparti commented on a change in pull request #353:
URL: https://github.com/apache/cloudstack-primate/pull/353#discussion_r429895447
##
File path: src/views/iam/ImportRole.vue
##
@@ -0,0 +1,267 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+
+
+
+
+
+
+
+
+
+ Click or drag rule defintions CVS file to import
+
+
+
+
+
+
+
+
+
+
+
+
+
+Admin
+DomainAdmin
+ResourceAdmin
+User
+
+
+
+
+
+
+
+
+ {{ this.$t('Cancel') }}
+ {{
this.$t('OK') }}
+
+
+
+
+
+
+
[GitHub] [cloudstack-primate] sureshanaparti commented on a change in pull request #353: UI changes for Dynamic roles improvements
sureshanaparti commented on a change in pull request #353:
URL: https://github.com/apache/cloudstack-primate/pull/353#discussion_r429896090
##
File path: src/views/iam/RolePermissionTab.vue
##
@@ -227,6 +232,47 @@ export default {
this.resetNewFields()
this.fetchData()
})
+},
+csv ({ data = null, columnDelimiter = ',', lineDelimiter = '\n' }) {
Review comment:
> can we have a better name for method, something like generateRulesCSV,
etc
updated method name
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] sureshanaparti commented on a change in pull request #353: UI changes for Dynamic roles improvements
sureshanaparti commented on a change in pull request #353:
URL: https://github.com/apache/cloudstack-primate/pull/353#discussion_r429897348
##
File path: src/views/iam/RolePermissionTab.vue
##
@@ -227,6 +232,47 @@ export default {
this.resetNewFields()
this.fetchData()
})
+},
+csv ({ data = null, columnDelimiter = ',', lineDelimiter = '\n' }) {
+ let result = null
+ let ctr = null
+
+ if (data === null || !data.length) {
+return null
+ }
+
+ var keys = ['rule', 'permission', 'description']
+
+ result = ''
+ result += keys.join(columnDelimiter)
+ result += lineDelimiter
+
+ data.forEach(item => {
+ctr = 0
+keys.forEach(key => {
+ if (ctr > 0) {
+result += columnDelimiter
+ }
+
+ if (item[key] === undefined) {
+item[key] = ''
+ }
+ result += typeof item[key] === 'string' &&
item[key].includes(columnDelimiter) ? `"${item[key]}"` : item[key]
+ ctr++
+})
+result += lineDelimiter
+ })
+
+ return result
+},
+exportRolePermissions () {
+ const csvData = this.csv({ data: this.rules })
+
+ const hiddenElement = document.createElement('a')
Review comment:
> we need to delete this element?
element for the csv data to download as a file
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb merged pull request #122: Primate docs with 4.14 release
andrijapanicsb merged pull request #122: URL: https://github.com/apache/cloudstack-documentation/pull/122 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot removed a comment on pull request #95: Update 4.14 Release notes
ACSGitBot removed a comment on pull request #95: URL: https://github.com/apache/cloudstack-documentation/pull/95#issuecomment-633509202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #95: Update 4.14 Release notes
ACSGitBot commented on pull request #95: URL: https://github.com/apache/cloudstack-documentation/pull/95#issuecomment-633561686 Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb removed a comment on pull request #95: Update 4.14 Release notes
andrijapanicsb removed a comment on pull request #95: URL: https://github.com/apache/cloudstack-documentation/pull/95#issuecomment-617279222 requesting docbuild This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #95: Update 4.14 Release notes
ACSGitBot commented on pull request #95: URL: https://github.com/apache/cloudstack-documentation/pull/95#issuecomment-633562577 Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr95 Build Log Output: No log errors found to report. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
