[GitHub] [cloudstack-primate] rhtyd commented on issue #297: view: fix runDiagnostic output display

[GitBox]

rhtyd commented on issue #297:
URL: 
https://github.com/apache/cloudstack-primate/pull/297#issuecomment-617602855


   @shwstppr the output should also show stderr and exit value like old UI:
   ```
   exitcode: 0
   
   stderr:
   
   stdout: PING 8.8.8.8 (8.8.8.8): 56 data bytes 64 bytes from 8.8.8.8: 
icmp_seq=0 ttl=50 time=7.575 ms 64 bytes from 8.8.8.8: icmp_seq=1 ttl=50 
time=8.030 ms 64 bytes from 8.8.8.8: icmp_seq=2 ttl=50 time=14.950 ms 64 bytes 
from 8.8.8.8: icmp_seq=3 ttl=50 time=7.617 ms --- 8.8.8.8 ping statistics --- 4 
packets transmitted, 4 packets received, 0% packet loss round-trip 
min/avg/max/stddev = 7.575/9.543/14.950/3.127 ms
   ```
   
   Side-note I'm getting network error, for some reason the API request fails 
that I couldn't debug - are you seeing this as well (when using a non-local 
mgmt server env):
   ![Screenshot from 2020-04-22 
12-57-39](https://user-images.githubusercontent.com/95203/79953091-fcd6-8498-11ea-9ea7-71240841fbda.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] vladimirpetrov opened a new issue #233: [BUG] Domain admin: non-working links (insufficient rights)

[GitBox]

vladimirpetrov opened a new issue #233:
URL: https://github.com/apache/cloudstack-primate/issues/233


   **Describe the bug**
   The following links could generate (if the domain admin lacks the required 
permissions) a 404 (not found) or 500 (Internal server error) errors - 
template, zone, host, cluster, pod, domain, account, compute offering, storage 
pool.
   
   **To Reproduce**
   Steps to reproduce the behavior:
   1. Log in as domain admin, go to 'Network > Guest networks' and click on a 
network. Then try the 'Zone' and 'Domain' links - first returns '404' (Not 
found) error and the second - '500' (Internal server error).
   
   **Expected behavior**
   All links should work or be hidden (if the permissions are insufficient).
   
   **Screenshots**
   
![image](https://user-images.githubusercontent.com/12384665/76876043-09ec4780-687a-11ea-8200-1f9434366a64.png)
   
   **Desktop (please complete the following information):**
- OS: Ubuntu 18.04 LTS
- Browser: Chrome
- Version: 80.0.3987.132 (Official Build) (64-bit)
   
   **Additional context**
   Affected areas:
   > Instances > selected instance - 
   - template - 404
   - host - 404
   - zone - 404
   
   > Volumes - selected
   - compute offering - 404
   - storage pool - 404
   - cluster - 404
   - pod - 404
   - zone - 404
   
   > Snapshots - selected
   - zone - 404
   
   > VM Snapshots - selected
   - zone - 404
   
   > Guest networks
   - zone - 404
   - domain - 500
   
   > Images > Templates - selected
   - Zone 404
   - account - 500
   - domain - 500
   
   > Images > ISOs - selected
   - account - 500
   - domain - 500
   
   > Offerings > System Offerings - 404
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on issue #233: [BUG] Domain admin: non-working links (insufficient rights)

[GitBox]

rhtyd commented on issue #233:
URL: 
https://github.com/apache/cloudstack-primate/issues/233#issuecomment-617606254


   @vladimirpetrov cc @borisstoyanov please test and close against latest 
master.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] vladimirpetrov opened a new issue #245: [BUG] Normal user: non-working links (insufficient rights)

[GitBox]

vladimirpetrov opened a new issue #245:
URL: https://github.com/apache/cloudstack-primate/issues/245


   **Describe the bug**
   The following links could generate (if the normal user lacks the required 
permissions) a 404 (not found) or 500 (Internal server error) errors - 
template, zone, host, domain, account, compute offering.
   
   **To Reproduce**
   Steps to reproduce the behavior:
   1. Log in as normal user, go to 'Network > Guest networks' and click on a 
network. Then try the 'Zone' and 'Domain' links - they returns '404' (Not 
found) error.
   
   **Expected behavior**
   All links should work or be hidden (if the permissions are insufficient).
   
   **Screenshots**
   None
   
   **Desktop (please complete the following information):**
- OS: Ubuntu 18.04 LTS
- Browser: Chrome
- Version: 80.0.3987.132 (Official Build) (64-bit)
   
   **Additional context**
   Affected areas:
   > Instances
   - compute offering - 404
   - template - 404
   - host - 404
   - zone - 404
   - domain - 404
   
   > Instance groups
   - domain - 404
   
   > SSH Key Pairs
   - domain - 404
   
   > Affinity groups
   - domain - 404
   
   > Storage > Volumes
   - compute offering - 404
   - zone - 404
   - domain - 404
   
   > Storage > Snapshots
   - zone - 404
   - domain - 404
   
   > Storage > VM Snapshots
   - zone - 404
   - domain - 404
   
   > Network - Guest networks
   - zone - 404
   - domain - 404
   
   > Network - VPC
   - zone - 404
   - domain - 404
   
   > Network - Security groups
   - domain - 404
   
   > Network - Public IP Addresses
   - zone - 404
   - domain - 404
   
   > Network - VPN Users
   - domain - 404
   
   > Images > Templates - selected
   - Zone - 404
   - account - 500
   - domain - 404
   
   > Images > ISOs - selected
   - Zone 404
   - account - 500
   - domain - 404
   
   > Projects
   - domain - 404
   
   > Identify and access
   - domain - 404
   
   > Quota
   - domain - 404
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on issue #245: [BUG] Normal user: non-working links (insufficient rights)

[GitBox]

rhtyd commented on issue #245:
URL: 
https://github.com/apache/cloudstack-primate/issues/245#issuecomment-617606306


   @vladimirpetrov cc @borisstoyanov please test and close against latest 
master.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr opened a new pull request #304: view: upload template form hypervisor fix

[GitBox]

shwstppr opened a new pull request #304:
URL: https://github.com/apache/cloudstack-primate/pull/304


   Fixes #300 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #231: storage: fix volume actions

[GitBox]

rhtyd commented on a change in pull request #231:
URL: https://github.com/apache/cloudstack-primate/pull/231#discussion_r412757975



##
File path: src/config/section/storage.js
##
@@ -150,20 +150,45 @@ export default {
   icon: 'picture',
   label: 'Create Template from Volume',
   dataView: true,
-  show: (record) => { return record.type === 'ROOT' },
+  show: (record) => { return record.type === 'ROOT' && record.vmstate 
=== 'Stopped' },
   args: ['volumeid', 'name', 'displaytext', 'ostypeid', 'ispublic', 
'isfeatured', 'isdynamicallyscalable', 'requireshvm', 'passwordenabled', 
'sshkeyenabled'],
   mapping: {
 volumeid: {
   value: (record) => { return record.id }
 }
   }
 },
+{
+  api: 'recoverVolume',
+  icon: 'medicine-box',
+  label: 'Recover Volume',
+  dataView: true,
+  show: (record, store) => {
+return (['Admin', 'DomainAdmin'].includes(store.userInfo.roletype) 
|| store.getters.features.allowuserexpungerecovervolume) && record.state === 
'Destroy'
+  }
+},
 {
   api: 'deleteVolume',
   icon: 'delete',
   label: 'Delete Volume',
   dataView: true,
-  groupAction: true
+  groupAction: true,
+  show: (record, store) => {
+return ['Expunging', 'Expunged', 
'UploadError'].includes(record.state) ||
+  ((['Admin', 'DomainAdmin'].includes(store.userInfo.roletype) || 
store.getters.features.allowuserexpungerecovervolume) && record.state === 
'Destroy')
+  }
+},
+{
+  api: 'destroyVolume',
+  icon: 'delete',
+  label: 'Destroy Volume',
+  dataView: true,
+  args: (record, store) => {

Review comment:
   @shwstppr args is expected to be an array not a function; this would 
require some changes in AutogenView. On testing I'm getting:
   ```
   vue.runtime.esm.js?2b0e:619 [Vue warn]: Error in v-on handler: "TypeError: 
action.args.map is not a function"
   
   found in
   
   --->  at src/components/view/ActionButton.vue
  

  
 at src/views/AutogenView.vue
   at src/layouts/RouteView.vue... (1 recursive 
calls)

  

  

  
 at 
src/components/page/GlobalLayout.vue
   at src/layouts/BasicLayout.vue

   at src/App.vue

   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on issue #231: storage: fix volume actions

[GitBox]

rhtyd commented on issue #231:
URL: 
https://github.com/apache/cloudstack-primate/pull/231#issuecomment-617617002


   @shwstppr please review existing actions against old UI implementation; it 
seems some cases are not covered. There is another issue with the `args`. Have 
you tested your changes?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #231: storage: fix volume actions

[GitBox]

rhtyd edited a comment on issue #231:
URL: 
https://github.com/apache/cloudstack-primate/pull/231#issuecomment-617617002


   @shwstppr please review existing actions against old UI implementation; it 
seems some cases are not covered. There is another issue with the `args`. Have 
you tested your changes?
   Looks like there are two different APIs - deleteVolume and destroyVolume, 
please review against old UI for suitable actions.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] vladimirpetrov opened a new issue #173: [BUG] Selected instance actions difference between old and new UI

[GitBox]

vladimirpetrov opened a new issue #173:
URL: https://github.com/apache/cloudstack-primate/issues/173


   **Describe the bug**
   Here are the differences between the old and new UI:
   
   | Running instance - old UI | Running instance - Primate UI |
   |---|---|
   | Stop instance | Stop instance |
   | Reboot instance | Reboot instance |
   | Take VM snapshot | Create VM snapshot |
   | Take VM volume snapshot | |
   | Assign VM to backup offering | |
   | Destroy instance | Destroy instance |
   | Reinstall VM | Reinstall VM |
   | Attach ISO | Attach ISO |
   | Reset password | |
   | Migrate instance to another host | Migrate instance to another host |
   | Change service offering | |
   | Reset SSH Key Pair | |
   | View console | View console |
   | | Update VM |
   | | Scale VM |
   
   Probably 'Scale VM' could be a replacement of 'Change service offering' - 
they are quite similar. But still this could be confusing for the current 
users. Actually, 'Scale VM' has one additional field 'Details' which I'm not 
really sure how to use.
   
   | Stopped instance - old UI | Stopped instance - Primate UI |
   |---|---|
   | Start instance | Start VM |
   | Take VM snapshot | |
   | Take VM volume snapshot | |
   | Assign VM to backup offering | |
   | Destroy instance | Destroy instance |
   | Reinstall VM | Reinstall VM |
   | Change affinity | Change affinity |
   | Edit | Update VM |
   | Attach ISO | Attach ISO |
   | Reset password | Reset instance password |
   | Migrate instance to another host | Migrate instance to another host |
   | Change service offering | Change service offering |
   | Reset SSH Key Pair | Reset SSH Key |
   | Assign instance to another account | Assign instance to another account |
   | | Scale VM | 
   
   I'm not sure if some of these differences are intended but I do feel like 
there's something wrong here.
   
   **To Reproduce**
   Steps to reproduce the behavior:
   1. Go to 'Compute > Instances > selected instance'
   2. Look at the action buttons and compare with the old UI for running and 
stopped VM.
   
   **Expected behavior**
   There should be no missing actions in the Primate UI - only improvements, if 
any.
   
   **Screenshots**
   None
   
   **Desktop (please complete the following information):**
- OS: Windows 10 Pro x64
- Browser Chrome
- Version: 80.0.3987.116 (Official Build) (64-bit)
   
   **Additional context**
   None



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on issue #173: [BUG] Selected instance actions difference between old and new UI

[GitBox]

rhtyd commented on issue #173:
URL: 
https://github.com/apache/cloudstack-primate/issues/173#issuecomment-617621867


   @vladimirpetrov @borisstoyanov please re-test against master. I've removed 
the `VM volume snapshot` action on purpose, this button shouldn't exist for VM 
view; if we need that please log another ticket that we can target for GA/1.0. 
Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] utchoang commented on issue #298: [WIP] Quota UI

[GitBox]

utchoang commented on issue #298:
URL: 
https://github.com/apache/cloudstack-primate/pull/298#issuecomment-617623921


   Hi @rhtyd . Regarding Issue 
https://github.com/apache/cloudstack-primate/issues/210 (Missing calendar 
functionality in Quota > Tariff), I found there is a conflict as I restructured 
the search function in PR 
https://github.com/apache/cloudstack-primate/pull/235. Is it possible for this 
issue to be solved after PR 
https://github.com/apache/cloudstack-primate/pull/235 is merged?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Start problem with Marvin

[Sven Vogel]

Hi Dirk,

Nice to see you here.

Cheers

Sven


__

Sven Vogel
Lead Cloud Solution Architect

EWERK DIGITAL GmbH
Brühl 24, D-04109 Leipzig
P +49 341 42649 - 99
F +49 341 42649 - 98
s.vo...@ewerk.com
www.ewerk.com

Geschäftsführer:
Dr. Erik Wende, Hendrik Schubert, Tassilo Möschke
Registergericht: Leipzig HRB 9065

Support:
+49 341 42649 555

Zertifiziert nach:
ISO/IEC 27001:2013
DIN EN ISO 9001:2015
DIN ISO/IEC 2-1:2011

ISAE 3402 Typ II Assessed

EWERK-Blog | 
LinkedIn | 
Xing | 
Twitter | 
Facebook


Mit Handelsregistereintragung vom 09.07.2019 ist die EWERK RZ GmbH auf die 
EWERK IT GmbH verschmolzen und firmiert nun gemeinsam unter dem Namen: EWERK 
DIGITAL GmbH, für weitere Informationen klicken Sie 
hier.

Auskünfte und Angebote per Mail sind freibleibend und unverbindlich.

Disclaimer Privacy:
Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist 
vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der 
bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, 
Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte 
informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie die 
E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. Vielen 
Dank.

The contents of this e-mail (including any attachments) are confidential and 
may be legally privileged. If you are not the intended recipient of this 
e-mail, any disclosure, copying, distribution or use of its contents is 
strictly prohibited, and you should please notify the sender immediately and 
then delete it (including any attachments) from your system. Thank you.

Am 20.04.2020 um 10:51 schrieb Klahre, Dirk 
mailto:dirk.kla...@itelligence.de>>:

Hi Paul,

no problem, I’ve found the reason.

During the Cloudstack start, the TransactionLegacy object build a connection 
string with placeholders without replacement with original values  and tries to 
load the driver with this. That goes wrong and the TransactionLegacy object 
switch to default values.  By the default values is the problem that the 
database name for simulator values named “cloud_simulator” but maven builds the 
database with name “simulator´”. Therefore cloudstack can’t save simulated 
hosts into database.

Not quite sure what the right way is but my workaround is currently to rename 
“cloud_simulator” to “simulator” to put the test data into cloudstack.

Best regards
Dirk


Dirk Klahre
Senior System Admin

[cid:itelligence_ntt_ddd17a2c-b83a-434e-af62-f51bab775945.png]

We Transform. Trust into Value

itelligence Global Managed Services GmbH ▪ Breitscheidstrasse 48 ▪ 01237 Dresden
phone: +49 3591 5253-1562 ▪
e-mail: dirk.kla...@itelligence.de

www.itelligencegroup.com


Wir halten Sie immer auf dem Laufenden!
Folgen Sie uns auf unseren Social Media Kanälen:
Xing 
LinkedIn 
Facebook 
Twitter

Profitieren Sie vom Know-how unserer Experten – mit dem itelligence 
Infoservice! Jetzt kostenlos 
registrieren!


itelligence Global Managed Services GmbH ▪ Sitz: Bautzen ▪ Handelsregister: 
Amtsgericht Dresden, HRB 21356
Geschäftsführer: Mirko Kruse ▪ André Walter

From: Paul Angus mailto:paul.an...@shapeblue.com>>
Sent: Freitag, 17. April 2020 17:52
To: dev@cloudstack.apache.org
Cc: Klahre, Dirk mailto:dirk.kla...@itelligence.de>>
Subject: RE: Start problem with Marvin

EXTERNAL MAIL:

Hi Dirk,

Sorry that no one has been able to get back to you yet, a lot of people are 
‘off’ at the moment.

The place to look at the cause of this would be the management server logs.  
They would give the specific reason that the hosts could not be added.
If you can’t figure it out from the logs, put them in pastebin (or similar) and 
let us know. (attachments are stripped in the mailing list).

Kind regards

Paul Angus



paul.an...@shapeblue.com
www.shapeblue.com
@shapeblue



From: Klahre, Dirk 
mailto:dirk.kla...@itelligence.de>>
Sent: 14 April 2020 10:03
To:dev@cloudstack.apache.org
Subject: Start problem with Marvin

Hi All,

my name is Dirk and I'm the new developer for cloudstack at the Itelligence GMS.
I have been working at Itelli since 2015 and look forward to a good 
cooperation. ☺

I

[GitHub] [cloudstack-primate] rhtyd commented on issue #304: view: upload template form hypervisor fix

[GitBox]

rhtyd commented on issue #304:
URL: 
https://github.com/apache/cloudstack-primate/pull/304#issuecomment-617625634


   @shwstppr can you also check/test the 
`.../views/image/RegisterOrUploadIso.vue` for the same issue/pattern?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr commented on issue #304: view: upload template form hypervisor fix

[GitBox]

shwstppr commented on issue #304:
URL: 
https://github.com/apache/cloudstack-primate/pull/304#issuecomment-617637737


   @rhtyd we don't have hypervisor field in ISO form and I just checked there 
is no similar code while handling zone selection



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr opened a new pull request #305: fixes

[GitBox]

shwstppr opened a new pull request #305:
URL: https://github.com/apache/cloudstack-primate/pull/305


   Fixes: #301 
   Fixes: #302 
   Fixes: #303 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd opened a new issue #306: [BUG] VM Deployment Wizard Changes

[GitBox]

rhtyd opened a new issue #306:
URL: https://github.com/apache/cloudstack-primate/issues/306


   We need to address the following:
   - Template filter can be left to search box; does n't seem to work - if I 
select something like Community in primate-qa server env it should show no 
templates (empty)
   - TBD: should we add/have a way to add network, re-use the add network form 
perhaps?
   - Not able to specify a new group: (this could be okay if we ask/expect 
users to create groups first?)
   - Hypervisor option could be moved next to zone?
   - Changing default network has no effect?
   - Do validation for form elements, looks like only zone is validated; but 
say service offering is not
   - Group ID passed instead of name in the deployVM API
   
   Overall: Implement new/missing changes per 4.14/master in the VM deployment 
wizard
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on issue #273: [FIX] VM Deployment Wizard Issues

[GitBox]

rhtyd commented on issue #273:
URL: 
https://github.com/apache/cloudstack-primate/pull/273#issuecomment-617655406


   Further issues can be fixed for 
https://github.com/apache/cloudstack-primate/issues/306 cc @utchoang Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on issue #304: view: upload template form hypervisor fix

[GitBox]

rhtyd commented on issue #304:
URL: 
https://github.com/apache/cloudstack-primate/pull/304#issuecomment-617659321


   okay LGTM.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on issue #300: [BUG] Upload local template - empty Hypervisor drop-down after selecting incomplete zone

[GitBox]

rhtyd commented on issue #300:
URL: 
https://github.com/apache/cloudstack-primate/issues/300#issuecomment-617659679


   @vladimirpetrov please re-test and close against latest master.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr commented on issue #297: view: fix runDiagnostic output display

[GitBox]

shwstppr commented on issue #297:
URL: 
https://github.com/apache/cloudstack-primate/pull/297#issuecomment-617684250


   @rhtyd it works with a lab env and also with cloudmonkey local env
   Made changes to show stderr and errorCode,
   ![Screenshot from 2020-04-22 
15-36-06](https://user-images.githubusercontent.com/153340/79969636-62cd8200-84af-11ea-8339-5a48357fe636.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr commented on issue #296: view: fix api error handling

[GitBox]

shwstppr commented on issue #296:
URL: 
https://github.com/apache/cloudstack-primate/pull/296#issuecomment-617705363


   @rhtyd I've fixed that message comparison issue. I don't have a better 
solution right now for the whole notification thing.
   Maybe we can add a parameter for `api` function call such as `notifyError` 
(with false as the default value) and then remove 
`this.$notification.error(...` code for API calls from the whole codebase where 
we are just simply showing error in notifications.
   Although I feel better to not do it in TP milestone.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-kubernetes-provider] onitake commented on issue #9: Support loadBalancerSourceRanges

[GitBox]

onitake commented on issue #9:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-617720855


   I reverted all changes that are covered by the other PRs for easier review.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-kubernetes-provider] onitake commented on issue #15: Maintenance

[GitBox]

onitake commented on issue #15:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/issues/15#issuecomment-617727040


   @iamcryptoki Thanks for the offer!
   The project is very much alive, but still needs some love from a few sides.
   
   If you have any issues, input or pull requests, please post them on the 
Github tracker.
   
   And if you want to try the provider for yourself, you can always build it 
locally.
   I recommend merging #8 , #10 , #11 and #9 as they contain various fixes and 
the IP whitelisting feature that I just finished. Any feedback on #9 is highly 
appreciated.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] onitake commented on issue #296: view: fix api error handling

[GitBox]

onitake commented on issue #296:
URL: 
https://github.com/apache/cloudstack-primate/pull/296#issuecomment-617825950


   I tested b3805f8 and it solved the issue reported in #294 . I haven't tested 
944c5f6 yet.
   Is there a specific reason why you changed `(x && y) || z` to `x ? y : z`?
   A general dislike of the ternary operator notwithstanding, I think the ?: 
construct is easier to read - but YMMV.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr commented on issue #296: view: fix api error handling

[GitBox]

shwstppr commented on issue #296:
URL: 
https://github.com/apache/cloudstack-primate/pull/296#issuecomment-617831261


   @onitake change was due to an internal review comment. I like `?:` myself, 
easier to understand.
   Although, we might have to refactor the error handling more exhaustively as 
mentioned in previous comment.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] utchoang opened a new pull request #307: [FIX] VM Deployment Wizard Changes

[GitBox]

utchoang opened a new pull request #307:
URL: https://github.com/apache/cloudstack-primate/pull/307


   Open for https://github.com/apache/cloudstack-primate/issues/306
   @rhtyd cc @svenvogel 
   * [ ] Template filter can be left to search box and not working
   * [ ] TBD: should we add/have a way to add network, re-use the add network 
form perhaps?
   * [ ] Not able to specify a new group
   * [ ] Hypervisor option could be moved next to zone?
   * [ ] Changing default network has no effect
   * [ ] Do validation for form elements, looks like only zone is validated; 
but say service offering is not
   * [ ] Group ID passed instead of name in the deployVM API



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] utchoang commented on issue #307: [FIX] VM Deployment Wizard Changes

[GitBox]

utchoang commented on issue #307:
URL: 
https://github.com/apache/cloudstack-primate/pull/307#issuecomment-618147573


   * Move template/iso filter to left of search box
   
![image](https://user-images.githubusercontent.com/13766648/80054199-c9eb4500-8548-11ea-9a0f-434cf36973ec.png)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] utchoang edited a comment on issue #307: [FIX] VM Deployment Wizard Changes

[GitBox]

utchoang edited a comment on issue #307:
URL: 
https://github.com/apache/cloudstack-primate/pull/307#issuecomment-618147573


   * Move template/iso filter to left of search box
   
![image](https://user-images.githubusercontent.com/13766648/80054266-f0a97b80-8548-11ea-87bf-cf2643134b1a.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr commented on issue #231: storage: fix volume actions

[GitBox]

shwstppr commented on issue #231:
URL: 
https://github.com/apache/cloudstack-primate/pull/231#issuecomment-618201337


   @rhtyd fixed actions and args error. Tested for different scenarios
   
   Allocated volume without VM
   ![Screenshot from 2020-04-23 
11-07-54](https://user-images.githubusercontent.com/153340/80065140-44bb5c80-8557-11ea-9da4-cbc39013b3de.png)
   ROOT disk for stopped VM
   ![Screenshot from 2020-04-23 
11-08-33](https://user-images.githubusercontent.com/153340/80065188-5997f000-8557-11ea-869b-7a9133d38768.png)
   DATA disk for stopped VM
   ![Screenshot from 2020-04-23 
11-21-52](https://user-images.githubusercontent.com/153340/80065216-64528500-8557-11ea-9412-9445689f9420.png)
   ROOT disk for running VM
   ![Screenshot from 2020-04-23 
11-09-48](https://user-images.githubusercontent.com/153340/80065229-6a486600-8557-11ea-998e-39c5fcb0a433.png)
   DATA disk for running VM
   ![Screenshot from 2020-04-23 
11-09-25](https://user-images.githubusercontent.com/153340/80065250-70d6dd80-8557-11ea-887b-3cb5080dcd0b.png)
   Ready volume without VM
   ![Screenshot from 2020-04-23 
11-20-49](https://user-images.githubusercontent.com/153340/80065293-80eebd00-8557-11ea-92d1-dc0b1d281c66.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] utchoang commented on issue #307: [FIX] VM Deployment Wizard Changes

[GitBox]

utchoang commented on issue #307:
URL: 
https://github.com/apache/cloudstack-primate/pull/307#issuecomment-618208782


   Hi @rhtyd I have some questions:
   1. For adding new network, do you mean you want to make it similar to the 
first version? (add networking in a network section)
   2. Change default network: According to 
https://github.com/apache/cloudstack/blob/ef14e195c4b40be53466f081e4632547aa0cf43c/ui/scripts/instanceWizard.js#L1227.
 I found that in the old UI, the default network selected as will be ordered 
first in the list of network for send to server. Do you have any other 
requirements?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org