[GitHub] [cloudstack-primate] rhtyd commented on issue #144: [WIP] Custom upload action
rhtyd commented on issue #144: [WIP] Custom upload action URL: https://github.com/apache/cloudstack-primate/pull/144#issuecomment-582810713 @Pearl1594 I've implemented custom progress bar feature while uploading, please replicate that and some error handling etc. for template and volume. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #141: VPC: Add Internal LB form and Assign VM to LB rule form
rhtyd commented on issue #141: VPC: Add Internal LB form and Assign VM to LB rule form URL: https://github.com/apache/cloudstack-primate/issues/141#issuecomment-582820803 @RitchieVincent just do the assign form. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #145: UI Wide Implement a-table with pagination for possible a-list uses
rhtyd commented on issue #145: UI Wide Implement a-table with pagination for possible a-list uses URL: https://github.com/apache/cloudstack-primate/issues/145#issuecomment-582821215 Also https://github.com/apache/cloudstack-primate/pull/134 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] vladimirpetrov opened a new issue #150: JS errors when trying to sort a column in a grid with missing data
vladimirpetrov opened a new issue #150: JS errors when trying to sort a column in a grid with missing data URL: https://github.com/apache/cloudstack-primate/issues/150 **Describe the bug** If you try to sort by column and there is a missing element (IP or CPU usage, if the VM is stopped) in the grid, the following JS exception is thrown: vue.runtime.esm.js?2b0e:619 [Vue warn]: Error in v-on handler: "TypeError: Cannot read property 'localeCompare' of undefined" vue.runtime.esm.js?2b0e:1888 TypeError: Cannot read property 'localeCompare' of undefined at stringComparator (sort.js?dbd1:26) at genericCompare (sort.js?dbd1:101) at Object.sorter (AutogenView.vue?feaa:402) at eval (Table.js?372e:346) at Array.sort () at VueComponent.recursiveSort (Table.js?372e:1011) at VueComponent.getLocalData (Table.js?372e:1029) at VueComponent.prepareParamsArguments (Table.js?372e:958) at VueComponent.toggleSortOrder (Table.js?372e:390) at colProps.on.click (Table.js?372e:855) **To Reproduce** Steps to reproduce the behavior: 1. Go to a grid with missing data in some rows - for example Compute > Instances. If needed - stop some of the VMs. 2. Sort by a column with some missing data - IP or CPU usage, if the VM is stopped. 3. Look at the JS console **Expected behavior** This event (missing grid data) must be handled properly and not throw exceptions. **Screenshots** Not needed. **Desktop (please complete the following information):** - OS: Windows 10 Pro x64 (doesn't matter) - Browser: Chrome - Version 79.0.3945.130 (Official Build) (64-bit) **Additional context** Sometimes it leads to some strange UI behavior as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] svenvogel commented on issue #146: [WIP] Feature/vm wizard
svenvogel commented on issue #146: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-582868956 @rhtyd i my experience most of my infra user find a way for creating a network in the wizard in the process of creating a virtual machine a good way. do complete creation in one step. my most users here was confused in the old UI because they dont know "whats that for network type and where is it connected"... if this is better in new UI i think it will not confuse. i see 2 ways. 1. like @utchoang suggest i would use a help button if we dont want creation of network or "we have an ugly content switch". this means we avoid switch the site to another and back. this is from design perpective and usability not nice for handling. at the moment we have a speedy nice one pager vm wizard. each content switch will destroy it. help button like create network there... but not switch them... 2. for me +1 for the possibility to create directly the network because we use collapse mode. users they dont want it will not use it and if you plan network before you will go directly to network tab. @rhtyd what do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] RitchieVincent commented on issue #134: [WIP] IP Ranges form component for Public, Management and Storage traffic types
RitchieVincent commented on issue #134: [WIP] IP Ranges form component for Public, Management and Storage traffic types URL: https://github.com/apache/cloudstack-primate/pull/134#issuecomment-582898781 > @RitchieVincent can you make use of `a-table` with pagination in this PR as well? That's complete now in the latest PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] RitchieVincent opened a new pull request #151: [WIP] - UI Wide Implement a-table with pagination for possible a-list uses
RitchieVincent opened a new pull request #151: [WIP] - UI Wide Implement a-table with pagination for possible a-list uses URL: https://github.com/apache/cloudstack-primate/pull/151 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
4.13 force push apologies
All, I made a forward merge error and accidentally merged master into 4.13, rather than the opposite (while using Github, should have stick to using zsh to do forward merges). This happened after this commit on 4.13 branch: https://github.com/apache/cloudstack/commit/d88c614a35107015f211c598282c03f0408f32d2 For reference, I've applied the course correction by resetting --hard the known good commit on 4.13, cherry-pick the PRs merged onto 4.13 and force push on remote 4.13 branch, and then forward merged the same onto origin/master. I further checked the commit SHAs to ensure branch integrities of both 4.13 and master, I'll be watching both 4.13 and master smoketests+Travis. Please accept my apologies for the force push and I hope to have your support. Thanks. Regards, Rohit Yadav Software Architect, ShapeBlue https://www.shapeblue.com rohit.ya...@shapeblue.com www.shapeblue.com 3 London Bridge Street, 3rd floor, News Building, London SE1 9SGUK @shapeblue
