[GitHub] [cloudstack-primate] rhtyd merged pull request #139: VPC: Private Gateway Static Routes Tab

2020-02-03 Thread GitBox
rhtyd merged pull request #139: VPC: Private Gateway Static Routes Tab
URL: https://github.com/apache/cloudstack-primate/pull/139
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] rhtyd merged pull request #138: VPC: Network ACL List Management

2020-02-03 Thread GitBox
rhtyd merged pull request #138: VPC: Network ACL List Management
URL: https://github.com/apache/cloudstack-primate/pull/138
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] rhtyd commented on issue #138: VPC: Network ACL List Management

2020-02-03 Thread GitBox
rhtyd commented on issue #138: VPC: Network ACL List Management
URL: 
https://github.com/apache/cloudstack-primate/pull/138#issuecomment-581359316
 
 
   @RitchieVincent couple of issues with the PR:
   - Make the list of items in a single row (use a-table if possible without 
borders, or use appropriate flex/grid?)
   - Edit form does not fill all the values of the row
   - Exported CSV does not match the data, as the csv from the old UI


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] rhtyd commented on issue #134: [WIP] IP Ranges form component for Public, Management and Storage traffic types

2020-02-03 Thread GitBox
rhtyd commented on issue #134: [WIP] IP Ranges form component for Public, 
Management and Storage traffic types
URL: 
https://github.com/apache/cloudstack-primate/pull/134#issuecomment-581385344
 
 
   @RitchieVincent for the public network IP range, can you show the 
domain/account reservation form in the main modal itself than the 
modal-in-a-modal format:
   
   ![Screenshot from 2020-02-03 
17-41-33](https://user-images.githubusercontent.com/95203/73652292-9832b280-46ac-11ea-8021-0885d08eabce.png)
   
   For example, use a radio button to show/hide whether admin wants reservation 
or not.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] rhtyd opened a new issue #142: Pagination in action forms

2020-02-03 Thread GitBox
rhtyd opened a new issue #142: Pagination in action forms
URL: https://github.com/apache/cloudstack-primate/issues/142
 
 
   Implement pagination support in action forms where a group of hosts, or VMs 
are listed. In some cases the page size is set at 500, but in very large 
environments this could cause an issue
   
   For example, VM migration form:
   ![Screenshot from 2020-02-03 
17-44-53](https://user-images.githubusercontent.com/95203/73652432-f6f82c00-46ac-11ea-915a-09de6d6af593.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[DISCUSS] blocker issue 3646 for 4.14/4.13.1

2020-02-03 Thread Daan Hoogland
People,
A ticket has been raised as a blocker but i don't think anybody here has
the resources to fix it. It is a regression of kinds, and a known issue but
in my not so humble opinion won't block anybody from using a future
release. The Issue [1] describes the problem and a PR [2] gives a partial
solution. It is known to work for a KVM/Ceph environment and thus might be
to specific.

I move that we either
1. find the PR that caused this and revert it, and/or
2. postpone fixing it till after 4.14 (unless someone has the resources and
volunteers to address it)
and as an ugly workaround (creating a cron job for your env that deletes
stale images) exists, unmark it as blocker.

[1] https://github.com/apache/cloudstack/issues/3646
[2] https://github.com/apache/cloudstack/pull/3649

any comments, please?
-- 
Daan


Re: [DISCUSS] blocker issue 3646 for 4.14/4.13.1

2020-02-03 Thread Andrija Panic
This issue is here from before (i.e. not new to 4.14), so we can argue it's
not technically a blocker due to regression happening in some previous
release, and I can live with it being moved to 4.15.

That being said, would be great to see it solved if this rings any bells
for anyone who might have played with the related code...

On Mon, 3 Feb 2020 at 13:21, Daan Hoogland  wrote:

> People,
> A ticket has been raised as a blocker but i don't think anybody here has
> the resources to fix it. It is a regression of kinds, and a known issue but
> in my not so humble opinion won't block anybody from using a future
> release. The Issue [1] describes the problem and a PR [2] gives a partial
> solution. It is known to work for a KVM/Ceph environment and thus might be
> to specific.
>
> I move that we either
> 1. find the PR that caused this and revert it, and/or
> 2. postpone fixing it till after 4.14 (unless someone has the resources and
> volunteers to address it)
> and as an ugly workaround (creating a cron job for your env that deletes
> stale images) exists, unmark it as blocker.
>
> [1] https://github.com/apache/cloudstack/issues/3646
> [2] https://github.com/apache/cloudstack/pull/3649
>
> any comments, please?
> --
> Daan
>


-- 

Andrija Panić


RE: [DISCUSS] blocker issue 3646 for 4.14/4.13.1

2020-02-03 Thread Paul Angus
Is there any kind of workaround or way to 'force' snapshots to be cleaned up 
(that doesn't create inconsistencies in CloudStack's view of the world vs the 
physical world?

paul.an...@shapeblue.com 
www.shapeblue.com
Amadeus House, Floral Street, London  WC2E 9DPUK
@shapeblue
  
 


-Original Message-
From: Andrija Panic  
Sent: 03 February 2020 16:35
To: dev 
Subject: Re: [DISCUSS] blocker issue 3646 for 4.14/4.13.1

This issue is here from before (i.e. not new to 4.14), so we can argue it's not 
technically a blocker due to regression happening in some previous release, and 
I can live with it being moved to 4.15.

That being said, would be great to see it solved if this rings any bells for 
anyone who might have played with the related code...

On Mon, 3 Feb 2020 at 13:21, Daan Hoogland  wrote:

> People,
> A ticket has been raised as a blocker but i don't think anybody here 
> has the resources to fix it. It is a regression of kinds, and a known 
> issue but in my not so humble opinion won't block anybody from using a 
> future release. The Issue [1] describes the problem and a PR [2] gives 
> a partial solution. It is known to work for a KVM/Ceph environment and 
> thus might be to specific.
>
> I move that we either
> 1. find the PR that caused this and revert it, and/or 2. postpone 
> fixing it till after 4.14 (unless someone has the resources and 
> volunteers to address it) and as an ugly workaround (creating a cron 
> job for your env that deletes stale images) exists, unmark it as 
> blocker.
>
> [1] https://github.com/apache/cloudstack/issues/3646
> [2] https://github.com/apache/cloudstack/pull/3649
>
> any comments, please?
> --
> Daan
>


-- 

Andrija Panić


[GitHub] [cloudstack-documentation] andrijapanicsb commented on a change in pull request #87: upgrade: upgrade systemvmtemplate for 4.14

2020-02-03 Thread GitBox
andrijapanicsb commented on a change in pull request #87: upgrade: upgrade 
systemvmtemplate for 4.14
URL: 
https://github.com/apache/cloudstack-documentation/pull/87#discussion_r374210501
 
 

 ##
 File path: source/upgrading/upgrade/upgrade_notes.rst
 ##
 @@ -18,15 +18,28 @@ General Upgrade Notes
 =
 
 
-Java version upgraded to Java 1.8
+Java version upgraded to Java 1.11
 -
 
-As of Apache CloudStack 4.10, Java version required is 1.8 for the
+As of Apache CloudStack 4.14, Java version required is 1.11 for the
 management-server, cloudstack-usage, KVM agent and system-VMs.
 
 
-.. include:: _java_8_ubuntu.rst
+.. include:: _java_version.rst
 
+UI Deprecation Notice
 
 Review comment:
   @rhtyd I don't see this whole section visible anywhere (in any of the 
specific version upgrade docs..) - I could include it myself somewhere, but not 
sure where is the best place - possibly in index page?
   
   And we should probably also add that we don't support CentOS 6 anymore.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-documentation] PaulAngus commented on a change in pull request #87: upgrade: upgrade systemvmtemplate for 4.14

2020-02-03 Thread GitBox
PaulAngus commented on a change in pull request #87: upgrade: upgrade 
systemvmtemplate for 4.14
URL: 
https://github.com/apache/cloudstack-documentation/pull/87#discussion_r374212890
 
 

 ##
 File path: source/upgrading/upgrade/upgrade_notes.rst
 ##
 @@ -18,15 +18,28 @@ General Upgrade Notes
 =
 
 
-Java version upgraded to Java 1.8
+Java version upgraded to Java 1.11
 -
 
-As of Apache CloudStack 4.10, Java version required is 1.8 for the
+As of Apache CloudStack 4.14, Java version required is 1.11 for the
 management-server, cloudstack-usage, KVM agent and system-VMs.
 
 
-.. include:: _java_8_ubuntu.rst
+.. include:: _java_version.rst
 
+UI Deprecation Notice
 
 Review comment:
   There is a compatibility section in the release notes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[DISCUSS] SIG for SDN Tungsten Fabric Network Plugin

2020-02-03 Thread Simon Weller
All,

During the 2019 CCC @ Apachecon North America, a few of us discussed the need 
for a new Software Defined Networking (SDN) integration for CloudStack, now 
that Nuage has chosen to depreciate their SDN product portfolio.
I've been working closely with Sven Vogel on outlining how we might be able to 
start a Special Interest Group (SIG) to design and build an ACS network plugin 
into the Linux Foundation project Tungsten Fabric (Formally known as Open 
Contrail).

Both Sven's company, EWERK and my company ENA are willing to contribute 
developers to this effort, as we feel it's important for Apache CloudStack to 
have a robust SDN option that utilizes a well known and stable open source SDN 
project and one that is community supported.
Although there is an existing plugin for Contrail that was originally 
contributed by Juniper, it has been orphaned in the ACS code base for many 
years and to my knowledge, it’s unusable.
Over the years, we've had a number of SDN integrations come and go. This has 
left users in the lurch and discouraged other potential companies from 
considering these options, as one has to be confident in the longevity of the 
plugin.

Why Tungsten Fabric?
Tungsten Fabric has been around for quite a while and it is now officially a 
Linux Foundation project, so it has a considerable amount of support behind it. 
It's scalable, multi-tenant, supports a number of advanced security features, 
as well a large chunk of built in components we currently need a Virtual Router 
to provide.
It's dual stack IPV4 and IPV6 and heavily utilizes BGP and MPLS. This makes it 
ideal for those of us that maintain our own networks, as it will provide tight 
integration options and eliminate the need for complicated Private Gateway (PG) 
setups for VPCs.
Additionally, with service stitching and EVPN capabilities, it will make it a 
lot easier for operators to support other platforms without having to build a 
dedicated plugin, or figure out how to support those network or security 
features through other L2/L3 hacks.

Sven and I would like to gauge feedback from the community on this proposal and 
see whether other organizations are interested in participating.

Thanks,

Sven and Simon


[GitHub] [cloudstack-documentation] andrijapanicsb commented on issue #87: upgrade: upgrade systemvmtemplate for 4.14

2020-02-03 Thread GitBox
andrijapanicsb commented on issue #87: upgrade: upgrade systemvmtemplate for 
4.14
URL: 
https://github.com/apache/cloudstack-documentation/pull/87#issuecomment-581510083
 
 
   requesting docbuild


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-documentation] ACSGitBot commented on issue #87: upgrade: upgrade systemvmtemplate for 4.14

2020-02-03 Thread GitBox
ACSGitBot commented on issue #87: upgrade: upgrade systemvmtemplate for 4.14
URL: 
https://github.com/apache/cloudstack-documentation/pull/87#issuecomment-581510121
 
 
   Your request had been received, i'll go and build the documentation and 
check the output log for errors.
   
   This shouldn't take long.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-documentation] ACSGitBot commented on issue #87: upgrade: upgrade systemvmtemplate for 4.14

2020-02-03 Thread GitBox
ACSGitBot commented on issue #87: upgrade: upgrade systemvmtemplate for 4.14
URL: 
https://github.com/apache/cloudstack-documentation/pull/87#issuecomment-581510961
 
 
   Build finished.  You can review it at:   
https://acs-www.shapeblue.com/docs/pr87
   
   Build Log Output:
   
   
   No log errors found to report.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: [DISCUSS] blocker issue 3646 for 4.14/4.13.1

2020-02-03 Thread Andrija Panic
I believe not - i.e. you can go and delete the files manually (but in some
cases there is also records not properly removed from the
snapshots_store_ref, for either primary or secondary kind, which makes it
more complicated...)

I can see Simon has asked his colleague to check it (comments on PR) -
fingers crossed.

On Mon, 3 Feb 2020 at 17:37, Paul Angus  wrote:

> Is there any kind of workaround or way to 'force' snapshots to be cleaned
> up (that doesn't create inconsistencies in CloudStack's view of the world
> vs the physical world?
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> Amadeus House, Floral Street, London  WC2E 9DPUK
> @shapeblue
>
>
>
>
> -Original Message-
> From: Andrija Panic 
> Sent: 03 February 2020 16:35
> To: dev 
> Subject: Re: [DISCUSS] blocker issue 3646 for 4.14/4.13.1
>
> This issue is here from before (i.e. not new to 4.14), so we can argue
> it's not technically a blocker due to regression happening in some previous
> release, and I can live with it being moved to 4.15.
>
> That being said, would be great to see it solved if this rings any bells
> for anyone who might have played with the related code...
>
> On Mon, 3 Feb 2020 at 13:21, Daan Hoogland 
> wrote:
>
> > People,
> > A ticket has been raised as a blocker but i don't think anybody here
> > has the resources to fix it. It is a regression of kinds, and a known
> > issue but in my not so humble opinion won't block anybody from using a
> > future release. The Issue [1] describes the problem and a PR [2] gives
> > a partial solution. It is known to work for a KVM/Ceph environment and
> > thus might be to specific.
> >
> > I move that we either
> > 1. find the PR that caused this and revert it, and/or 2. postpone
> > fixing it till after 4.14 (unless someone has the resources and
> > volunteers to address it) and as an ugly workaround (creating a cron
> > job for your env that deletes stale images) exists, unmark it as
> > blocker.
> >
> > [1] https://github.com/apache/cloudstack/issues/3646
> > [2] https://github.com/apache/cloudstack/pull/3649
> >
> > any comments, please?
> > --
> > Daan
> >
>
>
> --
>
> Andrija Panić
>


-- 

Andrija Panić


RE: [DISCUSS] blocker issue 3646 for 4.14/4.13.1

2020-02-03 Thread Paul Angus
Thanks.  My vote would be that it is a blocker, as there is no way to clean up 
and so storage filling up and crashing is a very real possibility.


paul.an...@shapeblue.com 
www.shapeblue.com
Amadeus House, Floral Street, London  WC2E 9DPUK
@shapeblue
  
 


-Original Message-
From: Andrija Panic  
Sent: 03 February 2020 16:58
To: dev 
Subject: Re: [DISCUSS] blocker issue 3646 for 4.14/4.13.1

I believe not - i.e. you can go and delete the files manually (but in some 
cases there is also records not properly removed from the snapshots_store_ref, 
for either primary or secondary kind, which makes it more complicated...)

I can see Simon has asked his colleague to check it (comments on PR) - fingers 
crossed.

On Mon, 3 Feb 2020 at 17:37, Paul Angus  wrote:

> Is there any kind of workaround or way to 'force' snapshots to be 
> cleaned up (that doesn't create inconsistencies in CloudStack's view 
> of the world vs the physical world?
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> Amadeus House, Floral Street, London  WC2E 9DPUK @shapeblue
>
>
>
>
> -Original Message-
> From: Andrija Panic 
> Sent: 03 February 2020 16:35
> To: dev 
> Subject: Re: [DISCUSS] blocker issue 3646 for 4.14/4.13.1
>
> This issue is here from before (i.e. not new to 4.14), so we can argue
> it's not technically a blocker due to regression happening in some previous
> release, and I can live with it being moved to 4.15.
>
> That being said, would be great to see it solved if this rings any bells
> for anyone who might have played with the related code...
>
> On Mon, 3 Feb 2020 at 13:21, Daan Hoogland 
> wrote:
>
> > People,
> > A ticket has been raised as a blocker but i don't think anybody here
> > has the resources to fix it. It is a regression of kinds, and a known
> > issue but in my not so humble opinion won't block anybody from using a
> > future release. The Issue [1] describes the problem and a PR [2] gives
> > a partial solution. It is known to work for a KVM/Ceph environment and
> > thus might be to specific.
> >
> > I move that we either
> > 1. find the PR that caused this and revert it, and/or 2. postpone
> > fixing it till after 4.14 (unless someone has the resources and
> > volunteers to address it) and as an ugly workaround (creating a cron
> > job for your env that deletes stale images) exists, unmark it as
> > blocker.
> >
> > [1] https://github.com/apache/cloudstack/issues/3646
> > [2] https://github.com/apache/cloudstack/pull/3649
> >
> > any comments, please?
> > --
> > Daan
> >
>
>
> --
>
> Andrija Panić
>


-- 

Andrija Panić


Re: [DISCUSS] blocker issue 3646 for 4.14/4.13.1

2020-02-03 Thread Gabriel Beims Bräscher
I would try as much as possible to have it merged into 4.14. Considering
that it is not simple to map all the garbage snapshots on secondary storage.

The proposed PR [1] should, in theory, fix also for XenServer. However, I
did not test it for XenServer so far.
Today I am deploying a XenServer cluster to check it. If someone else could
also hammer that PR and see if it works fine would be great :-)

[1] https://github.com/apache/cloudstack/pull/3649

Em seg., 3 de fev. de 2020 às 14:02, Paul Angus 
escreveu:

> Thanks.  My vote would be that it is a blocker, as there is no way to
> clean up and so storage filling up and crashing is a very real possibility.
>
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> Amadeus House, Floral Street, London  WC2E 9DPUK
> @shapeblue
>
>
>
>
> -Original Message-
> From: Andrija Panic 
> Sent: 03 February 2020 16:58
> To: dev 
> Subject: Re: [DISCUSS] blocker issue 3646 for 4.14/4.13.1
>
> I believe not - i.e. you can go and delete the files manually (but in some
> cases there is also records not properly removed from the
> snapshots_store_ref, for either primary or secondary kind, which makes it
> more complicated...)
>
> I can see Simon has asked his colleague to check it (comments on PR) -
> fingers crossed.
>
> On Mon, 3 Feb 2020 at 17:37, Paul Angus  wrote:
>
> > Is there any kind of workaround or way to 'force' snapshots to be
> > cleaned up (that doesn't create inconsistencies in CloudStack's view
> > of the world vs the physical world?
> >
> > paul.an...@shapeblue.com
> > www.shapeblue.com
> > Amadeus House, Floral Street, London  WC2E 9DPUK @shapeblue
> >
> >
> >
> >
> > -Original Message-
> > From: Andrija Panic 
> > Sent: 03 February 2020 16:35
> > To: dev 
> > Subject: Re: [DISCUSS] blocker issue 3646 for 4.14/4.13.1
> >
> > This issue is here from before (i.e. not new to 4.14), so we can argue
> > it's not technically a blocker due to regression happening in some
> previous
> > release, and I can live with it being moved to 4.15.
> >
> > That being said, would be great to see it solved if this rings any bells
> > for anyone who might have played with the related code...
> >
> > On Mon, 3 Feb 2020 at 13:21, Daan Hoogland 
> > wrote:
> >
> > > People,
> > > A ticket has been raised as a blocker but i don't think anybody here
> > > has the resources to fix it. It is a regression of kinds, and a known
> > > issue but in my not so humble opinion won't block anybody from using a
> > > future release. The Issue [1] describes the problem and a PR [2] gives
> > > a partial solution. It is known to work for a KVM/Ceph environment and
> > > thus might be to specific.
> > >
> > > I move that we either
> > > 1. find the PR that caused this and revert it, and/or 2. postpone
> > > fixing it till after 4.14 (unless someone has the resources and
> > > volunteers to address it) and as an ugly workaround (creating a cron
> > > job for your env that deletes stale images) exists, unmark it as
> > > blocker.
> > >
> > > [1] https://github.com/apache/cloudstack/issues/3646
> > > [2] https://github.com/apache/cloudstack/pull/3649
> > >
> > > any comments, please?
> > > --
> > > Daan
> > >
> >
> >
> > --
> >
> > Andrija Panić
> >
>
>
> --
>
> Andrija Panić
>


[GitHub] [cloudstack-primate] RitchieVincent opened a new pull request #143: [WIP] - VPC Router Tab: Implement List and Add Forms for each of the tabs

2020-02-03 Thread GitBox
RitchieVincent opened a new pull request #143: [WIP] - VPC Router Tab: 
Implement List and Add Forms for each of the tabs
URL: https://github.com/apache/cloudstack-primate/pull/143
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #144: [WIP] Custom upload action

2020-02-03 Thread GitBox
Pearl1594 opened a new pull request #144: [WIP] Custom upload action
URL: https://github.com/apache/cloudstack-primate/pull/144
 
 
   Renamed RegisterTemplate.vue to RegisterOrUploadTemplate.vue
   Handled upload of local template 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services