[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #116: [WIP] - Add LDAP Account Form
rhtyd commented on a change in pull request #116: [WIP] - Add LDAP Account Form
URL: https://github.com/apache/cloudstack-primate/pull/116#discussion_r368443937
##
File path: src/components/view/ActionButton.vue
##
@@ -44,7 +44,7 @@
v-if="action.api in $store.getters.apis &&
!action.showBadge &&
((!dataView && (action.listView || action.groupAction &&
selectedRowKeys.length > 0)) || (dataView && action.dataView)) &&
- ('show' in action ? action.show(resource, $store.getters.userInfo) :
true)"
+ ('show' in action ? action.show(resource, $store.getters.userInfo,
$store.getters.isLdapEnabled) : true)"
Review comment:
I'm thinking to get rid of this at this.$store must be accessible by all
parts of the code; or simply only pass $store.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #116: [WIP] - Add LDAP Account Form
rhtyd commented on issue #116: [WIP] - Add LDAP Account Form URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576185889 @utchoang is this ready for testing and reviewing? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #116: [WIP] - Add LDAP Account Form
utchoang commented on issue #116: [WIP] - Add LDAP Account Form URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576186590 @rhtyd Yes. Please review and let me know your comment This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #62: Custom Upload Action - Template, ISO, volume
rhtyd commented on issue #62: Custom Upload Action - Template, ISO, volume URL: https://github.com/apache/cloudstack-primate/issues/62#issuecomment-576195849 @utchoang I guess you can pick this one next, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #116: [WIP] - Add LDAP Account Form
rhtyd commented on issue #116: [WIP] - Add LDAP Account Form URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576195634 fantastic @utchoang I'll review and test and get back to you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd closed issue #39: Add LDAP Account Form
rhtyd closed issue #39: Add LDAP Account Form URL: https://github.com/apache/cloudstack-primate/issues/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #39: Add LDAP Account Form
rhtyd commented on issue #39: Add LDAP Account Form URL: https://github.com/apache/cloudstack-primate/issues/39#issuecomment-576197026 PR opened https://github.com/apache/cloudstack-primate/pull/116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #117: Add Secondary Storage Form
rhtyd commented on issue #117: Add Secondary Storage Form URL: https://github.com/apache/cloudstack-primate/issues/117#issuecomment-576197732 Assigned to Pearl. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] svenvogel commented on issue #116: [WIP] - Add LDAP Account Form
svenvogel commented on issue #116: [WIP] - Add LDAP Account Form URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576210572 @utchoang thanks! cool! is is possible to add a search filter for the user? if you have many user you will find it easier... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #108: Add Host Form
rhtyd commented on issue #108: Add Host Form URL: https://github.com/apache/cloudstack-primate/issues/108#issuecomment-576213513 Only to support: VMware, XenServer, KVM... Ovm3/Ovm... Old UI refs: https://github.com/apache/cloudstack/blob/master/ui/scripts/zoneWizard.js#L4372 https://raw.githubusercontent.com/apache/cloudstack/master/ui/scripts/system.js (search for addHost) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd opened a new issue #118: Add Pod form with dedicated option
rhtyd opened a new issue #118: Add Pod form with dedicated option URL: https://github.com/apache/cloudstack-primate/issues/118 UI->Infra->Pod-> Add Pod form See https://github.com/apache/cloudstack-primate/issues/106 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #115: Enable static NAT for VM form
rhtyd commented on issue #115: Enable static NAT for VM form URL: https://github.com/apache/cloudstack-primate/issues/115#issuecomment-576214449 MigrateVM... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: New joiner!
Welcome Vladi, really glad that we have another pair of testing hands on board with community! Looking forward! Bobby. On 16.01.20, 17:05, "Vladimir Petrov" wrote: Hello everyone, I'm happy to announce that I just joined ShapeBlue as a QA engineer. I have about 17 years of experience in different QA areas and I’m going to do my very best to further improve the quality of CloudStack project. Best wishes, Vladimir Petrov vladimir.pet...@shapeblue.com www.shapeblue.com Amadeus House, Floral Street, London WC2E 9DPUK @shapeblue boris.stoya...@shapeblue.com www.shapeblue.com Amadeus House, Floral Street, London WC2E 9DPUK @shapeblue
[GitHub] [cloudstack-primate] rhtyd closed issue #82: Review Primate Resource View Styling and Layout
rhtyd closed issue #82: Review Primate Resource View Styling and Layout URL: https://github.com/apache/cloudstack-primate/issues/82 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: New joiner!
Welcome Vladimir ! -Wei On Thu, 16 Jan 2020 at 16:05, Vladimir Petrov wrote: > Hello everyone, > > I'm happy to announce that I just joined ShapeBlue as a QA engineer. I > have about 17 years of experience in different QA areas and I’m going to do > my very best to further improve the quality of CloudStack project. > > Best wishes, > Vladimir Petrov > > vladimir.pet...@shapeblue.com > www.shapeblue.com > Amadeus House, Floral Street, London WC2E 9DPUK > @shapeblue > > > >
Re: [PRIMATE][SIG] Meeting Notes
20 Jan 2020 meeting notes: Project board: https://github.com/apache/cloudstack-primate/projects/1 Est. total effort left: ~150 hours Progress by number of supported APIs: ~81% (88 remaining APIs vs 461 APIs in old UI) High-level changes since last week: * Resource view and styling changes * Recurring snapshot schedule and take snapshot action form * Support for LDAP configuration management * Minor bug fixes and enhancements * In review - guest network tabs/actions, add network form, ldap account form, dedicated resource component, add cluster&host form * Work in progress: https://github.com/apache/cloudstack-primate/pulls Actions and goals for the next two weeks are to continue to work on issues from the project board, work towards manual QA and test-automation. Regards, Rohit Yadav Software Architect, ShapeBlue https://www.shapeblue.com From: Rohit Yadav Sent: Tuesday, January 14, 2020 15:11 To: dev@cloudstack.apache.org Subject: Re: [PRIMATE][SIG] Meeting Notes 14 Jan 2020 meeting notes: Project board: https://github.com/apache/cloudstack-primate/projects/1 Est. total effort left: ~170 hours Progress by number of supported APIs: 80% (95 remaining APIs vs 461 APIs in old UI) High-level changes since last two weeks: * Project dashboard, actions, configuration and actions * Register ISO action * Update offering access and update template permissions form * Zones tab for templates and ISOs * SG: ingress/egress tabs * Guest Network: Egress tab, firewall, pf, vpn, lb tabs (under review) * VPC: create VPN customer gateway, basic list views, tab stubs and navigations * Minor bug fixes and enhancements * Work in progress: https://github.com/apache/cloudstack-primate/pulls Actions and goals for the next two weeks are to continue to work on issues from the project board, work towards manual QA and test-automation. Regards, Rohit Yadav Software Architect, ShapeBlue https://www.shapeblue.com From: Rohit Yadav Sent: Monday, December 16, 2019 20:58 To: dev@cloudstack.apache.org Subject: Re: [PRIMATE][SIG] Meeting Notes 16 Dec 2019 meeting notes: Project board: https://github.com/apache/cloudstack-primate/projects/1 Est. total effort left: ~270 hours Progress by number of supported APIs: ~70% (138 remaining APIs vs 461 APIs in old UI) High-level changes since last two weeks: * Infra/SSL-cert setup form * Domain tree-based list view * Reusable settings component for global settings and scoped settings (in domain, accounts, zones, cluster, primary/secondary storages etc) * IAM: Account certs tab * Compute: VM migration form, assign to account/project form * Minor bug fixes and enhancements * Work in progress: * VM NIC/IP management buttons/views * Backup and recovery UI views and actions Actions and goals for the next two weeks are to continue to work on issues from the project board. Regards, Rohit Yadav Software Architect, ShapeBlue https://www.shapeblue.com From: Rohit Yadav Sent: Monday, December 2, 2019 22:39 To: dev@cloudstack.apache.org Subject: Re: [PRIMATE][SIG] Meeting Notes 2 Dec 2019 meeting notes: Project board: https://github.com/apache/cloudstack-primate/projects/1 Est. total effort left: ~300 hours Progress by number of supported APIs: ~68% (148 remaining APIs vs 461 APIs in old UI) High-level changes since last two weeks: * docker support (wip) + eslint fixes * all related navigation on views * recursive actions/async polling + refresh * reusable details setings for vm & templates * breadcrumb fixes * placement fixes, put actions in card * contextual doc links in views and actions * API remapping framework, most actions work now * infra:summary page, boilerplate code PRs: * Tree-like domain view (in review, Sven/Hoang/EWerk) * Infra/SSL cert setup form (in progress, Rohit/Shapeblue) * VM deployment wizard (in progress, Sven/Florian/EWerk) * Zone deployment (on-hold, Rohit/Shapeblue) Actions and goals for the next two weeks: Gabriel/PCExtreme: to pick a few UI issues from the board, Rohit to suggest easy tasks to start with Sven/EWerk: Continue on the VM deployment and new tasks (project, account views/tabs) Rohit/Shapeblue: write spec/requirements and details on project issues, progress on many of the design/arch issues as well as project board tasks Regards, Rohit Yadav Software Architect, ShapeBlue https://www.shapeblue.com From: Rohit Yadav Sent: Monday, November 18, 2019 18:31 To: dev@cloudstack.apache.org Subject: [PRIMATE][SIG] Meeting Notes 18 Nov 2019 High level: * Attendees - Bobby, Gabriel, Paul, Rohit * High-level project updates discussed: no major changes or significant work in last two weeks * Few bugs fixes and PRs merged in las
[GitHub] [cloudstack-primate] RitchieVincent opened a new pull request #119: [WIP] - Static nat form
RitchieVincent opened a new pull request #119: [WIP] - Static nat form URL: https://github.com/apache/cloudstack-primate/pull/119 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #116: [WIP] - Add LDAP Account Form
utchoang commented on issue #116: [WIP] - Add LDAP Account Form URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576475556 @svenvogel OK. I understood. @rhtyd I'll add new search filter and pagination for list users and you can review again... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #116: [WIP] - Add LDAP Account Form
utchoang commented on issue #116: [WIP] - Add LDAP Account Form URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576499056 @svenvogel According to http://cloudstack.apache.org/api/apidocs-4.13/apis/listLdapUsers.html. I did try to add search filter, however, this API does not support keyword filter or pagination. Thus, it is impossible to add search filter in this case. I have an alternative which is to filter on client only, not by API. What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #116: [WIP] - Add LDAP Account Form
rhtyd commented on issue #116: [WIP] - Add LDAP Account Form URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576503259 @utchoang you're right, you may refer to old code here: https://github.com/apache/cloudstack/blob/5ff932eb868e88f298b2fb54af8bbcc688a4cc29/ui/scripts/ui-custom/accountsWizard.js#L137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #116: [WIP] - Add LDAP Account Form
utchoang commented on issue #116: [WIP] - Add LDAP Account Form URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576508482 @rhtyd @svenvogel I added the search filter section in the Ldap users list. Please review and let me know the comments  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #113: [WIP] - Dedicated domain
rhtyd commented on issue #113: [WIP] - Dedicated domain URL: https://github.com/apache/cloudstack-primate/pull/113#issuecomment-576530493 @RitchieVincent ping me when this has been refactored out as a separate re-usable dedicated component (at least for the action form)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #116: [WIP] - Add LDAP Account Form
rhtyd commented on issue #116: [WIP] - Add LDAP Account Form URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576530672 @utchoang thanks, will review later today/tomorrow and get back to you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd merged pull request #84: Guest network: Egress, PF, FW, VPN, LB
rhtyd merged pull request #84: Guest network: Egress, PF, FW, VPN, LB URL: https://github.com/apache/cloudstack-primate/pull/84 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #116: [WIP] - Add LDAP Account Form
rhtyd commented on issue #116: [WIP] - Add LDAP Account Form URL: https://github.com/apache/cloudstack-primate/pull/116#issuecomment-576561653 @utchoang I started review it, looks like you still have git merge/branching issues. Did you follow the previously advised steps to fix your branch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
