DirectDownload feature implementation RFC
Hello guys, just tried direct download feature with Local Storage CloudStack Zone and found that it doesn't work. Quick search showed that https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java#L1694 Only StoragePoolType.NetworkFilesystem is supported. Is there is a reason for that? Why cannot it work with the local storage? NVasquez is the author of the PR where it's introduced, hope he can find a time to reply.
Re: DirectDownload feature implementation RFC
there is pending work which is going to provide pretty much full stuff, except i.e. managed storage. Planned for 4.14... On Mon, 13 Jan 2020, 09:21 Ivan Kudryavtsev, wrote: > Hello guys, > just tried direct download feature with Local Storage CloudStack Zone and > found that it doesn't work. Quick search showed that > > > https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java#L1694 > > Only StoragePoolType.NetworkFilesystem is supported. Is there is a reason > for that? > Why cannot it work with the local storage? > > NVasquez is the author of the PR where it's introduced, hope he can find a > time to reply. >
Re: DirectDownload feature implementation RFC
Andrija, thanks. Could you please give me a PR link if it exists, so I could take a look... On Mon, Jan 13, 2020 at 3:57 PM Andrija Panic wrote: > there is pending work which is going to provide pretty much full stuff, > except i.e. managed storage. Planned for 4.14... > > On Mon, 13 Jan 2020, 09:21 Ivan Kudryavtsev, wrote: > > > Hello guys, > > just tried direct download feature with Local Storage CloudStack Zone and > > found that it doesn't work. Quick search showed that > > > > > > > https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java#L1694 > > > > Only StoragePoolType.NetworkFilesystem is supported. Is there is a reason > > for that? > > Why cannot it work with the local storage? > > > > NVasquez is the author of the PR where it's introduced, hope he can find > a > > time to reply. > > >
Re: DirectDownload feature implementation RFC
Seems not - still cooking in-house! On Mon, 13 Jan 2020 at 10:03, Ivan Kudryavtsev wrote: > Andrija, thanks. Could you please give me a PR link if it exists, so I > could take a look... > > On Mon, Jan 13, 2020 at 3:57 PM Andrija Panic > wrote: > > > there is pending work which is going to provide pretty much full stuff, > > except i.e. managed storage. Planned for 4.14... > > > > On Mon, 13 Jan 2020, 09:21 Ivan Kudryavtsev, wrote: > > > > > Hello guys, > > > just tried direct download feature with Local Storage CloudStack Zone > and > > > found that it doesn't work. Quick search showed that > > > > > > > > > > > > https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java#L1694 > > > > > > Only StoragePoolType.NetworkFilesystem is supported. Is there is a > reason > > > for that? > > > Why cannot it work with the local storage? > > > > > > NVasquez is the author of the PR where it's introduced, hope he can > find > > a > > > time to reply. > > > > > > -- Andrija Panić
[GitHub] [cloudstack-primate] rhtyd merged pull request #103: config: fix existing access values display for update offering access
rhtyd merged pull request #103: config: fix existing access values display for update offering access URL: https://github.com/apache/cloudstack-primate/pull/103 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: DirectDownload feature implementation RFC
Andrija, please, if you have some kind of internal issue tracking and if it's possible to add a note, please add a wish for DD work for local storage KVM. I'm ready to provide the folks with a local storage dev cloud if extra HW is required for testing. Thanks a lot. On Mon, Jan 13, 2020 at 4:38 PM Andrija Panic wrote: > Seems not - still cooking in-house! > > On Mon, 13 Jan 2020 at 10:03, Ivan Kudryavtsev wrote: > > > Andrija, thanks. Could you please give me a PR link if it exists, so I > > could take a look... > > > > On Mon, Jan 13, 2020 at 3:57 PM Andrija Panic > > wrote: > > > > > there is pending work which is going to provide pretty much full stuff, > > > except i.e. managed storage. Planned for 4.14... > > > > > > On Mon, 13 Jan 2020, 09:21 Ivan Kudryavtsev, wrote: > > > > > > > Hello guys, > > > > just tried direct download feature with Local Storage CloudStack Zone > > and > > > > found that it doesn't work. Quick search showed that > > > > > > > > > > > > > > > > > > https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java#L1694 > > > > > > > > Only StoragePoolType.NetworkFilesystem is supported. Is there is a > > reason > > > > for that? > > > > Why cannot it work with the local storage? > > > > > > > > NVasquez is the author of the PR where it's introduced, hope he can > > find > > > a > > > > time to reply. > > > > > > > > > > > > -- > > Andrija Panić >
Re: DirectDownload feature implementation RFC
That's exactly cooking: - NFS – already supported · Local storage · SharedMountpoint On Mon, 13 Jan 2020 at 10:52, Ivan Kudryavtsev wrote: > Andrija, > > please, if you have some kind of internal issue tracking and if it's > possible to add a note, please add a wish for DD work for local storage > KVM. I'm ready to provide the folks with a local storage dev cloud if extra > HW is required for testing. > > Thanks a lot. > > On Mon, Jan 13, 2020 at 4:38 PM Andrija Panic > wrote: > > > Seems not - still cooking in-house! > > > > On Mon, 13 Jan 2020 at 10:03, Ivan Kudryavtsev wrote: > > > > > Andrija, thanks. Could you please give me a PR link if it exists, so I > > > could take a look... > > > > > > On Mon, Jan 13, 2020 at 3:57 PM Andrija Panic > > > > wrote: > > > > > > > there is pending work which is going to provide pretty much full > stuff, > > > > except i.e. managed storage. Planned for 4.14... > > > > > > > > On Mon, 13 Jan 2020, 09:21 Ivan Kudryavtsev, wrote: > > > > > > > > > Hello guys, > > > > > just tried direct download feature with Local Storage CloudStack > Zone > > > and > > > > > found that it doesn't work. Quick search showed that > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java#L1694 > > > > > > > > > > Only StoragePoolType.NetworkFilesystem is supported. Is there is a > > > reason > > > > > for that? > > > > > Why cannot it work with the local storage? > > > > > > > > > > NVasquez is the author of the PR where it's introduced, hope he can > > > find > > > > a > > > > > time to reply. > > > > > > > > > > > > > > > > > > -- > > > > Andrija Panić > > > -- Andrija Panić
Re: DirectDownload feature implementation RFC
Great to hear that! Thanks a lot. On Mon, Jan 13, 2020 at 5:06 PM Andrija Panic wrote: > That's exactly cooking: > > - NFS – already supported > > · Local storage > > · SharedMountpoint > > On Mon, 13 Jan 2020 at 10:52, Ivan Kudryavtsev wrote: > > > Andrija, > > > > please, if you have some kind of internal issue tracking and if it's > > possible to add a note, please add a wish for DD work for local storage > > KVM. I'm ready to provide the folks with a local storage dev cloud if > extra > > HW is required for testing. > > > > Thanks a lot. > > > > On Mon, Jan 13, 2020 at 4:38 PM Andrija Panic > > wrote: > > > > > Seems not - still cooking in-house! > > > > > > On Mon, 13 Jan 2020 at 10:03, Ivan Kudryavtsev wrote: > > > > > > > Andrija, thanks. Could you please give me a PR link if it exists, so > I > > > > could take a look... > > > > > > > > On Mon, Jan 13, 2020 at 3:57 PM Andrija Panic < > andrija.pa...@gmail.com > > > > > > > wrote: > > > > > > > > > there is pending work which is going to provide pretty much full > > stuff, > > > > > except i.e. managed storage. Planned for 4.14... > > > > > > > > > > On Mon, 13 Jan 2020, 09:21 Ivan Kudryavtsev, > wrote: > > > > > > > > > > > Hello guys, > > > > > > just tried direct download feature with Local Storage CloudStack > > Zone > > > > and > > > > > > found that it doesn't work. Quick search showed that > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java#L1694 > > > > > > > > > > > > Only StoragePoolType.NetworkFilesystem is supported. Is there is > a > > > > reason > > > > > > for that? > > > > > > Why cannot it work with the local storage? > > > > > > > > > > > > NVasquez is the author of the PR where it's introduced, hope he > can > > > > find > > > > > a > > > > > > time to reply. > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Andrija Panić > > > > > > > > -- > > Andrija Panić >
[GitHub] [cloudstack-primate] rhtyd commented on issue #84: [WIP] - Guest network: Many tabs
rhtyd commented on issue #84: [WIP] - Guest network: Many tabs URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-573600724 @RitchieVincent as discussed over call, few issues: - Show/hide VPN enable/disable button - Listing/going to the resource view fails for project (see browser console for errors) - Delete or list LB tab, loading continues - Good to have a fix: Refreshing resource view, selected tab resets in some cases - Add a new LB rule, add a VM to it, on refresh; VM list is empty - Revisit the LB tab This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-documentation] PaulAngus commented on issue #84: [WIP DO NOT MERGE] VM ingestion
PaulAngus commented on issue #84: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack-documentation/pull/84#issuecomment-573602483 requesting docbuild This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-documentation] ACSGitBot commented on issue #84: [WIP DO NOT MERGE] VM ingestion
ACSGitBot commented on issue #84: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack-documentation/pull/84#issuecomment-573602526 Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-documentation] ACSGitBot commented on issue #84: [WIP DO NOT MERGE] VM ingestion
ACSGitBot commented on issue #84: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack-documentation/pull/84#issuecomment-573603102 Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr84 Build Log Output: No log errors found to report. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
JIRA karma or someting
Hi all, can someone please grant me Star Wars karma to be able to edit pages on https://cwiki.apache.org/confluence/ My email address is: andrijapa...@apache.org Thanks, -- Andrija Panić
Re: JIRA karma or someting
gave you the default access, ping if it doesn't suffice (blogs/delete/etc) On Mon, Jan 13, 2020 at 2:47 PM Andrija Panic wrote: > Hi all, > > can someone please grant me Star Wars karma to be able to edit pages on > https://cwiki.apache.org/confluence/ > > My email address is: andrijapa...@apache.org > > Thanks, > > -- > > Andrija Panić > -- Daan
Re: CloudStack Kubernetes provider containers on DockerHub
Hi Paul, So we should not use our 2 account but use under apache one instead, correct? if so, I will remove all owner and projects from the 2 I've created a while back. they are outdated anyway so better hiding them then keep old stuff that can cause confusion. On Sun, Jan 12, 2020 at 4:10 PM Sven Vogel wrote: > Hi Paul, > > I agree! I would do the same If it’s possible. > > Cheers > > > __ > > Sven Vogel > Teamlead Platform > > EWERK DIGITAL GmbH > Brühl 24, D-04109 Leipzig > P +49 341 42649 - 99 > F +49 341 42649 - 98 > s.vo...@ewerk.com > www.ewerk.com > > Geschäftsführer: > Dr. Erik Wende, Hendrik Schubert, Frank Richter > Registergericht: Leipzig HRB 9065 > > Zertifiziert nach: > ISO/IEC 27001:2013 > DIN EN ISO 9001:2015 > DIN ISO/IEC 2-1:2011 > > EWERK-Blog | LinkedIn | Xing | Twitter | Facebook > > Auskünfte und Angebote per Mail sind freibleibend und unverbindlich. > > Disclaimer Privacy: > Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist > vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der > bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, > Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte > informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie > die E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. > Vielen Dank. > > The contents of this e-mail (including any attachments) are confidential > and may be legally privileged. If you are not the intended recipient of > this e-mail, any disclosure, copying, distribution or use of its contents > is strictly prohibited, and you should please notify the sender immediately > and then delete it (including any attachments) from your system. Thank you. > > Am 12.01.2020 um 21:40 schrieb Paul Angus : > > > > Hey Guys, > > > > Actually I've been meaning to get round to sorting this. We need to > remove 'our' docker hub account and use the Apache run one > > https://hub.docker.com/u/apache > > > > This came up on the Board mailing list with another project. We'll need > to align ourselves with the policy also. > > > > > > > > Kind regards > > > > > > Paul. > > > > paul.an...@shapeblue.com > > www.shapeblue.com > > Amadeus House, Floral Street, London WC2E 9DPUK > > @shapeblue > > > > > > > > > > -Original Message- > > From: Sven Vogel > > Sent: 12 January 2020 14:07 > > To: dev > > Cc: Pierre-Luc Dion ; Pierre-Luc Dion < > pd...@cloudops.com>; Will Stevens ; > gabrasc...@gmail.com; Wido den Hollander > > Subject: Re: CloudStack Kubernetes provider containers on DockerHub > > > > Hi Guys, > > > > Should we also find a ways to put the passwords accessible for all > committers or PMC like Youtube Account? > > > > Make that sense? > > > > Cheers > > > > Sven > > > > > > __ > > > > Sven Vogel > > Teamlead Platform > > > > EWERK DIGITAL GmbH > > Brühl 24, D-04109 Leipzig > > P +49 341 42649 - 99 > > F +49 341 42649 - 98 > > s.vo...@ewerk.com > > www.ewerk.com > > > > Geschäftsführer: > > Dr. Erik Wende, Hendrik Schubert, Frank Richter > > Registergericht: Leipzig HRB 9065 > > > > Zertifiziert nach: > > ISO/IEC 27001:2013 > > DIN EN ISO 9001:2015 > > DIN ISO/IEC 2-1:2011 > > > > EWERK-Blog | LinkedIn | Xing | Twitter | Facebook > > > > Auskünfte und Angebote per Mail sind freibleibend und unverbindlich. > > > > Disclaimer Privacy: > > Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) > ist vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der > bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, > Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte > informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie > die E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. > Vielen Dank. > > > > The contents of this e-mail (including any attachments) are confidential > and may be legally privileged. If you are not the intended recipient of > this e-mail, any disclosure, copying, distribution or use of its contents > is strictly prohibited, and you should please notify the sender immediately > and then delete it (including any attachments) from your system. Thank you. > >> Am 12.01.2020 um 07:17 schrieb Rohit Yadav : > >> > >> Hi PL, > >> > >> Thanks for replying. My dockerhub username is 'bhaisaab' [1]. Please > add me as an admin to both the groups. We can discuss later if we want to > favour one org name vs the other. > >> > >> [1] https://hub.docker.com/u/bhaisaab/ > >> > >> > >> Regards, > >> > >> Rohit Yadav > >> > >> Software Architect, ShapeBlue > >> > >> https://www.shapeblue.com > >> > >> > >> From: Pierre-Luc Dion > >> Sent: Friday, January 10, 2020 19:24 > >> To: dev@cloudstack.apache.org > >> Cc: Pierre-Luc Dion ; Will Stevens > >> ; gabrasc...@gmail.com ; > >> Wido den Hollander > >> Subject: Re: CloudStack Kubernetes provider containers on DockerHub > >> > >> hi, sorry for the la
Re: JIRA karma or someting
Now I can do some damage...! Thanks Daan. On Mon, 13 Jan 2020 at 14:56, Daan Hoogland wrote: > gave you the default access, ping if it doesn't suffice (blogs/delete/etc) > > On Mon, Jan 13, 2020 at 2:47 PM Andrija Panic > wrote: > > > Hi all, > > > > can someone please grant me Star Wars karma to be able to edit pages on > > https://cwiki.apache.org/confluence/ > > > > My email address is: andrijapa...@apache.org > > > > Thanks, > > > > -- > > > > Andrija Panić > > > > > -- > Daan > -- Andrija Panić
[GitHub] [cloudstack-primate] svenvogel commented on issue #99: [WIP] - Recurring Volume Snapshot Custom Action Form
svenvogel commented on issue #99: [WIP] - Recurring Volume Snapshot Custom Action Form URL: https://github.com/apache/cloudstack-primate/pull/99#issuecomment-57341 @utchoang from design looks good to me. if @rhtyd give okay after test we can merge it ... good work! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Your security@ needs YOU!
Hi John, is there a way to see who is on the security@ mailing list? At least to the PCM members? We need this list resurrected due to obvious reasons. Thanks, Andrija On Tue, 24 Sep 2019 at 18:49, John Kinsella wrote: > HI. WHAT'S WITH THE YELLING? :) > > I'm already on security@ and I actively monitor what goes there. About > 6 weeks ago a message came through which I missed and nobody else > responded to until ASF security reminded us about the post this > morning. > > While having people who "can/will do something" about issues, usually > with appsec you want people who can understand the security aspects, > and then engage developers familiar with the code to help with a fix. > Those who can fulfill both roles are a plus, but not required. > > John > ps - your email went into my spam folder... > > On Tue, Sep 24, 2019 at 5:04 AM Paul Angus wrote: > > > > HELLO? > > > > > > > > Have we enough ‘active’ security representatives? > > > > > > Please respond if you are ALREADY on the security maililing list and are > still willing/able to assist with CloudStack security issues. > > > > OR > > > > You AREN'T already on the security mailing list, but would like to > assist with security issues. Please note 'people with opinions' are > welcome, but we very much need 'people who can/will do something about' any > issues which are identified. > > > > > > Kind regards > > > > > > Paul Angus > -- Andrija Panić
Re: Your security@ needs YOU!
Ping ... I am here :) Cheers, Sven Vogel Apache CloudStack PMC On Tuesday, 01/14/2020 at 00:45 Andrija Panic wrote: Hi John, is there a way to see who is on the security@ mailing list? At least to the PCM members? We need this list resurrected due to obvious reasons. Thanks, Andrija On Tue, 24 Sep 2019 at 18:49, John Kinsella wrote: HI. WHAT'S WITH THE YELLING? :) I'm already on security@ and I actively monitor what goes there. About 6 weeks ago a message came through which I missed and nobody else responded to until ASF security reminded us about the post this morning. While having people who "can/will do something" about issues, usually with appsec you want people who can understand the security aspects, and then engage developers familiar with the code to help with a fix. Those who can fulfill both roles are a plus, but not required. John ps - your email went into my spam folder... On Tue, Sep 24, 2019 at 5:04 AM Paul Angus wrote: > > HELLO? > > > > Have we enough ‘active’ security representatives? > > > Please respond if you are ALREADY on the security maililing list and are still willing/able to assist with CloudStack security issues. > > OR > > You AREN'T already on the security mailing list, but would like to assist with security issues. Please note 'people with opinions' are welcome, but we very much need 'people who can/will do something about' any issues which are identified. > > > Kind regards > > > Paul Angus -- Andrija Panić
[GitHub] [cloudstack-primate] rhtyd commented on issue #100: [WIP] - Resource view style/layout improvement
rhtyd commented on issue #100: [WIP] - Resource view style/layout improvement URL: https://github.com/apache/cloudstack-primate/pull/100#issuecomment-573999190 @RitchieVincent ping - can you address styling issues? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #77: Guest Network: LB tab
rhtyd commented on issue #77: Guest Network: LB tab URL: https://github.com/apache/cloudstack-primate/issues/77#issuecomment-574011168 Handled in https://github.com/apache/cloudstack-primate/pull/84 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #93: Guest Network: VPN tab
rhtyd commented on issue #93: Guest Network: VPN tab URL: https://github.com/apache/cloudstack-primate/issues/93#issuecomment-574011130 Handled in https://github.com/apache/cloudstack-primate/pull/84 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd closed issue #77: Guest Network: LB tab
rhtyd closed issue #77: Guest Network: LB tab URL: https://github.com/apache/cloudstack-primate/issues/77 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd closed issue #93: Guest Network: VPN tab
rhtyd closed issue #93: Guest Network: VPN tab URL: https://github.com/apache/cloudstack-primate/issues/93 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd closed issue #76: Guest Network: Port Forwarding Tab
rhtyd closed issue #76: Guest Network: Port Forwarding Tab URL: https://github.com/apache/cloudstack-primate/issues/76 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd closed issue #75: Guest Network: Firewall Tab
rhtyd closed issue #75: Guest Network: Firewall Tab URL: https://github.com/apache/cloudstack-primate/issues/75 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #75: Guest Network: Firewall Tab
rhtyd commented on issue #75: Guest Network: Firewall Tab URL: https://github.com/apache/cloudstack-primate/issues/75#issuecomment-574011229 Handled in https://github.com/apache/cloudstack-primate/pull/84 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #76: Guest Network: Port Forwarding Tab
rhtyd commented on issue #76: Guest Network: Port Forwarding Tab URL: https://github.com/apache/cloudstack-primate/issues/76#issuecomment-574011202 Handled in https://github.com/apache/cloudstack-primate/pull/84 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd closed issue #74: Guest network: Egress rules tab
rhtyd closed issue #74: Guest network: Egress rules tab URL: https://github.com/apache/cloudstack-primate/issues/74 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #74: Guest network: Egress rules tab
rhtyd commented on issue #74: Guest network: Egress rules tab URL: https://github.com/apache/cloudstack-primate/issues/74#issuecomment-574011307 Handled in https://github.com/apache/cloudstack-primate/pull/84 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #92: [WIP] - Register Template Action
rhtyd commented on issue #92: [WIP] - Register Template Action URL: https://github.com/apache/cloudstack-primate/pull/92#issuecomment-574021233 @utchoang I've completed the review, made some fixes. However, the API request is not correct, for example all the extra options should be passed as `details`. For example, to register a VMware template with custom nic, storage controller, nic controller, this PR send this request:  And, the old UI sends this request:  @utchoang please refer to the API doc here: http://cloudstack.apache.org/api/apidocs-4.13/apis/registerTemplate.html ... and for reference please refer to the old code/implementation here: https://github.com/apache/cloudstack/blob/master/ui/scripts/templates.js#L123 cc @svenvogel This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd merged pull request #102: Add Template and ISO Zones tab
rhtyd merged pull request #102: Add Template and ISO Zones tab URL: https://github.com/apache/cloudstack-primate/pull/102 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #84: [WIP] - Guest network: Many tabs
rhtyd commented on issue #84: [WIP] - Guest network: Many tabs URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-574028610 @RitchieVincent ping - kindly update status, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #92: [WIP] - Register Template Action
utchoang commented on issue #92: [WIP] - Register Template Action URL: https://github.com/apache/cloudstack-primate/pull/92#issuecomment-574034540 @rhtyd Thanks for your respond. I have reviewed and fixed the params of the API. Please review again cc @svenvogel This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #99: [WIP] - Recurring Volume Snapshot Custom Action Form
rhtyd commented on issue #99: [WIP] - Recurring Volume Snapshot Custom Action Form URL: https://github.com/apache/cloudstack-primate/pull/99#issuecomment-574046988 @utchoang reviewed, LGTM except for this few issues: 1. Please always checkout new work/branch from origin/master, otherwise the PRs will have commits from other PRs/branches and will cause difficulties in reviewing them. I've fixed it manually for at least two PRs for now. 2. When I open the recurring action form the first time, I'm unable to list the timezones:  I've moved the timezone file/folder under utils and changed the import paths. It's also okay if instead of resolve/importing the json, you want to consume it as a static object/map. 3. While you're at it, can you also fix the createSnapshot form which takes in tags, which is not supported out of the box:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #92: [WIP] - Register Template Action
rhtyd commented on issue #92: [WIP] - Register Template Action URL: https://github.com/apache/cloudstack-primate/pull/92#issuecomment-574047805 @utchoang can you do another round of testing, it's not the KVM or VMware, all additional information of a template such as the disk controller, nic controller, keyboard and XenServer tool version (for example in case of xenserver) are all sent as `details` of the API request. Please ping me once you've checked all those params against the old implementation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
