[GitHub] [cloudstack-primate] RitchieVincent opened a new pull request #71: [WIP] - VM Hardware: NICs and IPs management

2019-12-15 Thread GitBox 
RitchieVincent opened a new pull request #71: [WIP] - VM Hardware: NICs and IPs 
management 
URL: https://github.com/apache/cloudstack-primate/pull/71
 
 
   #58 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack-primate] RitchieVincent commented on issue #71: [WIP] - VM Hardware: NICs and IPs management

2019-12-15 Thread GitBox 
RitchieVincent commented on issue #71: [WIP] - VM Hardware: NICs and IPs 
management 
URL: https://github.com/apache/cloudstack-primate/pull/71#issuecomment-565876876
 
 
   @rhtyd I've updated the async poll function to be inside a global plugin 
found in `src/utils/plugins.js`. If you're happy with that way of doing things 
let me know, and I can refactor the old methods to use this way.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack-primate] rhtyd commented on issue #71: [WIP] - VM Hardware: NICs and IPs management

2019-12-15 Thread GitBox 
rhtyd commented on issue #71: [WIP] - VM Hardware: NICs and IPs management 
URL: https://github.com/apache/cloudstack-primate/pull/71#issuecomment-565878856
 
 
   Thanks @RitchieVincent, I'll review and test, and get back to you. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack-primate] utchoang edited a comment on issue #41: Project View and Actions

2019-12-15 Thread GitBox 
utchoang edited a comment on issue #41: Project View and Actions
URL: 
https://github.com/apache/cloudstack-primate/issues/41#issuecomment-565899819
 
 
   @rhtyd @svenvogel 
   1. Please find my suggested UI for Project Accounts and Project Invitations. 
I'd like to have your comments.
   
![project_1](https://user-images.githubusercontent.com/13766648/70879100-b8bc8580-1ff6-11ea-843e-17a3dda57aee.png)
   
![project_2](https://user-images.githubusercontent.com/13766648/70879101-bb1edf80-1ff6-11ea-96e3-c20ed09433b9.png)
   
   2. Could you please explain how permissions to view Project Accounts and 
Project Invitations are granted?
   
   3. For the list of Project | Invitations as below, there are two options 
when selecting view:
   
![project_old_ui](https://user-images.githubusercontent.com/13766648/70879141-df7abc00-1ff6-11ea-8bf3-a9b07254a059.png)
   
   - Add "Select view" UI similar to the old UI
   - Add new tab in listview
   What would you think is the better option? Or if you have other idea, please 
let me know


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack-primate] utchoang commented on issue #41: Project View and Actions

2019-12-15 Thread GitBox 
utchoang commented on issue #41: Project View and Actions
URL: 
https://github.com/apache/cloudstack-primate/issues/41#issuecomment-565899819
 
 
   1. Please find my suggested UI for Project Accounts and Project Invitations. 
I'd like to have your comments.
   
![project_1](https://user-images.githubusercontent.com/13766648/70879100-b8bc8580-1ff6-11ea-843e-17a3dda57aee.png)
   
![project_2](https://user-images.githubusercontent.com/13766648/70879101-bb1edf80-1ff6-11ea-96e3-c20ed09433b9.png)
   
   2. Could you please explain how permissions to view Project Accounts and 
Project Invitations are granted?
   
   3. For the list of Project | Invitations as below, there are two options 
when selecting view:
   
![project_old_ui](https://user-images.githubusercontent.com/13766648/70879141-df7abc00-1ff6-11ea-8bf3-a9b07254a059.png)
   
   - Add "Select view" UI similar to the old UI
   - Add new tab in listview
   What would you think is the better option? Or if you have other idea, please 
let me know


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services