logger question

[Daan Hoogland]

devs,

The console proxy has its own logger, which is actually a wrapper around
log4j. Is there a compelling reason to keep it?

Background: We are using log4j sl4j and this wrapper in our code base but
as log4j2 is the de-facto standard I would like to unify them all and
upgrade.

​tnx​
-- 
Daan

Re: Can't create Basic Zone with master

[Tutkowski, Mike]

Yes, I can debug it more. I’m in the middle of some other task at the moment, 
so I might not be able to get to it until later this evening. In the meanwhile, 
I figured I’d send out the previous e-mail in case it might sound like 
something one of our networking devs recognize. :) Thanks!

On Oct 12, 2017, at 12:18 AM, Rohit Yadav 
mailto:rohit.ya...@shapeblue.com>> wrote:

Hi Mike,


I think you can repeat the process with 4.10 and compare with master as to 
which NetworkGuru is supposed to design and return you a network, then you can 
do some git log tracing to find what was changed and why the respective network 
guru is not returning a network. It could be environment/config issue or 
change/regression in code.


For local/nfs storage, and all three hypervisor no major regression was seen in 
last trillian smoke test runs.


- Rohit


From: Tutkowski, Mike 
mailto:mike.tutkow...@netapp.com>>
Sent: Thursday, October 12, 2017 1:17:50 AM
To: dev@cloudstack.apache.org
Subject: Re: Can't create Basic Zone with master

Hi Rohit,

I walked through the debugger with this and now have more info:

The following network gurus are leveraged to create networks successfully:

PublicNetworkGuru
PodBasedNetworkGuru
ControlNetworkGuru
StorageNetworkGuru

Once the zone-creation wizard reaches the “Enabling Security Group provider” 
part, NetworkOrchestrator.setupNetwork is again invoked and this time throws an 
exception.

It walks through all of its network gurus and none of them returns a pointer to 
a Network object.

   for (final NetworkGuru guru : networkGurus) {
   final Network network = guru.design(offering, plan, predefined, 
owner);
   if (network == null) {
   continue;
   }

Since no Network object was returned, the list of Network objects is empty and 
an exception is thrown.

Thanks,
Mike

On 10/11/17, 1:44 AM, "Rohit Yadav" 
mailto:rohit.ya...@shapeblue.com>> wrote:

   Mike,


   Can you re-deploy a fresh environment and see what's failing, stepping 
through the workflow. The specific line it's throwing exception is caused when 
there are no network (network size is 0) setup:


   
https://github.com/apache/cloudstack/blob/master/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java#L715


   - Rohit

   
   From: Tutkowski, Mike 
mailto:mike.tutkow...@netapp.com>>
   Sent: Wednesday, October 11, 2017 6:08:10 AM
   To: dev@cloudstack.apache.org
   Subject: Can't create Basic Zone with master

   Hi,

   I was trying to run the managed-storage regression test suite on PR 2018 
(https://github.com/apache/cloudstack/pull/2081) when I realized I couldn’t 
create a Basic Zone (using XenServer) with that code.

   I then took a step back from that PR and tried to create a Basic Zone 
(again, with XenServer) using master (specifically f1c01a5).

   After this didn’t work, I tried with the tag 4.10.0.0 (9d2893d) and it 
worked.

   As such, it appears somewhere along the way that we have introduced code 
into master that has broken the use case of creating a Basic Zone (at least 
with XenServer).

   It seems to be networking related.

   Here is the stack trace I’m getting:

   ERROR [c.c.a.ApiServer] (qtp708058685-279:ctx-a3ea1e98 ctx-b18fc696) 
(logid:ce86e7d9) unhandled exception executing api command: 
[Ljava.lang.String;@50361bfa
   com.cloud.utils.exception.CloudRuntimeException: Unable to convert network 
offering with specified id to network profile
   at 
org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.setupNetwork(NetworkOrchestrator.java:715)
   at 
org.apache.cloudstack.engine.orchestration.NetworkOrchestrator$10.doInTransaction(NetworkOrchestrator.java:2296)
   at 
org.apache.cloudstack.engine.orchestration.NetworkOrchestrator$10.doInTransaction(NetworkOrchestrator.java:2250)
   at com.cloud.utils.db.Transaction$2.doInTransaction(Transaction.java:50)
   at com.cloud.utils.db.Transaction.execute(Transaction.java:40)
   at com.cloud.utils.db.Transaction.execute(Transaction.java:47)
   at 
org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.createGuestNetwork(NetworkOrchestrator.java:2250)
   at 
com.cloud.network.NetworkServiceImpl$4.doInTransaction(NetworkServiceImpl.java:1411)
   at 
com.cloud.network.NetworkServiceImpl$4.doInTransaction(NetworkServiceImpl.java:1359)
   at com.cloud.utils.db.Transaction.execute(Transaction.java:40)
   at 
com.cloud.network.NetworkServiceImpl.commitNetwork(NetworkServiceImpl.java:1359)
   at 
com.cloud.network.NetworkServiceImpl.createGuestNetwork(NetworkServiceImpl.java:1322)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.jav

Re: [ANNOUNCE] Syed Mushtaq Ahmed has joined the PMC

[Nathan Johnson]

Congrats Syed!

Re: [ANNOUNCE] Syed Mushtaq Ahmed has joined the PMC

[Syed Ahmed]

Thanks guys :)
On Thu, Oct 12, 2017 at 10:19 AM Nathan Johnson 
wrote:

> Congrats Syed!
>

Re: Can't create Basic Zone with master

[Tutkowski, Mike]

It looks like this commit broke support for Basic Zones:

a06530d (Daan: Can you look into this?)

4.10

@Override
protected boolean canHandle(NetworkOffering offering, DataCenter dc) {
// this guru handles system Direct pod based network
if (dc.getNetworkType() == NetworkType.Basic && 
isMyTrafficType(offering.getTrafficType())) {
return true;
} else {
s_logger.trace("We only take care of Guest Direct Pod based networks");
return false;
}
}

master

@Override
protected boolean canHandle(NetworkOffering offering, DataCenter dc, 
PhysicalNetwork physnet) {
// this guru handles system Direct pod based network
if (dc.getNetworkType() == NetworkType.Basic && 
isMyTrafficType(offering.getTrafficType()) && isMyIsolationMethod(physnet)) {
return true;
} else {
s_logger.trace("We only take care of Guest Direct Pod based networks");
return false;
}
}

isMyIsolationMethod(physnet) fails (new to master):

protected boolean isMyIsolationMethod(PhysicalNetwork physicalNetwork) {
for (IsolationMethod m : _isolationMethods) {
if (physicalNetwork.getIsolationMethods().contains(m.toString())) {
return true;
}
}
return false;
}

_isolationMethods = new IsolationMethod[] { new IsolationMethod("VLAN") };

_isolationMethods is only of size = 1 and m.toString() returns “VLAN” whereas 
physicalNetwork.getIsolationMethods() is of size = 0. This method returns false 
and none of the network gurus can support the creation of a Basic Zone.

On 10/12/17, 7:03 AM, "Tutkowski, Mike"  wrote:

Yes, I can debug it more. I’m in the middle of some other task at the 
moment, so I might not be able to get to it until later this evening. In the 
meanwhile, I figured I’d send out the previous e-mail in case it might sound 
like something one of our networking devs recognize. :) Thanks!

On Oct 12, 2017, at 12:18 AM, Rohit Yadav 
mailto:rohit.ya...@shapeblue.com>> wrote:

Hi Mike,


I think you can repeat the process with 4.10 and compare with master as to 
which NetworkGuru is supposed to design and return you a network, then you can 
do some git log tracing to find what was changed and why the respective network 
guru is not returning a network. It could be environment/config issue or 
change/regression in code.


For local/nfs storage, and all three hypervisor no major regression was 
seen in last trillian smoke test runs.


- Rohit


From: Tutkowski, Mike 
mailto:mike.tutkow...@netapp.com>>
Sent: Thursday, October 12, 2017 1:17:50 AM
To: dev@cloudstack.apache.org
Subject: Re: Can't create Basic Zone with master

Hi Rohit,

I walked through the debugger with this and now have more info:

The following network gurus are leveraged to create networks successfully:

PublicNetworkGuru
PodBasedNetworkGuru
ControlNetworkGuru
StorageNetworkGuru

Once the zone-creation wizard reaches the “Enabling Security Group 
provider” part, NetworkOrchestrator.setupNetwork is again invoked and this time 
throws an exception.

It walks through all of its network gurus and none of them returns a 
pointer to a Network object.

   for (final NetworkGuru guru : networkGurus) {
   final Network network = guru.design(offering, plan, 
predefined, owner);
   if (network == null) {
   continue;
   }

Since no Network object was returned, the list of Network objects is empty 
and an exception is thrown.

Thanks,
Mike

On 10/11/17, 1:44 AM, "Rohit Yadav" 
mailto:rohit.ya...@shapeblue.com>> wrote:

   Mike,


   Can you re-deploy a fresh environment and see what's failing, stepping 
through the workflow. The specific line it's throwing exception is caused when 
there are no network (network size is 0) setup:


   
https://github.com/apache/cloudstack/blob/master/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java#L715


   - Rohit

   
   From: Tutkowski, Mike 
mailto:mike.tutkow...@netapp.com>>
   Sent: Wednesday, October 11, 2017 6:08:10 AM
   To: dev@cloudstack.apache.org
   Subject: Can't create Basic Zone with master

   Hi,

   I was trying to run the managed-storage regression test suite on PR 2018 
(https://github.com/apache/cloudstack/pull/2081) when I realized I couldn’t 
create a Basic Zone (using XenServer) with that code.

   I then took a step back from that PR and tried to create a Basic Zone 
(again, with XenServer) using master (specifically f1c01a5).

   After this didn’t work, I tried with the

[ANNOUNCE][SECURITY] Dnsmasq Vulnerability and CloudStack

[Rohit Yadav]

All,

Recently, a number of security flaws were recently found in the DNSMasq
tool. This tool is used by many systems to provide DNS and DHCP services,
including by the CloudStack System VMs.

CloudStack users can go through the following advisory to know more and how
to mitigate the issue in their environment:
https://blogs.apache.org/cloudstack/entry/dnsmasq-vulnerabilities-advisory-for-cloudstack

Regards.