Re: [VOTE] Apache CloudStack 4.10.0.0 RC5
> Op 20 juni 2017 om 21:35 schreef Kris Sterckx > : > > > I am sorry, I need to vote -1 :( Anybody else have an idea on how to proceed? We keep having issues popping up with 4.10 This should be fixable right for 4.10? We have so many work piling up for 4.11 right now, we should really get that going. Wido > > > https://github.com/apache/cloudstack/pull/2084 is causing password reset > issues for us (Nuage) (i know in native tests pass though...). > > We are trying to provide a fix but the following modified VR script is > having severe issues : > > https://github.com/apache/cloudstack/blob/master/systemvm/patches/debian/config/opt/cloud/bin/configure.py > : > > - import of CsPassword is missing > > - line 910 : this invocation of the constructor is invalid (ctor is def > __init__(self, dbag) ) > > Also i believe for SDN provided networks there is something overlooked as > we don't see the ip tables set for the VR to respond to password reset > requests. We believe the script is not setting iptables_change = True in > case of networks for which the VR is not in the dataplane. > > > I suggest this PR is backed out for now it this is not an urgent add to the > 4.10 release, or we spend time at fixing it. > > We definitely want to help in making that happen. > > > Thanks, > > Kris > > -- Nuage Networks > > On 20 June 2017 at 07:45, Rajani Karuturi wrote: > > > Hi All, > > > > I've created 4.10.0.0 release with the following artifacts up for a vote: > > > > Git Branch and Commit SH: > > https://github.com/apache/cloudstack/commit/058e34224c0555396c043c6473ac07 > > ab3e8424cd > > Commit:058e34224c0555396c043c6473ac07ab3e8424cd > > Branch: https://github.com/apache/cloudstack/tree/4.10.0.0-RC20170620T1023 > > > > Source release (checksums and signatures are available at the same > > location): > > https://dist.apache.org/repos/dist/dev/cloudstack/4.10.0.0/ > > > > SystemVm Templates: http://download.cloudstack.org/systemvm/4.10/RC5/ > > > > New PRs merged since RC4: #2150 and #2089 > > > > PGP release keys (signed using CBB44821): > > https://dist.apache.org/repos/dist/release/cloudstack/KEYS > > > > Vote will be open for 72 hours. > > > > For sanity in tallying the vote, can PMC members please be sure to indicate > > "(binding)" with their vote? > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove (and reason why) > > > > > > Thanks, > > ~Rajani > > http://cloudplatform.accelerite.com/ > >
Re: [VOTE] Apache CloudStack 4.10.0.0 RC5
It was an optimization that got merged and if someone is hindered we should back out and proceed, I’d say. On 21/06/17 16:00, "Wido den Hollander" wrote: > Op 20 juni 2017 om 21:35 schreef Kris Sterckx : > > > I am sorry, I need to vote -1 :( Anybody else have an idea on how to proceed? We keep having issues popping up with 4.10 This should be fixable right for 4.10? We have so many work piling up for 4.11 right now, we should really get that going. Wido > > > https://github.com/apache/cloudstack/pull/2084 is causing password reset > issues for us (Nuage) (i know in native tests pass though...). > > We are trying to provide a fix but the following modified VR script is > having severe issues : > > https://github.com/apache/cloudstack/blob/master/systemvm/patches/debian/config/opt/cloud/bin/configure.py > : > > - import of CsPassword is missing > > - line 910 : this invocation of the constructor is invalid (ctor is def > __init__(self, dbag) ) > > Also i believe for SDN provided networks there is something overlooked as > we don't see the ip tables set for the VR to respond to password reset > requests. We believe the script is not setting iptables_change = True in > case of networks for which the VR is not in the dataplane. > > > I suggest this PR is backed out for now it this is not an urgent add to the > 4.10 release, or we spend time at fixing it. > > We definitely want to help in making that happen. > > > Thanks, > > Kris > > -- Nuage Networks > daan.hoogl...@shapeblue.com www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue > On 20 June 2017 at 07:45, Rajani Karuturi wrote: > > > Hi All, > > > > I've created 4.10.0.0 release with the following artifacts up for a vote: > > > > Git Branch and Commit SH: > > https://github.com/apache/cloudstack/commit/058e34224c0555396c043c6473ac07 > > ab3e8424cd > > Commit:058e34224c0555396c043c6473ac07ab3e8424cd > > Branch: https://github.com/apache/cloudstack/tree/4.10.0.0-RC20170620T1023 > > > > Source release (checksums and signatures are available at the same > > location): > > https://dist.apache.org/repos/dist/dev/cloudstack/4.10.0.0/ > > > > SystemVm Templates: http://download.cloudstack.org/systemvm/4.10/RC5/ > > > > New PRs merged since RC4: #2150 and #2089 > > > > PGP release keys (signed using CBB44821): > > https://dist.apache.org/repos/dist/release/cloudstack/KEYS > > > > Vote will be open for 72 hours. > > > > For sanity in tallying the vote, can PMC members please be sure to indicate > > "(binding)" with their vote? > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove (and reason why) > > > > > > Thanks, > > ~Rajani > > http://cloudplatform.accelerite.com/ > >
Re: [VOTE] Apache CloudStack 4.10.0.0 RC5
Hi Wido, Daan, all We have just pushed a workaround https://github.com/apache/cloudstack/pull/2155 This works for us. The CsPassword class seems like not needed at all ? The important part for us is that iptables_change = True is set also in case of password handling. That was missing. Daan, we left a TODO for you to look into deeper though. We worked at getting the databag handling fixed inside the class but as we don't have full background, we kept hitting issues. Until we then saw that commenting out the lines which we did actually works as well. I suggest the /2155 is reviewed by the involved stakeholders and based on that we decide ? thanks and toi-toi :-) Kris
