Re: [apache/cloudstack] Vyos router plugin (#2105)

2017-06-03 Thread Matthew Smart 

This didn't go through the first time for some reason...

Hey guys,

I know this is going to take some time to merge. In the meantime, I am 
preparing my design for the next iteration of the plugin which will 
tentatively add DNS, DHCP, VPN, and maybe VRRP (redundant routing) 
support. I am not very familiar with GIT or the PR process. Assuming my 
design phase completes before my PR is merged how should I go about 
starting work on the next iteration of the plugin? Can I create a new 
branch from the branch that is waiting for the PR to be merged and make 
my changes there?


Thanks,

Matthew Smart
President
Smart Software Solutions Inc.
108 S Pierre St.
Pierre, SD 57501

Phone: (605) 280-0383
Skype: msmart13
Email: msm...@smartsoftwareinc.com



 Forwarded Message 
Subject:Re: [apache/cloudstack] Vyos router plugin (#2105)
Date:   Fri, 2 Jun 2017 15:47:37 -0500
From:   Matthew Smart 
To: 
reply+0133cbd45f36984313fd3e0860108796fac2fb386eb2d6d492cf0001153d1db792a169ce0da2c...@reply.github.com 





Hey guys,

I know this is going to take some time to merge. In the meantime, I am 
preparing my design for the next iteration of the plugin which will 
tentatively add DNS, DHCP, VPN, and maybe VRRP (redundant routing) 
support. I am not very familiar with GIT or the PR process. Assuming my 
design phase completes before my PR is merged how should I go about 
starting work on the next iteration of the plugin? Can I create a new 
branch from the branch that is waiting for the PR to be merged and make 
my changes there?


Thanks,

Matthew Smart
President
Smart Software Solutions Inc.
108 S Pierre St.
Pierre, SD 57501

Phone: (605) 280-0383
Skype: msmart13
Email:msm...@smartsoftwareinc.com

On 05/24/2017 05:08 AM, Blue Orangutan Build Things wrote:


Packaging result: ✔centos6 ✔centos7 ✔debian. JID-741

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub 
, 
or mute the thread 
.Web 
Bug from 
https://github.com/notifications/beacon/ATPL1CU8Qdww8m5wKxzpzxmhtOcv9OKMks5r9AG3gaJpZM4NbYdv.gif

RE: [apache/cloudstack] Vyos router plugin (#2105)

2017-06-03 Thread Paul Angus 
Hi Matthew,

I don't know how others feel about this, but I don't think that the core 
CloudStack code is the place for Proof-of-Concepts.  

I have nothing against your VyOS concept, in fact I have suggested it as an 
alternative in the past and I kicked off a Blue Orangutan build and looked at 
what you had done so far.

My personal feeling is that the we (you) need to have a branch which is kept in 
sync with master that is used for this work.  My 2p worth, is that the part 
that really needs PoC is refactoring the code such that the VyOS can be 
deployed in place of a VR, then that CloudStack can send commands to alternate 
'drivers' when configuring what it sees as a user created VR.

I really don't wish to  on your bonfire, I think that this is a great 
project I would love to help out with it...


Kind regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 


-Original Message-
From: Matthew Smart [mailto:msm...@smartsoftwareinc.com] 
Sent: 03 June 2017 12:50
To: dev@cloudstack.apache.org
Subject: Re: [apache/cloudstack] Vyos router plugin (#2105)

This didn't go through the first time for some reason...

Hey guys,

I know this is going to take some time to merge. In the meantime, I am 
preparing my design for the next iteration of the plugin which will tentatively 
add DNS, DHCP, VPN, and maybe VRRP (redundant routing) support. I am not very 
familiar with GIT or the PR process. Assuming my design phase completes before 
my PR is merged how should I go about starting work on the next iteration of 
the plugin? Can I create a new branch from the branch that is waiting for the 
PR to be merged and make my changes there?

Thanks,

Matthew Smart
President
Smart Software Solutions Inc.
108 S Pierre St.
Pierre, SD 57501

Phone: (605) 280-0383
Skype: msmart13
Email: msm...@smartsoftwareinc.com



 Forwarded Message 
Subject:Re: [apache/cloudstack] Vyos router plugin (#2105)
Date:   Fri, 2 Jun 2017 15:47:37 -0500
From:   Matthew Smart 
To: 
reply+0133cbd45f36984313fd3e0860108796fac2fb386eb2d6d492cf0001153d1d
reply+b792a169ce0da2c...@reply.github.com




Hey guys,

I know this is going to take some time to merge. In the meantime, I am 
preparing my design for the next iteration of the plugin which will tentatively 
add DNS, DHCP, VPN, and maybe VRRP (redundant routing) support. I am not very 
familiar with GIT or the PR process. Assuming my design phase completes before 
my PR is merged how should I go about starting work on the next iteration of 
the plugin? Can I create a new branch from the branch that is waiting for the 
PR to be merged and make my changes there?

Thanks,

Matthew Smart
President
Smart Software Solutions Inc.
108 S Pierre St.
Pierre, SD 57501

Phone: (605) 280-0383
Skype: msmart13
Email:msm...@smartsoftwareinc.com

On 05/24/2017 05:08 AM, Blue Orangutan Build Things wrote:
>
> Packaging result: ✔centos6 ✔centos7 ✔debian. JID-741
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub 
>  >,
> or mute the thread
>  15mP-6zmdwUneks5r9AG3gaJpZM4NbYdv>.Web
> Bug from
> https://github.com/notifications/beacon/ATPL1CU8Qdww8m5wKxzpzxmhtOcv9O
> KMks5r9AG3gaJpZM4NbYdv.gif
>

Re: [apache/cloudstack] Vyos router plugin (#2105)

2017-06-03 Thread Rene Moser 
Hi Matthew

On 06/03/2017 01:50 PM, Matthew Smart wrote:
> This didn't go through the first time for some reason...
> 
> Hey guys,
> 
> I know this is going to take some time to merge. In the meantime, I am
> preparing my design for the next iteration of the plugin which will
> tentatively add DNS, DHCP, VPN, and maybe VRRP (redundant routing)
> support. I am not very familiar with GIT or the PR process. Assuming my
> design phase completes before my PR is merged how should I go about
> starting work on the next iteration of the plugin? Can I create a new
> branch from the branch that is waiting for the PR to be merged and make
> my changes there?

This is possible, just branch off from that branch by

# change to the vyos branch
git checkout 

# branch off
git checkout -b ".

But be aware that if you change your origin branch, it can cause merge
conflicts. While conflicts are not generally a problem, it can cause
some headache if you are not familiar with it.

In case that happens or if you have questions, don't hesitate to ask
here again.

Regards
René

Re: [apache/cloudstack] Vyos router plugin (#2105)

2017-06-03 Thread Will Stevens 
Hey Matthew,
I recommend what Rene proposed as well.

Will

On Jun 3, 2017 10:26 AM, "Rene Moser"  wrote:

> Hi Matthew
>
> On 06/03/2017 01:50 PM, Matthew Smart wrote:
> > This didn't go through the first time for some reason...
> >
> > Hey guys,
> >
> > I know this is going to take some time to merge. In the meantime, I am
> > preparing my design for the next iteration of the plugin which will
> > tentatively add DNS, DHCP, VPN, and maybe VRRP (redundant routing)
> > support. I am not very familiar with GIT or the PR process. Assuming my
> > design phase completes before my PR is merged how should I go about
> > starting work on the next iteration of the plugin? Can I create a new
> > branch from the branch that is waiting for the PR to be merged and make
> > my changes there?
>
> This is possible, just branch off from that branch by
>
> # change to the vyos branch
> git checkout 
>
> # branch off
> git checkout -b ".
>
> But be aware that if you change your origin branch, it can cause merge
> conflicts. While conflicts are not generally a problem, it can cause
> some headache if you are not familiar with it.
>
> In case that happens or if you have questions, don't hesitate to ask
> here again.
>
> Regards
> René
>
>
>

Re: [apache/cloudstack] Vyos router plugin (#2105)

2017-06-03 Thread Matthew Smart 

Hey Paul,

I appreciate the feedback. Building the Vyos integration to the point 
where it can be deployed by ACS in place of the VR is the ultimate goal. 
I plan to get there iteratively though with releases that are functional 
for a subset of the VR functionality. That way it gets the code out in 
the wild and some feedback to me as I work. It is quite an undertaking 
to do the full replacement and it seems prudent to release often 
especially since this is my first ACS contribution. I would certainly 
not refuse any help that is on offer.


That being said, the current PR is fully functional and has feature 
parity with the current Palo Alto Firewall plugin. It is usable in its 
current state. There is one major security issue I am working on right 
now regarding ssh access but other than that it is ready for deployment 
(wouldn't recommend production use yet of course since it has not been 
tested).


Thanks,

Matthew Smart
President
Smart Software Solutions Inc.
108 S Pierre St.
Pierre, SD 57501

Phone: (605) 280-0383
Skype: msmart13
Email: msm...@smartsoftwareinc.com

On 06/03/2017 09:15 AM, Paul Angus wrote:

Hi Matthew,

I don't know how others feel about this, but I don't think that the core 
CloudStack code is the place for Proof-of-Concepts.

I have nothing against your VyOS concept, in fact I have suggested it as an 
alternative in the past and I kicked off a Blue Orangutan build and looked at 
what you had done so far.

My personal feeling is that the we (you) need to have a branch which is kept in 
sync with master that is used for this work.  My 2p worth, is that the part 
that really needs PoC is refactoring the code such that the VyOS can be 
deployed in place of a VR, then that CloudStack can send commands to alternate 
'drivers' when configuring what it sees as a user created VR.

I really don't wish to  on your bonfire, I think that this is a great 
project I would love to help out with it...


Kind regards,

Paul Angus

paul.an...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
   
  



-Original Message-
From: Matthew Smart [mailto:msm...@smartsoftwareinc.com]
Sent: 03 June 2017 12:50
To: dev@cloudstack.apache.org
Subject: Re: [apache/cloudstack] Vyos router plugin (#2105)

This didn't go through the first time for some reason...

Hey guys,

I know this is going to take some time to merge. In the meantime, I am 
preparing my design for the next iteration of the plugin which will tentatively 
add DNS, DHCP, VPN, and maybe VRRP (redundant routing) support. I am not very 
familiar with GIT or the PR process. Assuming my design phase completes before 
my PR is merged how should I go about starting work on the next iteration of 
the plugin? Can I create a new branch from the branch that is waiting for the 
PR to be merged and make my changes there?

Thanks,

Matthew Smart
President
Smart Software Solutions Inc.
108 S Pierre St.
Pierre, SD 57501

Phone: (605) 280-0383
Skype: msmart13
Email: msm...@smartsoftwareinc.com



 Forwarded Message 
Subject:Re: [apache/cloudstack] Vyos router plugin (#2105)
Date:   Fri, 2 Jun 2017 15:47:37 -0500
From:   Matthew Smart 
To:
reply+0133cbd45f36984313fd3e0860108796fac2fb386eb2d6d492cf0001153d1d
reply+b792a169ce0da2c...@reply.github.com




Hey guys,

I know this is going to take some time to merge. In the meantime, I am 
preparing my design for the next iteration of the plugin which will tentatively 
add DNS, DHCP, VPN, and maybe VRRP (redundant routing) support. I am not very 
familiar with GIT or the PR process. Assuming my design phase completes before 
my PR is merged how should I go about starting work on the next iteration of 
the plugin? Can I create a new branch from the branch that is waiting for the 
PR to be merged and make my changes there?

Thanks,

Matthew Smart
President
Smart Software Solutions Inc.
108 S Pierre St.
Pierre, SD 57501

Phone: (605) 280-0383
Skype: msmart13
Email:msm...@smartsoftwareinc.com

On 05/24/2017 05:08 AM, Blue Orangutan Build Things wrote:

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-741

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
.Web
Bug from
https://github.com/notifications/beacon/ATPL1CU8Qdww8m5wKxzpzxmhtOcv9O
KMks5r9AG3gaJpZM4NbYdv.gif