[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack
Github user rajesh-battala commented on the issue: https://github.com/apache/cloudstack/pull/1859 Can you please share the test cases and Test plan executed for this feature. It would be great if community knows the testing done on this feature and its coverage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov Thanks. Can you check in B.O. what is value of global configuration 'vmware.create.full.clone', if the same configuration is set for the primary storage pool and if so what is the value ? @priyankparihar Based on the exception it looks like B.O. Is set to use link clones but test doesn't handle it intended way. How about you temporary alter 'vmware.create.full.clone' to make it true for the PS pool used during the test and then revert it back to the original value. You can use similar to below to alter flag just for the PS pool: updateConfigurationCmd = updateConfiguration.updateConfigurationCmd() updateConfigurationCmd.name = "vmware.create.full.clone" updateConfigurationCmd.value = "true" updateConfigurationCmd.storageid = pool.id updateConfigurationResponse = self.apiClient.updateConfiguration(updateConfigurationCmd) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1269: CLOUDSTACK-8867: Added retry logic to reconne...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1269: CLOUDSTACK-8867: Added retry logic to reconne...
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1269 CLOUDSTACK-8867: Added retry logic to reconnect to host on connection termination to console It also improves handling of sessions to hypervisor in console proxy https://issues.apache.org/jira/browse/CLOUDSTACK-8867 To test: Try on XenServer setup as frequent disconnections are more common for XenServer. Try random key combinations on VM console and see after fix console access denied errors are less frequent. You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-8867-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1269.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1269 commit 79e6d9f3b8bb9ecc9a515c9e1c4a2b6969a8f94e Author: Anshul Gangwar Date: 2015-09-16T04:45:32Z CLOUDSTACK-8867: Added retry logic to reconnect to host on connection termination to console. It also improves handling of sessions to hypervisor in console proxy --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1845: CLOUDSTACK-9689: [Hyper-V] Fixed VM console i...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1845#discussion_r104339191
--- Diff:
services/console-proxy-rdp/rdpconsole/src/main/java/streamer/apr/AprSocketSource.java
---
@@ -103,44 +103,46 @@ public void poll(boolean block) {
if (verbose)
System.out.println("[" + this + "] INFO: Reading data from
stream.");
-// to unblock during reboot
-long startTime = System.currentTimeMillis();
// FIXME: If pull is destroyed or socket is closed, segfault
will happen here
-int actualLength = (block) ? // Blocking read
-Socket.recv(socket, buf.data, buf.offset,
buf.data.length - buf.offset)
-: // Non-blocking read
-Socket.recvt(socket, buf.data, buf.offset,
buf.data.length - buf.offset, 500);
+int actualLength;
+if(block) {
+// Blocking read
+actualLength = Socket.recv(socket, buf.data, buf.offset,
buf.data.length - buf.offset);
+} else {
+// non blocking read with 5 seconds timeout
+Socket.timeoutSet(socket, 500);
+actualLength = Socket.recv(socket, buf.data, buf.offset,
buf.data.length - buf.offset);
--- End diff --
@ramkatru, Will try that and get back to you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @GabrielBrascher @rafaelweingartner, Please go through deployment planner code. Deployment planner decides the VM placement and virtual router also goes through that. Deployment planners uses allocators and planners. In those planners and allocators you will find the admin account related checks as pointed out in one of my previous comment. My intent to point out those old commits of Calling context introduction was that with that introduction there is calling context is passed around implicit. Here the code changes are making sure that context gets changed to proper user. Hope this clears your doubt. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1989: WIP: support for multidisk OVA files
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1989 WIP: support for multidisk OVA files Signed-off-by: Abhinandan Prateek You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack multidisk-OVA Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1989.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1989 commit f8a0494d0420dc6b847e6e2f80139942c31a0847 Author: Abhinandan Prateek Date: 2017-03-06T05:04:16Z support for multidisk OVA files Signed-off-by: Abhinandan Prateek --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1978: CLOUDSTACK-9779 : Releasing secondary guest IP fails...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1978 This is Ready to Merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1987: CLOUDSTACK-9814 : Unable to edit a Sub domain, which...
Github user jayantpatil1234 commented on the issue: https://github.com/apache/cloudstack/pull/1987 I have tested this and **LGTM** for test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1987: CLOUDSTACK-9814 : Unable to edit a Sub domain, which...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1987 This is Ready to Merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1813 @serg38 it's: `vmware.create.full.clone FALSE ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: 'concurrent.snapshots.threshold.per...
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1776 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1726 I have tested this and **LGTM** for test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1779 Looks good to me, @rhtyd are your concerns met? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
