Re: Modern template hosting

2017-02-28 Thread Daan Hoogland
On Tue, Feb 28, 2017 at 2:40 AM, Pierre-Luc Dion  wrote:
> For our systemvm templates, can we just change the URL for somthing like
> cloudstack.apache.org/systemvm/... ?

I agree,
is there any change we can host a domain for this at apache, if we
can't keep downloads.cloud.com then maybe downloads.cloudstack.com. To
many people are used to this this way of working and a patch for a
name change is the easiest. Devising a new mechanism is nice but a
different job, is it?

-- 
Daan


[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1954
  
Thanks @dmabry looks like this has been already merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1974: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1974
  
LGTM, looks like we'll have to backport by cherry-picking this given the PR 
for master has been merged. Thanks @dmabry 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-28 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1960#discussion_r103221221
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/host/PrepareForMaintenanceCmd.java
 ---
@@ -108,4 +108,8 @@ public void execute() {
 throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, 
"Failed to prepare host for maintenance");
 }
 }
+
+public void setHostId(final Long hostId) {
--- End diff --

naming: consistency would dictate this be called setId()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1257
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware...

2017-02-28 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1302
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1241: CLOUDSTACK-9162: Unable to add VPN user via API with...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1241
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1241: CLOUDSTACK-9162: Unable to add VPN user via API with...

2017-02-28 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1241
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-28 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1960#discussion_r103221397
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ChangeOutOfBandManagementPasswordCmd.java
 ---
@@ -74,7 +74,7 @@ public void execute() throws 
ResourceUnavailableException, InsufficientCapacityE
 CallContext.current().setEventDetails("Host Id: " + host.getId() + 
" Password: " + getPassword().charAt(0) + "");
 CallContext.current().putContextParameter(Host.class, 
host.getUuid());
 
-final OutOfBandManagementResponse response = 
outOfBandManagementService.changeOutOfBandManagementPassword(host, 
getPassword());
+final OutOfBandManagementResponse response = 
outOfBandManagementService.changePassword(host, getPassword());
--- End diff --

:+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1302
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2017-02-28 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1257
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-28 Thread DaanHoogland
Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1960
  
I went through the code and found no real issues. for any other reviewers I 
recommend reading the FS first. It is quit a big chunk but very neat.

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1960#discussion_r103397573
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/ha/DisableHAForClusterCmd.java 
---
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.ha;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.org.Cluster;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiArgValidator;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.ClusterResponse;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.cloudstack.ha.HAConfigManager;
+
+import javax.inject.Inject;
+
+@APICommand(name = DisableHAForClusterCmd.APINAME, description = "Disables 
HA cluster-wide",
--- End diff --

@DaanHoogland can you illustrate an example where we may hit such a 
conflict? This API actually disables the feature (framework etc) for 
cluster/zone etc. While the Host specific APIs work on the host.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1960#discussion_r103397882
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/host/PrepareForMaintenanceCmd.java
 ---
@@ -108,4 +108,8 @@ public void execute() {
 throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, 
"Failed to prepare host for maintenance");
 }
 }
+
+public void setHostId(final Long hostId) {
--- End diff --

I think the setters and getters are named per the variable, since the 
variable is hostId IDEs generate getHostId, setHostId named methods.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1960
  
Thanks @DaanHoogland wherever applicable I'll address the comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-28 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
Thanks everyone. merging this now. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1768: CLOUDSTACK 9601: Upgrade: change logic for up...

2017-02-28 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1768


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Modern template hosting

2017-02-28 Thread Erik Weber
On Tue, Feb 28, 2017 at 8:59 AM, Daan Hoogland  wrote:
> On Tue, Feb 28, 2017 at 2:40 AM, Pierre-Luc Dion  wrote:
>> For our systemvm templates, can we just change the URL for somthing like
>> cloudstack.apache.org/systemvm/... ?
>
> I agree,
> is there any change we can host a domain for this at apache, if we
> can't keep downloads.cloud.com then maybe downloads.cloudstack.com. To
> many people are used to this this way of working and a patch for a
> name change is the easiest. Devising a new mechanism is nice but a
> different job, is it?

packages.apache.org exists.

Has been discussed before in a thread called 'Package Repositories'.

One thing that should be focused on is that if we go the ASF hosted
route, we should be able to update the content without involving ASF
Infra team.

-- 
Erik


[GitHub] cloudstack issue #1241: CLOUDSTACK-9162: Unable to add VPN user via API with...

2017-02-28 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1241
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-542


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2017-02-28 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1257
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-544


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware...

2017-02-28 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1302
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-543


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1257
  
@blueorangutan test centos7 vmware-55u3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2017-02-28 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1257
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1302#discussion_r103404351
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2226,17 +2227,33 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 return new String[] {datastoreDiskPath};
 }
 
-// Pair
-private Pair composeVmNames(VirtualMachineTO vmSpec) {
-String vmInternalCSName = vmSpec.getName();
-String vmNameOnVcenter = vmSpec.getName();
-if (_instanceNameFlag && vmSpec.getHostName() != null) {
-vmNameOnVcenter = vmSpec.getHostName();
+/**
+ * This method generates VM name for Vcenter and Cloudstack( when 
Hypervisor is VMware).
+ * It generates VM name according to  _instanceNameFlag setting.
+ *
+ * @param VirtualMachineTO
+ *vmSpec
+ * @return Pair. A pair which 
contain 'internal CS name'  and
+ * 'vCenter display name'(vCenter knows VM by this name).
+ **/
+protected Pair composeVmNames(VirtualMachineTO vmSpec) 
{
+
--- End diff --

- Why is the method attribute changed from private to protected?
- If vmspec is null, this method should throw an exception, to avoid a 
situation where empty vmnames are returned. Discuss?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1302#discussion_r103404645
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2226,17 +2227,33 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 return new String[] {datastoreDiskPath};
 }
 
-// Pair
-private Pair composeVmNames(VirtualMachineTO vmSpec) {
-String vmInternalCSName = vmSpec.getName();
-String vmNameOnVcenter = vmSpec.getName();
-if (_instanceNameFlag && vmSpec.getHostName() != null) {
-vmNameOnVcenter = vmSpec.getHostName();
+/**
+ * This method generates VM name for Vcenter and Cloudstack( when 
Hypervisor is VMware).
+ * It generates VM name according to  _instanceNameFlag setting.
+ *
+ * @param VirtualMachineTO
+ *vmSpec
+ * @return Pair. A pair which 
contain 'internal CS name'  and
+ * 'vCenter display name'(vCenter knows VM by this name).
+ **/
+protected Pair composeVmNames(VirtualMachineTO vmSpec) 
{
+
+String vmInternalCSName = "";
+String vmNameOnVcenter  = "";
+if(vmSpec != null)
+{
+vmInternalCSName = vmNameOnVcenter = vmSpec.getName();
+if (_instanceNameFlag == true && vmSpec.getType() == 
VirtualMachine.Type.User) {
--- End diff --

If _instanceNameFlag is boolean, so there is no need of an explicit `== 
true`. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1302#discussion_r103405279
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2226,17 +2227,33 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 return new String[] {datastoreDiskPath};
 }
 
-// Pair
-private Pair composeVmNames(VirtualMachineTO vmSpec) {
-String vmInternalCSName = vmSpec.getName();
-String vmNameOnVcenter = vmSpec.getName();
-if (_instanceNameFlag && vmSpec.getHostName() != null) {
-vmNameOnVcenter = vmSpec.getHostName();
+/**
+ * This method generates VM name for Vcenter and Cloudstack( when 
Hypervisor is VMware).
+ * It generates VM name according to  _instanceNameFlag setting.
+ *
+ * @param VirtualMachineTO
+ *vmSpec
+ * @return Pair. A pair which 
contain 'internal CS name'  and
+ * 'vCenter display name'(vCenter knows VM by this name).
+ **/
+protected Pair composeVmNames(VirtualMachineTO vmSpec) 
{
+
+String vmInternalCSName = "";
+String vmNameOnVcenter  = "";
+if(vmSpec != null)
+{
+vmInternalCSName = vmNameOnVcenter = vmSpec.getName();
+if (_instanceNameFlag == true && vmSpec.getType() == 
VirtualMachine.Type.User) {
+String[] tokens = vmInternalCSName.split("-");
+if(tokens.length<3) throw new 
InvalidParameterValueException("Invalid vmInternalCSName format: 
"+vmInternalCSName+" expected format : *-*-* (e.g -> i-x-y)"); // 
vmInternalCSName has format i-x-y-
+vmNameOnVcenter = String.format("%s-%s-%s-%s", tokens[0], 
tokens[1], tokens[2], vmSpec.getHostName());
--- End diff --

The token length comparison may break backward compatibility for existing 
VMs that may not conform to this scheme. Also, assuming the token length is 3 
the line can be written as:
`vmNameOnVcenter = String.format("%s-%s", vmInternalCSName, 
vmSpec.getHostName());`

As per previous code, `vmNameOnVcenter = vmSpec.getHostName()`, which will 
introduce backward compatibility issues for older 4.3 environments. Is there 
any code that handles for such old VMs. If a 4.3 user decides to upgrade to 
4.10+, their VMs might not start the next time someone restarts. Please comment 
on how the change addresses backward compatibility issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1302#discussion_r103405341
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2226,17 +2227,33 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 return new String[] {datastoreDiskPath};
 }
 
-// Pair
-private Pair composeVmNames(VirtualMachineTO vmSpec) {
-String vmInternalCSName = vmSpec.getName();
-String vmNameOnVcenter = vmSpec.getName();
-if (_instanceNameFlag && vmSpec.getHostName() != null) {
-vmNameOnVcenter = vmSpec.getHostName();
+/**
+ * This method generates VM name for Vcenter and Cloudstack( when 
Hypervisor is VMware).
+ * It generates VM name according to  _instanceNameFlag setting.
+ *
+ * @param VirtualMachineTO
+ *vmSpec
+ * @return Pair. A pair which 
contain 'internal CS name'  and
+ * 'vCenter display name'(vCenter knows VM by this name).
+ **/
+protected Pair composeVmNames(VirtualMachineTO vmSpec) 
{
+
+String vmInternalCSName = "";
+String vmNameOnVcenter  = "";
+if(vmSpec != null)
+{
+vmInternalCSName = vmNameOnVcenter = vmSpec.getName();
+if (_instanceNameFlag == true && vmSpec.getType() == 
VirtualMachine.Type.User) {
+String[] tokens = vmInternalCSName.split("-");
+if(tokens.length<3) throw new 
InvalidParameterValueException("Invalid vmInternalCSName format: 
"+vmInternalCSName+" expected format : *-*-* (e.g -> i-x-y)"); // 
vmInternalCSName has format i-x-y-
+vmNameOnVcenter = String.format("%s-%s-%s-%s", tokens[0], 
tokens[1], tokens[2], vmSpec.getHostName());
+}
+
 }
 return new Pair(vmInternalCSName, vmNameOnVcenter);
 }
 
-protected void configNestedHVSupport(VirtualMachineMO vmMo, 
VirtualMachineTO vmSpec, VirtualMachineConfigSpec vmConfigSpec) throws 
Exception {
+protected static void configNestedHVSupport(VirtualMachineMO vmMo, 
VirtualMachineTO vmSpec, VirtualMachineConfigSpec vmConfigSpec) throws 
Exception {
--- End diff --

Please explain why `static` was added, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-28 Thread koushik-das
Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1960
  
I have already raised some questions on dev@ on the need for a new HA 
framework when the existing HA framework can do all the things mentioned. The 
new framework only supports VM HA. If we see some concrete implementation of 
network/storage or any other type of resource HA which doesn't currently exist 
using the new framework then it would be much more easier to see the value add. 
I think more discussion is needed on this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1241: CLOUDSTACK-9162: Unable to add VPN user via API with...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1241
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1302
  
I've left some outstanding comments, I'm -1 on the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1241: CLOUDSTACK-9162: Unable to add VPN user via API with...

2017-02-28 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1241
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs issue #19: Updating The Nuage VSP Plugin Documentation for A...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack-docs/pull/19
  
LGTM thanks. /cc @karuturi we can merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1779
  
I think we'll need to discuss, I'm not sure if we should hide hosts that 
are disabled and cluster is un-managed. /cc @DaanHoogland  @abhinandanprateek 
comment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-02-28 Thread sureshanaparti
Github user sureshanaparti commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1813#discussion_r103409558
  
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -3520,27 +3520,17 @@ public UserVmVO doInTransaction(TransactionStatus 
status) throws InsufficientCap
 }
 rootDiskSize = 
Long.parseLong(customParameters.get("rootdisksize"));
 
-// only KVM supports rootdisksize override
-if (hypervisorType != HypervisorType.KVM) {
-throw new 
InvalidParameterValueException("Hypervisor " + hypervisorType + " does not 
support rootdisksize override");
+// only KVM, XenServer and VMware  supports 
rootdisksize override
+if (!(hypervisorType == HypervisorType.KVM || 
hypervisorType == HypervisorType.XenServer || hypervisorType == 
HypervisorType.VMware)) {
+throw new 
InvalidParameterValueException("Hypervisor " + hypervisorType + " does not 
support  rootdisksize override");
--- End diff --

@priyankparihar Ok. thanks for the confirmation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Modern template hosting

2017-02-28 Thread Rajani Karuturi
Pierre-Luc did an amazing job in getting
https://builds.cloudstack.org/ working [1].

We can work on similar lines and probably get
packages.cloudstack.org working with mirrored entries form
apt-get.eu or openvm.eu or s3.downloads.accelerite or
packages.shapeblue etc.

[1] https://issues.apache.org/jira/browse/INFRA-11903

Thanks,

~ Rajani

http://cloudplatform.accelerite.com/

On February 28, 2017 at 2:13 PM, Erik Weber (terbol...@gmail.com)
wrote:

On Tue, Feb 28, 2017 at 8:59 AM, Daan Hoogland
 wrote:

On Tue, Feb 28, 2017 at 2:40 AM, Pierre-Luc Dion
 wrote:

For our systemvm templates, can we just change the URL for
somthing like
cloudstack.apache.org/systemvm/... ?

I agree,
is there any change we can host a domain for this at apache, if
we
can't keep downloads.cloud.com then maybe
downloads.cloudstack.com. To
many people are used to this this way of working and a patch for
a
name change is the easiest. Devising a new mechanism is nice but
a
different job, is it?

packages.apache.org exists.

Has been discussed before in a thread called 'Package
Repositories'.

One thing that should be focused on is that if we go the ASF
hosted
route, we should be able to update the content without involving
ASF
Infra team.

--
Erik

[GitHub] cloudstack pull request #1978: CLOUDSTACK-9779 : Releasing secondary guest I...

2017-02-28 Thread niteshsarda
GitHub user niteshsarda opened a pull request:

https://github.com/apache/cloudstack/pull/1978

CLOUDSTACK-9779 : Releasing secondary guest IP fails with error VM nic Ip 
x.x.x.x is mapped to load balancing rule

ISSUE

Releasing secondary guest IP fails with error VM nic Ip x.x.x.x is mapped 
to load balancing rule

REPRO STEPS

Create two isolated guest networks with same CIDR
Deploy VMs on both networks
Acquire secondary IP on NICs of both VMs and make sure they have the same 
value, user can input the IP address.
Configure Loadbalancing rule on one of the secondary IP address and try 
releasing the other secondary IP address.
The operation would fail
EXPECTED BEHAVIOR

Secondary IP address should be released if there are no LB rules associated 
with it.

ACTUAL BEHAVIOR

Not releasing secondary IP address even if there are no LB rules associated 
with it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack ReleaseNicSecondaryIP

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1978.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1978






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1972: CLOUDSTACK-9779 : Releasing secondary guest IP fails...

2017-02-28 Thread niteshsarda
Github user niteshsarda commented on the issue:

https://github.com/apache/cloudstack/pull/1972
  
@ustcweizhou : Can you please check new PR for this issue and provide LGTM 
on that PR.

PR link : 
https://github.com/apache/cloudstack/pull/1978


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1972: CLOUDSTACK-9779 : Releasing secondary guest IP fails...

2017-02-28 Thread niteshsarda
Github user niteshsarda commented on the issue:

https://github.com/apache/cloudstack/pull/1972
  
@SudharmaJain Can you please check new PR for this issue. Also, I have 
implemented the changes which you have suggested.

PR link :
#1978


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1978: CLOUDSTACK-9779 : Releasing secondary guest I...

2017-02-28 Thread niteshsarda
Github user niteshsarda commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1978#discussion_r103415320
  
--- Diff: server/test/resources/createNetworkOffering.xml ---
@@ -34,22 +34,23 @@
 
 
 
-
-  
-
-
-
-
-
-
-
+
+  
+
+
+
+
+
+
+
 
 
-
-
-
-
+
+
+
+
 
+
--- End diff --

This is the only line, I have added in this file. Other changes were not 
visible in the patch which was created before committing the changes in local.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1978: CLOUDSTACK-9779 : Releasing secondary guest I...

2017-02-28 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1978#discussion_r103416124
  
--- Diff: server/test/resources/createNetworkOffering.xml ---
@@ -34,22 +34,23 @@
 
 
 
-
-  
-
-
-
-
-
-
-
+
+  
+
+
+
+
+
+
+
 
 
-
-
-
-
+
+
+
+
 
+
--- End diff --

this change LGTM, otherwise the unit tests will fail


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1241: CLOUDSTACK-9162: Unable to add VPN user via API with...

2017-02-28 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1241
  
I am wondering if this is a general issue when create other resources 
(volume,vm,etc) using integration port 8096.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1942: CLOUDSTACK-9784 : GPU detail not displayed in GPU ta...

2017-02-28 Thread Ashadeepa
Github user Ashadeepa commented on the issue:

https://github.com/apache/cloudstack/pull/1942
  
Tested the code changes. LGTM 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-28 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1960
  
@koushik-das The current framework is specifically implemented for Host HA 
with KVM HA as the initial implementation. This framework is supposed to 
replace the framework that is specifically written for VM-HA. @rhtyd 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


RE: [PROPOSAL] add native vm-cluster orchestration service (was: [PROPOSAL] add native container orchestration service)

2017-02-28 Thread Kishan Kavala
Daan,
 I've updated the earlier spec to support any Vm cluster. Please let me know 
your thoughts on this.
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Service+Cluster+Functional+Specification

regards,
Kishan

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@shapeblue.com] 
Sent: 27 February 2017 04:02 PM
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] add native vm-cluster orchestration service (was: 
[PROPOSAL] add native container orchestration service)

Any follow up Koushik? I want to refactor our proof of concept and integrate it 
in master.

On 21/02/17 10:42, "Kishan Kavala"  wrote:

Sure Daan. I'll publish the design on cwiki and share the link.

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@shapeblue.com] 
Sent: Monday, February 20, 2017 7:27 PM
To: dev@cloudstack.apache.org
Subject: [PROPOSAL] add native vm-cluster orchestration service (was: 
[PROPOSAL] add native container orchestration service)

So, being very late in the discussion but havingread the whole thread 
before editting the title of this thread,

Can we agree that we want a generic vm-cluster service and leave the 
container bits to containers? Kishan can you share your design? Shapeblue wants 
to rebase their k8 service on top of this and I would like yours and Murali's 
work to not conflict.

daan.hoogl...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, Utrecht Utrecht 3531 VENetherlands 
@shapeblue
  
 


-Original Message-
From: Paul Angus [mailto:paul.an...@shapeblue.com]
Sent: dinsdag 7 februari 2017 08:14
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] add native container orchestration service

Will is 100% correct.  As I mentioned the Title is misleading.  However, 
Murali did clarify in his explanation; this is really about vm cluster 
orchestration.




From: Will Stevens 
Sent: 6 Feb 2017 22:54
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] add native container orchestration service

​My understanding is that what Paul is talking about is what is already 
built and IS what the thread is talking about.​

*Will STEVENS*
Lead Developer



On Mon, Feb 6, 2017 at 2:29 PM, Rajesh Ramchandani < 
rajesh.ramchand...@accelerite.com> wrote:

> Hi Paul - I think this is different from what the thread was about. 
> The conversation was specifically about adding support for container 
> orchestrators. You are talking about provisioning a group of VMs.
> Although, this is something I think several Cloudstack users have 
> requested before and we should propose a solution to this.
>
> Raj
>
> 
> From: Paul Angus 
> Sent: Monday, February 6, 2017 11:16:41 AM
> To: dev@cloudstack.apache.org
> Subject: RE: [PROPOSAL] add native container orchestration service
>
> #WhatHeSaid
>
> The title is misleading.  The proposal is purely to add the notion of 
> Clusters of VMs to CloudStack.  These may be for databases, containers 
> or anything else that needs 'clusters' of compute. Self-healing and 
> autoscaling are logical next steps to be added.
>
> Those guys at ShapeBlue have open-sourced their whole k8s container 
> service piece.  If/when the 'cluster' part of that work is added into 
> CloudStack, the k8s specific pieces can be used by anyone who wants 
> to, alternatively they could be used for reference in order to create 
> another types of cluster.  (or ignored completely).
>
>
>
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
>
>
>
>
> -Original Message-
> From: Will Stevens [mailto:williamstev...@gmail.com]
> Sent: 31 January 2017 13:26
> To: dev@cloudstack.apache.org
> Subject: Re: [PROPOSAL] add native container orchestration service
>
> s/cloud-init/cloud-config/
>
> On Jan 31, 2017 7:24 AM, "Will Stevens"  wrote:
>
> > I think that is covered in this proposal. There is nothing k8s 
> > specific in this integration (from what I understand), all the k8s 
> > details are passed in via the cloud-init configuration after the 
> > cluster
> has been provisioned.
> >
> > On Jan 31, 2017 3:06 AM, "Lianghwa Jou" 
> > 
> > wrote:
> >
> >
> > There are many container orchestrators. Those container 
> > orchestrators are happy to run on any VMs or bare metal machines. 
> > K8s is just one of them and there will be more in the future. It may 
> > not be a good idea to make CloudStack to be k8s aware. IMO, the 
> > relationship between k8s and 

[GitHub] cloudstack issue #1852: CLOUDSTACK-9695: VM snapshot is disabled if the VM I...

2017-02-28 Thread rashmidixit
Github user rashmidixit commented on the issue:

https://github.com/apache/cloudstack/pull/1852
  
@ustcweizhou The reason for not putting this in vmActionFilter is that the 
snapshot action itself is allowed when a VM is shut down. We only want to 
disable the option for memory snapshot which is not valid in this case. Hope 
this clarifies.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1960
  
@koushik-das I've shared a list of advantages of this work over existing 
framework on dev@ that explain why existing VM-HA framework cannot be used for 
host-ha implementation. If you've more questions or comments, we can discuss 
them here or on dev@.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1852: CLOUDSTACK-9695: VM snapshot is disabled if the VM I...

2017-02-28 Thread rashmidixit
Github user rashmidixit commented on the issue:

https://github.com/apache/cloudstack/pull/1852
  
ping @koushik-das.

When VM is running and snapshot option is clicked, the memory option is 
enabled.


![vm-running-state](https://cloud.githubusercontent.com/assets/13415006/23401932/82efb52c-fdcf-11e6-91e5-9ec4d99bc09d.PNG)

When VM is stopped and snapshot option is clicked, the memory option is 
disabled.

![vm-stopped-memorysnapshotdisabled](https://cloud.githubusercontent.com/assets/13415006/23401933/82f0253e-fdcf-11e6-93fe-4643b2b41a70.PNG)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

2017-02-28 Thread priyankparihar
Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1302#discussion_r103423690
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2226,17 +2227,33 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 return new String[] {datastoreDiskPath};
 }
 
-// Pair
-private Pair composeVmNames(VirtualMachineTO vmSpec) {
-String vmInternalCSName = vmSpec.getName();
-String vmNameOnVcenter = vmSpec.getName();
-if (_instanceNameFlag && vmSpec.getHostName() != null) {
-vmNameOnVcenter = vmSpec.getHostName();
+/**
+ * This method generates VM name for Vcenter and Cloudstack( when 
Hypervisor is VMware).
+ * It generates VM name according to  _instanceNameFlag setting.
+ *
+ * @param VirtualMachineTO
+ *vmSpec
+ * @return Pair. A pair which 
contain 'internal CS name'  and
+ * 'vCenter display name'(vCenter knows VM by this name).
+ **/
+protected Pair composeVmNames(VirtualMachineTO vmSpec) 
{
+
+String vmInternalCSName = "";
+String vmNameOnVcenter  = "";
+if(vmSpec != null)
+{
+vmInternalCSName = vmNameOnVcenter = vmSpec.getName();
+if (_instanceNameFlag == true && vmSpec.getType() == 
VirtualMachine.Type.User) {
+String[] tokens = vmInternalCSName.split("-");
+if(tokens.length<3) throw new 
InvalidParameterValueException("Invalid vmInternalCSName format: 
"+vmInternalCSName+" expected format : *-*-* (e.g -> i-x-y)"); // 
vmInternalCSName has format i-x-y-
+vmNameOnVcenter = String.format("%s-%s-%s-%s", tokens[0], 
tokens[1], tokens[2], vmSpec.getHostName());
--- End diff --

@sateesh-chodapuneedi what is your opinion ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [PROPOSAL] add native vm-cluster orchestration service (was: [PROPOSAL] add native container orchestration service)

2017-02-28 Thread Rene Moser
On 02/20/2017 02:56 PM, Daan Hoogland wrote:
> So, being very late in the discussion but havingread the whole thread before 
> editting the title of this thread,
> 
> Can we agree that we want a generic vm-cluster service and leave the 
> container bits to containers? Kishan can you share your design? Shapeblue 
> wants to rebase their k8 service on top of this and I would like yours and 
> Murali's work to not conflict.

+1


[GitHub] cloudstack pull request #1894: CLOUDSTACK-9700 Allow user to Register/Copy t...

2017-02-28 Thread rashmidixit
GitHub user rashmidixit reopened a pull request:

https://github.com/apache/cloudstack/pull/1894

CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at 
the same time

A user can currently copy or register a template with only one zone at a 
time.
The idea of this feature is to allow the user to allow copying or 
registering of one template to multiple zones at the same time.

For RegisterTemplate and CopyTemplate APIs have been modified to add a new 
parameter called zoneIds. This is not compulsory to keep backward compatibility.

The UIs have been changes - When you add, the earlier select control for 
zones now is a multi select and you can choose multiple zones at the same time. 
For CopyTemplate a new dialog has been added - this shows all the zones you 
can copy to and allows you to select multiple at a time.

Please see 
[CLOUDSTACK-9700](https://issues.apache.org/jira/browse/CLOUDSTACK-9700) for 
more details. Snapshots of the UI have been attached there.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9700

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1894.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1894


commit 95bf9f0f5b640f6673606e7f56fce39654e16fff
Author: rashmidixit 
Date:   2017-02-28T06:33:07Z

CLOUDSTACK-9700: Allow user to Register/Copy templates to multiple zones at 
the same time




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1894: CLOUDSTACK-9700 Allow user to Register/Copy t...

2017-02-28 Thread rashmidixit
Github user rashmidixit closed the pull request at:

https://github.com/apache/cloudstack/pull/1894


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

2017-02-28 Thread priyankparihar
Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1302#discussion_r103427150
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2226,17 +2227,33 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 return new String[] {datastoreDiskPath};
 }
 
-// Pair
-private Pair composeVmNames(VirtualMachineTO vmSpec) {
-String vmInternalCSName = vmSpec.getName();
-String vmNameOnVcenter = vmSpec.getName();
-if (_instanceNameFlag && vmSpec.getHostName() != null) {
-vmNameOnVcenter = vmSpec.getHostName();
+/**
+ * This method generates VM name for Vcenter and Cloudstack( when 
Hypervisor is VMware).
+ * It generates VM name according to  _instanceNameFlag setting.
+ *
+ * @param VirtualMachineTO
+ *vmSpec
+ * @return Pair. A pair which 
contain 'internal CS name'  and
+ * 'vCenter display name'(vCenter knows VM by this name).
+ **/
+protected Pair composeVmNames(VirtualMachineTO vmSpec) 
{
+
--- End diff --

>Why is the method attribute changed from private to protected?

Otherwise Unit testing will be difficult. 

>If vmspec is null, this method should throw an exception, to avoid a 
situation where empty vmnames are returned.

In CS vmspec can not be null. But still code will be  modified according 
your suggestion.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

2017-02-28 Thread priyankparihar
Github user priyankparihar commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1302#discussion_r103427642
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2226,17 +2227,33 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
 return new String[] {datastoreDiskPath};
 }
 
-// Pair
-private Pair composeVmNames(VirtualMachineTO vmSpec) {
-String vmInternalCSName = vmSpec.getName();
-String vmNameOnVcenter = vmSpec.getName();
-if (_instanceNameFlag && vmSpec.getHostName() != null) {
-vmNameOnVcenter = vmSpec.getHostName();
+/**
+ * This method generates VM name for Vcenter and Cloudstack( when 
Hypervisor is VMware).
+ * It generates VM name according to  _instanceNameFlag setting.
+ *
+ * @param VirtualMachineTO
+ *vmSpec
+ * @return Pair. A pair which 
contain 'internal CS name'  and
+ * 'vCenter display name'(vCenter knows VM by this name).
+ **/
+protected Pair composeVmNames(VirtualMachineTO vmSpec) 
{
+
+String vmInternalCSName = "";
+String vmNameOnVcenter  = "";
+if(vmSpec != null)
+{
+vmInternalCSName = vmNameOnVcenter = vmSpec.getName();
+if (_instanceNameFlag == true && vmSpec.getType() == 
VirtualMachine.Type.User) {
--- End diff --

@rhtyd Good point. Code will be modified. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

2017-02-28 Thread nitin-maharana
Github user nitin-maharana closed the pull request at:

https://github.com/apache/cloudstack/pull/1771


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

2017-02-28 Thread nitin-maharana
GitHub user nitin-maharana reopened a pull request:

https://github.com/apache/cloudstack/pull/1771

CLOUDSTACK-9611: Dedicating a Guest VLAN range to Project does not work.

Description:
=

Trying to dedicate a guest VLAN range to an account fails. Either API 
documentation is wrong or code path needs to be corrected. If we pass both 
account and projectId parameters to the dedicateGuestVlanRange (which are not 
mentioned as mutually exclusive in API description) the API layer throws error 
saying both are mutually exclusive.

Steps to Reproduce:
===
Create an account. Create a project in that account.

Go to Admin account and change the view to the above project.

Navigate to Infrastructure -> Zone -> Physical Network -> Guest -> Dedicate 
Guest VLAN range.

Try to dedicate the guest VLAN range from the project view for the account 
associated with the project.

It fails with error saying "accountName and projectId are mutually 
exclusive".


![image](https://cloud.githubusercontent.com/assets/12583725/20559763/15fe55d8-b19c-11e6-9996-62602d269f10.png)


![image](https://cloud.githubusercontent.com/assets/12583725/20559765/1957af36-b19c-11e6-938f-e9c7c9eee987.png)

Expected:
===
The VLAN range should get dedicated to the project account.


![image](https://cloud.githubusercontent.com/assets/12583725/20559787/33ef67b2-b19c-11e6-90fd-41c9c583efd9.png)


![image](https://cloud.githubusercontent.com/assets/12583725/20559789/376cae22-b19c-11e6-9755-ff1e7237fb21.png)

Resolution:

Changed the account field of API to optional.
Even if the account name is passed while adding from a particular project 
view, then it is ignored in API.

Notes:
=
If we do the dedication from default view then it works fine as no 
projectId is associated over there.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-maharana/CloudStack-Nitin nitin3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1771.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1771


commit f56961392662f4b45e3e4cb989203f918ec19916
Author: Nitin Kumar Maharana 
Date:   2017-02-28T10:57:38Z

CLOUDSTACK-9611: Dedicating a Guest VLAN range to Project does not work.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-02-28 Thread ProjectMoon
Github user ProjectMoon commented on the issue:

https://github.com/apache/cloudstack/pull/1908
  
Question: would #1907 be relevant to this? That change relied on sending 
all the IPs to the router, but under this change, we will be sending one at a 
time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs issue #19: Updating The Nuage VSP Plugin Documentation for A...

2017-02-28 Thread prashanthvarma
Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack-docs/pull/19
  
@rhtyd @karuturi @krissterckx Additionally, added a section on how to run 
The Nuage VSP Plugin specific Marvin tests.

You can merge this PR as it is complete now.

 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-02-28 Thread ProjectMoon
Github user ProjectMoon commented on the issue:

https://github.com/apache/cloudstack/pull/1908
  
I'm looking at the `DataBag` code, and it seems that it loads information 
from the data located at `/etc/cloudstack/` and therefore 1907 should work fine 
with this, ASSUMING that is smart enough to recognize that the IP should no 
longer be there.

I think this is a scenario that should definitely be tested as it has the 
potential to break the whole PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1832: CLOUDSTACK-9652 Job framework - Cancelling async job...

2017-02-28 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1832
  
> @karuturi Ok thanks for the clarifications, and it's the scenario I 
thought about too. That being said, I'm currently thinking of a new approach 
for the command sequencer because having implemented the live migration, the 
non-parallel commands isn't optimal at all when you have long running 
sequential commands on a hypervisor. And I tend to think that's the reason 
behind your PR, isn't it?

Yes, thats right.

> The way it's currently done is too simple (if a job cannot be run in 
parallel on the HV, it will put in 
> So don't you think we're better of rewriting the sequencer to let more 
commands being executed in parallel to avoid this bottleneck on the 
AgentAttache? It would normally make the cancellation not needed in the way you 
implemented it since less jobs will be queued.
> 

As you already said, with todays design it isn't possible. Rewriting is 
obviously better. But, thats a bigger job. In the current design, this was the 
only possible way to allow cloudstack to process queued up jobs.

> If we wish to be able to cancel a job, IMHO it should cancel the job down 
on the hypervisor too, thus clearing normally the resources involved as if the 
execution didn't go well.
> 

I agree. But, thats a huge task given the number of hypervisors we support 
and their versions.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-28 Thread koushik-das
Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1960
  
@abhinandanprateek If you refer to the discussion on dev@ 
https://goo.gl/cU8RuX, @rhtyd proposed it as a generic HA framework for any 
resources (and not limited to VM). Now if it just a replacement of the existing 
VM-HA framework then we need to discuss the benefits it provides in more detail 
compared to the existing one. I have already made some specific comments on the 
justifications provided in favour of a new framework.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1896: [CLOUDSTACK-9732] Update L10N resource files ...

2017-02-28 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1896


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1914: CLOUDSTACK-9753 - Update L10N resource files ...

2017-02-28 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1914


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1848: CLOUDSTACK-9693 Cluster View - Status symbol does no...

2017-02-28 Thread rashmidixit
Github user rashmidixit commented on the issue:

https://github.com/apache/cloudstack/pull/1848
  
@koushik-das : Please see attached image. With these changes, when a 
cluster is unmanaged, the status will change to Unmanaged as below. Earlier it 
used to show up as enabled (whereas in the metrics view it showed it up 
correctly as unmanaged). This fix merely makes it consistent


![unmanaged-cluster](https://cloud.githubusercontent.com/assets/13415006/23404540/8afa00cc-fddb-11e6-98dd-5cec6c96278e.PNG)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1942: CLOUDSTACK-9784 : GPU detail not displayed in...

2017-02-28 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1942


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-28 Thread sureshanaparti
Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
@priyankparihar Perfect. Code changes LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #803: CLOUDSTACK-8833: Fixed Generating url and migrate vol...

2017-02-28 Thread anshul1886
Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/803
  
@rhtyd Rebased against latest master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #868: CLOUDSTACK-8894: Restrict vGPU enabled VMs dynamic sc...

2017-02-28 Thread anshul1886
Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/868
  
@rhtyd, Rebased against latest master. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...

2017-02-28 Thread anshul1886
Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1269
  
@rhtyd , Rebased against latest master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-02-28 Thread anshul1886
Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1278
  
@rhtyd , Rebased against laster master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2017-02-28 Thread sureshanaparti
Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1257
  
Please ignore the above BVT test results from @cloudmonger. These tests 
were executed on xenserver instead of VMware. VMware tests has been kicked off 
in @blueorangutan 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...

2017-02-28 Thread sureshanaparti
Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1253
  
Please ignore the above BVT test results from @cloudmonger. These tests 
were executed on xenserver instead of VMware.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-02-28 Thread ProjectMoon
Github user ProjectMoon commented on the issue:

https://github.com/apache/cloudstack/pull/1908
  
We have been testing this PR internally for some time now, and we have seen 
some strange `arping` issues. We have seen that `/etc/cloudstack/ips.json` on 
the router has IPs on them that aren't cleaned up. Since #1908 is now merged, 
I'm worried that the changes in this PR will not play well with #1908.

Specifically, we have seen that IPs left over in the `ips.json` file can be 
stuck on `"add": true` even if the IP is no longer on the account. 

Thus, the code that was added in PR 1907 concerns me:

```
 if not address['add'] and not ip.configured():
logging.info("Skipping %s as the add flag is set to %s " % 
(address['public_ip'], address['add']))
continue
```

The `if` condition fails in a case we've been investigating. Because our IP 
is `"add": true`, but `configured()` returns `False`, the IP gets reconfigured 
anyway. This doesn't add the IP to the router's interface, but it _does_ run an 
`arping` command (see CsAddress.py). Essentially, if this PR is merged as-is, 
we might wind up with a regression on CLOUDSTACK-9500. 

I will do a bit of manual testing combining both #1908 and #1907 to see 
what happens. It may just be that after restarting the network (and thus 
cleaning the router), these issues will vanish.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-28 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
looks like BO didn't pickup the message @karuturi 
@blueorangutan test centos7 vmware-60u2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-28 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1883: CLOUDSTACK-9723: Enable unique mac address across th...

2017-02-28 Thread kishankavala
Github user kishankavala commented on the issue:

https://github.com/apache/cloudstack/pull/1883
  
Code LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...

2017-02-28 Thread sureshanaparti
Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1253
  
@sateesh-chodapuneedi These two test failures are due to the ssh failure to 
the router VM, are not related to this PR changes.

_test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed_

> Failed to SSH into the Virtual Machine: SSH connection has Failed. Waited 
150s. Error is SSH Connection Failed
> === TestName: test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | 
Status : FAILED ===
> 
"/automation/virtenv/00-16-3e-17-43-25/396/test/integration/smoke/test_routers_network_ops.py",
 line 338, in test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true\n
result = check_router_command(virtual_machine, nat_rule.ipaddress, ssh_command, 
check_string, self)\n', '  File 
"/automation/virtenv/00-16-3e-17-43-25/396/test/integration/smoke/test_routers_network_ops.py",
 line 64, in check_router_command\ntest_case.fail("Failed to SSH into the 
Virtual Machine: %s" % e)\n', '  File 
"/usr/local/lib/python2.7/unittest/case.py", line 412, in fail\nraise 
self.failureException(msg)\n', 'AssertionError: Failed to SSH into the Virtual 
Machine: SSH connection has Failed. Waited 150s. Error is SSH Connection 
Failed\n']


_test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed_

> Failed to SSH into the Virtual Machine: SSH connection has Failed. Waited 
150s. Error is SSH Connection Failed
> === TestName: test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | 
Status : FAILED ===
> 
> 
"/automation/virtenv/00-16-3e-17-43-25/396/test/integration/smoke/test_routers_network_ops.py",
 line 502, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false\\n
result = check_router_command(virtual_machine, nat_rule.ipaddress, ssh_command, 
check_string, self)\\n\', \'  File 
"/automation/virtenv/00-16-3e-17-43-25/396/test/integration/smoke/test_routers_network_ops.py",
 line 64, in check_router_command\\ntest_case.fail("Failed to SSH into the 
Virtual Machine: %s" % e)\\n\', \'  File 
"/usr/local/lib/python2.7/unittest/case.py", line 412, in fail\\nraise 
self.failureException(msg)\\n\', \'AssertionError: Failed to SSH into the 
Virtual Machine: SSH connection has Failed. Waited 150s. Error is SSH 
Connection Failed\\n\']






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...

2017-02-28 Thread sureshanaparti
Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1253
  
@rhtyd @borisroman can you kick off vmware tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...

2017-02-28 Thread kishankavala
Github user kishankavala commented on the issue:

https://github.com/apache/cloudstack/pull/1886
  
Tested manually. Did not see any issues with long list of IPs.
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1832: CLOUDSTACK-9652 Job framework - Cancelling async job...

2017-02-28 Thread marcaurele
Github user marcaurele commented on the issue:

https://github.com/apache/cloudstack/pull/1832
  
@karuturi Ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


User registration

2017-02-28 Thread Eric Waegeman
Hi all,

My name is Eric Waegeman.
I am working on the Nuage Network plugin in CloudStack.
Is it possible to give me access on:

   - jira (issues.apache.org - username: waegemae)
   - slack (eric.waege...@nuagenetworks.net
   )
   - cwiki (username: waegemae)

Thanks,
Eric.


Re: User registration

2017-02-28 Thread Rafael Weingärtner
I added you on Slack and assigned a role "contributor" on Jira.
I think I do not have permission (karma) do the same on cwiki.

On Tue, Feb 28, 2017 at 9:18 AM, Eric Waegeman <
eric.waege...@nuagenetworks.net> wrote:

> Hi all,
>
> My name is Eric Waegeman.
> I am working on the Nuage Network plugin in CloudStack.
> Is it possible to give me access on:
>
>- jira (issues.apache.org - username: waegemae)
>- slack (eric.waege...@nuagenetworks.net
>)
>- cwiki (username: waegemae)
>
> Thanks,
> Eric.
>



-- 
Rafael Weingärtner


[GitHub] cloudstack issue #1866: Advanced isolated network egress destination cidr su...

2017-02-28 Thread jayapalu
Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1866
  
I tested manually test_02_isolate_network_FW_PF_default_routes_egress_false 
Failed. It worked for me.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: User registration

2017-02-28 Thread Daan Hoogland
Eric and Rafael, you are added. Rafael with rights to add people

On 28/02/17 15:32, "Rafael Weingärtner"  wrote:

I added you on Slack and assigned a role "contributor" on Jira.
I think I do not have permission (karma) do the same on cwiki.

On Tue, Feb 28, 2017 at 9:18 AM, Eric Waegeman <
eric.waege...@nuagenetworks.net> wrote:

> Hi all,
>
> My name is Eric Waegeman.
> I am working on the Nuage Network plugin in CloudStack.
> Is it possible to give me access on:
>
>- jira (issues.apache.org - username: waegemae)
>- slack (eric.waege...@nuagenetworks.net
>)
>- cwiki (username: waegemae)
>
> Thanks,
> Eric.
>



-- 
Rafael Weingärtner



daan.hoogl...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 



Re: [PROPOSAL] add native vm-cluster orchestration service (was: [PROPOSAL] add native container orchestration service)

2017-02-28 Thread Daan Hoogland
Kishan, I see some sensible additions but also some unnecessary omissions. Most 
of it seems to be Murali’s text so I’ll c&p your improvements back and rename 
the page to the more sensible title of “MachineCluster service” and delete the 
other.

About naming, I was thinking MachineCluster instead of ServiceCluster, makes 
sense? Or even GuestMachineCluster. ServiceCluster could mean a supporting 
cluster that delivers e.g. backup as a service to guests, or maybe some build, 
artifact or networking service. For this ambiguity im am :-1: on the name 
ServiceCluster.


On 28/02/17 11:16, "Kishan Kavala"  wrote:

Daan,
 I've updated the earlier spec to support any Vm cluster. Please let me 
know your thoughts on this.

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Service+Cluster+Functional+Specification

regards,
Kishan

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@shapeblue.com] 
Sent: 27 February 2017 04:02 PM
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] add native vm-cluster orchestration service (was: 
[PROPOSAL] add native container orchestration service)

Any follow up Koushik? I want to refactor our proof of concept and 
integrate it in master.

On 21/02/17 10:42, "Kishan Kavala"  wrote:

Sure Daan. I'll publish the design on cwiki and share the link.

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@shapeblue.com] 
Sent: Monday, February 20, 2017 7:27 PM
To: dev@cloudstack.apache.org
Subject: [PROPOSAL] add native vm-cluster orchestration service (was: 
[PROPOSAL] add native container orchestration service)

So, being very late in the discussion but havingread the whole thread 
before editting the title of this thread,

Can we agree that we want a generic vm-cluster service and leave the 
container bits to containers? Kishan can you share your design? Shapeblue wants 
to rebase their k8 service on top of this and I would like yours and Murali's 
work to not conflict.

daan.hoogl...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, Utrecht Utrecht 3531 VENetherlands 
@shapeblue
  
 


-Original Message-
From: Paul Angus [mailto:paul.an...@shapeblue.com]
Sent: dinsdag 7 februari 2017 08:14
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] add native container orchestration service

Will is 100% correct.  As I mentioned the Title is misleading.  
However, Murali did clarify in his explanation; this is really about vm cluster 
orchestration.




From: Will Stevens 
Sent: 6 Feb 2017 22:54
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] add native container orchestration service

​My understanding is that what Paul is talking about is what is already 
built and IS what the thread is talking about.​

*Will STEVENS*
Lead Developer



On Mon, Feb 6, 2017 at 2:29 PM, Rajesh Ramchandani < 
rajesh.ramchand...@accelerite.com> wrote:

> Hi Paul - I think this is different from what the thread was about. 
> The conversation was specifically about adding support for container 
> orchestrators. You are talking about provisioning a group of VMs.
> Although, this is something I think several Cloudstack users have 
> requested before and we should propose a solution to this.
>
> Raj
>
> 
> From: Paul Angus 
> Sent: Monday, February 6, 2017 11:16:41 AM
> To: dev@cloudstack.apache.org
> Subject: RE: [PROPOSAL] add native container orchestration service
>
> #WhatHeSaid
>
> The title is misleading.  The proposal is purely to add the notion of 
> Clusters of VMs to CloudStack.  These may be for databases, 
containers 
> or anything else that needs 'clusters' of compute. Self-healing and 
> autoscaling are logical next steps to be added.
>
> Those guys at ShapeBlue have open-sourced their whole k8s container 
> service piece.  If/when the 'cluster' part of that work is added into 
> CloudStack, the k8s specific pieces can be used by anyone who wants 
> to, alternatively they could be used for reference in order to create 
> another types of cluster.  (or ignored completely).
>
>
>
>
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
>
>
>
>
> -Ori

Re: User registration

2017-02-28 Thread Rafael Weingärtner
Thank you sir ;)

On Tue, Feb 28, 2017 at 9:56 AM, Daan Hoogland 
wrote:

> Eric and Rafael, you are added. Rafael with rights to add people
>
> On 28/02/17 15:32, "Rafael Weingärtner" 
> wrote:
>
> I added you on Slack and assigned a role "contributor" on Jira.
> I think I do not have permission (karma) do the same on cwiki.
>
> On Tue, Feb 28, 2017 at 9:18 AM, Eric Waegeman <
> eric.waege...@nuagenetworks.net> wrote:
>
> > Hi all,
> >
> > My name is Eric Waegeman.
> > I am working on the Nuage Network plugin in CloudStack.
> > Is it possible to give me access on:
> >
> >- jira (issues.apache.org - username: waegemae)
> >- slack (eric.waege...@nuagenetworks.net
> >)
> >- cwiki (username: waegemae)
> >
> > Thanks,
> > Eric.
> >
>
>
>
> --
> Rafael Weingärtner
>
>
>
> daan.hoogl...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>


-- 
Rafael Weingärtner


Re: [PROPOSAL] add native vm-cluster orchestration service (was: [PROPOSAL] add native container orchestration service)

2017-02-28 Thread Syed Ahmed
We already call the VMs as Instances. So, InstanceCluster would be a better
name imo.

On Tue, Feb 28, 2017 at 10:05 AM, Daan Hoogland  wrote:

> Kishan, I see some sensible additions but also some unnecessary omissions.
> Most of it seems to be Murali’s text so I’ll c&p your improvements back and
> rename the page to the more sensible title of “MachineCluster service” and
> delete the other.
>
> About naming, I was thinking MachineCluster instead of ServiceCluster,
> makes sense? Or even GuestMachineCluster. ServiceCluster could mean a
> supporting cluster that delivers e.g. backup as a service to guests, or
> maybe some build, artifact or networking service. For this ambiguity im am
> :-1: on the name ServiceCluster.
>
>
> On 28/02/17 11:16, "Kishan Kavala"  wrote:
>
> Daan,
>  I've updated the earlier spec to support any Vm cluster. Please let
> me know your thoughts on this.
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/
> Service+Cluster+Functional+Specification
>
> regards,
> Kishan
>
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@shapeblue.com]
> Sent: 27 February 2017 04:02 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [PROPOSAL] add native vm-cluster orchestration service
> (was: [PROPOSAL] add native container orchestration service)
>
> Any follow up Koushik? I want to refactor our proof of concept and
> integrate it in master.
>
> On 21/02/17 10:42, "Kishan Kavala" 
> wrote:
>
> Sure Daan. I'll publish the design on cwiki and share the link.
>
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@shapeblue.com]
> Sent: Monday, February 20, 2017 7:27 PM
> To: dev@cloudstack.apache.org
> Subject: [PROPOSAL] add native vm-cluster orchestration service
> (was: [PROPOSAL] add native container orchestration service)
>
> So, being very late in the discussion but havingread the whole
> thread before editting the title of this thread,
>
> Can we agree that we want a generic vm-cluster service and leave
> the container bits to containers? Kishan can you share your design?
> Shapeblue wants to rebase their k8 service on top of this and I would like
> yours and Murali's work to not conflict.
>
> daan.hoogl...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, Utrecht Utrecht 3531
> VENetherlands @shapeblue
>
>
>
>
> -Original Message-
> From: Paul Angus [mailto:paul.an...@shapeblue.com]
> Sent: dinsdag 7 februari 2017 08:14
> To: dev@cloudstack.apache.org
> Subject: Re: [PROPOSAL] add native container orchestration service
>
> Will is 100% correct.  As I mentioned the Title is misleading.
> However, Murali did clarify in his explanation; this is really about vm
> cluster orchestration.
>
>
>
> 
> From: Will Stevens 
> Sent: 6 Feb 2017 22:54
> To: dev@cloudstack.apache.org
> Subject: Re: [PROPOSAL] add native container orchestration service
>
> ​My understanding is that what Paul is talking about is what is
> already built and IS what the thread is talking about.​
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Mon, Feb 6, 2017 at 2:29 PM, Rajesh Ramchandani <
> rajesh.ramchand...@accelerite.com> wrote:
>
> > Hi Paul - I think this is different from what the thread was
> about.
> > The conversation was specifically about adding support for
> container
> > orchestrators. You are talking about provisioning a group of VMs.
> > Although, this is something I think several Cloudstack users have
> > requested before and we should propose a solution to this.
> >
> > Raj
> >
> > 
> > From: Paul Angus 
> > Sent: Monday, February 6, 2017 11:16:41 AM
> > To: dev@cloudstack.apache.org
> > Subject: RE: [PROPOSAL] add native container orchestration
> service
> >
> > #WhatHeSaid
> >
> > The title is misleading.  The proposal is purely to add the
> notion of
> > Clusters of VMs to CloudStack.  These may be for databases,
> containers
> > or anything else that needs 'clusters' of compute. Self-healing
> and
> > autoscaling are logical next steps to be added.
> >
> > Those guys at ShapeBlue have open-sourced their whole k8s
> container
> > service piece.  If/when the 'cluster' part of that work is added
> into
> > CloudStack, the k8s specific pieces can be used by anyone who
> wants
> > to, alternatively they could be used for reference in order to
> create
> > another types of cluster.  (or ignored completely).
> >
> >
> >
> >
> > paul.an...@shapeblue.co

[GitHub] cloudstack issue #1883: CLOUDSTACK-9723: Enable unique mac address across th...

2017-02-28 Thread jayapalu
Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1883
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...

2017-02-28 Thread jayapalu
Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1886
  
 tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-28 Thread priyankparihar
Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
Hi @koushik-das, @borisroman,  @serg38,  @jburwell and @ustcweizhou
Things are modified and added according to your suggestions. I think, Now 
LGTM comment should be provided.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

2017-02-28 Thread cloudmonger
Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1873
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 404
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=0
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

2017-02-28 Thread nitin-maharana
Github user nitin-maharana commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@ustcweizhou @koushik-das : I implemented the way @ustcweizhou's suggested. 
It was purely an UI change. But I found an issue while testing.

On API side, the entire logic uses VLAN owner account details, they find it 
from the account given by the user. So, they made account field as mandatory. 
But that contradicts when it is accessed from a project view(This issue). 

The current logic works in a default view because we don't add projectid 
details while accessing the API. But when it is accessed from a particular 
project view, by default the projectid parameter is added with the API call, So 
this issue arises. 

Now, if we go with the change suggested by @ustcweizhou, once we select the 
scope as domain, we don't pass any account details, so the logic can't able to 
find the owner hence gives an error.

According to my suggestion, On API side, we should make the account field 
as optional and on UI front, we should make it mandatory and the account field 
will appear only in case of default view, which will fix the issue. Please give 
your input on this. Accordingly, I will proceed.

Please see the current change(I pushed it here)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Modern template hosting

2017-02-28 Thread Wido den Hollander

> Op 28 februari 2017 om 2:40 schreef Pierre-Luc Dion :
> 
> 
> hi!
> 
> I think we should work with distro provider to have their cloud builds work
> with cloudstack. Good example is CoreOS, it work out of the box from their
> channel builds.
> it shouldn't be too complicated to have centos, ubuntu and debian, unless
> ...

I fully agree. I think that we shouldn't bother about VM templates. CentOS and 
Ubuntu both have a proper template which we can include.

The less we host as a project, the better.

Keep in mind that we host a Open Source project. the RPM and DEB packages on 
cloudstack.apt-get.eu are a service, but we release source as a project.

Wido

> 
> For our systemvm templates, can we just change the URL for somthing like
> cloudstack.apache.org/systemvm/... ?
> and for old systemvm that are depricated but that we might want to keep,
> could we archive them into a github repo in
> https://github.com/apachecloudstack ?
> 
> 
> 
> 
> On Mon, Feb 27, 2017 at 6:28 PM, Chiradeep Vittal 
> wrote:
> 
> > My stance is that the current workflow does a disservice to the user
> > community by letting them install / use outdated and insecure templates.
> > Now, let's assume download.cloud.com is gone forever. What do we tell ACS
> > users pre-4.11 as far as *built-in templates* go?
> > 1. Direct them to update templates.sql with some new URL, but with the same
> > dirty old templates
> > 2. Direct them to update templates.sql with some new URL, but with nice
> > templates (e.g., open.vm.eu)
> > 3. Same as (2), but document more choices.
> >
> > Now, why should things be different for 4.11 and later? Documenting the
> > steps to install templates offline is trivial (and can be scripted to a
> > large part, like cloud-install-sys-tmplt)
> >
> > For pre-4.11 users, for *systemvms*, anyway we tell them to use
> > http://cloudstack.apt-get.eu which is not controlled by ACS.
> >
> >
> > On Mon, Feb 27, 2017 at 2:50 PM, Rafael Weingärtner <
> > rafaelweingart...@gmail.com> wrote:
> >
> > > Agree with you.
> > > We need to support the current working flow. And then, define the first
> > > version that will start using the new approach.
> > >
> > > On Mon, Feb 27, 2017 at 5:36 PM, Will Stevens 
> > > wrote:
> > >
> > > > I think we almost need a two pronged approach.
> > > >
> > > > 1) Get a solution in place which will enable us to document and serve
> > > > templates for legacy systems.  I will work on this.
> > > > 2) Discuss and understand how we SHOULD be handling this problem in the
> > > > future and in what release we can expect it.
> > > >
> > > > I think we need to do both.  I think we should start to try to really
> > > > understand what we want to deliver in (2) going forward.
> > > >
> > > > *Will STEVENS*
> > > > Lead Developer
> > > >
> > > > 
> > > >
> > > > On Mon, Feb 27, 2017 at 4:53 PM, Rafael Weingärtner <
> > > > rafaelweingart...@gmail.com> wrote:
> > > >
> > > > > My worry is exactly with system VMs templates.
> > > > >
> > > > > Currently, we indicate administrators to download them from
> > > > > http://cloudstack.apt-get.eu/systemvm/4.6/ [1]. However, the
> > > > installation
> > > > > docs do not mention the expected hashes for the file that is going to
> > > be
> > > > > downloaded.
> > > > > Also, I do not know the code that downloads system VMs templates
> > (when
> > > > > upgrading), but if the hash being checked is taken from the mirror
> > used
> > > > to
> > > > > download the file; the only thing it checks is that if the download
> > > > > finished successfully (no transmission errors). If we want to check
> > > > > integrity, check that the template we created is untampered; we need
> > to
> > > > > host and serve the hash in a secure manner.
> > > > >
> > > > > [1]
> > > > > http://docs.cloudstack.apache.org/projects/cloudstack-
> > > > installation/en/4.9/
> > > > > management-server/index.html#prepare-the-system-vm-template
> > > > >
> > > > >
> > > > > On Mon, Feb 27, 2017 at 4:36 PM, Chiradeep Vittal <
> > > chirade...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Hashes are checked (md5 IIRC) today.
> > > > > > But given the issues, I think the project should steer away from
> > > > hosting
> > > > > > templates except the systemvm template.
> > > > > >
> > > > > > On Mon, Feb 27, 2017 at 1:31 PM, Rafael Weingärtner <
> > > > > > rafaelweingart...@gmail.com> wrote:
> > > > > >
> > > > > > > Will, I think we could support different path structures. This
> > can
> > > > > > > facilitate different deployment of mirrors based on the structure
> > > the
> > > > > > host
> > > > > > > has.
> > > > > > >
> > > > > > > Could I add something else to the discussion? Have we discussed
> > the
> > > > > > > security impacts of setting up this mirrors approach?
> > > > > > > I mean, if any of the mirrors gets corrupted (let`s say by a
> > > hacker),
> > > > > and
> > > > > > > the templates are injected with malicious code, an attacker could
> > > > > > > 

Re: [PROPOSAL] add native vm-cluster orchestration service (was: [PROPOSAL] add native container orchestration service)

2017-02-28 Thread Daan Hoogland
Syed, I chose machine as they might be bare metal in some cases.

Sent from Nine

From: Syed Ahmed 
Sent: 28 Feb 2017 4:22 pm
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] add native vm-cluster orchestration service (was: 
[PROPOSAL] add native container orchestration service)

We already call the VMs as Instances. So, InstanceCluster would be a better
name imo.

On Tue, Feb 28, 2017 at 10:05 AM, Daan Hoogland  wrote:

> Kishan, I see some sensible additions but also some unnecessary omissions.
> Most of it seems to be Murali’s text so I’ll c&p your improvements back and
> rename the page to the more sensible title of “MachineCluster service” and
> delete the other.
>
> About naming, I was thinking MachineCluster instead of ServiceCluster,
> makes sense? Or even GuestMachineCluster. ServiceCluster could mean a
> supporting cluster that delivers e.g. backup as a service to guests, or
> maybe some build, artifact or networking service. For this ambiguity im am
> :-1: on the name ServiceCluster.
>
>
> On 28/02/17 11:16, "Kishan Kavala"  wrote:
>
> Daan,
>  I've updated the earlier spec to support any Vm cluster. Please let
> me know your thoughts on this.
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/
> Service+Cluster+Functional+Specification
>
> regards,
> Kishan
>
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@shapeblue.com]
> Sent: 27 February 2017 04:02 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [PROPOSAL] add native vm-cluster orchestration service
> (was: [PROPOSAL] add native container orchestration service)
>
> Any follow up Koushik? I want to refactor our proof of concept and
> integrate it in master.
>
> On 21/02/17 10:42, "Kishan Kavala" 
> wrote:
>
> Sure Daan. I'll publish the design on cwiki and share the link.
>
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@shapeblue.com]
> Sent: Monday, February 20, 2017 7:27 PM
> To: dev@cloudstack.apache.org
> Subject: [PROPOSAL] add native vm-cluster orchestration service
> (was: [PROPOSAL] add native container orchestration service)
>
> So, being very late in the discussion but havingread the whole
> thread before editting the title of this thread,
>
> Can we agree that we want a generic vm-cluster service and leave
> the container bits to containers? Kishan can you share your design?
> Shapeblue wants to rebase their k8 service on top of this and I would like
> yours and Murali's work to not conflict.
>
> daan.hoogl...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, Utrecht Utrecht 3531
> VENetherlands @shapeblue
>
>
>
>
> -Original Message-
> From: Paul Angus [mailto:paul.an...@shapeblue.com]
> Sent: dinsdag 7 februari 2017 08:14
> To: dev@cloudstack.apache.org
> Subject: Re: [PROPOSAL] add native container orchestration service
>
> Will is 100% correct.  As I mentioned the Title is misleading.
> However, Murali did clarify in his explanation; this is really about vm
> cluster orchestration.
>
>
>
> 
> From: Will Stevens 
> Sent: 6 Feb 2017 22:54
> To: dev@cloudstack.apache.org
> Subject: Re: [PROPOSAL] add native container orchestration service
>
> ​My understanding is that what Paul is talking about is what is
> already built and IS what the thread is talking about.​
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Mon, Feb 6, 2017 at 2:29 PM, Rajesh Ramchandani <
> rajesh.ramchand...@accelerite.com> wrote:
>
> > Hi Paul - I think this is different from what the thread was
> about.
> > The conversation was specifically about adding support for
> container
> > orchestrators. You are talking about provisioning a group of VMs.
> > Although, this is something I think several Cloudstack users have
> > requested before and we should propose a solution to this.
> >
> > Raj
> >
> > 
> > From: Paul Angus 
> > Sent: Monday, February 6, 2017 11:16:41 AM
> > To: dev@cloudstack.apache.org
> > Subject: RE: [PROPOSAL] add native container orchestration
> service
> >
> > #WhatHeSaid
> >
> > The title is misleading.  The proposal is purely to add the
> notion of
> > Clusters of VMs to CloudStack.  These may be for databases,
> containers
> > or anything else that needs 'clusters' of compute. Self-healing
> and
> > autoscaling are logical next steps to be added.
> >
> > Those guys at ShapeBlue have open-sourced their whole k8s
> container
> > service piece.

Re: Modern template hosting

2017-02-28 Thread Chiradeep Vittal
To repeat what was discussed earlier in the thread: the cloud templates
provided by Ubuntu and CentOS do not work because they expect the metadata
URL to be at http://169.254.269.254/. Well, they work, but they take
awfully long to time out and after they time out, you still wouldn't  be
able to login since they do not install the ssh keys.

On Tue, Feb 28, 2017 at 9:34 AM, Wido den Hollander  wrote:

>
> > Op 28 februari 2017 om 2:40 schreef Pierre-Luc Dion  >:
> >
> >
> > hi!
> >
> > I think we should work with distro provider to have their cloud builds
> work
> > with cloudstack. Good example is CoreOS, it work out of the box from
> their
> > channel builds.
> > it shouldn't be too complicated to have centos, ubuntu and debian, unless
> > ...
>
> I fully agree. I think that we shouldn't bother about VM templates. CentOS
> and Ubuntu both have a proper template which we can include.
>
> The less we host as a project, the better.
>
> Keep in mind that we host a Open Source project. the RPM and DEB packages
> on cloudstack.apt-get.eu are a service, but we release source as a
> project.
>
> Wido
>
> >
> > For our systemvm templates, can we just change the URL for somthing like
> > cloudstack.apache.org/systemvm/... ?
> > and for old systemvm that are depricated but that we might want to keep,
> > could we archive them into a github repo in
> > https://github.com/apachecloudstack ?
> >
> >
> >
> >
> > On Mon, Feb 27, 2017 at 6:28 PM, Chiradeep Vittal 
> > wrote:
> >
> > > My stance is that the current workflow does a disservice to the user
> > > community by letting them install / use outdated and insecure
> templates.
> > > Now, let's assume download.cloud.com is gone forever. What do we tell
> ACS
> > > users pre-4.11 as far as *built-in templates* go?
> > > 1. Direct them to update templates.sql with some new URL, but with the
> same
> > > dirty old templates
> > > 2. Direct them to update templates.sql with some new URL, but with nice
> > > templates (e.g., open.vm.eu)
> > > 3. Same as (2), but document more choices.
> > >
> > > Now, why should things be different for 4.11 and later? Documenting the
> > > steps to install templates offline is trivial (and can be scripted to a
> > > large part, like cloud-install-sys-tmplt)
> > >
> > > For pre-4.11 users, for *systemvms*, anyway we tell them to use
> > > http://cloudstack.apt-get.eu which is not controlled by ACS.
> > >
> > >
> > > On Mon, Feb 27, 2017 at 2:50 PM, Rafael Weingärtner <
> > > rafaelweingart...@gmail.com> wrote:
> > >
> > > > Agree with you.
> > > > We need to support the current working flow. And then, define the
> first
> > > > version that will start using the new approach.
> > > >
> > > > On Mon, Feb 27, 2017 at 5:36 PM, Will Stevens  >
> > > > wrote:
> > > >
> > > > > I think we almost need a two pronged approach.
> > > > >
> > > > > 1) Get a solution in place which will enable us to document and
> serve
> > > > > templates for legacy systems.  I will work on this.
> > > > > 2) Discuss and understand how we SHOULD be handling this problem
> in the
> > > > > future and in what release we can expect it.
> > > > >
> > > > > I think we need to do both.  I think we should start to try to
> really
> > > > > understand what we want to deliver in (2) going forward.
> > > > >
> > > > > *Will STEVENS*
> > > > > Lead Developer
> > > > >
> > > > > 
> > > > >
> > > > > On Mon, Feb 27, 2017 at 4:53 PM, Rafael Weingärtner <
> > > > > rafaelweingart...@gmail.com> wrote:
> > > > >
> > > > > > My worry is exactly with system VMs templates.
> > > > > >
> > > > > > Currently, we indicate administrators to download them from
> > > > > > http://cloudstack.apt-get.eu/systemvm/4.6/ [1]. However, the
> > > > > installation
> > > > > > docs do not mention the expected hashes for the file that is
> going to
> > > > be
> > > > > > downloaded.
> > > > > > Also, I do not know the code that downloads system VMs templates
> > > (when
> > > > > > upgrading), but if the hash being checked is taken from the
> mirror
> > > used
> > > > > to
> > > > > > download the file; the only thing it checks is that if the
> download
> > > > > > finished successfully (no transmission errors). If we want to
> check
> > > > > > integrity, check that the template we created is untampered; we
> need
> > > to
> > > > > > host and serve the hash in a secure manner.
> > > > > >
> > > > > > [1]
> > > > > > http://docs.cloudstack.apache.org/projects/cloudstack-
> > > > > installation/en/4.9/
> > > > > > management-server/index.html#prepare-the-system-vm-template
> > > > > >
> > > > > >
> > > > > > On Mon, Feb 27, 2017 at 4:36 PM, Chiradeep Vittal <
> > > > chirade...@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > Hashes are checked (md5 IIRC) today.
> > > > > > > But given the issues, I think the project should steer away
> from
> > > > > hosting
> > > > > > > templates except the systemvm template.
> > > > > > >
> > > > > > > On Mon, Feb 27, 2017 at 1:31 PM, Ra

Re: Modern template hosting

2017-02-28 Thread Wido den Hollander

> Op 28 februari 2017 om 18:55 schreef Chiradeep Vittal :
> 
> 
> To repeat what was discussed earlier in the thread: the cloud templates
> provided by Ubuntu and CentOS do not work because they expect the metadata
> URL to be at http://169.254.269.254/. Well, they work, but they take
> awfully long to time out and after they time out, you still wouldn't  be
> able to login since they do not install the ssh keys.

But that is a 'simple fix' in the VR. Like you mentioned, add a DNAT rule in 
the VR and have the VR handle the traffic.

Wido

> 
> On Tue, Feb 28, 2017 at 9:34 AM, Wido den Hollander  wrote:
> 
> >
> > > Op 28 februari 2017 om 2:40 schreef Pierre-Luc Dion  > >:
> > >
> > >
> > > hi!
> > >
> > > I think we should work with distro provider to have their cloud builds
> > work
> > > with cloudstack. Good example is CoreOS, it work out of the box from
> > their
> > > channel builds.
> > > it shouldn't be too complicated to have centos, ubuntu and debian, unless
> > > ...
> >
> > I fully agree. I think that we shouldn't bother about VM templates. CentOS
> > and Ubuntu both have a proper template which we can include.
> >
> > The less we host as a project, the better.
> >
> > Keep in mind that we host a Open Source project. the RPM and DEB packages
> > on cloudstack.apt-get.eu are a service, but we release source as a
> > project.
> >
> > Wido
> >
> > >
> > > For our systemvm templates, can we just change the URL for somthing like
> > > cloudstack.apache.org/systemvm/... ?
> > > and for old systemvm that are depricated but that we might want to keep,
> > > could we archive them into a github repo in
> > > https://github.com/apachecloudstack ?
> > >
> > >
> > >
> > >
> > > On Mon, Feb 27, 2017 at 6:28 PM, Chiradeep Vittal 
> > > wrote:
> > >
> > > > My stance is that the current workflow does a disservice to the user
> > > > community by letting them install / use outdated and insecure
> > templates.
> > > > Now, let's assume download.cloud.com is gone forever. What do we tell
> > ACS
> > > > users pre-4.11 as far as *built-in templates* go?
> > > > 1. Direct them to update templates.sql with some new URL, but with the
> > same
> > > > dirty old templates
> > > > 2. Direct them to update templates.sql with some new URL, but with nice
> > > > templates (e.g., open.vm.eu)
> > > > 3. Same as (2), but document more choices.
> > > >
> > > > Now, why should things be different for 4.11 and later? Documenting the
> > > > steps to install templates offline is trivial (and can be scripted to a
> > > > large part, like cloud-install-sys-tmplt)
> > > >
> > > > For pre-4.11 users, for *systemvms*, anyway we tell them to use
> > > > http://cloudstack.apt-get.eu which is not controlled by ACS.
> > > >
> > > >
> > > > On Mon, Feb 27, 2017 at 2:50 PM, Rafael Weingärtner <
> > > > rafaelweingart...@gmail.com> wrote:
> > > >
> > > > > Agree with you.
> > > > > We need to support the current working flow. And then, define the
> > first
> > > > > version that will start using the new approach.
> > > > >
> > > > > On Mon, Feb 27, 2017 at 5:36 PM, Will Stevens  > >
> > > > > wrote:
> > > > >
> > > > > > I think we almost need a two pronged approach.
> > > > > >
> > > > > > 1) Get a solution in place which will enable us to document and
> > serve
> > > > > > templates for legacy systems.  I will work on this.
> > > > > > 2) Discuss and understand how we SHOULD be handling this problem
> > in the
> > > > > > future and in what release we can expect it.
> > > > > >
> > > > > > I think we need to do both.  I think we should start to try to
> > really
> > > > > > understand what we want to deliver in (2) going forward.
> > > > > >
> > > > > > *Will STEVENS*
> > > > > > Lead Developer
> > > > > >
> > > > > > 
> > > > > >
> > > > > > On Mon, Feb 27, 2017 at 4:53 PM, Rafael Weingärtner <
> > > > > > rafaelweingart...@gmail.com> wrote:
> > > > > >
> > > > > > > My worry is exactly with system VMs templates.
> > > > > > >
> > > > > > > Currently, we indicate administrators to download them from
> > > > > > > http://cloudstack.apt-get.eu/systemvm/4.6/ [1]. However, the
> > > > > > installation
> > > > > > > docs do not mention the expected hashes for the file that is
> > going to
> > > > > be
> > > > > > > downloaded.
> > > > > > > Also, I do not know the code that downloads system VMs templates
> > > > (when
> > > > > > > upgrading), but if the hash being checked is taken from the
> > mirror
> > > > used
> > > > > > to
> > > > > > > download the file; the only thing it checks is that if the
> > download
> > > > > > > finished successfully (no transmission errors). If we want to
> > check
> > > > > > > integrity, check that the template we created is untampered; we
> > need
> > > > to
> > > > > > > host and serve the hash in a secure manner.
> > > > > > >
> > > > > > > [1]
> > > > > > > http://docs.cloudstack.apache.org/projects/cloudstack-
> > > > > > installation/en/4.9/
> > > > > > > management-server/index.

Re: Modern template hosting

2017-02-28 Thread Chiradeep Vittal
Yes, that's my preferred solution. But there's a couple of scenarios to be
dealt with:
 1. standard isolated networks where the VR is the default router
 2. basic zone where the VR is not the default router
 3. isolated networks where the VR is not the default router

For (2) and (3) you may have to send down a static route in the DHCP
response to point 169.254.169.254 to the VR (or do it in all cases,
shouldn't be a big deal).


On Tue, Feb 28, 2017 at 9:57 AM, Wido den Hollander  wrote:

>
> > Op 28 februari 2017 om 18:55 schreef Chiradeep Vittal <
> chirade...@gmail.com>:
> >
> >
> > To repeat what was discussed earlier in the thread: the cloud templates
> > provided by Ubuntu and CentOS do not work because they expect the
> metadata
> > URL to be at http://169.254.269.254/. Well, they work, but they take
> > awfully long to time out and after they time out, you still wouldn't  be
> > able to login since they do not install the ssh keys.
>
> But that is a 'simple fix' in the VR. Like you mentioned, add a DNAT rule
> in the VR and have the VR handle the traffic.
>
> Wido
>
> >
> > On Tue, Feb 28, 2017 at 9:34 AM, Wido den Hollander 
> wrote:
> >
> > >
> > > > Op 28 februari 2017 om 2:40 schreef Pierre-Luc Dion <
> pdion...@apache.org
> > > >:
> > > >
> > > >
> > > > hi!
> > > >
> > > > I think we should work with distro provider to have their cloud
> builds
> > > work
> > > > with cloudstack. Good example is CoreOS, it work out of the box from
> > > their
> > > > channel builds.
> > > > it shouldn't be too complicated to have centos, ubuntu and debian,
> unless
> > > > ...
> > >
> > > I fully agree. I think that we shouldn't bother about VM templates.
> CentOS
> > > and Ubuntu both have a proper template which we can include.
> > >
> > > The less we host as a project, the better.
> > >
> > > Keep in mind that we host a Open Source project. the RPM and DEB
> packages
> > > on cloudstack.apt-get.eu are a service, but we release source as a
> > > project.
> > >
> > > Wido
> > >
> > > >
> > > > For our systemvm templates, can we just change the URL for somthing
> like
> > > > cloudstack.apache.org/systemvm/... ?
> > > > and for old systemvm that are depricated but that we might want to
> keep,
> > > > could we archive them into a github repo in
> > > > https://github.com/apachecloudstack ?
> > > >
> > > >
> > > >
> > > >
> > > > On Mon, Feb 27, 2017 at 6:28 PM, Chiradeep Vittal <
> chirade...@gmail.com>
> > > > wrote:
> > > >
> > > > > My stance is that the current workflow does a disservice to the
> user
> > > > > community by letting them install / use outdated and insecure
> > > templates.
> > > > > Now, let's assume download.cloud.com is gone forever. What do we
> tell
> > > ACS
> > > > > users pre-4.11 as far as *built-in templates* go?
> > > > > 1. Direct them to update templates.sql with some new URL, but with
> the
> > > same
> > > > > dirty old templates
> > > > > 2. Direct them to update templates.sql with some new URL, but with
> nice
> > > > > templates (e.g., open.vm.eu)
> > > > > 3. Same as (2), but document more choices.
> > > > >
> > > > > Now, why should things be different for 4.11 and later?
> Documenting the
> > > > > steps to install templates offline is trivial (and can be scripted
> to a
> > > > > large part, like cloud-install-sys-tmplt)
> > > > >
> > > > > For pre-4.11 users, for *systemvms*, anyway we tell them to use
> > > > > http://cloudstack.apt-get.eu which is not controlled by ACS.
> > > > >
> > > > >
> > > > > On Mon, Feb 27, 2017 at 2:50 PM, Rafael Weingärtner <
> > > > > rafaelweingart...@gmail.com> wrote:
> > > > >
> > > > > > Agree with you.
> > > > > > We need to support the current working flow. And then, define the
> > > first
> > > > > > version that will start using the new approach.
> > > > > >
> > > > > > On Mon, Feb 27, 2017 at 5:36 PM, Will Stevens <
> wstev...@cloudops.com
> > > >
> > > > > > wrote:
> > > > > >
> > > > > > > I think we almost need a two pronged approach.
> > > > > > >
> > > > > > > 1) Get a solution in place which will enable us to document and
> > > serve
> > > > > > > templates for legacy systems.  I will work on this.
> > > > > > > 2) Discuss and understand how we SHOULD be handling this
> problem
> > > in the
> > > > > > > future and in what release we can expect it.
> > > > > > >
> > > > > > > I think we need to do both.  I think we should start to try to
> > > really
> > > > > > > understand what we want to deliver in (2) going forward.
> > > > > > >
> > > > > > > *Will STEVENS*
> > > > > > > Lead Developer
> > > > > > >
> > > > > > > 
> > > > > > >
> > > > > > > On Mon, Feb 27, 2017 at 4:53 PM, Rafael Weingärtner <
> > > > > > > rafaelweingart...@gmail.com> wrote:
> > > > > > >
> > > > > > > > My worry is exactly with system VMs templates.
> > > > > > > >
> > > > > > > > Currently, we indicate administrators to download them from
> > > > > > > > http://cloudstack.apt-get.eu/systemvm/4.6/ [1]. However, the
> > > > > 

[GitHub] cloudstack issue #1241: CLOUDSTACK-9162: Unable to add VPN user via API with...

2017-02-28 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1241
  
Trillian test result (tid-910)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31888 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1241-t910-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 46 look ok, 3 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 373.92 
| test_vpc_redundant.py
test_04_rvpc_privategw_static_routes | `Failure` | 330.43 | 
test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.04 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 160.67 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.17 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 255.69 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 282.04 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 533.28 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 509.17 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1401.24 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 549.79 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 751.72 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.54 | test_volumes.py
test_08_resize_volume | Success | 156.42 | test_volumes.py
test_07_resize_fail | Success | 161.54 | test_volumes.py
test_06_download_detached_volume | Success | 156.32 | test_volumes.py
test_05_detach_volume | Success | 155.78 | test_volumes.py
test_04_delete_attached_volume | Success | 151.25 | test_volumes.py
test_03_download_attached_volume | Success | 156.46 | test_volumes.py
test_02_attach_volume | Success | 94.38 | test_volumes.py
test_01_create_volume | Success | 712.32 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.14 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 95.67 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 158.65 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 247.67 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 27.00 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.18 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 30.83 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 131.01 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.86 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.68 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 40.51 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.06 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.13 | test_templates.py
test_03_delete_template | Success | 5.12 | test_templates.py
test_02_edit_template | Success | 90.11 | test_templates.py
test_01_create_template | Success | 45.51 | test_templates.py
test_10_destroy_cpvm | Success | 161.68 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.71 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.55 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.51 | test_ssvm.py
test_06_stop_cpvm | Success | 131.71 | test_ssvm.py
test_05_stop_ssvm | Success | 168.72 | test_ssvm.py
test_04_cpvm_internals | Success | 1.19 | test_ssvm.py
test_03_ssvm_internals | Success | 3.28 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.07 | test_snapshots.py
test_04_change_offering_small | Success | 239.71 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.07 | test_service_offerings.py
test_01_create_service_offering | Success | 0.10 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.17 | test_secondary_storage.py
test_09_reboot_router | Success | 35.32 

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-28 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
Hi @rafaelweingartner, I've refactored the code instead of using 
`rollBackState` as static. I think that using static variable could lead to a 
problem if new methods are invoked from another method different than 
`deleteDomain` method. Instead of declaring it as static, we reduced the scope 
again and only set it true when `CloudRuntimeException` is thrown. What do you 
think about this refactor? I tryied not to introduce major changes in original 
code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-28 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
Thanks @priyankparihar . We verified in our environment that all is working 
fine  including UI part.
LGTM
I think this one is 
tag:mergeready



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2017-02-28 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1257
  
Trillian test result (tid-909)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44025 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1257-t909-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 45 look ok, 4 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_test_vm_volume_snapshot | `Failure` | 337.51 | test_vm_snapshots.py
test_04_rvpc_privategw_static_routes | `Failure` | 803.96 | 
test_privategw_acl.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Error` | 458.04 | test_vpc_redundant.py
test_02_list_snapshots_with_removed_data_store | `Error` | 116.05 | 
test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 121.14 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 367.07 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 151.74 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 563.17 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 339.81 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 671.25 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 652.85 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1548.46 | 
test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 630.35 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1355.86 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 25.79 | test_volumes.py
test_06_download_detached_volume | Success | 50.55 | test_volumes.py
test_05_detach_volume | Success | 100.23 | test_volumes.py
test_04_delete_attached_volume | Success | 15.25 | test_volumes.py
test_03_download_attached_volume | Success | 20.30 | test_volumes.py
test_02_attach_volume | Success | 54.49 | test_volumes.py
test_01_create_volume | Success | 518.56 | test_volumes.py
test_change_service_offering_for_vm_with_snapshots | Success | 418.33 | 
test_vm_snapshots.py
test_03_delete_vm_snapshots | Success | 275.19 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 219.12 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 128.89 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 277.99 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.83 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.16 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 66.16 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.10 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 5.11 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 5.19 | test_vm_life_cycle.py
test_02_start_vm | Success | 20.20 | test_vm_life_cycle.py
test_01_stop_vm | Success | 10.14 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 191.27 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.08 | test_templates.py
test_04_extract_template | Success | 10.27 | test_templates.py
test_03_delete_template | Success | 5.10 | test_templates.py
test_02_edit_template | Success | 90.17 | test_templates.py
test_01_create_template | Success | 85.65 | test_templates.py
test_10_destroy_cpvm | Success | 241.74 | test_ssvm.py
test_09_destroy_ssvm | Success | 328.82 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.47 | test_ssvm.py
test_07_reboot_ssvm | Success | 128.08 | test_ssvm.py
test_06_stop_cpvm | Success | 206.97 | test_ssvm.py
test_05_stop_ssvm | Success | 173.51 | test_ssvm.py
test_04_cpvm_internals | Success | 1.16 | test_ssvm.py
test_03_ssvm_internals | Success | 3.11 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.11 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.12 | test_ssvm.py
test_01_snapshot_root_disk | Success | 61.65 | test_snapshots.py
test_04_change_offering_small | Success | 91.82 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.09 

  1   2   >