[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

2017-02-09 Thread koushik-das 
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1727#discussion_r100267498
  
--- Diff: setup/db/db/schema-490to4910.sql ---
@@ -71,3 +71,17 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` 
(uuid,hypervisor_type, hypervis
 INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'VMware', '6.0', 'sles11_64Guest', 187, utc_timestamp(), 0);
 INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'VMware', '6.0', 'sles11Guest', 188, utc_timestamp(), 0);
 INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'VMware', '6.0', 'sles12_64Guest', 244, utc_timestamp(), 0);
+
+-- Add service_offering_id column to vm_snapshots table
--- End diff --

@nvazquez This should be either in schema-4920to41000.sql or 
schema-4920to4930.sql if there is a plan for 4.9.3. 490to4910 is not the 
correct one to put these schema changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1933: CLOUDSTACK-9569: add router.aggregation.command.each...

2017-02-09 Thread koushik-das 
Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1933
  
@abhinandanprateek Looks like there is another PR #1856 related to this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1930: CLOUDSTACK-9687: if the allocated amount is 0 the ca...

2017-02-09 Thread koushik-das 
Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1930
  
Code changes LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1906: CLOUDSTACK-9743 - ODL plugin responds to dele...

2017-02-09 Thread koushik-das 
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1906#discussion_r100281158
  
--- Diff: 
plugins/network-elements/opendaylight/src/main/java/org/apache/cloudstack/network/opendaylight/OpendaylightElement.java
 ---
@@ -156,7 +153,7 @@ public HostVO createHostVOForDirectConnectAgent(HostVO 
host, StartupCommand[] st
 
 @Override
 public DeleteHostAnswer deleteHost(HostVO host, boolean isForced, 
boolean isForceDeleteStorage) throws UnableDeleteHostException {
-return new DeleteHostAnswer(true);
+return null;
--- End diff --

@syed I am not sure if this is used or maintained by anyone. But the right 
fix may be to use some checks to return a valid answer or null. How is this 
handled in some of the other network elements?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-09 Thread nvazquez 
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
@rafaelweingartner excellent, I added both test cases on 
`VMSnapshotManagerTest`, thanks!
@koushik-das thanks for pointing that out, I agree with you that db changes 
should be in `schema-4920to4930.sql`, but it still no file on 4.9 branch, so I 
moved changes to `schema-4910to4920.sql` in the mean time. @karuturi is there a 
plan for 4.9.3 or should I retarget this PR to master branch so I could include 
changes in `schema-4920to41000.sql`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

2017-02-09 Thread swill 
Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1741
  


### CI RESULTS

```
Tests Run: 87
  Skipped: 1
   Failed: 4
   Errors: 0
 Duration: 9h 13m 51s
```

**Summary of the problem(s):**
```
FAIL: Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test 
Network GC Nics
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_redundant.py", line 
635, in test_04_rvpc_network_garbage_collector_nics
self.do_vpc_test(False)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_redundant.py", line 
727, in do_vpc_test
self.check_ssh_into_vm(vm.get_vm(), vm.get_ip(), expectFail=expectFail, 
retries=retries)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_redundant.py", line 
571, in check_ssh_into_vm
self.fail("Failed to SSH into VM - %s" % 
(public_ip.ipaddress.ipaddress))
AssertionError: Failed to SSH into VM - 192.168.23.5
--
Additional details in: /tmp/MarvinLogs/test_network_23KW40/results.txt
```

```
FAIL: test_02_vpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
271, in test_02_vpc_privategw_static_routes
self.performVPCTests(vpc_off)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
362, in performVPCTests
self.check_pvt_gw_connectivity(vm1, public_ip_1, [vm2.nic[0].ipaddress, 
vm1.nic[0].ipaddress])
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
724, in check_pvt_gw_connectivity
"Ping to VM on Network Tier N from VM in Network Tier A should be 
successful at least for 2 out of 3 VMs"
AssertionError: Ping to VM on Network Tier N from VM in Network Tier A 
should be successful at least for 2 out of 3 VMs
--
Additional details in: /tmp/MarvinLogs/test_network_23KW40/results.txt
```

```
FAIL: test_03_vpc_privategw_restart_vpc_cleanup 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
283, in test_03_vpc_privategw_restart_vpc_cleanup
self.performVPCTests(vpc_off, restart_with_cleanup = True)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
362, in performVPCTests
self.check_pvt_gw_connectivity(vm1, public_ip_1, [vm2.nic[0].ipaddress, 
vm1.nic[0].ipaddress])
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
724, in check_pvt_gw_connectivity
"Ping to VM on Network Tier N from VM in Network Tier A should be 
successful at least for 2 out of 3 VMs"
AssertionError: Ping to VM on Network Tier N from VM in Network Tier A 
should be successful at least for 2 out of 3 VMs
--
Additional details in: /tmp/MarvinLogs/test_network_23KW40/results.txt
```

```
FAIL: test_04_rvpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
295, in test_04_rvpc_privategw_static_routes
self.performVPCTests(vpc_off)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
362, in performVPCTests
self.check_pvt_gw_connectivity(vm1, public_ip_1, [vm2.nic[0].ipaddress, 
vm1.nic[0].ipaddress])
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
724, in check_pvt_gw_connectivity
"Ping to VM on Network Tier N from VM in Network Tier A should be 
successful at least for 2 out of 3 VMs"
AssertionError: Ping to VM on Network Tier N from VM in Network Tier A 
should be successful at least for 2 out of 3 VMs
--
Additional details in: /tmp/MarvinLogs/test_network_23KW40/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__Feb_08_2017_21_26_59_GVX6SA:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1741/tmp/MarvinL

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

2017-02-09 Thread swill 
Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1741
  
Here is the CI run for this PR using my KVM Bubble environment.  This CI 
run is using a SystemVM built from this PR branch (required for a valid test) 
and since we have not been able to do that with Trillian (so far), only my CI 
runs are actually testing this functionality correctly (so far).

The failures listed are not associated with my PR.  Historically, I have 
had some trouble with consistency with connectivity inside a bubble CI run, so 
it is possible that could be coming into play as well.

I think this PR is ready.  We have been running this PR in production for 
two months now and it fixes a lot of problems.  Can I please get some LGTM on 
this so we can get it into 4.10?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

2017-02-09 Thread DaanHoogland 
Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1741
  
I started a build yesterday but am not at my computer today. I'll look at
the results later.

Biligual auto correct use.  Read at your own risico

On 8 Feb 2017 4:58 pm, "Will Stevens"  wrote:

> @DaanHoogland  I don't think this will
> work. I think you have to manually specify a SystemVM template built from
> this PR in order for the tests to work. I don't think a SystemVM from this
> PR is used by default.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-09 Thread DaanHoogland 
Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1747
  
@blueorangutan package 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-09 Thread blueorangutan 
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1747
  
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-09 Thread blueorangutan 
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1747
  
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-09 Thread DaanHoogland 
Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1747
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-09 Thread blueorangutan 
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1747
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-476


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1282: CLOUDSTACK-9200: Fixed failed to delete snapshot if ...

2017-02-09 Thread Slair1 
Github user Slair1 commented on the issue:

https://github.com/apache/cloudstack/pull/1282
  
@anshul1886 any idea why this hasn't been merged yet?  are there 
concerns/issues?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-09 Thread karuturi 
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
Its an enhancement. It should be for the next major release which is 
4.10(on master branch)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1282: CLOUDSTACK-9200: Fixed failed to delete snapshot if ...

2017-02-09 Thread karuturi 
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1282
  
@Slair1 Its missing required reviews and tests.(We have a huge backlog. any 
help in code review/test run is welcome). please refer to 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-09 Thread rafaelweingartner 
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
Perfect @nvazquez 
Thanks for all of the hard work 👍 

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

2017-02-09 Thread swill 
Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1741
  
@DaanHoogland did you make the test run in Trillian install a SystemVM 
built from this PR?  If you didn't it won't actually be a valid test run...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

2017-02-09 Thread DaanHoogland 
Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1741
  
@swill I know and work needs done. On the other hand, you mentioned you
wanted to see this run in trillian. You still want that? Else I will skip
and just review the code tomorrow.

Biligual auto correct use.  Read at your own risico

On 9 Feb 2017 6:29 pm, "Will Stevens"  wrote:

> @DaanHoogland  did you make the test run
> in Trillian install a SystemVM built from this PR? If you didn't it won't
> actually be a valid test run...
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

2017-02-09 Thread swill 
Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1741
  
@DaanHoogland: yes, I want it run in Trillian, but my understanding is that 
manual steps need to be taken in the test setup for Trillian in order to first 
build the SystemVM from this PR and then use that SystemVM in the Trillian test 
run.  That has not been done, and any test done by Trillian without that done 
is not a valid test of the PR.  Make sense?  

So yes, I would like to have this run against Trillian, but it is only 
valid if the run includes the SystemVM from this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-09 Thread nvazquez 
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
@rafaelweingartner @koushik-das @karuturi
Great, I've re-targeted PR to master branch. Thanks for your help!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request #1906: CLOUDSTACK-9743 - ODL plugin responds to dele...

2017-02-09 Thread Syed Ahmed 
If no action is being taken, the valid answer is to return null. This will
make the listener logic to try the next listener

On Thu, Feb 9, 2017 at 6:00 AM, koushik-das  wrote:

> Github user koushik-das commented on a diff in the pull request:
>
> https://github.com/apache/cloudstack/pull/1906#discussion_r100281158
>
> --- Diff: plugins/network-elements/opendaylight/src/main/java/
> org/apache/cloudstack/network/opendaylight/OpendaylightElement.java ---
> @@ -156,7 +153,7 @@ public HostVO createHostVOForDirectConnectAgent(HostVO
> host, StartupCommand[] st
>
>  @Override
>  public DeleteHostAnswer deleteHost(HostVO host, boolean isForced,
> boolean isForceDeleteStorage) throws UnableDeleteHostException {
> -return new DeleteHostAnswer(true);
> +return null;
> --- End diff --
>
> @syed I am not sure if this is used or maintained by anyone. But the
> right fix may be to use some checks to return a valid answer or null. How
> is this handled in some of the other network elements?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-09 Thread blueorangutan 
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1747
  
Trillian test result (tid-808)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32193 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1747-t808-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 47 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 368.45 
| test_vpc_redundant.py
test_04_rvpc_privategw_static_routes | `Failure` | 345.44 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 160.24 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.14 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 256.13 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 269.86 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 543.88 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 511.03 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1398.83 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 563.54 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 760.97 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.51 | test_volumes.py
test_08_resize_volume | Success | 156.41 | test_volumes.py
test_07_resize_fail | Success | 161.61 | test_volumes.py
test_06_download_detached_volume | Success | 156.27 | test_volumes.py
test_05_detach_volume | Success | 155.82 | test_volumes.py
test_04_delete_attached_volume | Success | 151.20 | test_volumes.py
test_03_download_attached_volume | Success | 156.32 | test_volumes.py
test_02_attach_volume | Success | 94.87 | test_volumes.py
test_01_create_volume | Success | 711.13 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.21 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 100.69 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 163.79 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 247.55 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.60 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 40.89 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.12 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.81 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.84 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.31 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 35.45 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.05 | test_templates.py
test_04_extract_template | Success | 5.15 | test_templates.py
test_03_delete_template | Success | 5.10 | test_templates.py
test_02_edit_template | Success | 90.18 | test_templates.py
test_01_create_template | Success | 25.32 | test_templates.py
test_10_destroy_cpvm | Success | 131.61 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.68 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.59 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.60 | test_ssvm.py
test_06_stop_cpvm | Success | 161.79 | test_ssvm.py
test_05_stop_ssvm | Success | 133.66 | test_ssvm.py
test_04_cpvm_internals | Success | 1.20 | test_ssvm.py
test_03_ssvm_internals | Success | 3.32 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.22 | test_snapshots.py
test_04_change_offering_small | Success | 239.60 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.12 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.17 | test_secondary_storage.py
test_09_reboot_router | Success | 35.29 | test_routers.py
test_08_start_router | Success | 30.28 | test_routers.py
test_07_stop_router | Success | 10.70 | test_routers.py
test_06_router_ad

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-09 Thread serg38 
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1747
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-09 Thread serg38 
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1747
  
@karuturi Test passed. Two LGTM received. Looks like it is ready for merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-09 Thread serg38 
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
@DaanHoogland @borisstoyanov @rhtyd Guys can you kick off tests for this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-09 Thread borisstoyanov 
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
@blueorangutan package 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-09 Thread blueorangutan 
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1936: [CLOUDSTACK-9773] API: don't break API output with n...

2017-02-09 Thread koushik-das 
Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1936
  
Code changes LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Travis CI test cases failure in PR 1908

2017-02-09 Thread Jayapal Uradi 
Hi,

In PR 1908 few of the test cases are failing which are not related to the this.
vgpu test case is failing. I think this test is not required to run on 
simulator.

Is this the same case for all or I am only getting these error.

https://github.com/apache/cloudstack/pull/1908


Thanks,
Jayapal


DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-09 Thread blueorangutan 
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-477


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-02-09 Thread koushik-das 
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1935#discussion_r100477949
  
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean 
cleanup) {
 
 @Override
 public boolean deleteDomain(DomainVO domain, Boolean cleanup) {
-// mark domain as inactive
-s_logger.debug("Marking domain id=" + domain.getId() + " as " + 
Domain.State.Inactive + " before actually deleting it");
-domain.setState(Domain.State.Inactive);
-_domainDao.update(domain.getId(), domain);
-boolean rollBackState = false;
-boolean hasDedicatedResources = false;
+GlobalLock lock = GlobalLock.getInternLock("AccountCleanup");
+if (lock == null) {
+s_logger.debug("Couldn't get the global lock");
+return false;
+}
+
+if (!lock.lock(30)) {
+s_logger.debug("Couldn't lock the db");
+return false;
+}
 
 try {
-long ownerId = domain.getAccountId();
-if ((cleanup != null) && cleanup.booleanValue()) {
-if (!cleanupDomain(domain.getId(), ownerId)) {
-rollBackState = true;
-CloudRuntimeException e =
-new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
-domain.getId() + ").");
-e.addProxyObject(domain.getUuid(), "domainId");
-throw e;
-}
-} else {
-//don't delete the domain if there are accounts set for 
cleanup, or non-removed networks exist, or domain has dedicated resources
-List networkIds = 
_networkDomainDao.listNetworkIdsByDomain(domain.getId());
-List accountsForCleanup = 
_accountDao.findCleanupsForRemovedAccounts(domain.getId());
-List dedicatedResources = 
_dedicatedDao.listByDomainId(domain.getId());
-if (dedicatedResources != null && 
!dedicatedResources.isEmpty()) {
-s_logger.error("There are dedicated resources for the 
domain " + domain.getId());
-hasDedicatedResources = true;
-}
-if (accountsForCleanup.isEmpty() && networkIds.isEmpty() 
&& !hasDedicatedResources) {
-_messageBus.publish(_name, 
MESSAGE_PRE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
-if (!_domainDao.remove(domain.getId())) {
+// mark domain as inactive
+s_logger.debug("Marking domain id=" + domain.getId() + " as " 
+ Domain.State.Inactive + " before actually deleting it");
+domain.setState(Domain.State.Inactive);
+_domainDao.update(domain.getId(), domain);
+boolean rollBackState = false;
+boolean hasDedicatedResources = false;
+
+try {
+long ownerId = domain.getAccountId();
+if ((cleanup != null) && cleanup.booleanValue()) {
+if (!cleanupDomain(domain.getId(), ownerId)) {
 rollBackState = true;
 CloudRuntimeException e =
-new CloudRuntimeException("Delete failed on 
domain " + domain.getName() + " (id: " + domain.getId() +
-"); Please make sure all users and sub 
domains have been removed from the domain before deleting");
+new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
+domain.getId() + ").");
 e.addProxyObject(domain.getUuid(), "domainId");
 throw e;
 }
-_messageBus.publish(_name, 
MESSAGE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
 } else {
-rollBackState = true;
-String msg = null;
-if (!accountsForCleanup.isEmpty()) {
-msg = accountsForCleanup.size() + " accounts to 
cleanup";
-} else if (!networkIds.isEmpty()) {
-msg = networkIds.size() + " non-removed networks";
-} else if (hasDedicatedResources) {
-msg = "dedicated resources.";
+//don't delete the domain if there are accounts set 
for cleanup, or non-removed networ

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-09 Thread borisstoyanov 
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
@blueorangutan test 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-09 Thread blueorangutan 
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-02-09 Thread koushik-das 
Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1935#discussion_r100478202
  
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean 
cleanup) {
 
 @Override
 public boolean deleteDomain(DomainVO domain, Boolean cleanup) {
-// mark domain as inactive
-s_logger.debug("Marking domain id=" + domain.getId() + " as " + 
Domain.State.Inactive + " before actually deleting it");
-domain.setState(Domain.State.Inactive);
-_domainDao.update(domain.getId(), domain);
-boolean rollBackState = false;
-boolean hasDedicatedResources = false;
+GlobalLock lock = GlobalLock.getInternLock("AccountCleanup");
+if (lock == null) {
+s_logger.debug("Couldn't get the global lock");
+return false;
+}
+
+if (!lock.lock(30)) {
+s_logger.debug("Couldn't lock the db");
+return false;
+}
 
 try {
-long ownerId = domain.getAccountId();
-if ((cleanup != null) && cleanup.booleanValue()) {
-if (!cleanupDomain(domain.getId(), ownerId)) {
-rollBackState = true;
-CloudRuntimeException e =
-new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
-domain.getId() + ").");
-e.addProxyObject(domain.getUuid(), "domainId");
-throw e;
-}
-} else {
-//don't delete the domain if there are accounts set for 
cleanup, or non-removed networks exist, or domain has dedicated resources
-List networkIds = 
_networkDomainDao.listNetworkIdsByDomain(domain.getId());
-List accountsForCleanup = 
_accountDao.findCleanupsForRemovedAccounts(domain.getId());
-List dedicatedResources = 
_dedicatedDao.listByDomainId(domain.getId());
-if (dedicatedResources != null && 
!dedicatedResources.isEmpty()) {
-s_logger.error("There are dedicated resources for the 
domain " + domain.getId());
-hasDedicatedResources = true;
-}
-if (accountsForCleanup.isEmpty() && networkIds.isEmpty() 
&& !hasDedicatedResources) {
-_messageBus.publish(_name, 
MESSAGE_PRE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
-if (!_domainDao.remove(domain.getId())) {
+// mark domain as inactive
+s_logger.debug("Marking domain id=" + domain.getId() + " as " 
+ Domain.State.Inactive + " before actually deleting it");
+domain.setState(Domain.State.Inactive);
+_domainDao.update(domain.getId(), domain);
+boolean rollBackState = false;
+boolean hasDedicatedResources = false;
+
+try {
+long ownerId = domain.getAccountId();
+if ((cleanup != null) && cleanup.booleanValue()) {
+if (!cleanupDomain(domain.getId(), ownerId)) {
 rollBackState = true;
 CloudRuntimeException e =
-new CloudRuntimeException("Delete failed on 
domain " + domain.getName() + " (id: " + domain.getId() +
-"); Please make sure all users and sub 
domains have been removed from the domain before deleting");
+new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
+domain.getId() + ").");
 e.addProxyObject(domain.getUuid(), "domainId");
 throw e;
 }
-_messageBus.publish(_name, 
MESSAGE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
 } else {
-rollBackState = true;
-String msg = null;
-if (!accountsForCleanup.isEmpty()) {
-msg = accountsForCleanup.size() + " accounts to 
cleanup";
-} else if (!networkIds.isEmpty()) {
-msg = networkIds.size() + " non-removed networks";
-} else if (hasDedicatedResources) {
-msg = "dedicated resources.";
+//don't delete the domain if there are accounts set 
for cleanup, or non-removed networ