[GitHub] cloudstack pull request #1907: Fix public IPs not being removed from the VR ...
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1907#discussion_r97082665
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -659,7 +663,10 @@ def is_guest_gateway(self, bag, ip):
gw = interface.get_gateway()
logging.info("Interface has the following gateway ==> %s", gw)
-if bag['nw_type'] == "guest" and rip == gw:
+guest_gw = self.config.cmdline().get_guest_gw()
+logging.info("Interface has the following gateway ==> %s",
guest_gw)
+
+if bag['nw_type'] == "guest" and (rip == gw or rip == guest_gw):
--- End diff --
this works for isolated networks, but not for vpc tiers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1913: CLOUDSTACK-9752: [Vmware] Optimization of vol...
GitHub user nvazquez opened a pull request: https://github.com/apache/cloudstack/pull/1913 CLOUDSTACK-9752: [Vmware] Optimization of volume attachness to vm ## Description This optimization aims to reduce volume attach slowness due to vmdk files search on datastore before creating the volume (search for `.vmdk`, `-flat.vmdk` and `-delta.vmdk` files to delete them if they exist). This search is not necessary when attaching a volume in Allocated state, due to volume files don't exist on datastore. On large datastores, this search can cause volume attachness to be really slow, as we can see in this log lines: 13-mgmt.log:2016-11-02 10:16:33,136 INFO [vmware.mo.DatastoreMO] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Searching file 9ce7731fd38b4045afbb7ce9754abbc1.vmdk in [b5ebda046d613e079b5874b169cd848f] 13-mgmt.log:2016-11-02 10:19:42,567 WARN [storage.resource.VmwareStorageLayoutHelper] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Unable to locate VMDK file: 9ce7731fd38b4045afbb7ce9754abbc1.vmdk 13-mgmt.log:2016-11-02 10:19:42,719 INFO [vmware.mo.DatastoreMO] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Search file 9ce7731fd38b4045afbb7ce9754abbc1-flat.vmdk on [b5ebda046d613e079b5874b169cd848f] ⦠13-mgmt.log:2016-11-02 10:19:44,399 INFO [vmware.mo.DatastoreMO] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Searching file 9ce7731fd38b4045afbb7ce9754abbc1-flat.vmdk in [b5ebda046d613e079b5874b169cd848f] 13-mgmt.log:2016-11-02 10:22:07,581 WARN [storage.resource.VmwareStorageLayoutHelper] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Unable to locate VMDK file: 9ce7731fd38b4045afbb7ce9754abbc1-flat.vmdk 13-mgmt.log:2016-11-02 10:22:07,731 INFO [vmware.mo.DatastoreMO] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Search file 9ce7731fd38b4045afbb7ce9754abbc1-delta.vmdk on [b5ebda046d613e079b5874b169cd848f] 13-mgmt.log:2016-11-02 10:22:09,745 INFO [vmware.mo.DatastoreMO] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Searching file 9ce7731fd38b4045afbb7ce9754abbc1-delta.vmdk in [b5ebda046d613e079b5874b169cd848f] 13-mgmt.log:2016-11-02 10:25:06,362 WARN [storage.resource.VmwareStorageLayoutHelper] (DirectAgent-931:ctx-5687d68e uscrlpdcsesx240.ads.autodesk.com, job-8675314/job-8675315, cmd: CreateObjectCommand) Unable to locate VMDK file: 9ce7731fd38b4045afbb7ce9754abbc1-delta.vmdk You can merge this pull request into a Git repository by running: $ git pull https://github.com/nvazquez/cloudstack createVolumeOptimization Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1913.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1913 commit 29308f0c53af1550b52bc0cb5a7558482c6da452 Author: nvazquez Date: 2017-01-20T16:20:37Z CLOUDSTACK-9752: [Vmware] Optimization of volume attachness to vm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation
Github user PaulAngus commented on the issue: https://github.com/apache/cloudstack/pull/1741 Any failures relating to rVPC maybe can't be completely ignored but the design of the rVPC means that it will not work under XenServer or vSphere, so tests will fail under those hypervisors. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1741 This set of test was run on KVM. I am not sure of the current state of RVR in general, so I can run this PR again because some of those issues were SSH connectivity issues (which could be env related). Can we run Trillian against this PR now @rhtyd? I have fixed some of the tests which would have been failing before due to the DH status before. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Adding VirtIO SCSI to KVM hypervisors
Hi, VirtIO SCSI [0] has been supported a while now by Linux and all kernels, but inside CloudStack we are not using it. There is a issue for this [1]. It would bring more (theoretical) performance to VMs, but one of the motivators (for me) is that we can support TRIM/DISCARD [2]. This would allow for RBD images on Ceph to shrink, but it can also give back free space on QCOW2 images if quests run fstrim. Something all modern distributions all do weekly in a CRON. Now, it is simple to swap VirtIO for VirtIO SCSI. This would however mean that disks inside VMs are then called /dev/sdX instead of /dev/vdX. For GRUB and such this is no problems. This usually work on UUIDs and/or labels, but for static mounts on /dev/vdb1 for example things break. We currently don't have any configuration method on how we want to present a disk to a guest, so when attaching a volume we can't say that we want to use a different driver. If we think that a Operating System supports VirtIO we use that driver in KVM. Any suggestion on how to add VirtIO SCSI support? Wido [0]: http://wiki.qemu.org/Features/VirtioSCSI [1]: https://issues.apache.org/jira/browse/CLOUDSTACK-8239 [2]: https://issues.apache.org/jira/browse/CLOUDSTACK-8104
[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1741 @PaulAngus Out of curiosity, why wouldn't rVPCs work properly on XenServer? As far as I know it works fine, but I may have missed your point. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1741 @remibergsma last time we tested rvr we had a lot of problems and have not yet been able to adopt it. @pdion891 do you have any details on this? I am not sure if we have tested it recently. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1741 @swill OK, check. Shouldn't be dependent on hypervisor type I'd say. Anyway, when I find some time I'll spin master and have a look. All I can say is that we run quite a bunch of them without serious issues. But obviously the code base diverged quite a bit in the past year. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation
Github user PaulAngus commented on the issue: https://github.com/apache/cloudstack/pull/1741 hi @remibergsma , the design puts the same MAC on the two VPC routers. XenServer doesn't seem to like this. (ESXi hosts give a specific warning). @swill have you pulled in the updated marvin smoke tests? We had all green on KVM tests with the updated component test suite --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
